[jdk11u-dev] RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x

[Antonio Vieiro]

On Mon, 13 Jan 2025 19:55:14 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

> Backport of [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316) to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded.
> 
> This solves the problem in https://github.com/openjdk/jdk11u-dev/pull/2967#issuecomment-2538048579, so all tier1 tests are expected to pass in all GHA platforms. 
> 
> The change is not clean as there were merge conflicts in ProblemList.txt, as these usually differ between JDK versions (just dropped `8294316`). Also `add_map_info` has a different number of arguments in JDK11.

The tests that were failing are passing now in 11 with on `macos13/XCode 14` combination with the GitHub runners.


2025-01-10T20:42:40.3502240Z TEST: serviceability/sa/ClhsdbFindPC.java#id0
2025-01-10T20:42:40.3544430Z   build: 0.797 seconds
2025-01-10T20:42:40.3594360Z   compile: 0.797 seconds
2025-01-10T20:42:40.3625370Z   main: 35.655 seconds
2025-01-10T20:42:40.3652970Z TEST RESULT: Passed. Execution successful
2025-01-10T20:42:40.3685900Z --------------------------------------------------
2025-01-10T20:43:07.3248130Z TEST: serviceability/sa/ClhsdbFindPC.java#id2
2025-01-10T20:43:07.3248690Z   build: 0.65 seconds
2025-01-10T20:43:07.3249030Z   compile: 0.648 seconds
2025-01-10T20:43:07.3249550Z   main: 21.154 seconds
2025-01-10T20:43:07.3249930Z TEST RESULT: Passed. Execution successful
2025-01-10T20:43:07.3250420Z --------------------------------------------------
2025-01-10T20:44:23.6450570Z TEST: serviceability/sa/ClhsdbFindPC.java#id3
2025-01-10T20:44:23.6590930Z   build: 2.521 seconds
2025-01-10T20:44:23.6626600Z   compile: 2.521 seconds
2025-01-10T20:44:23.6634720Z   main: 68.66 seconds
2025-01-10T20:44:23.6637250Z TEST RESULT: Passed. Execution successful
2025-01-10T20:44:23.6644360Z --------------------------------------------------
2025-01-10T20:44:23.9983120Z TEST: serviceability/sa/ClhsdbFindPC.java#id1
2025-01-10T20:44:24.0109410Z   build: 1.103 seconds
2025-01-10T20:44:24.0114190Z   compile: 1.102 seconds
2025-01-10T20:44:24.0115000Z   main: 97.538 seconds
2025-01-10T20:44:24.0116180Z TEST RESULT: Passed. Execution successful


I'll run tier1 tests in the previous `macos-12 and XCode 13.4.1` to ensure backwards compatibility.

All tier1 tests pass on `macos 13` and `XCode 14`. Also ran tier1 tests on the _previous_ `macOS Monterey v 12.6.1` with `Xcode 13.4.1` on `arm64`:


==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/hotspot/jtreg:tier1                     1381  1381     0     0   
   jtreg:test/jdk:tier1                               1894  1894     0     0   
   jtreg:test/langtools:tier1                         3940  3940     0     0   
   jtreg:test/nashorn:tier1                              0     0     0     0   
   jtreg:test/jaxp:tier1                                 0     0     0     0   
==============================
TEST SUCCESS

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2987#issuecomment-2615059557
PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2987#issuecomment-2635166737