[jdk21u-dev] RFR: 8302111: Serialization considerations [v2]

[Goetz Lindenmaier]

On Mon, 10 Feb 2025 21:02:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove parseKeyBits()
>
> Backport mostly looks good. The initialisation differences for `l`, `x` and `y` are also from JDK-8315974: "Make fields final in 'com.sun.crypto.provider' package". I presume, because the fields were now final, there could not be code paths that didn't initialise `l` and the initialisation of `x` and `y` could no longer be delegated to `parseKeyBits`.
> 
> On the subject of `parseKeyBits`, I think this method can now be removed, as it is in JDK-8315974. It is a private method that I don't see being called from anywhere else in those files.

Hi @gnu-andrew,
thanks for your review. Good point to remove the function, done.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1391#issuecomment-2650107898