[jdk21u-dev] RFR: 8180450: secondary_super_cache does not scale well [v2]

[Andrew Haley]

On Mon, 10 Feb 2025 11:58:15 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add check
>
> src/hotspot/share/cds/filemap.cpp line 293:
> 
>> 291:   st->print_cr("- cloned_vtables_offset:          " SIZE_FORMAT_X, _cloned_vtables_offset);
>> 292:   st->print_cr("- serialized_data_offset:         " SIZE_FORMAT_X, _serialized_data_offset);
>> 293:   st->print_cr("- heap_begin:                     " INTPTR_FORMAT, p2i(_heap_begin));
> 
> The upstream patch added the following sanity check at line 2425 (equivalent to line 2411 in the 21u version):
> 
>     if (! _use_secondary_supers_table && UseSecondarySupersTable) {
>       log_warning(cds)("The shared archive was created without UseSecondarySupersTable.");
>       return false;
>     }
> 
> Is there a reason why it has been omitted from this patch?

I think it was a hunk I should have applied manually. Good catch.

I'm assuming that CDS gets tested reasonably well as part of tier1.

-------------

PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1090#discussion_r1950526159