[jdk21u-dev] RFR: 8342958: Use jvmArgs consistently in microbenchmarks [v2]
SendaoYan
syan at openjdk.org
Thu Feb 13 12:38:36 UTC 2025
> Hi all,
>
> - This is PR contains two backport to jdk21u-dev
>
> 1. Uncleanly backport of [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958).
> 2. Cleanly backport of [JDK-8343345](https://bugs.openjdk.org/browse/JDK-8343345).
>
> - Why do we need these two backport?
>
> 1. [Suggests using jvmArgs consistently](https://github.com/openjdk/jdk/pull/21683#issue-2611685724).
> 2. This backport will make several JMH tests run normally after this backport. Before this backport, 'org.openjdk.bench.java.net.NetworkInterfaceLookup.bound' report fails "java.lang.IllegalAccessException: class org.openjdk.bench.java.net.NetworkInterfaceLookup cannot access a member of class java.net.NetworkInterface (in module java.base) with package access", after this backport this JMH test will run passes.
>
> Why this backport can not backport cleanly?
>
> 1. TODO
>
>
> Testing:
>
> - [ ] Run all the touch JMH tests locally.
>
> Test commands:
>
> wget https://patch-diff.githubusercontent.com/raw/openjdk/jdk21u-dev/pull/1403.diff -O JDK-8342958-21u.patch
> grep "diff --git" JDK-8342958-21u.patch | awk '{print $3}' | grep "^a/test" | sed "s|^a/test/||" | sed "s|/|.|g" | sed "s|.java$||" > list.txt
> rm -rf build/jmh-result/ ; mkdir -p build/jmh-result/ ; time for test in `cat list.txt` ; do time make test TEST="micro:$test" MICRO="FORK=1;WARMUP_ITER=2" CONF=release &> build/jmh-result/$test.log ; done
SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
Replace jvmArgsAppend as jvmArgs
-------------
Changes:
- all: https://git.openjdk.org/jdk21u-dev/pull/1403/files
- new: https://git.openjdk.org/jdk21u-dev/pull/1403/files/bb4da1ec..7a55ff48
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1403&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1403&range=00-01
Stats: 82 lines in 68 files changed: 0 ins; 0 del; 82 mod
Patch: https://git.openjdk.org/jdk21u-dev/pull/1403.diff
Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1403/head:pull/1403
PR: https://git.openjdk.org/jdk21u-dev/pull/1403
More information about the jdk-updates-dev
mailing list