[jdk11u-dev] RFR: 8339560: Unaddressed comments during code review of JDK-8337664

[Antonio Vieiro]

On Fri, 14 Feb 2025 07:39:31 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

>> Clean backport of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560) that improves `Distrust.java` and reorganizes the directories of distrusted certificates. 
>> 
>> It will prove useful in order to ease the review of future backports such as upcoming [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) for next april 2025.
>> 
>> Tested with tier1 tests in Linux...
>> 
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/hotspot/jtreg:tier1                     1497  1497     0     0   
>>    jtreg:test/jdk:tier1                               1899  1899     0     0   
>>    jtreg:test/langtools:tier1                         3941  3941     0     0   
>>    jtreg:test/nashorn:tier1                              0     0     0     0   
>>    jtreg:test/jaxp:tier1                                 0     0     0     0   
>> ==============================
>> TEST SUCCESS
>> 
>> 
>> ... and with the `jdk/sun/security` tests too.
>> 
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/jdk/sun/security                         656   656     0     0   
>> ==============================
>> TEST SUCCESS
>
> Build failure on macos is unrelated (see https://github.com/openjdk/jdk11u-dev/pull/2987)

> @vieiro Please mention that it's a test only change for backports like these in the approval request going forward. This helps assess the risk when gauging the request for approval.

Very true, thanks!

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2993#issuecomment-2658905972