[jdk24u] RFR: 8347377: Add validation checks for ICC_Profile header fields
Kevin Rushforth
kcr at openjdk.org
Thu Feb 20 12:40:54 UTC 2025
On Thu, 20 Feb 2025 00:36:55 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> @prrace @jayathirthrao Can you please review and approve this backport?
>
>> @prrace @jayathirthrao Can you please review and approve this backport?
>
> To be clear on the terminology: Phil or Jay can Review the PR (and approve the review). Since this is a clean backport, this is optional unless either you or they feel that it is needed.
>
> The maintainer Approval (from @robm-openjdk) is what is blocking integration.
> @kevinrushforth I was under the same assumption that a clean backport doesn't require additional review/approval. After discussing with Phil, he mentioned that a review/approval is required (because of RFR label) before the maintainer approves the fix request.
Not for a clean backport (although it's always OK to have it reviewed, it's optional).
> Additionally do I need to add client label to this PR?
You can if you like, but it isn't necessary.
See, for example, the recent TrayIcon Wayland backport #78 -- it was neither reviewed nor was the client label added.
-------------
PR Comment: https://git.openjdk.org/jdk24u/pull/82#issuecomment-2671378387
More information about the jdk-updates-dev
mailing list