[jdk17u-dev] RFR: 8302111: Serialization considerations [v2]

[Goetz Lindenmaier]

On Thu, 20 Feb 2025 15:52:14 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove mentioning of ProviderException
>
> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java line 229:
> 
>> 227:         } catch (IOException e) {
>> 228:             throw new ProviderException("Cannot produce ASN.1 encoding", e);
>> 229:         }
> 
> You should remove the try-catch. `encode` doesn't throw IOE. This also removes the diff to jdk 21.

It is toByteArray that trows the IOException.
I can add the InternalError here as in the other places?
But here I thought it's obvious to have the old behaviour.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3278#discussion_r1964952623