[jdk24u] Withdrawn: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases

Konanki Sreenath duke at openjdk.org
Thu Feb 27 08:44:06 UTC 2025


On Mon, 24 Feb 2025 08:16:38 GMT, Konanki Sreenath <duke at openjdk.org> wrote:

> Earlier code will trigger NPE if the certificate does not contain the extensions or if the requested extensions does not exist. The better approach for hardening getExtensionValue here is to to check for NULL explicitly before calling getExtensionValue() and avoding try-catch block which ensures the readability and maintainability.
> 
> After scanning in multiple places where invokng getExtensions on the X509CertInfo reference, the check for NULL is added in the getKeyUsage() as well while calling before getExtensionValue()
> 
> The associated tests are written and added in test class CertificateExtensions. Which will ensure to validate the
> getExtensionValue() and getKeyUsage() methods in X509CertImpl class.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk24u/pull/88


More information about the jdk-updates-dev mailing list