[jdk21u-dev] RFR: 8327460: Compile tests with the same visibility rules as product code

[Matthias Baesken]

On Fri, 3 Jan 2025 10:45:05 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I would like to backport this to keep the test suite close to head.
> This simplifies later backports.
> 
> I had to resolve some files.
> 
> test/jdk/java/foreign/critical/libCritical.c
> This was added by "8254693: Add Panama feature to pass heap segments to native code". Omitted.
> 
> patching file test/jdk/java/foreign/libLibraryLookup.c
> patching file test/jdk/java/foreign/libLookupTest.c
> test/jdk/java/foreign/libSafeAccess.c
> Resolved because "8310643: Misformatted copyright messages in FFM" is not in 21
> 
> patching file test/jdk/java/foreign/nested/libNested.c
> patching file test/jdk/java/foreign/shared.h
> Resolved because "8318175: AIX PPC64: Handle alignment of double in structs" is not in 21 
> 
> patching file test/jdk/java/foreign/stackwalk/libAsyncStackWalk.cpp
> Resolved because "8324799: Use correct extension for C++ test headers" is not in 21.
> 
> patching file test/jdk/java/foreign/stackwalk/libReentrantUpcalls.c
> patching file test/jdk/java/foreign/stackwalk/libStackWalk.c
> Resolved because "8310643: Misformatted copyright messages in FFM" is not in 21
> 
> test/lib/jdk/test/lib/thread/libVThreadPinner.c
> This was added by "8320707: Virtual thread test updates", which was backported to 21.
> But this file was dropped from the backport as it is not applicable to 21.
> 
> test/micro/org/openjdk/bench/java/lang/foreign/libCriticalCalls.c
> This was added by "8254693: Add Panama feature to pass heap segments to native code". Omitted.
> 
> Executed affected tests and micro benchmarks.

Marked as reviewed by mbaesken (Reviewer).

libTrivial.c was changed too , I do not see this in the head change; but it is most likely fine to add this here.

-------------

PR Review: https://git.openjdk.org/jdk21u-dev/pull/1301#pullrequestreview-2533948772
PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1301#issuecomment-2574917921