[jdk17u-dev] RFR: 8314752: Use google test string comparison macros

[Matthias Baesken]

On Thu, 16 Jan 2025 11:57:10 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 17.0.15-oracle.  It's based on the commit to 21.
> 
> test/hotspot/gtest/logging/test_logConfiguration.cpp
> Resolved because "8293873: Centralize the initialization of UL" is not in 17.
> It changes .name to ->name in the lines edited.
> 
> test/hotspot/gtest/oops/test_cpCache_output.cpp
> This file was added by 8295893: Improve printing of Constant Pool Cache Entries in 20. Omitted.
> 
> test/hotspot/gtest/oops/test_instanceKlass.cpp
> A lot of changes were applied to this file after 17. The test cases edited by this change are not in 17.
> They were added by 8271219: [REDO] JDK-8271063 Print injected fields for InstanceKlass. Omitted these.
> 
> test/hotspot/gtest/oops/test_markWord.cpp
> Minor edit to make this build.  See extra commit.
> 
> test/hotspot/gtest/runtime/test_classPrinter.cpp
> This file was added by 8292699: Improve printing of classes in native debugger in 20. Omitted.
> 
> test/hotspot/gtest/runtime/test_os.cpp
> The test case that was changed by "8299790: os::print_hex_dump is racy". Resolved.
> 
> test/hotspot/gtest/runtime/test_os_linux.cpp
> Patches new testcases not in 17. Omitted.
> 
> test/hotspot/gtest/utilities/test_globalDefinitions.cpp
> Already backported.
> 
> test/hotspot/gtest/utilities/test_parse_memory_size.cpp
> This file was added by 8293711: Factor out size parsing functions from arguments.cpp in 20. Omitted.
> 
> 
> test/hotspot/gtest/utilities/test_resourceHash.cpp
> Testcase was added by 8291970: Add TableStatistics get function to ResourceHashtable. Omitted.

Please check in test/hotspot/gtest/oops/test_markWord.cpp
the change to method
assert_not_test_pattern - change looks problematic, is that really what you want? Can't see this in 21u-dev

Otherwise the backport looks okay.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3215#issuecomment-2597693564