[jdk17u-dev] RFR: 8314752: Use google test string comparison macros [v3]

Goetz Lindenmaier goetz at openjdk.org
Mon Jan 27 07:12:38 UTC 2025


> I backport this for parity with 17.0.15-oracle.  It's based on the commit to 21.
> 
> test/hotspot/gtest/logging/test_logConfiguration.cpp
> Resolved because "8293873: Centralize the initialization of UL" is not in 17.
> It changes .name to ->name in the lines edited.
> 
> test/hotspot/gtest/oops/test_cpCache_output.cpp
> This file was added by 8295893: Improve printing of Constant Pool Cache Entries in 20. Omitted.
> 
> test/hotspot/gtest/oops/test_instanceKlass.cpp
> A lot of changes were applied to this file after 17. The test cases edited by this change are not in 17.
> They were added by 8271219: [REDO] JDK-8271063 Print injected fields for InstanceKlass. Omitted these.
> 
> test/hotspot/gtest/oops/test_markWord.cpp
> Minor edit to make this build.  See extra commit.
> 
> test/hotspot/gtest/runtime/test_classPrinter.cpp
> This file was added by 8292699: Improve printing of classes in native debugger in 20. Omitted.
> 
> test/hotspot/gtest/runtime/test_os.cpp
> The test case that was changed by "8299790: os::print_hex_dump is racy". Resolved.
> 
> test/hotspot/gtest/runtime/test_os_linux.cpp
> Patches new testcases not in 17. Omitted.
> 
> test/hotspot/gtest/utilities/test_globalDefinitions.cpp
> Already backported.
> 
> test/hotspot/gtest/utilities/test_parse_memory_size.cpp
> This file was added by 8293711: Factor out size parsing functions from arguments.cpp in 20. Omitted.
> 
> 
> test/hotspot/gtest/utilities/test_resourceHash.cpp
> Testcase was added by 8291970: Add TableStatistics get function to ResourceHashtable. Omitted.

Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:

  Use better Not

-------------

Changes:
  - all: https://git.openjdk.org/jdk17u-dev/pull/3215/files
  - new: https://git.openjdk.org/jdk17u-dev/pull/3215/files/bf4f9711..18e27d0c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3215&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3215&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk17u-dev/pull/3215.diff
  Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3215/head:pull/3215

PR: https://git.openjdk.org/jdk17u-dev/pull/3215


More information about the jdk-updates-dev mailing list