From fyang at openjdk.org Tue Jul 1 00:52:50 2025 From: fyang at openjdk.org (Fei Yang) Date: Tue, 1 Jul 2025 00:52:50 GMT Subject: [jdk25u] RFR: 8359270: C2: alignment check should consider base offset when emitting arraycopy runtime call In-Reply-To: References: Message-ID: On Thu, 26 Jun 2025 01:49:33 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [6b439391](https://github.com/openjdk/jdk/commit/6b4393917ae689818d67fcaf9cc61ca16ea6d426) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 23 Jun 2025 and was reviewed by Tobias Hartmann and Vladimir Kozlov. > > Thanks! GHA failures on windows is unrelated. ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/6#issuecomment-3021301091 From fyang at openjdk.org Tue Jul 1 00:52:51 2025 From: fyang at openjdk.org (Fei Yang) Date: Tue, 1 Jul 2025 00:52:51 GMT Subject: [jdk25u] Integrated: 8359270: C2: alignment check should consider base offset when emitting arraycopy runtime call In-Reply-To: References: Message-ID: On Thu, 26 Jun 2025 01:49:33 GMT, Fei Yang wrote: > Hi all, > > This pull request contains a backport of commit [6b439391](https://github.com/openjdk/jdk/commit/6b4393917ae689818d67fcaf9cc61ca16ea6d426) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Fei Yang on 23 Jun 2025 and was reviewed by Tobias Hartmann and Vladimir Kozlov. > > Thanks! This pull request has now been integrated. Changeset: 26d99e04 Author: Fei Yang URL: https://git.openjdk.org/jdk25u/commit/26d99e045a353168c535272615d733fcce00df32 Stats: 136 lines in 3 files changed: 128 ins; 0 del; 8 mod 8359270: C2: alignment check should consider base offset when emitting arraycopy runtime call Backport-of: 6b4393917ae689818d67fcaf9cc61ca16ea6d426 ------------- PR: https://git.openjdk.org/jdk25u/pull/6 From sgehwolf at openjdk.org Tue Jul 1 09:22:55 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 1 Jul 2025 09:22:55 GMT Subject: [jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v6] In-Reply-To: References: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> Message-ID: <78PoAXIDd56sBQtuTFYPAWQnbZAYP1ncLhRlXML6Lus=.9d93c5aa-4e4a-430e-86f8-27005a4c9f07@github.com> On Fri, 27 Jun 2025 17:08:59 GMT, Antonio Vieiro wrote: >> A fix for [JDK-8360816](https://bugs.openjdk.org/browse/JDK-8360816). >> >> The `ProgramFiles(x86)` environment variable is not properly propagated to JTReg tests in JDK11, which makes the AOT compiler tests fail on the new `windows-2025` GHA runners, as manifested in the backport of [https://bugs.openjdk.org/browse/JDK-8358538](JDK-8358538). >> >> Propagating this environment variable to JTRegs may require creating devkits for Windows 2022, but previous attempts were discarded [JDK-8283723](https://bugs.openjdk.org/browse/JDK-8283723). >> >> This fix prints a warning message when this environment variable is not set, and then uses a default value (`C:\Program Files (x86)`) that makes it possible to run the AOT tests with these new `windows-2025` GHA runners. If the `ProgramFiles(x86)` env variable is set the fix has no effect, ensuring the previous behaviour. If the proposed default value is incorrect the AOT tests will continue to fail as before. >> >> The PR is on top of https://github.com/openjdk/jdk11u-dev/pull/3052 to verify the fix works as intended with the new `windows-2025` GHA runners. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > 8360816: [11u] Use default value for ProgramFiles(x86) in GHA .github/workflows/test.yml line 156: > 154: SYMBOLS_IMAGE_DIR=${{ steps.bundles.outputs.symbols-path }} > 155: TEST_IMAGE_DIR=${{ steps.bundles.outputs.tests-path }} > 156: JTREG='OPTIONS=-e:ProgramFiles\(x86\)=C:\\Program\ Files\ \(x86\);JAVA_OPTIONS=-XX:-CreateCoredumpOnCrash;VERBOSE=fail,error,time;KEYWORDS=!headful' We could set a variable separately in a separate step to the right value for Windows jobs. Then we could check here if the variable is empty and only set the `-e` value when the corresponding environment is not empty. Thoughts? See for example `Set PATH` step and the `env` clause in this `Run tests` step. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3056#discussion_r2176968587 From sgehwolf at openjdk.org Tue Jul 1 09:22:54 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 1 Jul 2025 09:22:54 GMT Subject: [jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v6] In-Reply-To: References: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> Message-ID: On Fri, 27 Jun 2025 17:12:22 GMT, Antonio Vieiro wrote: > This is cleaner (no changes to product code) but it propagates the environment variable on Linux and MacOS. Right, but we can fix that too. See my suggested comment. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3056#issuecomment-3022915526 From duke at openjdk.org Tue Jul 1 09:39:50 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Tue, 1 Jul 2025 09:39:50 GMT Subject: [jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v6] In-Reply-To: References: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> Message-ID: <54lpzNpqO4Wl6zPG0jZptlvdCOS0_e69bt9rxUgZpBQ=.1a81f928-2619-449d-af00-8edcd721c5d0@github.com> On Fri, 27 Jun 2025 17:08:59 GMT, Antonio Vieiro wrote: >> A fix for [JDK-8360816](https://bugs.openjdk.org/browse/JDK-8360816). >> >> The `ProgramFiles(x86)` environment variable is not properly propagated to JTReg tests in JDK11, which makes the AOT compiler tests fail on the new `windows-2025` GHA runners, as manifested in the backport of [https://bugs.openjdk.org/browse/JDK-8358538](JDK-8358538). >> >> Propagating this environment variable to JTRegs may require creating devkits for Windows 2022, but previous attempts were discarded [JDK-8283723](https://bugs.openjdk.org/browse/JDK-8283723). >> >> This fix prints a warning message when this environment variable is not set, and then uses a default value (`C:\Program Files (x86)`) that makes it possible to run the AOT tests with these new `windows-2025` GHA runners. If the `ProgramFiles(x86)` env variable is set the fix has no effect, ensuring the previous behaviour. If the proposed default value is incorrect the AOT tests will continue to fail as before. >> >> The PR is on top of https://github.com/openjdk/jdk11u-dev/pull/3052 to verify the fix works as intended with the new `windows-2025` GHA runners. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > 8360816: [11u] Use default value for ProgramFiles(x86) in GHA Ah, that's clever. Will do that during the week! Thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3056#issuecomment-3023009633 From duke at openjdk.org Tue Jul 1 13:34:47 2025 From: duke at openjdk.org (duke) Date: Tue, 1 Jul 2025 13:34:47 GMT Subject: [jdk21u-dev] RFR: 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers [v4] In-Reply-To: References: Message-ID: On Thu, 26 Jun 2025 18:39:59 GMT, Jan Kratochvil wrote: >> A patch 5 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) >> >> It has a patch dependency on PR 3 of 7: https://github.com/openjdk/jdk21u-dev/pull/1661 >> >> This backport is not clean: >> >> - `src/hotspot/os/linux/cgroupSubsystem_linux.hpp`, `src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp`, `src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp`, `src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp`, `src/hotspot/os/linux/cgroupV2Subsystem_linux.hpp` are missing `CgroupSubsystem::memory_and_swap_usage_in_bytes()` as [JDK-8325139](https://github.com/openjdk/jdk/commit/3d106cb091de6b6ef2a9bf483fb0f5c98c28263c) has not been backported. >> >> - `src/hotspot/os/linux/cgroupSubsystem_linux.hpp`, `src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp`, `src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp`, `src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp`, `src/hotspot/os/linux/cgroupV2Subsystem_linux.hpp` have some differences in `CgroupSubsystem::rss_usage_in_bytes()` and `CgroupSubsystem::cache_usage_in_bytes()` placement as [JDK-8313083](https://github.com/openjdk/jdk/commit/c96cbe481c86800b76e220374b24b6671984adb7) has been backported independently. >> >> The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. > > Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits: > > - Merge branch 'devmaster' into devmaster-cgroup2reduced1234-conflict > - Merge remote-tracking branch 'janjdk21u-dev/devmaster-cgroup2reduced1234b' into devmaster-cgroup2reduced1234-conflict > - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers > > Reviewed-by: jsjolen, stuefe > - 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container > > Reviewed-by: stuefe, iklam > - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized' > - a patch by Yuri Nesterenko > - 8333326: Linux Alpine build fails after 8302744 > > Reviewed-by: sgehwolf, clanger, stuefe > - 8302744: Refactor Hotspot container detection code > > Reviewed-by: jsjolen, stuefe > - rss/cache fixups. > - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers > > Reviewed-by: jsjolen, stuefe @jankratochvil Your change (at version b1a6efc52b7f09f280e88ce74456749d00aa1b96) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1662#issuecomment-3024044854 From jkratochvil at openjdk.org Tue Jul 1 13:58:51 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 1 Jul 2025 13:58:51 GMT Subject: [jdk21u-dev] Integrated: 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers In-Reply-To: References: Message-ID: On Wed, 16 Apr 2025 10:42:40 GMT, Jan Kratochvil wrote: > A patch 5 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 3 of 7: https://github.com/openjdk/jdk21u-dev/pull/1661 > > This backport is not clean: > > - `src/hotspot/os/linux/cgroupSubsystem_linux.hpp`, `src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp`, `src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp`, `src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp`, `src/hotspot/os/linux/cgroupV2Subsystem_linux.hpp` are missing `CgroupSubsystem::memory_and_swap_usage_in_bytes()` as [JDK-8325139](https://github.com/openjdk/jdk/commit/3d106cb091de6b6ef2a9bf483fb0f5c98c28263c) has not been backported. > > - `src/hotspot/os/linux/cgroupSubsystem_linux.hpp`, `src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp`, `src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp`, `src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp`, `src/hotspot/os/linux/cgroupV2Subsystem_linux.hpp` have some differences in `CgroupSubsystem::rss_usage_in_bytes()` and `CgroupSubsystem::cache_usage_in_bytes()` placement as [JDK-8313083](https://github.com/openjdk/jdk/commit/c96cbe481c86800b76e220374b24b6671984adb7) has been backported independently. > > The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. This pull request has now been integrated. Changeset: 7facfe3c Author: Jan Kratochvil Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/7facfe3ca92651fef03e4ea9d4c953e2e5585769 Stats: 570 lines in 8 files changed: 325 ins; 81 del; 164 mod 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers Reviewed-by: sgehwolf Backport-of: 65a282aae3f81379f1471db4fc0ff2e3b479140e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1662 From tpushkin at openjdk.org Tue Jul 1 13:59:46 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Tue, 1 Jul 2025 13:59:46 GMT Subject: [jdk21u-dev] Integrated: 8339460: CDS error when module is located in a directory with space in the name In-Reply-To: References: Message-ID: On Tue, 27 May 2025 07:23:49 GMT, Timofei Pushkin wrote: > Clean backport which fixes CDS's handling of paths that need to be escaped in path URLs. > > Testing besides the CI (performed on macos/arm64): `runtime/cds`, a separate minimal reproducer app. This pull request has now been integrated. Changeset: ee0c1167 Author: Timofei Pushkin Committer: Alexey Bakhtin URL: https://git.openjdk.org/jdk21u-dev/commit/ee0c1167d1a51a54207b07eb6c338cf9a3d8e98a Stats: 291 lines in 10 files changed: 280 ins; 2 del; 9 mod 8339460: CDS error when module is located in a directory with space in the name Backport-of: aceae76fb5853ab65851225aeb35a425af8f7af8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1833 From tpushkin at openjdk.org Tue Jul 1 14:05:15 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Tue, 1 Jul 2025 14:05:15 GMT Subject: [jdk21u-dev] RFR: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() [v2] In-Reply-To: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> References: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> Message-ID: > The original change cleaned up code of static CDS. I am backporting it as a dependency of [JDK-8315130](https://bugs.openjdk.org/browse/JDK-8315130) which I am backporting next (#1835): without this change the backport JDK-8315130 would need to include some parts of this change and would also leave some code unused. > > Resolved conflicts: > - `src/hotspot/share/cds/unregisteredClasses.cpp`: bug fix [JDK-8343416](https://bugs.openjdk.org/browse/JDK-8343416) is missing in this version but the backported change itself incorporates the bug fix (to verify I checked that the backport makes [the test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) pass, but I did not include that test in this PR) > - `src/hotspot/share/cds/classListParser.*pp`: constant pool resolution was added there in JDK 23/24 as part of Project Layden ([JDK-8293980](https://bugs.openjdk.org/browse/JDK-8293980), [JDK-8332176](https://bugs.openjdk.org/browse/JDK-8332176)) ? this required only insignificant changes to the backport > - The rest of the conflicts were trivial (caused by renaming, neighboring code removal, copyright year updates) > > The PR depends on #1833 though it can be rewritten not to if needed. > > Testing besides the CI (performed on macos/arm64): `runtime/cds`, [test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) (not included in the backport since that is a separate change). Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1834/files - new: https://git.openjdk.org/jdk21u-dev/pull/1834/files/ec2af255..ec2af255 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1834&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1834&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1834.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1834/head:pull/1834 PR: https://git.openjdk.org/jdk21u-dev/pull/1834 From jkratochvil at openjdk.org Tue Jul 1 14:05:40 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 1 Jul 2025 14:05:40 GMT Subject: [jdk21u-dev] RFR: 8338236: Compile error in cgroup code on Linux when using clang [v2] In-Reply-To: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> References: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> Message-ID: > A patch 6 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 5 of 7: https://github.com/openjdk/jdk21u-dev/pull/1662 > > This backport is clean. > > The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1663/files - new: https://git.openjdk.org/jdk21u-dev/pull/1663/files/c952f4de..c952f4de Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1663&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1663&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1663.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1663/head:pull/1663 PR: https://git.openjdk.org/jdk21u-dev/pull/1663 From sgehwolf at openjdk.org Tue Jul 1 15:13:49 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 1 Jul 2025 15:13:49 GMT Subject: [jdk21u-dev] RFR: 8338236: Compile error in cgroup code on Linux when using clang [v2] In-Reply-To: References: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> Message-ID: On Tue, 1 Jul 2025 14:05:40 GMT, Jan Kratochvil wrote: >> A patch 6 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) >> >> It has a patch dependency on PR 5 of 7: https://github.com/openjdk/jdk21u-dev/pull/1662 >> >> This backport is clean. >> >> The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. > > Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. @jankratochvil Please resolve the merge conflict here so we can move forward with this. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1663#issuecomment-3024457004 From roland at openjdk.org Tue Jul 1 16:25:48 2025 From: roland at openjdk.org (Roland Westrelin) Date: Tue, 1 Jul 2025 16:25:48 GMT Subject: [jdk21u-dev] RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: On Thu, 19 Jun 2025 18:26:09 GMT, William Kemper wrote: > My approval doesn't count for anything here, but in case it helps grease the wheels: I ran this test without the patch and observed it fail. I ran the test with the patch and observed it pass. Thank you for the backport! Thanks for giving it a try and the review @earthling-amzn . Maybe one of the reviewers of https://github.com/openjdk/jdk/pull/25729 can review it? @shipilev @JohnTortugo ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1901#issuecomment-3024723133 From shade at openjdk.org Tue Jul 1 17:23:40 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 1 Jul 2025 17:23:40 GMT Subject: [jdk21u-dev] RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 13:48:14 GMT, Roland Westrelin wrote: > Patch doesn't apply cleanly: > > - jdk21u still has IU barriers: context for some of the changes is > different. > > - Because of IU barriers, there's an extra call to `fix_ctrl()` for > which the renaming to `nodes_above_barriers` must be applied. > > - The initial patch makes a subtle change that doesn't affect jdk > 25/26 in the code that was > refactored. `ShenandoahBarrierC2Support::push_data_inputs_at_control()` > is introduced with logic: > > if (in != nullptr && phase->has_ctrl(in) && phase->get_ctrl(in) == ctrl) { > > > which replaces the same logic in > `ShenandoahBarrierC2Support::fix_ctrl()` but also a slightly > different logic in > `ShenandoahBarrierC2Support::is_dominator_same_ctrl()`: > > > if (m->in(i) != nullptr && phase->ctrl_or_self(m->in(i)) == c) { > > > that is, it uses `ctrl_or_self()` which works for both data nodes > and control nodes but the new method uses `has_ctrl(in) && > get_ctrl(in)` which can only be true for data nodes. That change > causes failures in jdk 21 again because of IU barriers that produce > a new memory state when expanded and need the logic from > `MemoryGraphFixer`. What I propose in this backport to be on the > safe side is to leave > `ShenandoahBarrierC2Support::is_dominator_same_ctrl()` alone (not > apply that part of the refactoring). > > Tested with hotspot_gc_shenandoah + tier1 with -XX:+UseShenandoahGC Ah yes, apologies, it slipped off my radar. I'll take a look. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1901#issuecomment-3024909612 From jkratochvil at openjdk.org Tue Jul 1 18:08:00 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 1 Jul 2025 18:08:00 GMT Subject: [jdk21u-dev] RFR: 8338236: Compile error in cgroup code on Linux when using clang [v3] In-Reply-To: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> References: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> Message-ID: > A patch 6 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 5 of 7: https://github.com/openjdk/jdk21u-dev/pull/1662 > > This backport is clean. > > The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merge remote-tracking branch 'janjdk21u-dev/devmaster-cgroup2reduced12345b' into devmaster-cgroup2reduced12345-new-conflict - 8338236: Compile error in cgroup code on Linux when using clang Reviewed-by: mdoerr, sgehwolf - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers Reviewed-by: jsjolen, stuefe - 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container Reviewed-by: stuefe, iklam - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized' - a patch by Yuri Nesterenko - 8333326: Linux Alpine build fails after 8302744 Reviewed-by: sgehwolf, clanger, stuefe - 8302744: Refactor Hotspot container detection code Reviewed-by: jsjolen, stuefe - 8338236: Compile error in cgroup code on Linux when using clang Reviewed-by: mdoerr, sgehwolf ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1663/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1663&range=02 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1663.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1663/head:pull/1663 PR: https://git.openjdk.org/jdk21u-dev/pull/1663 From jkratochvil at openjdk.org Tue Jul 1 18:17:27 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 1 Jul 2025 18:17:27 GMT Subject: [jdk21u-dev] RFR: 8338236: Compile error in cgroup code on Linux when using clang [v4] In-Reply-To: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> References: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> Message-ID: > A patch 6 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 5 of 7: https://github.com/openjdk/jdk21u-dev/pull/1662 > > This backport is clean. > > The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: retry CI ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1663/files - new: https://git.openjdk.org/jdk21u-dev/pull/1663/files/cb362b01..a3a5d309 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1663&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1663&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1663.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1663/head:pull/1663 PR: https://git.openjdk.org/jdk21u-dev/pull/1663 From gnu_andrew at member.fsf.org Tue Jul 1 22:02:40 2025 From: gnu_andrew at member.fsf.org (Andrew Hughes) Date: Tue, 1 Jul 2025 23:02:40 +0100 Subject: [11u] [FREEZE] 11.0.28 NOW FROZEN Message-ID: The release forest: https://github.com/openjdk/jdk11u is frozen as of 2025-06-28 in preparation for release on or after 2025-07-15. The final pre-release tag is jdk-11.0.28+5. [0] The final release tag will thus be no lower than jdk-11.0.28+6. [0] https://github.com/openjdk/jdk11u/releases/tag/jdk-11.0.28%2B5 Thanks, -- Andrew :) Pronouns: he / him or they / them PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From duke at openjdk.org Tue Jul 1 22:52:53 2025 From: duke at openjdk.org (Daniel Huang) Date: Tue, 1 Jul 2025 22:52:53 GMT Subject: [jdk17u-dev] RFR: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport In-Reply-To: <_EZkw0mQ-05jmb6g5Jm9r9kQWG-Q0JLSnkWXj0iBQ40=.f7e052b4-f146-4575-a7b0-8f5ba0493ff3@github.com> References: <_EZkw0mQ-05jmb6g5Jm9r9kQWG-Q0JLSnkWXj0iBQ40=.f7e052b4-f146-4575-a7b0-8f5ba0493ff3@github.com> Message-ID: On Mon, 30 Jun 2025 17:19:40 GMT, Daniel Huang wrote: > Backport for RandomSupport issue. There is a loss of information when using convertSeedBytesToLongs() with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result. > > Clean backport, ran GHA sanity checks and locally tested tier1, tier2. In tier2, there were 2 failures: > `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` > `test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java` > However, these both failed before the backport as well. will backport the two bugfixes individually ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3694#issuecomment-3025788807 From duke at openjdk.org Tue Jul 1 22:52:53 2025 From: duke at openjdk.org (Daniel Huang) Date: Tue, 1 Jul 2025 22:52:53 GMT Subject: [jdk17u-dev] Withdrawn: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport In-Reply-To: <_EZkw0mQ-05jmb6g5Jm9r9kQWG-Q0JLSnkWXj0iBQ40=.f7e052b4-f146-4575-a7b0-8f5ba0493ff3@github.com> References: <_EZkw0mQ-05jmb6g5Jm9r9kQWG-Q0JLSnkWXj0iBQ40=.f7e052b4-f146-4575-a7b0-8f5ba0493ff3@github.com> Message-ID: On Mon, 30 Jun 2025 17:19:40 GMT, Daniel Huang wrote: > Backport for RandomSupport issue. There is a loss of information when using convertSeedBytesToLongs() with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result. > > Clean backport, ran GHA sanity checks and locally tested tier1, tier2. In tier2, there were 2 failures: > `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` > `test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java` > However, these both failed before the backport as well. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3694 From duke at openjdk.org Wed Jul 2 03:25:51 2025 From: duke at openjdk.org (duke) Date: Wed, 2 Jul 2025 03:25:51 GMT Subject: [jdk25u] RFR: 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119) In-Reply-To: References: Message-ID: On Thu, 12 Jun 2025 12:15:31 GMT, Renjith Kannath Pariyangad wrote: > Hi all, > > This pull request contains a backport of commit [2103dc15](https://github.com/openjdk/jdk/commit/2103dc15cb662fd8795b1b51d9cb61c389bed7a0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 9 Jun 2025 and was reviewed by Prasanta Sadhukhan, Sergey Bylokhov, Alexey Ivanov and Alexey Ushakov. > > Thanks! @Renjithkannath Your change (at version 9e32ca3f848195edec95449b8fd7fcfc13347286) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/3#issuecomment-3026235304 From tpushkin at openjdk.org Wed Jul 2 06:44:07 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Wed, 2 Jul 2025 06:44:07 GMT Subject: [jdk21u-dev] RFR: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() [v3] In-Reply-To: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> References: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> Message-ID: <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> > The original change cleaned up code of static CDS. I am backporting it as a dependency of [JDK-8315130](https://bugs.openjdk.org/browse/JDK-8315130) which I am backporting next (#1835): without this change the backport JDK-8315130 would need to include some parts of this change and would also leave some code unused. > > Resolved conflicts: > - `src/hotspot/share/cds/unregisteredClasses.cpp`: bug fix [JDK-8343416](https://bugs.openjdk.org/browse/JDK-8343416) is missing in this version but the backported change itself incorporates the bug fix (to verify I checked that the backport makes [the test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) pass, but I did not include that test in this PR) > - `src/hotspot/share/cds/classListParser.*pp`: constant pool resolution was added there in JDK 23/24 as part of Project Layden ([JDK-8293980](https://bugs.openjdk.org/browse/JDK-8293980), [JDK-8332176](https://bugs.openjdk.org/browse/JDK-8332176)) ? this required only insignificant changes to the backport > - The rest of the conflicts were trivial (caused by renaming, neighboring code removal, copyright year updates) > > Testing besides the CI (performed on macos/arm64): `runtime/cds`, [test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) (not included in the backport since that is a separate change). Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'jdk-jdk21u-dev/master' into app-cds-bug-2 - 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() Reviewed-by: ccheung, coleenp - 8339460: CDS error when module is located in a directory with space in the name Reviewed-by: ccheung, iklam ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1834/files - new: https://git.openjdk.org/jdk21u-dev/pull/1834/files/ec2af255..f8bf196c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1834&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1834&range=01-02 Stats: 11004 lines in 276 files changed: 5743 ins; 4142 del; 1119 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1834.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1834/head:pull/1834 PR: https://git.openjdk.org/jdk21u-dev/pull/1834 From tpushkin at openjdk.org Wed Jul 2 06:52:47 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Wed, 2 Jul 2025 06:52:47 GMT Subject: [jdk21u-dev] RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive In-Reply-To: References: Message-ID: On Tue, 27 May 2025 09:12:21 GMT, Timofei Pushkin wrote: > Fixes a error which significantly complicates the use of static CDS in some applications with user-provided class loaders (workarounds require either manually editing the generated CDS classlist which is error-prone, or switching to dynamic CDS which has its own implications, or rewriting the application which is not always possible). > > The conflicts were trivial: a few neighboring methods missing from this version and not directly related to the change. > > The PR depends on #1833 and #1834 though it can be rewritten not to if needed. > > Testing besides the CI (performed on macos/arm64): `runtime/cds`, a minimal reproducer app described in the original bug report. @iklam As a reviewer of the original change, could you please review this JDK 21 backport and its dependency #1834? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1835#issuecomment-3026664500 From goetz at openjdk.org Wed Jul 2 08:35:46 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Jul 2025 08:35:46 GMT Subject: [jdk17u-dev] RFR: 8302635: Race condition in HttpBodySubscriberWrapper when cancelling request In-Reply-To: References: Message-ID: <0aPoCpN2WUsM3QpOnKoAkoYBo55CYLB0SZMh2eYTrQY=.9d9535c5-5ab0-42d9-a377-e2b36daf2581@github.com> On Mon, 30 Jun 2025 14:37:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. GHA failure: build hangs, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3690#issuecomment-3026957338 From duke at openjdk.org Wed Jul 2 08:57:35 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 2 Jul 2025 08:57:35 GMT Subject: [jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v7] In-Reply-To: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> References: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> Message-ID: > A fix for [JDK-8360816](https://bugs.openjdk.org/browse/JDK-8360816). > > The `ProgramFiles(x86)` environment variable is not properly propagated to JTReg tests in JDK11, which makes the AOT compiler tests fail on the new `windows-2025` GHA runners, as manifested in the backport of [https://bugs.openjdk.org/browse/JDK-8358538](JDK-8358538). > > Propagating this environment variable to JTRegs may require creating devkits for Windows 2022, but previous attempts were discarded [JDK-8283723](https://bugs.openjdk.org/browse/JDK-8283723). > > This fix prints a warning message when this environment variable is not set, and then uses a default value (`C:\Program Files (x86)`) that makes it possible to run the AOT tests with these new `windows-2025` GHA runners. If the `ProgramFiles(x86)` env variable is set the fix has no effect, ensuring the previous behaviour. If the proposed default value is incorrect the AOT tests will continue to fail as before. > > The PR is on top of https://github.com/openjdk/jdk11u-dev/pull/3052 to verify the fix works as intended with the new `windows-2025` GHA runners. Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: Set JTReg ProgramFiles(x86) env. variable on Windows ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/3056/files - new: https://git.openjdk.org/jdk11u-dev/pull/3056/files/d2fa919a..51e8454a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3056&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3056&range=05-06 Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3056.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3056/head:pull/3056 PR: https://git.openjdk.org/jdk11u-dev/pull/3056 From duke at openjdk.org Wed Jul 2 08:57:37 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 2 Jul 2025 08:57:37 GMT Subject: [jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v6] In-Reply-To: References: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> Message-ID: On Fri, 27 Jun 2025 17:08:59 GMT, Antonio Vieiro wrote: >> A fix for [JDK-8360816](https://bugs.openjdk.org/browse/JDK-8360816). >> >> The `ProgramFiles(x86)` environment variable is not properly propagated to JTReg tests in JDK11, which makes the AOT compiler tests fail on the new `windows-2025` GHA runners, as manifested in the backport of [https://bugs.openjdk.org/browse/JDK-8358538](JDK-8358538). >> >> Propagating this environment variable to JTRegs may require creating devkits for Windows 2022, but previous attempts were discarded [JDK-8283723](https://bugs.openjdk.org/browse/JDK-8283723). >> >> This fix prints a warning message when this environment variable is not set, and then uses a default value (`C:\Program Files (x86)`) that makes it possible to run the AOT tests with these new `windows-2025` GHA runners. If the `ProgramFiles(x86)` env variable is set the fix has no effect, ensuring the previous behaviour. If the proposed default value is incorrect the AOT tests will continue to fail as before. >> >> The PR is on top of https://github.com/openjdk/jdk11u-dev/pull/3052 to verify the fix works as intended with the new `windows-2025` GHA runners. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > 8360816: [11u] Use default value for ProgramFiles(x86) in GHA Well, this should do it... ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3056#issuecomment-3027024409 From duke at openjdk.org Wed Jul 2 08:57:39 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 2 Jul 2025 08:57:39 GMT Subject: [jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v6] In-Reply-To: <78PoAXIDd56sBQtuTFYPAWQnbZAYP1ncLhRlXML6Lus=.9d93c5aa-4e4a-430e-86f8-27005a4c9f07@github.com> References: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> <78PoAXIDd56sBQtuTFYPAWQnbZAYP1ncLhRlXML6Lus=.9d93c5aa-4e4a-430e-86f8-27005a4c9f07@github.com> Message-ID: On Tue, 1 Jul 2025 09:19:41 GMT, Severin Gehwolf wrote: >> Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: >> >> 8360816: [11u] Use default value for ProgramFiles(x86) in GHA > > .github/workflows/test.yml line 156: > >> 154: SYMBOLS_IMAGE_DIR=${{ steps.bundles.outputs.symbols-path }} >> 155: TEST_IMAGE_DIR=${{ steps.bundles.outputs.tests-path }} >> 156: JTREG='OPTIONS=-e:ProgramFiles\(x86\)=C:\\Program\ Files\ \(x86\);JAVA_OPTIONS=-XX:-CreateCoredumpOnCrash;VERBOSE=fail,error,time;KEYWORDS=!headful' > > We could set a variable separately in a separate step to the right value for Windows jobs. Then we could check here if the variable is empty and only set the `-e` value when the corresponding environment is not empty. Thoughts? > > See for example `Set PATH` step and the `env` clause in this `Run tests` step. Fixed on the last commit. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3056#discussion_r2179504376 From goetz at openjdk.org Wed Jul 2 09:00:24 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Jul 2025 09:00:24 GMT Subject: [jdk17u-dev] RFR: 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 4c5b66dceab15ce27f742c4173e14156249eb61a Changes: https://git.openjdk.org/jdk17u-dev/pull/3696/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3696&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317522 Stats: 82 lines in 1 file changed: 55 ins; 11 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3696.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3696/head:pull/3696 PR: https://git.openjdk.org/jdk17u-dev/pull/3696 From sgehwolf at openjdk.org Wed Jul 2 09:40:43 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 2 Jul 2025 09:40:43 GMT Subject: [jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v7] In-Reply-To: References: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> Message-ID: On Wed, 2 Jul 2025 08:57:35 GMT, Antonio Vieiro wrote: >> A fix for [JDK-8360816](https://bugs.openjdk.org/browse/JDK-8360816). >> >> The `ProgramFiles(x86)` environment variable is not properly propagated to JTReg tests in JDK11, which makes the AOT compiler tests fail on the new `windows-2025` GHA runners, as manifested in the backport of [https://bugs.openjdk.org/browse/JDK-8358538](JDK-8358538). >> >> Propagating this environment variable to JTRegs may require creating devkits for Windows 2022, but previous attempts were discarded [JDK-8283723](https://bugs.openjdk.org/browse/JDK-8283723). >> >> This fix prints a warning message when this environment variable is not set, and then uses a default value (`C:\Program Files (x86)`) that makes it possible to run the AOT tests with these new `windows-2025` GHA runners. If the `ProgramFiles(x86)` env variable is set the fix has no effect, ensuring the previous behaviour. If the proposed default value is incorrect the AOT tests will continue to fail as before. >> >> The PR is on top of https://github.com/openjdk/jdk11u-dev/pull/3052 to verify the fix works as intended with the new `windows-2025` GHA runners. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Set JTReg ProgramFiles(x86) env. variable on Windows Seems OK. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/3056#pullrequestreview-2978467217 From galder at openjdk.org Wed Jul 2 09:46:44 2025 From: galder at openjdk.org (Galder =?UTF-8?B?WmFtYXJyZcOxbw==?=) Date: Wed, 2 Jul 2025 09:46:44 GMT Subject: [jdk17u-dev] RFR: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl In-Reply-To: References: Message-ID: <9e8-0G68kJJ5VcI3t4cGab0g6MK7W4NAmAuPw5uYdtw=.6230fc23-3d20-42b4-8ede-b1fb5236dc92@github.com> On Wed, 11 Jun 2025 14:08:10 GMT, Shruthi wrote: > Signed-off-by: Shruthi [Shruthi.Shruthi1 at ibm.com](mailto:Shruthi.Shruthi1 at ibm.com) > > OpenJDK PR : https://github.com/openjdk/jdk/pull/10434 > OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8294399 > > The original patch does not apply cleanly to JDK17u-dev, as UnixFileDispatcherImpl.java and UnixFileDispatcherImpl.c do not exist in this version. > Instead, JDK 17 uses FileDispatcherImpl.java and FileDispatcherImpl.c under the unix directory for the relevant implementation. > Therefore, the changes were applied manually to align with the JDK 17 structure. The changes look fine to me. The changes that were originally `UnixFileDispatcherImpl.[java/c]` align with the ones in `FileDispatcherImpl.[java/c]`. What testing have you done to validate the changes? Once that is explained and validated I'll approve. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3631#pullrequestreview-2978485680 From duke at openjdk.org Wed Jul 2 10:29:54 2025 From: duke at openjdk.org (duke) Date: Wed, 2 Jul 2025 10:29:54 GMT Subject: [jdk21u-dev] RFR: 8338236: Compile error in cgroup code on Linux when using clang [v4] In-Reply-To: References: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> Message-ID: On Tue, 1 Jul 2025 18:17:27 GMT, Jan Kratochvil wrote: >> A patch 6 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) >> >> It has a patch dependency on PR 5 of 7: https://github.com/openjdk/jdk21u-dev/pull/1662 >> >> This backport is clean. >> >> The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. > > Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: > > retry CI @jankratochvil Your change (at version a3a5d309ac2e7705d418b09b88b70349b1da1dfd) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1663#issuecomment-3027320007 From jkratochvil at openjdk.org Wed Jul 2 11:53:53 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 2 Jul 2025 11:53:53 GMT Subject: [jdk21u-dev] Integrated: 8338236: Compile error in cgroup code on Linux when using clang In-Reply-To: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> References: <7Q3YY2tSRpAHWBKYqPn1xmkVbHrznPR18EqjUnriQ-Q=.e1d8773e-ebc4-4fdd-a14c-2577400dcd74@github.com> Message-ID: On Wed, 16 Apr 2025 10:55:45 GMT, Jan Kratochvil wrote: > A patch 6 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 5 of 7: https://github.com/openjdk/jdk21u-dev/pull/1662 > > This backport is clean. > > The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. This pull request has now been integrated. Changeset: 9d4c0dff Author: Jan Kratochvil Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/9d4c0dff8a282b7e8e7bee0bae8b6acfb0fef22f Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod 8338236: Compile error in cgroup code on Linux when using clang Backport-of: 11639a4ff3722725d014c5814f6d73635f11db4f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1663 From jkratochvil at openjdk.org Wed Jul 2 11:58:13 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 2 Jul 2025 11:58:13 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v2] In-Reply-To: References: Message-ID: <8qhhnRKOkD9jYuzPsC_3Qc6Fa0cxPNpfOkloe9cWayA=.e690549d-2ffe-4b57-adc0-548508e9420c@github.com> > A patch 7 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 6 of 7: https://github.com/openjdk/jdk21u-dev/pull/1663 > > This backport is clean. > > The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1664/files - new: https://git.openjdk.org/jdk21u-dev/pull/1664/files/f7356825..f7356825 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1664&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1664&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1664.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1664/head:pull/1664 PR: https://git.openjdk.org/jdk21u-dev/pull/1664 From duke at openjdk.org Wed Jul 2 13:26:42 2025 From: duke at openjdk.org (duke) Date: Wed, 2 Jul 2025 13:26:42 GMT Subject: [jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v7] In-Reply-To: References: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> Message-ID: On Wed, 2 Jul 2025 08:57:35 GMT, Antonio Vieiro wrote: >> A fix for [JDK-8360816](https://bugs.openjdk.org/browse/JDK-8360816). >> >> The `ProgramFiles(x86)` environment variable is not properly propagated to JTReg tests in JDK11, which makes the AOT compiler tests fail on the new `windows-2025` GHA runners, as manifested in the backport of [https://bugs.openjdk.org/browse/JDK-8358538](JDK-8358538). >> >> Propagating this environment variable to JTRegs may require creating devkits for Windows 2022, but previous attempts were discarded [JDK-8283723](https://bugs.openjdk.org/browse/JDK-8283723). >> >> This fix prints a warning message when this environment variable is not set, and then uses a default value (`C:\Program Files (x86)`) that makes it possible to run the AOT tests with these new `windows-2025` GHA runners. If the `ProgramFiles(x86)` env variable is set the fix has no effect, ensuring the previous behaviour. If the proposed default value is incorrect the AOT tests will continue to fail as before. >> >> The PR is on top of https://github.com/openjdk/jdk11u-dev/pull/3052 to verify the fix works as intended with the new `windows-2025` GHA runners. > > Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: > > Set JTReg ProgramFiles(x86) env. variable on Windows @vieiro Your change (at version 51e8454a1622c29cd780f0bca91d8b6ce8db43e5) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3056#issuecomment-3027877929 From jkratochvil at openjdk.org Wed Jul 2 13:32:35 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 2 Jul 2025 13:32:35 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v3] In-Reply-To: References: Message-ID: > A patch 7 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 6 of 7: https://github.com/openjdk/jdk21u-dev/pull/1663 > > This backport is clean. > > The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits: - Merge remote-tracking branch 'janjdk21u-dev/devmaster-cgroup2reduced123456b' into devmaster-cgroup2reduced123456-new - 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected Reviewed-by: stuefe, asmehra - 8338236: Compile error in cgroup code on Linux when using clang Reviewed-by: mdoerr, sgehwolf - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers Reviewed-by: jsjolen, stuefe - 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container Reviewed-by: stuefe, iklam - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized' - a patch by Yuri Nesterenko - 8333326: Linux Alpine build fails after 8302744 Reviewed-by: sgehwolf, clanger, stuefe - 8302744: Refactor Hotspot container detection code Reviewed-by: jsjolen, stuefe - 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected Reviewed-by: stuefe, asmehra ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1664/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1664&range=02 Stats: 445 lines in 9 files changed: 334 ins; 83 del; 28 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1664.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1664/head:pull/1664 PR: https://git.openjdk.org/jdk21u-dev/pull/1664 From goetz at openjdk.org Wed Jul 2 13:32:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Jul 2025 13:32:54 GMT Subject: [jdk21u-dev] RFR: 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention In-Reply-To: <2pfTBqaaznAFAYqOH1U1tJfv1v0u2AMloUMUSy2IaXY=.118231fa-1296-43d3-8403-f3f1cbabde13@github.com> References: <2pfTBqaaznAFAYqOH1U1tJfv1v0u2AMloUMUSy2IaXY=.118231fa-1296-43d3-8403-f3f1cbabde13@github.com> Message-ID: <07j-bs_NIAQH9koPgW_k1PRw7zk2u3hIjinzT3MmFhU=.e669205c-f21e-4a9a-9f42-d199b0c1352f@github.com> On Mon, 30 Jun 2025 21:03:48 GMT, Daniel Huang wrote: > Backport for ShenandoahLock performance regression issue. The fix involves sleeping for a very short duration every 3 yields, with the number of yields picked through manual testing. > > Clean backport, ran GHA sanity checks and locally tested `tier1`, `tier2`, and `hotspot_gc_shenandoah`. `test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java` sometimes fails locally, but it also sometimes failed before the backport. > `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` fails locally, but it also fails locally before the backport. Hi @dtmhuang Besides running the tier tests, can you please run some large applications that cause contention on the problematic code? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1933#issuecomment-3027900487 From goetz at openjdk.org Wed Jul 2 13:41:49 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Jul 2025 13:41:49 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v3] In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 13:32:35 GMT, Jan Kratochvil wrote: >> A patch 7 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) >> >> It has a patch dependency on PR 6 of 7: https://github.com/openjdk/jdk21u-dev/pull/1663 >> >> This backport is clean. >> >> The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. > > Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits: > > - Merge remote-tracking branch 'janjdk21u-dev/devmaster-cgroup2reduced123456b' into devmaster-cgroup2reduced123456-new > - 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected > > Reviewed-by: stuefe, asmehra > - 8338236: Compile error in cgroup code on Linux when using clang > > Reviewed-by: mdoerr, sgehwolf > - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers > > Reviewed-by: jsjolen, stuefe > - 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container > > Reviewed-by: stuefe, iklam > - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized' > - a patch by Yuri Nesterenko > - 8333326: Linux Alpine build fails after 8302744 > > Reviewed-by: sgehwolf, clanger, stuefe > - 8302744: Refactor Hotspot container detection code > > Reviewed-by: jsjolen, stuefe > - 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected > > Reviewed-by: stuefe, asmehra Hi @jankratochvil Can you please fix the pre-submit tests. Can you please also do a dependent PR for the follow-up build issue? We should submit them close after each other. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1664#issuecomment-3027926708 From duke at openjdk.org Wed Jul 2 14:54:51 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 2 Jul 2025 14:54:51 GMT Subject: [jdk11u-dev] Integrated: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA In-Reply-To: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> References: <_O07TZ2x8VJaHVASGUZwobuVT_9x7HbmQT_fz31s5Lw=.aa9569e3-332e-43cd-8f54-789c52917006@github.com> Message-ID: On Fri, 27 Jun 2025 10:16:29 GMT, Antonio Vieiro wrote: > A fix for [JDK-8360816](https://bugs.openjdk.org/browse/JDK-8360816). > > The `ProgramFiles(x86)` environment variable is not properly propagated to JTReg tests in JDK11, which makes the AOT compiler tests fail on the new `windows-2025` GHA runners, as manifested in the backport of [https://bugs.openjdk.org/browse/JDK-8358538](JDK-8358538). > > Propagating this environment variable to JTRegs may require creating devkits for Windows 2022, but previous attempts were discarded [JDK-8283723](https://bugs.openjdk.org/browse/JDK-8283723). > > This fix prints a warning message when this environment variable is not set, and then uses a default value (`C:\Program Files (x86)`) that makes it possible to run the AOT tests with these new `windows-2025` GHA runners. If the `ProgramFiles(x86)` env variable is set the fix has no effect, ensuring the previous behaviour. If the proposed default value is incorrect the AOT tests will continue to fail as before. > > The PR is on top of https://github.com/openjdk/jdk11u-dev/pull/3052 to verify the fix works as intended with the new `windows-2025` GHA runners. This pull request has now been integrated. Changeset: 646b6b5e Author: Antonio Vieiro Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/646b6b5ed967de67ebf90592eadf08c749c7e364 Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod 8360816: [11u] Use default value for ProgramFiles(x86) in GHA Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/3056 From jkratochvil at openjdk.org Wed Jul 2 14:57:40 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 2 Jul 2025 14:57:40 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4] In-Reply-To: References: Message-ID: > A patch 7 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 6 of 7: https://github.com/openjdk/jdk21u-dev/pull/1663 > > This backport is clean. > > The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. Jan Kratochvil has updated the pull request incrementally with two additional commits since the last revision: - retry CI #2 - retry CI ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1664/files - new: https://git.openjdk.org/jdk21u-dev/pull/1664/files/8f31c049..4d9f7ba5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1664&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1664&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1664.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1664/head:pull/1664 PR: https://git.openjdk.org/jdk21u-dev/pull/1664 From jkratochvil at openjdk.org Wed Jul 2 15:03:46 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 2 Jul 2025 15:03:46 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v3] In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 13:38:43 GMT, Goetz Lindenmaier wrote: > Hi @jankratochvil Can you please fix the pre-submit tests. I have filed for it now: https://bugs.openjdk.org/browse/SKARA-2533 > Can you please also do a dependent PR for the follow-up build issue? We should submit them close after each other. I think that is not relevant as this is a build infrastructure problem. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1664#issuecomment-3028212409 From goetz at openjdk.org Wed Jul 2 15:23:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Jul 2025 15:23:41 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4] In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 14:57:40 GMT, Jan Kratochvil wrote: >> A patch 7 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) >> >> It has a patch dependency on PR 6 of 7: https://github.com/openjdk/jdk21u-dev/pull/1663 >> >> This backport is clean. >> >> The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. > > Jan Kratochvil has updated the pull request incrementally with two additional commits since the last revision: > > - retry CI #2 > - retry CI Hi, Not having JDK-8322420 might break the build for people with clang, don't you think? It's unrelated to the GHA failure, if you want to say that. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1664#issuecomment-3028278270 From iklam at openjdk.org Wed Jul 2 15:31:41 2025 From: iklam at openjdk.org (Ioi Lam) Date: Wed, 2 Jul 2025 15:31:41 GMT Subject: [jdk21u-dev] RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive In-Reply-To: References: Message-ID: On Tue, 27 May 2025 09:12:21 GMT, Timofei Pushkin wrote: > Fixes a error which significantly complicates the use of static CDS in some applications with user-provided class loaders (workarounds require either manually editing the generated CDS classlist which is error-prone, or switching to dynamic CDS which has its own implications, or rewriting the application which is not always possible). > > The conflicts were trivial: a few neighboring methods missing from this version and not directly related to the change. > > The PR depends on #1833 and #1834 though it can be rewritten not to if needed. > > Testing besides the CI (performed on macos/arm64): `runtime/cds`, a minimal reproducer app described in the original bug report. Marked as reviewed by iklam (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1835#pullrequestreview-2979646363 From jkratochvil at openjdk.org Wed Jul 2 15:40:41 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 2 Jul 2025 15:40:41 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4] In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 15:20:43 GMT, Goetz Lindenmaier wrote: > Not having JDK-8322420 might break the build for people with clang, don't you think? I think you mean JDK-8338236 which is for clang. JDK-8322420 is this pull request and this one is unrelated to clang. JDK-8338236 is already backported as: https://github.com/openjdk/jdk21u-dev/commit/9d4c0dff8a282b7e8e7bee0bae8b6acfb0fef22f > It's unrelated to the GHA failure, if you want to say that. GHA failure happens randomly with any pull request. Currently I do not see it anywhere. As the GHA problem is repeating I have filed the GHA problem as: https://bugs.openjdk.org/browse/SKARA-2533 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1664#issuecomment-3028334802 From sgehwolf at openjdk.org Wed Jul 2 15:45:41 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 2 Jul 2025 15:45:41 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4] In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 15:37:38 GMT, Jan Kratochvil wrote: > > Not having JDK-8322420 might break the build for people with clang, don't you think? I believe the follow-up we'd want after this is: https://bugs.openjdk.org/browse/JDK-8341644 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1664#issuecomment-3028351905 From shade at openjdk.org Wed Jul 2 16:05:23 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 2 Jul 2025 16:05:23 GMT Subject: [jdk17u-dev] RFR: 8351997: AArch64: Interpreter volatile reference stores with G1 are not sequentially consistent Message-ID: Fixes AArch64 memory ordering problem. Readily manifests in new jcstress tests; there are sightings of related problems in JSR 133 tests. The patch is not clean, because [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) is in the way, and it is IMO too risky to backport. I picked up the JDK 21u backport version (https://git.openjdk.org/jdk21u-dev/commit/729f10053eab4b8fe8a857e14ce0f96a82c721b8), where I resolved some hunks to match the intended behavior, after checking `do_oop_store` clobbers the same `r3` as in mainline. Additional testing: - [x] Linux AArch64 server release, jcstress `RefDekker` test now passes - [x] Linux AArch64 server release, jcstress `seqcst.volatiles.ref` tests now pass - [ ] Linux AArch64 server release, jcstress `all` tests now pass - [ ] Linux AArch64 server fastdebug, `all` ------------- Commit messages: - Backport 83b15da2eb3cb6c8937f517c9b75eaa9eeece314 Changes: https://git.openjdk.org/jdk17u-dev/pull/3697/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3697&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8351997 Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3697.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3697/head:pull/3697 PR: https://git.openjdk.org/jdk17u-dev/pull/3697 From duke at openjdk.org Wed Jul 2 16:11:40 2025 From: duke at openjdk.org (duke) Date: Wed, 2 Jul 2025 16:11:40 GMT Subject: [jdk21u-dev] RFR: 8320859: gtest high malloc footprint caused by BufferNodeAllocator stress test In-Reply-To: References: Message-ID: On Fri, 27 Jun 2025 18:09:48 GMT, Daniel Hu wrote: > Clean backport. Reduces memory usage of gtest BufferNodeAllocatorTest.stress_free_list_allocator_vm. GHA passes. Affected gtest passes. @cost0much Your change (at version a7c51b640349dd28c24a6828e2aca7d3117de2c5) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1931#issuecomment-3028438497 From duke at openjdk.org Wed Jul 2 16:29:45 2025 From: duke at openjdk.org (Daniel Hu) Date: Wed, 2 Jul 2025 16:29:45 GMT Subject: [jdk21u-dev] Integrated: 8320859: gtest high malloc footprint caused by BufferNodeAllocator stress test In-Reply-To: References: Message-ID: <9CBSiHuFuLDcxJcgKaSMPZcXonB4nWVPGMiCY3lIFiw=.35e95ae3-b0ee-4bd4-8684-7683015c49b0@github.com> On Fri, 27 Jun 2025 18:09:48 GMT, Daniel Hu wrote: > Clean backport. Reduces memory usage of gtest BufferNodeAllocatorTest.stress_free_list_allocator_vm. GHA passes. Affected gtest passes. This pull request has now been integrated. Changeset: dbed35f4 Author: Daniel Hu Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/dbed35f41583f19c70645632a688d0c8ae1bd36a Stats: 14 lines in 1 file changed: 5 ins; 0 del; 9 mod 8320859: gtest high malloc footprint caused by BufferNodeAllocator stress test Backport-of: abf2e4909733550c228bd66ccebe33a492269e7f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1931 From jkratochvil at openjdk.org Wed Jul 2 16:39:51 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 2 Jul 2025 16:39:51 GMT Subject: [jdk21u-dev] RFR: 8341644: Compile error in cgroup coding when using toolchain clang Message-ID: A patch 8 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) It has a patch dependency on PR 7 of 7: https://github.com/openjdk/jdk21u-dev/pull/1664 This backport is clean. ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1664 Commit messages: - 8341644: Compile error in cgroup coding when using toolchain clang Changes: https://git.openjdk.org/jdk21u-dev/pull/1934/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1934&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341644 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1934.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1934/head:pull/1934 PR: https://git.openjdk.org/jdk21u-dev/pull/1934 From eosterlund at openjdk.org Wed Jul 2 16:42:45 2025 From: eosterlund at openjdk.org (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 2 Jul 2025 16:42:45 GMT Subject: [jdk17u-dev] RFR: 8351997: AArch64: Interpreter volatile reference stores with G1 are not sequentially consistent In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 12:19:05 GMT, Aleksey Shipilev wrote: > Fixes AArch64 memory ordering problem. Readily manifests in new jcstress tests; there are sightings of related problems in JSR 133 tests. > > The patch is not clean, because [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) is in the way, and it is IMO too risky to backport. I picked up the JDK 21u backport version (https://git.openjdk.org/jdk21u-dev/commit/729f10053eab4b8fe8a857e14ce0f96a82c721b8), where I resolved some hunks to match the intended behavior, after checking `do_oop_store` clobbers the same `r3` as in mainline. > > Additional testing: > - [x] Linux AArch64 server release, jcstress `RefDekker` test now passes > - [x] Linux AArch64 server release, jcstress `seqcst.volatiles.ref` tests now pass > - [ ] Linux AArch64 server release, jcstress `all` tests now pass > - [ ] Linux AArch64 server fastdebug, `all` Marked as reviewed by eosterlund (Committer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3697#pullrequestreview-2979886287 From rkannathpari at openjdk.org Wed Jul 2 16:46:49 2025 From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad) Date: Wed, 2 Jul 2025 16:46:49 GMT Subject: [jdk25u] Integrated: 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119) In-Reply-To: References: Message-ID: <1zj9bFB3MUtZZc2JZDeVP2qJVgV8lI5WKCzR_3lgVjo=.ef18067a-6da3-44cc-8392-44d4af56094b@github.com> On Thu, 12 Jun 2025 12:15:31 GMT, Renjith Kannath Pariyangad wrote: > Hi all, > > This pull request contains a backport of commit [2103dc15](https://github.com/openjdk/jdk/commit/2103dc15cb662fd8795b1b51d9cb61c389bed7a0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 9 Jun 2025 and was reviewed by Prasanta Sadhukhan, Sergey Bylokhov, Alexey Ivanov and Alexey Ushakov. > > Thanks! This pull request has now been integrated. Changeset: 94b6b99b Author: Renjith Kannath Pariyangad Committer: Paul Hohensee URL: https://git.openjdk.org/jdk25u/commit/94b6b99ba4909ec8db8ca9cffe641d80384ada13 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119) Backport-of: 2103dc15cb662fd8795b1b51d9cb61c389bed7a0 ------------- PR: https://git.openjdk.org/jdk25u/pull/3 From duke at openjdk.org Wed Jul 2 17:03:41 2025 From: duke at openjdk.org (duke) Date: Wed, 2 Jul 2025 17:03:41 GMT Subject: [jdk21u-dev] RFR: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 22:05:01 GMT, Todd V. Jonker wrote: > This is a clean backport of [d3f3011](https://github.com/openjdk/jdk/commit/d3f3011d56267360d65841da3550eca79cf1575b), originally authored by @archiecobbs and reviewed by @jaikiran > > I believe this should be covered by CSR https://bugs.openjdk.org/browse/JDK-8340729 though (as noted there) the description and issue metadata differ regarding JDK21. > > Testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: headless tiers 1-3 @toddjonker Your change (at version 4bf6edabc20acd5f3416f893a98efe70af98c9db) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1897#issuecomment-3028598873 From duke at openjdk.org Wed Jul 2 17:08:45 2025 From: duke at openjdk.org (Todd V. Jonker) Date: Wed, 2 Jul 2025 17:08:45 GMT Subject: [jdk21u-dev] Integrated: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 22:05:01 GMT, Todd V. Jonker wrote: > This is a clean backport of [d3f3011](https://github.com/openjdk/jdk/commit/d3f3011d56267360d65841da3550eca79cf1575b), originally authored by @archiecobbs and reviewed by @jaikiran > > I believe this should be covered by CSR https://bugs.openjdk.org/browse/JDK-8340729 though (as noted there) the description and issue metadata differ regarding JDK21. > > Testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: headless tiers 1-3 This pull request has now been integrated. Changeset: fcbf863f Author: Todd V. Jonker Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/fcbf863f4b71fe49b8883a5a2152912cde8ab72c Stats: 111 lines in 2 files changed: 96 ins; 9 del; 6 mod 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream Backport-of: d3f3011d56267360d65841da3550eca79cf1575b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1897 From duke at openjdk.org Wed Jul 2 17:29:01 2025 From: duke at openjdk.org (Todd V. Jonker) Date: Wed, 2 Jul 2025 17:29:01 GMT Subject: [jdk17u-dev] RFR: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream Message-ID: This is a clean backport of [d3f3011](https://github.com/openjdk/jdk/commit/d3f3011d56267360d65841da3550eca79cf1575b), originally authored by @archiecobbs and reviewed by @jaikiran The corresponding backport for JDK21 is https://github.com/openjdk/jdk21u-dev/pull/1897 Testing: - [x] New regression test fails without the fix, passes with it - [x] linux-x86_64-server-release: headless tiers 1-3 ------------- Commit messages: - Backport d3f3011d56267360d65841da3550eca79cf1575b Changes: https://git.openjdk.org/jdk17u-dev/pull/3667/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3667&range=00 Issue: https://bugs.openjdk.org/browse/JDK-7036144 Stats: 111 lines in 2 files changed: 96 ins; 9 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3667.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3667/head:pull/3667 PR: https://git.openjdk.org/jdk17u-dev/pull/3667 From duke at openjdk.org Wed Jul 2 17:40:44 2025 From: duke at openjdk.org (Daniel Huang) Date: Wed, 2 Jul 2025 17:40:44 GMT Subject: [jdk21u-dev] RFR: 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention In-Reply-To: <2pfTBqaaznAFAYqOH1U1tJfv1v0u2AMloUMUSy2IaXY=.118231fa-1296-43d3-8403-f3f1cbabde13@github.com> References: <2pfTBqaaznAFAYqOH1U1tJfv1v0u2AMloUMUSy2IaXY=.118231fa-1296-43d3-8403-f3f1cbabde13@github.com> Message-ID: On Mon, 30 Jun 2025 21:03:48 GMT, Daniel Huang wrote: > Backport for ShenandoahLock performance regression issue. The fix involves sleeping for a very short duration every 3 yields, with the number of yields picked through manual testing. > > Clean backport, ran GHA sanity checks and locally tested `tier1`, `tier2`, and `hotspot_gc_shenandoah`. `test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java` sometimes fails locally, but it also sometimes failed before the backport. > `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` fails locally, but it also fails locally before the backport. Sure! The original fix had code to reproduce the bug: import java.util.concurrent.CountDownLatch; import java.util.concurrent.Semaphore; public class Alloc { static final CountDownLatch startSignal = new CountDownLatch(1); static final Semaphore semaphore = new Semaphore(128); static final int THREADS = 1024; //64 threads per CPU core, 16 cores static final Object[] sinks = new Object[64 * THREADS]; static volatile boolean start; static volatile boolean stop; private static void waitOnStartSignal() { try { startSignal.await(); } catch (InterruptedException e) { throw new RuntimeException(e); } } public static void main(String... args) throws Throwable { for (int t = 0; t < THREADS; t++) { int ft = t; new Thread(() -> work(ft * 64)).start(); } Thread.sleep(1000); startSignal.countDown(); Thread.sleep(30_000); stop = true; } public static void work(int idx) { waitOnStartSignal(); while (!stop) { semaphore.acquireUninterruptibly(); try { sinks[idx] = new byte[128]; } catch (Throwable ex) { throw new RuntimeException(ex); } finally { semaphore.release(); } } } } I ran this on the command line with `.build/linux-x86_64-server-release/jdk/bin/java -Xms256m -Xmx256m -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:-ShenandoahPacing -XX:-UseTLAB -Xlog:gc -Xlog:safepoint Alloc.java | grep -Po "At safepoint: \d+ ns" | grep -Po "\d+" | sort -nr` Running this without the fix gives at-safepoint times 22273444 11615507 11297887 10424031 10117190 9789552 9754920 9599965 7477300 6897913 Running with the backported fix gives at-safepoint times 15667088 8279113 3800276 853206 464314 399752 387322 381562 378641 358231 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1933#issuecomment-3028728951 From duke at openjdk.org Wed Jul 2 17:57:45 2025 From: duke at openjdk.org (Daniel Huang) Date: Wed, 2 Jul 2025 17:57:45 GMT Subject: [jdk17u-dev] RFR: 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention [v2] In-Reply-To: <-eVoBn7cxEqe-vDv_6cSzxu6ygoye9hyWtbSowclkrs=.18768430-8efd-48ab-b887-8f3e53186ebc@github.com> References: <65ZadztmSSwGRFmbUcZkeYV7zxJApNIp-r1aRmjezMQ=.0f48e0bf-5083-4a70-a1f4-b34d4ee8a4cf@github.com> <-eVoBn7cxEqe-vDv_6cSzxu6ygoye9hyWtbSowclkrs=.18768430-8efd-48ab-b887-8f3e53186ebc@github.com> Message-ID: On Mon, 30 Jun 2025 16:28:27 GMT, Daniel Huang wrote: >> Backport for ShenandoahLock performance regression issue. The fix involves sleeping for a very short duration every 3 yields, with the number of yields picked through manual testing. >> >> Clean backport, ran GHA sanity checks and locally tested `tier1`, `tier2`, and `hotspot_gc_shenandoah`. `test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java` sometimes fails locally, but it also sometimes failed before the backport. >> `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` fails locally, but it also fails locally before the backport. > > Daniel Huang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-JDK-8350285-shenandoahlock > - Merge branch 'openjdk:master' into backport-JDK-8350285-shenandoahlock > - Backport bd8ad309b59bceb3073a8d6411cca74e73508885 Ran an additional test: The original fix had code to reproduce the bug: import java.util.concurrent.CountDownLatch; import java.util.concurrent.Semaphore; public class Alloc { static final CountDownLatch startSignal = new CountDownLatch(1); static final Semaphore semaphore = new Semaphore(128); static final int THREADS = 1024; //64 threads per CPU core, 16 cores static final Object[] sinks = new Object[64 * THREADS]; static volatile boolean start; static volatile boolean stop; private static void waitOnStartSignal() { try { startSignal.await(); } catch (InterruptedException e) { throw new RuntimeException(e); } } public static void main(String... args) throws Throwable { for (int t = 0; t < THREADS; t++) { int ft = t; new Thread(() -> work(ft * 64)).start(); } Thread.sleep(1000); startSignal.countDown(); Thread.sleep(30_000); stop = true; } public static void work(int idx) { waitOnStartSignal(); while (!stop) { semaphore.acquireUninterruptibly(); try { sinks[idx] = new byte[128]; } catch (Throwable ex) { throw new RuntimeException(ex); } finally { semaphore.release(); } } } } I ran this on the command line with `.build/linux-x86_64-server-release/jdk/bin/java -Xms256m -Xmx256m -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:-ShenandoahPacing -XX:-UseTLAB -Xlog:gc -Xlog:safepoint Alloc.java | grep -Po "At safepoint: \d+ ns" | grep -Po "\d+" | sort -nr` Running this without the fix gives at-safepoint times 78352042 71620203 69088015 63752840 61954634 57154656 55503155 50447201 49957634 42141662 Running with the backported fix gives at-safepoint times 14292926 5145001 3579042 3204251 1854438 1734104 1664821 1647101 1621830 1542978 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3614#issuecomment-3028816808 From duke at openjdk.org Wed Jul 2 20:47:33 2025 From: duke at openjdk.org (Daniel Huang) Date: Wed, 2 Jul 2025 20:47:33 GMT Subject: [jdk17u-dev] RFR: 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes Message-ID: Backport for RandomSupport issue. There is a loss of information when using `convertSeedBytesToLongs()` with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result. Note there is an exact same issue/bugfix with `convertSeedBytesToInts()`, but I will backport that bugfix separately Clean backport, ran GHA sanity checks and locally tested tier1, tier2. In tier2, there were 2 failures: `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` `test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java` However, these both failed before the backport as well. The backport also includes the test for this issue `T8282144.java`, which passes. ------------- Commit messages: - Backport 5fab27e1b8fdf2ea27cb3b349bd339a4a6ec828b Changes: https://git.openjdk.org/jdk17u-dev/pull/3698/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3698&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282144 Stats: 72 lines in 2 files changed: 71 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3698.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3698/head:pull/3698 PR: https://git.openjdk.org/jdk17u-dev/pull/3698 From serb at openjdk.org Wed Jul 2 23:16:19 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 2 Jul 2025 23:16:19 GMT Subject: [jdk21u-dev] RFR: 8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode Message-ID: Hi all, This pull request contains a backport of commit [ce0ca476](https://github.com/openjdk/jdk/commit/ce0ca476416cb6f96d4b6b4852144382d6abf717) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Daniel D. Daugherty on 29 Oct 2023 and was reviewed by Jaikiran Pai. Thanks! ------------- Commit messages: - Backport ce0ca476416cb6f96d4b6b4852144382d6abf717 Changes: https://git.openjdk.org/jdk21u-dev/pull/1935/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1935&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319067 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1935.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1935/head:pull/1935 PR: https://git.openjdk.org/jdk21u-dev/pull/1935 From sgehwolf at openjdk.org Thu Jul 3 08:49:46 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 3 Jul 2025 08:49:46 GMT Subject: [jdk21u-dev] RFR: 8341644: Compile error in cgroup coding when using toolchain clang In-Reply-To: References: Message-ID: <8EWZhTPTXOAkxf3C2QmRZozhWvlKCKGX-o2zidnaMfs=.92b63004-5b96-4668-a493-5dacdc3bd7a9@github.com> On Wed, 2 Jul 2025 16:33:39 GMT, Jan Kratochvil wrote: > A patch 8 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 7 of 7: https://github.com/openjdk/jdk21u-dev/pull/1664 > > This backport is clean. @jankratochvil Please apply for approval on this one too. Using `/approval`. Thank you. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1934#issuecomment-3031420500 From shade at openjdk.org Thu Jul 3 12:34:45 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 3 Jul 2025 12:34:45 GMT Subject: [jdk17u-dev] RFR: 8351997: AArch64: Interpreter volatile reference stores with G1 are not sequentially consistent In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 12:19:05 GMT, Aleksey Shipilev wrote: > Fixes AArch64 memory ordering problem. Readily manifests in new jcstress tests; there are sightings of related problems in JSR 133 tests. > > The patch is not clean, because [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) is in the way, and it is IMO too risky to backport. I picked up the JDK 21u backport version (https://git.openjdk.org/jdk21u-dev/commit/729f10053eab4b8fe8a857e14ce0f96a82c721b8), where I resolved some hunks to match the intended behavior, after checking `do_oop_store` clobbers the same `r3` as in mainline. > > Additional testing: > - [x] Linux AArch64 server release, jcstress `RefDekker` test now passes > - [x] Linux AArch64 server release, jcstress `seqcst.volatiles.ref` tests now pass > - [x] Linux AArch64 server release, jcstress `all` tests now pass > - [x] Linux AArch64 server fastdebug, `all` > @shipilev 8351997: Approval has already been requested and approved. Well, that's odd. Looks like @theRealAph approved the backport before I asked for the approval :) Was that intentional, Andrew? I'll put `jdk17u-fix-request` manually for better records, anyhow. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3697#issuecomment-3032096461 From sgehwolf at openjdk.org Thu Jul 3 13:30:41 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 3 Jul 2025 13:30:41 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4] In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 14:57:40 GMT, Jan Kratochvil wrote: >> A patch 7 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) >> >> It has a patch dependency on PR 6 of 7: https://github.com/openjdk/jdk21u-dev/pull/1663 >> >> This backport is clean. >> >> The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. > > Jan Kratochvil has updated the pull request incrementally with two additional commits since the last revision: > > - retry CI #2 > - retry CI Please `/integrate`. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1664#issuecomment-3032269735 From goetz at openjdk.org Thu Jul 3 13:31:46 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 13:31:46 GMT Subject: [jdk21u-dev] Integrated: 8226919: attach in linux hangs due to permission denied accessing /proc/pid/root In-Reply-To: <_SnuKhxbEgQ4wDKDHk7xAdZczuVIx887ucYYcbX162s=.63b3720a-a10e-46ec-8664-f81033c44e6c@github.com> References: <_SnuKhxbEgQ4wDKDHk7xAdZczuVIx887ucYYcbX162s=.63b3720a-a10e-46ec-8664-f81033c44e6c@github.com> Message-ID: On Mon, 30 Jun 2025 15:33:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle, This pull request has now been integrated. Changeset: c70ef074 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c70ef07456028d40cdfc14300e2c947d4d97c26f Stats: 36 lines in 1 file changed: 21 ins; 11 del; 4 mod 8226919: attach in linux hangs due to permission denied accessing /proc/pid/root Backport-of: ac4607ed81eb75f43e7d1062e38506972738d086 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1932 From goetz at openjdk.org Thu Jul 3 13:31:46 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 13:31:46 GMT Subject: [jdk17u-dev] Integrated: 8302635: Race condition in HttpBodySubscriberWrapper when cancelling request In-Reply-To: References: Message-ID: On Mon, 30 Jun 2025 14:37:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: c53cae6a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c53cae6a0b510201f0dd62236c273b85820693c6 Stats: 235 lines in 4 files changed: 190 ins; 22 del; 23 mod 8302635: Race condition in HttpBodySubscriberWrapper when cancelling request Backport-of: edf238b65e441a1d626f3a4ba06170badd05ca7c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3690 From goetz at openjdk.org Thu Jul 3 13:39:57 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 13:39:57 GMT Subject: [jdk17u-dev] RFR: 8299338: AssertionError in ResponseSubscribers$HttpResponseInputStream::onSubscribe [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.17-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3695/files - new: https://git.openjdk.org/jdk17u-dev/pull/3695/files/d799544c..d799544c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3695&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3695&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3695.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3695/head:pull/3695 PR: https://git.openjdk.org/jdk17u-dev/pull/3695 From duke at openjdk.org Thu Jul 3 13:42:46 2025 From: duke at openjdk.org (duke) Date: Thu, 3 Jul 2025 13:42:46 GMT Subject: [jdk21u-dev] RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4] In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 14:57:40 GMT, Jan Kratochvil wrote: >> A patch 7 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) >> >> It has a patch dependency on PR 6 of 7: https://github.com/openjdk/jdk21u-dev/pull/1663 >> >> This backport is clean. >> >> The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. > > Jan Kratochvil has updated the pull request incrementally with two additional commits since the last revision: > > - retry CI #2 > - retry CI @jankratochvil Your change (at version 4d9f7ba55ae931a986c029086c190a19d0413c82) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1664#issuecomment-3032321251 From jkratochvil at openjdk.org Thu Jul 3 13:49:46 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 3 Jul 2025 13:49:46 GMT Subject: [jdk21u-dev] Integrated: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected In-Reply-To: References: Message-ID: On Wed, 16 Apr 2025 11:12:02 GMT, Jan Kratochvil wrote: > A patch 7 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 6 of 7: https://github.com/openjdk/jdk21u-dev/pull/1663 > > This backport is clean. > > The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers. This pull request has now been integrated. Changeset: 65e9d36d Author: Jan Kratochvil Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/65e9d36d8074d0a23de0dbb6ddf5f0de9ce5e5fd Stats: 445 lines in 9 files changed: 334 ins; 83 del; 28 mod 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected Backport-of: fd80e759e8b0a471c0eeaaa63a62d3bc5e4cb372 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1664 From mbaesken at openjdk.org Thu Jul 3 13:51:15 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 3 Jul 2025 13:51:15 GMT Subject: [jdk17u-dev] RFR: 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table Message-ID: 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table ------------- Commit messages: - Backport bac2aa44454982684e06854add1dbbb806fba363 Changes: https://git.openjdk.org/jdk17u-dev/pull/3699/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3699&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352946 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3699.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3699/head:pull/3699 PR: https://git.openjdk.org/jdk17u-dev/pull/3699 From jkratochvil at openjdk.org Thu Jul 3 13:56:30 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 3 Jul 2025 13:56:30 GMT Subject: [jdk21u-dev] RFR: 8341644: Compile error in cgroup coding when using toolchain clang [v2] In-Reply-To: References: Message-ID: > A patch 8 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 7 of 7: https://github.com/openjdk/jdk21u-dev/pull/1664 > > This backport is clean. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: - 8341644: Compile error in cgroup coding when using toolchain clang Reviewed-by: stefank, mdoerr - retry CI #2 - retry CI - Merge remote-tracking branch 'janjdk21u-dev/devmaster-cgroup2reduced123456b' into devmaster-cgroup2reduced123456-new - 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected Reviewed-by: stuefe, asmehra - 8338236: Compile error in cgroup code on Linux when using clang Reviewed-by: mdoerr, sgehwolf - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers Reviewed-by: jsjolen, stuefe - 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container Reviewed-by: stuefe, iklam - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized' - a patch by Yuri Nesterenko - 8333326: Linux Alpine build fails after 8302744 Reviewed-by: sgehwolf, clanger, stuefe - ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/9d4c0dff...e886f48f ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1934/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1934&range=01 Stats: 445 lines in 9 files changed: 334 ins; 83 del; 28 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1934.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1934/head:pull/1934 PR: https://git.openjdk.org/jdk21u-dev/pull/1934 From goetz at openjdk.org Thu Jul 3 13:59:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 13:59:59 GMT Subject: [jdk17u-dev] RFR: 8299338: AssertionError in ResponseSubscribers$HttpResponseInputStream::onSubscribe [v3] In-Reply-To: References: Message-ID: <99VkM3M7Qeg3DZr7uICCgpl5fC5EFMQkQ2wtkL2OPx0=.ad7920cb-9052-4cd1-b3c4-6ab8717da0b5@github.com> > I backport this for parity with 17.0.17-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8299338 - Backport 575484806ce11634d4fa8bef6c0c5987e4e0a1c7 - Backport edf238b65e441a1d626f3a4ba06170badd05ca7c ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3695/files - new: https://git.openjdk.org/jdk17u-dev/pull/3695/files/d799544c..65435459 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3695&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3695&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3695.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3695/head:pull/3695 PR: https://git.openjdk.org/jdk17u-dev/pull/3695 From goetz at openjdk.org Thu Jul 3 13:59:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 13:59:59 GMT Subject: [jdk17u-dev] Integrated: 8299338: AssertionError in ResponseSubscribers$HttpResponseInputStream::onSubscribe In-Reply-To: References: Message-ID: On Mon, 30 Jun 2025 20:17:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: ffa7dd58 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ffa7dd58711fc711d71c94753bcfdfdcaaaed752 Stats: 52 lines in 6 files changed: 19 ins; 16 del; 17 mod 8299338: AssertionError in ResponseSubscribers$HttpResponseInputStream::onSubscribe Backport-of: 575484806ce11634d4fa8bef6c0c5987e4e0a1c7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3695 From goetz at openjdk.org Thu Jul 3 14:00:43 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 14:00:43 GMT Subject: [jdk17u-dev] Integrated: 8226919: attach in linux hangs due to permission denied accessing /proc/pid/root In-Reply-To: References: Message-ID: <6bI0UAa38cFv9FPB6HbJl0TUI2MJmUD2Vpvm8pV3eLI=.4b9a34e9-73cb-447b-a207-c72ff1142af9@github.com> On Mon, 30 Jun 2025 15:34:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: ca475980 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ca47598016470bb997038b378a5dbde923b40e28 Stats: 36 lines in 1 file changed: 21 ins; 11 del; 4 mod 8226919: attach in linux hangs due to permission denied accessing /proc/pid/root Backport-of: ac4607ed81eb75f43e7d1062e38506972738d086 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3692 From shade at openjdk.org Thu Jul 3 14:06:41 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 3 Jul 2025 14:06:41 GMT Subject: [jdk21u-dev] RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 13:48:14 GMT, Roland Westrelin wrote: > Patch doesn't apply cleanly: > > - jdk21u still has IU barriers: context for some of the changes is > different. > > - Because of IU barriers, there's an extra call to `fix_ctrl()` for > which the renaming to `nodes_above_barriers` must be applied. > > - The initial patch makes a subtle change that doesn't affect jdk > 25/26 in the code that was > refactored. `ShenandoahBarrierC2Support::push_data_inputs_at_control()` > is introduced with logic: > > if (in != nullptr && phase->has_ctrl(in) && phase->get_ctrl(in) == ctrl) { > > > which replaces the same logic in > `ShenandoahBarrierC2Support::fix_ctrl()` but also a slightly > different logic in > `ShenandoahBarrierC2Support::is_dominator_same_ctrl()`: > > > if (m->in(i) != nullptr && phase->ctrl_or_self(m->in(i)) == c) { > > > that is, it uses `ctrl_or_self()` which works for both data nodes > and control nodes but the new method uses `has_ctrl(in) && > get_ctrl(in)` which can only be true for data nodes. That change > causes failures in jdk 21 again because of IU barriers that produce > a new memory state when expanded and need the logic from > `MemoryGraphFixer`. What I propose in this backport to be on the > safe side is to leave > `ShenandoahBarrierC2Support::is_dominator_same_ctrl()` alone (not > apply that part of the refactoring). > > Tested with hotspot_gc_shenandoah + tier1 with -XX:+UseShenandoahGC I took a deeper look at this, and I have a concern about the divergence from mainline. It might be that some subsequent backport that applies to `maybe_push_anti_dependent_loads` or `push_data_inputs_at_control` would miss the need to update `is_dominator_same_ctrl`. IU mode is also experimental, so risking the default (SATB) mode this way to avoid the breakage if IU seems doubly awkward. So, seeing that the trouble is in `push_data_inputs_at_control`, I propose/suggest we pick up all the hunks from mainline, but change `push_data_inputs_at_control` to clearly demarcate the difference for IU mode. E.g.: void ShenandoahBarrierC2Support::push_data_inputs_at_control(PhaseIdealLoop* phase, Node* n, Node* ctrl, Unique_Node_List &wq) { for (uint i = 0; i < n->req(); i++) { Node* in = n->in(i); if (in != nullptr && (ShenandoahIUBarrier ? (phase->ctrl_or_self(in)) == ctrl) : (phase->has_ctrl(in) && phase->get_ctrl(in) == ctrl))) { wq.push(in); } } } Would that work, @rwestrel? ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1901#pullrequestreview-2983331511 From goetz at openjdk.org Thu Jul 3 14:14:15 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 14:14:15 GMT Subject: [jdk17u-dev] RFR: 8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport b7104ba9a9006ab65e08ea9d7db22e72611ed07c Changes: https://git.openjdk.org/jdk17u-dev/pull/3700/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3700&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8196017 Stats: 24 lines in 2 files changed: 9 ins; 6 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3700.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3700/head:pull/3700 PR: https://git.openjdk.org/jdk17u-dev/pull/3700 From aph at openjdk.org Thu Jul 3 14:14:40 2025 From: aph at openjdk.org (Andrew Haley) Date: Thu, 3 Jul 2025 14:14:40 GMT Subject: [jdk17u-dev] RFR: 8351997: AArch64: Interpreter volatile reference stores with G1 are not sequentially consistent In-Reply-To: References: Message-ID: <6Ov2KTEHDrkOjf3lPuJUfTAXkjsbSzQmUkcUcklyGyw=.1455daa9-9a23-4855-adc4-d70659127b66@github.com> On Thu, 3 Jul 2025 12:32:19 GMT, Aleksey Shipilev wrote: > > @shipilev 8351997: Approval has already been requested and approved. > > Well, that's odd. Looks like @theRealAph approved the backport before I asked for the approval :) Was that intentional, Andrew? I'll put `jdk17u-fix-request` manually for better records, anyhow. Oh, sorry. I was going to review it, and then I thought to myself that maintainers are rarer than approvers, so it's a better bottleneck to do the approval. I never thought to check you'd asked. I'm not sure that _requiring_ an ask before approval is granted is more than process for its own sake anyway. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3697#issuecomment-3032433859 From sgehwolf at openjdk.org Thu Jul 3 14:17:44 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 3 Jul 2025 14:17:44 GMT Subject: [jdk21u-dev] RFR: 8341644: Compile error in cgroup coding when using toolchain clang [v2] In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 13:56:30 GMT, Jan Kratochvil wrote: >> A patch 8 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) >> >> It has a patch dependency on PR 7 of 7: https://github.com/openjdk/jdk21u-dev/pull/1664 >> >> This backport is clean. > > Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - 8341644: Compile error in cgroup coding when using toolchain clang > > Reviewed-by: stefank, mdoerr > - retry CI #2 > - retry CI > - Merge remote-tracking branch 'janjdk21u-dev/devmaster-cgroup2reduced123456b' into devmaster-cgroup2reduced123456-new > - 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected > > Reviewed-by: stuefe, asmehra > - 8338236: Compile error in cgroup code on Linux when using clang > > Reviewed-by: mdoerr, sgehwolf > - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers > > Reviewed-by: jsjolen, stuefe > - 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container > > Reviewed-by: stuefe, iklam > - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized' > - a patch by Yuri Nesterenko > - 8333326: Linux Alpine build fails after 8302744 > > Reviewed-by: sgehwolf, clanger, stuefe > - ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/9d4c0dff...e886f48f @jankratochvil Please resolve the merge conflicts and then this PR should transition to ready as well. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1934#issuecomment-3032443809 From jkratochvil at openjdk.org Thu Jul 3 14:21:55 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 3 Jul 2025 14:21:55 GMT Subject: [jdk21u-dev] RFR: 8341644: Compile error in cgroup coding when using toolchain clang [v3] In-Reply-To: References: Message-ID: > A patch 8 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 7 of 7: https://github.com/openjdk/jdk21u-dev/pull/1664 > > This backport is clean. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - Merge branch 'devmaster-cgroup2reduced1234568' into devmaster-cgroup2reduced1234568-new - 8341644: Compile error in cgroup coding when using toolchain clang Reviewed-by: stefank, mdoerr - retry CI #2 - retry CI - Merge remote-tracking branch 'janjdk21u-dev/devmaster-cgroup2reduced123456b' into devmaster-cgroup2reduced123456-new - 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected Reviewed-by: stuefe, asmehra - 8338236: Compile error in cgroup code on Linux when using clang Reviewed-by: mdoerr, sgehwolf - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers Reviewed-by: jsjolen, stuefe - 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container Reviewed-by: stuefe, iklam - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized' - a patch by Yuri Nesterenko - ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/65e9d36d...26a41c35 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/1934/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1934&range=02 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1934.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1934/head:pull/1934 PR: https://git.openjdk.org/jdk21u-dev/pull/1934 From goetz at openjdk.org Thu Jul 3 14:26:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 14:26:20 GMT Subject: [jdk17u-dev] RFR: 8297499: Parallel: Missing iteration over klass when marking objArrays/objArrayOops during Full GC Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 6a856bc3f67d539f858904667ee86cbed54f94f7 Changes: https://git.openjdk.org/jdk17u-dev/pull/3701/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3701&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297499 Stats: 55 lines in 2 files changed: 43 ins; 3 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3701.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3701/head:pull/3701 PR: https://git.openjdk.org/jdk17u-dev/pull/3701 From goetz at openjdk.org Thu Jul 3 14:36:57 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 14:36:57 GMT Subject: [jdk17u-dev] RFR: 8297740: runtime/ClassUnload/UnloadTest.java failed with "Test failed: should still be live" Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/3701 Commit messages: - Backport a97e7d9887e448c88f59cf70bfb8ab72435ece9c Changes: https://git.openjdk.org/jdk17u-dev/pull/3702/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3702&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297740 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3702.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3702/head:pull/3702 PR: https://git.openjdk.org/jdk17u-dev/pull/3702 From goetz at openjdk.org Thu Jul 3 15:14:58 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 15:14:58 GMT Subject: [jdk21u-dev] RFR: 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1 Message-ID: I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport e21d06f488bce227eedc4c92d976301a7b54fda8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1936/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1936&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344338 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1936.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1936/head:pull/1936 PR: https://git.openjdk.org/jdk21u-dev/pull/1936 From goetz at openjdk.org Thu Jul 3 15:15:23 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Jul 2025 15:15:23 GMT Subject: [jdk17u-dev] RFR: 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1 Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport e21d06f488bce227eedc4c92d976301a7b54fda8 Changes: https://git.openjdk.org/jdk17u-dev/pull/3703/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3703&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344338 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3703.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3703/head:pull/3703 PR: https://git.openjdk.org/jdk17u-dev/pull/3703 From shade at openjdk.org Thu Jul 3 16:59:41 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 3 Jul 2025 16:59:41 GMT Subject: [jdk17u-dev] RFR: 8351997: AArch64: Interpreter volatile reference stores with G1 are not sequentially consistent In-Reply-To: <6Ov2KTEHDrkOjf3lPuJUfTAXkjsbSzQmUkcUcklyGyw=.1455daa9-9a23-4855-adc4-d70659127b66@github.com> References: <6Ov2KTEHDrkOjf3lPuJUfTAXkjsbSzQmUkcUcklyGyw=.1455daa9-9a23-4855-adc4-d70659127b66@github.com> Message-ID: On Thu, 3 Jul 2025 14:12:25 GMT, Andrew Haley wrote: > Oh, sorry. I was going to review it, and then I thought to myself that maintainers are rarer than approvers, so it's a better bottleneck to do the approval. I never thought to check you'd asked. Yeah, I followed the process: submit the PR, let people look at it while testing is running, wait until testing is complete, use test results as the justification for backport. So there is a natural sequence of events here :) Anyhow, I need a formal Review in this PR, as Erik's "committer" review formally does not count. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3697#issuecomment-3032946556 From duke at openjdk.org Thu Jul 3 17:37:45 2025 From: duke at openjdk.org (duke) Date: Thu, 3 Jul 2025 17:37:45 GMT Subject: [jdk21u-dev] RFR: 8341644: Compile error in cgroup coding when using toolchain clang [v3] In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 14:21:55 GMT, Jan Kratochvil wrote: >> A patch 8 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) >> >> It has a patch dependency on PR 7 of 7: https://github.com/openjdk/jdk21u-dev/pull/1664 >> >> This backport is clean. > > Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: > > - Merge branch 'devmaster-cgroup2reduced1234568' into devmaster-cgroup2reduced1234568-new > - 8341644: Compile error in cgroup coding when using toolchain clang > > Reviewed-by: stefank, mdoerr > - retry CI #2 > - retry CI > - Merge remote-tracking branch 'janjdk21u-dev/devmaster-cgroup2reduced123456b' into devmaster-cgroup2reduced123456-new > - 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected > > Reviewed-by: stuefe, asmehra > - 8338236: Compile error in cgroup code on Linux when using clang > > Reviewed-by: mdoerr, sgehwolf > - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers > > Reviewed-by: jsjolen, stuefe > - 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container > > Reviewed-by: stuefe, iklam > - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized' > - a patch by Yuri Nesterenko > - ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/65e9d36d...26a41c35 @jankratochvil Your change (at version 26a41c3556ac9c3c5c0af7d0d73d87d261077a2f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1934#issuecomment-3033042908 From dchuyko at openjdk.org Thu Jul 3 18:46:30 2025 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 3 Jul 2025 18:46:30 GMT Subject: [jdk11u-dev] RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool [v3] In-Reply-To: References: Message-ID: > This a backport of JDK-8351933 [0] (PR [1]) for 11u. At one of code paths the TC subfield of ctl field is decremented and the result is not masked correctly. The target code is in runWorker() instead of tryTrim()/awaitWork() and the surrounding code is different from the current master, as well as the original mask name. The core change is the same, candidate for CTL.compareAndSet is constructed using '(RC_MASK & c) | (TC_MASK & (c - TC_UNIT))' instead of '(UC_MASK & (c - TC_UNIT))' to correctly preserve the RC subfield. > > [0] https://bugs.openjdk.org/browse/JDK-8351933 > [1] https://github.com/openjdk/jdk/pull/24034 Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8351936 - Merge branch 'openjdk:master' into JDK-8351936 - RC_MASK and TC_MASK instead of UC_MASK ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/3012/files - new: https://git.openjdk.org/jdk11u-dev/pull/3012/files/362a8007..71d0c8f9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3012&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3012&range=01-02 Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3012.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3012/head:pull/3012 PR: https://git.openjdk.org/jdk11u-dev/pull/3012 From tkurashige at openjdk.org Fri Jul 4 02:35:06 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Fri, 4 Jul 2025 02:35:06 GMT Subject: [jdk11u-dev] RFR: 8355249: Remove the use of WMIC from the entire source code Message-ID: Hi all, This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported. Original patch does not apply cleanly because WindowsHelper.java doesn't exist in jdk11. WindowsHelper.java was added in jdk14 ([JDK-8212780](https://bugs.openjdk.org/browse/JDK-8212780)). Except for this point, original patch applies cleanly. ------------- Commit messages: - Backport 4458719a108f45d3744d47a6ea081fe9ec3e675e Changes: https://git.openjdk.org/jdk11u-dev/pull/3057/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3057&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355249 Stats: 16 lines in 3 files changed: 4 ins; 1 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3057.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3057/head:pull/3057 PR: https://git.openjdk.org/jdk11u-dev/pull/3057 From goetz at openjdk.org Fri Jul 4 07:41:50 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Jul 2025 07:41:50 GMT Subject: [jdk17u-dev] RFR: 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1 In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 15:09:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. GHA failure: ant download failed, will restart. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3703#issuecomment-3034846168 From goetz at openjdk.org Fri Jul 4 07:43:29 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Jul 2025 07:43:29 GMT Subject: [jdk21u-dev] RFR: 8344137: Update XML Security for Java to 3.0.5 Message-ID: I backport this for parity with 21.0.8-oracle. Clean backport except for GenerationTests.java. That differs because the backport of this update always omits the new signature method Strings so that the standard must not be touched, see also the backport CSR. The test was adapted to this in the past in 21. We need to adapt this change, too. We can just skip the chunk that does not apply in GenerationTests. It increments the number of methods, but as this is not changed in 21 we don't need this. In an extra commit I remove the new method strings and adapt the test to it. ------------- Commit messages: - Adapt to CSR - backport 18e0b343ab002b193d4db3be226394ee7dbe9f19 Changes: https://git.openjdk.org/jdk21u-dev/pull/1937/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1937&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344137 Stats: 640 lines in 24 files changed: 600 ins; 12 del; 28 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1937.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1937/head:pull/1937 PR: https://git.openjdk.org/jdk21u-dev/pull/1937 From duke at openjdk.org Fri Jul 4 07:52:45 2025 From: duke at openjdk.org (Andrew Lygin) Date: Fri, 4 Jul 2025 07:52:45 GMT Subject: [jdk21u-dev] RFR: 8332506: SIGFPE In ObjectSynchronizer::is_async_deflation_needed() In-Reply-To: References: Message-ID: On Wed, 2 Apr 2025 10:33:08 GMT, Roman Marchenko wrote: > This is backport of "[JDK-8332506](https://bugs.openjdk.org/browse/JDK-8332506) SIGFPE In ObjectSynchronizer::is_async_deflation_needed()". > > This fixes division by zero problem in JDK21 as there are cases the problem occurs in 21. > > Backport is almost clean, I resolved a few minor conflicts (copyright, and type conversion differences). Hi! Could someone, please, suggest, is switching to ParallelGC a workaround for this bug? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1566#issuecomment-3034868172 From duke at openjdk.org Fri Jul 4 07:59:47 2025 From: duke at openjdk.org (anuj-ion) Date: Fri, 4 Jul 2025 07:59:47 GMT Subject: [jdk17u-dev] RFR: 8347826: Introspector shows wrong method list after 8071693 In-Reply-To: References: Message-ID: On Thu, 5 Jun 2025 09:07:14 GMT, Roman Marchenko wrote: > This is backport of "8347826: Introspector shows wrong method list after 8071693" > > The backport is almost clean, the only conflicts were in copyright year in 2 files. @GoeLin , Sir, you validated [same request](https://github.com/openjdk/jdk21u-dev/pull/184) for JDK21 last month7. Can you please help to move this PR as well. Many thanks, Anuj ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3618#issuecomment-3034886796 From tpushkin at openjdk.org Fri Jul 4 08:49:44 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Fri, 4 Jul 2025 08:49:44 GMT Subject: [jdk21u-dev] RFR: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() [v3] In-Reply-To: <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> References: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> Message-ID: On Wed, 2 Jul 2025 06:44:07 GMT, Timofei Pushkin wrote: >> The original change cleaned up code of static CDS. I am backporting it as a dependency of [JDK-8315130](https://bugs.openjdk.org/browse/JDK-8315130) which I am backporting next (#1835): without this change the backport JDK-8315130 would need to include some parts of this change and would also leave some code unused. >> >> Resolved conflicts: >> - `src/hotspot/share/cds/unregisteredClasses.cpp`: bug fix [JDK-8343416](https://bugs.openjdk.org/browse/JDK-8343416) is missing in this version but the backported change itself incorporates the bug fix (to verify I checked that the backport makes [the test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) pass, but I did not include that test in this PR) >> - `src/hotspot/share/cds/classListParser.*pp`: constant pool resolution was added there in JDK 23/24 as part of Project Layden ([JDK-8293980](https://bugs.openjdk.org/browse/JDK-8293980), [JDK-8332176](https://bugs.openjdk.org/browse/JDK-8332176)) ? this required only insignificant changes to the backport >> - The rest of the conflicts were trivial (caused by renaming, neighboring code removal, copyright year updates) >> >> Testing besides the CI (performed on macos/arm64): `runtime/cds`, [test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) (not included in the backport since that is a separate change). > > Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge remote-tracking branch 'jdk-jdk21u-dev/master' into app-cds-bug-2 > - 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() > > Reviewed-by: ccheung, coleenp > - 8339460: CDS error when module is located in a directory with space in the name > > Reviewed-by: ccheung, iklam @iklam Thank you for reviewing the main backport #1835, could you please also review this dependency of it? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1834#issuecomment-3035022195 From jkratochvil at openjdk.org Fri Jul 4 09:07:45 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Fri, 4 Jul 2025 09:07:45 GMT Subject: [jdk21u-dev] Integrated: 8341644: Compile error in cgroup coding when using toolchain clang In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 16:33:39 GMT, Jan Kratochvil wrote: > A patch 8 of 7 for: [[21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-April/043206.html) > > It has a patch dependency on PR 7 of 7: https://github.com/openjdk/jdk21u-dev/pull/1664 > > This backport is clean. This pull request has now been integrated. Changeset: 4e0f354b Author: Jan Kratochvil Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/4e0f354b49a95e5e6017c02b95736fe9d85710e8 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod 8341644: Compile error in cgroup coding when using toolchain clang Backport-of: 6e486181613bde8da6874eeed680c7136e8d778a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1934 From mbaesken at openjdk.org Fri Jul 4 09:11:46 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 4 Jul 2025 09:11:46 GMT Subject: [jdk21u-dev] RFR: 8344137: Update XML Security for Java to 3.0.5 In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 16:12:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle. > > Clean backport except for GenerationTests.java. > That differs because the backport of this update always > omits the new signature method Strings so that the standard > must not be touched, see also the backport CSR. > The test was adapted to this in the past in 21. > > We need to adapt this change, too. > > We can just skip the chunk that does not apply > in GenerationTests. > It increments the number of methods, but as this > is not changed in 21 we don't need this. > > In an extra commit I remove the new method strings and > adapt the test to it. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1937#pullrequestreview-2986205106 From mvs at openjdk.org Fri Jul 4 09:38:21 2025 From: mvs at openjdk.org (Manukumar V S) Date: Fri, 4 Jul 2025 09:38:21 GMT Subject: [jdk25u] RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar Message-ID: This is the backport of a test stabilisation fix done by @manukumarvs and approved by @aivanov-jdk. Issue: In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar. This may open some other UI item and may interfere further testing on that machine. Fix: Move the test UI to the centre of the screen by calling frame.setLocationRelativeTo(null). ------------- Commit messages: - Backport b7fcd0b2351cee8d3d18abaf0bf5905d20c9d46c Changes: https://git.openjdk.org/jdk25u/pull/12/files Webrev: https://webrevs.openjdk.org/?repo=jdk25u&pr=12&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359889 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk25u/pull/12.diff Fetch: git fetch https://git.openjdk.org/jdk25u.git pull/12/head:pull/12 PR: https://git.openjdk.org/jdk25u/pull/12 From goetz at openjdk.org Fri Jul 4 10:25:43 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Jul 2025 10:25:43 GMT Subject: [jdk21u-dev] RFR: 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention In-Reply-To: References: <2pfTBqaaznAFAYqOH1U1tJfv1v0u2AMloUMUSy2IaXY=.118231fa-1296-43d3-8403-f3f1cbabde13@github.com> Message-ID: On Wed, 2 Jul 2025 17:37:42 GMT, Daniel Huang wrote: >> Backport for ShenandoahLock performance regression issue. The fix involves sleeping for a very short duration every 3 yields, with the number of yields picked through manual testing. >> >> Clean backport, ran GHA sanity checks and locally tested `tier1`, `tier2`, and `hotspot_gc_shenandoah`. `test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java` sometimes fails locally, but it also sometimes failed before the backport. >> `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` fails locally, but it also fails locally before the backport. > > Sure! > > The original fix had code to reproduce the bug: > > import java.util.concurrent.CountDownLatch; > import java.util.concurrent.Semaphore; > > public class Alloc { > static final CountDownLatch startSignal = new CountDownLatch(1); > static final Semaphore semaphore = new Semaphore(128); > static final int THREADS = 1024; //64 threads per CPU core, 16 cores > static final Object[] sinks = new Object[64 * THREADS]; > static volatile boolean start; > static volatile boolean stop; > > private static void waitOnStartSignal() { > try { > startSignal.await(); > } catch (InterruptedException e) { > throw new RuntimeException(e); > } > } > > public static void main(String... args) throws Throwable { > for (int t = 0; t < THREADS; t++) { > int ft = t; > new Thread(() -> work(ft * 64)).start(); > } > > Thread.sleep(1000); > startSignal.countDown(); > Thread.sleep(30_000); > stop = true; > } > > public static void work(int idx) { > waitOnStartSignal(); > while (!stop) { > semaphore.acquireUninterruptibly(); > try { > sinks[idx] = new byte[128]; > } catch (Throwable ex) { > throw new RuntimeException(ex); > } finally { > semaphore.release(); > } > } > } > } > > > I ran this on the command line with > `.build/linux-x86_64-server-release/jdk/bin/java -Xms256m -Xmx256m -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:-ShenandoahPacing -XX:-UseTLAB -Xlog:gc -Xlog:safepoint Alloc.java | grep -Po "At safepoint: \d+ ns" | grep -Po "\d+" | sort -nr` > > Running this without the fix gives at-safepoint times > > 22273444 > 11615507 > 11297887 > 10424031 > 10117190 > 9789552 > 9754920 > 9599965 > 7477300 > 6897913 > > > Running with the backported fix gives at-safepoint times > > 15667088 > 8279113 > 3800276 > 853206 > 464314 > 399752 > 387322 > 381562 > 378641 > 358231 Hi @dtmhuang well, that shows that the change does what it intends to do. That's not my point. I want to make sure you cause no regressions of any other kind. jdk25, which you mention wrt. testing is not live yet. I don't see why we should take any risk for a performance optimization that helps only in rare situations. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1933#issuecomment-3035405536 From goetz at openjdk.org Fri Jul 4 10:38:44 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Jul 2025 10:38:44 GMT Subject: [jdk17u-dev] RFR: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream In-Reply-To: References: Message-ID: On Thu, 19 Jun 2025 19:24:36 GMT, Todd V. Jonker wrote: > This is a clean backport of [d3f3011](https://github.com/openjdk/jdk/commit/d3f3011d56267360d65841da3550eca79cf1575b), originally authored by @archiecobbs and reviewed by @jaikiran > > The corresponding backport for JDK21 is https://github.com/openjdk/jdk21u-dev/pull/1897 > > Testing: > - [x] New regression test fails without the fix, passes with it > - [x] linux-x86_64-server-release: headless tiers 1-3 Hi @toddjonker Have you tested anything besides the jtreg tests mentioned above? This change modifies behaviour, this might have negative side effects, especially on the many working installations that receive this update. Oracle tried to backport, but they didn't deliver it. Usually, they have a good reason for this. Do we need to rush this backport? I would rather defer it to the next (January) release to get experience with the change in 21. People can go to 21 or soon 25 if they have an issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3667#issuecomment-3035479753 From goetz at openjdk.org Fri Jul 4 10:57:42 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Jul 2025 10:57:42 GMT Subject: [jdk21u-dev] RFR: 8344137: Update XML Security for Java to 3.0.5 In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 16:12:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle. > > Clean backport except for GenerationTests.java. > That differs because the backport of this update always > omits the new signature method Strings so that the standard > must not be touched, see also the backport CSR. > The test was adapted to this in the past in 21. > > We need to adapt this change, too. > > We can just skip the chunk that does not apply > in GenerationTests. > It increments the number of methods, but as this > is not changed in 21 we don't need this. > > In an extra commit I remove the new method strings and > adapt the test to it. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1937#issuecomment-3035582582 From mbaesken at openjdk.org Fri Jul 4 11:32:54 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 4 Jul 2025 11:32:54 GMT Subject: [jdk17u-dev] Integrated: 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 13:46:47 GMT, Matthias Baesken wrote: > 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table This pull request has now been integrated. Changeset: 2f8944c0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/2f8944c0c6f075688ffe6b931df00fce15e2d22a Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table Backport-of: bac2aa44454982684e06854add1dbbb806fba363 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3699 From mbaesken at openjdk.org Fri Jul 4 11:42:51 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 4 Jul 2025 11:42:51 GMT Subject: [jdk17u-dev] RFR: 8353568: SEGV_BNDERR signal code adjust definition Message-ID: 8353568: SEGV_BNDERR signal code adjust definition ------------- Commit messages: - Backport 6abf4e6d4d9f948b8ae51aec731b94ba7acd022e Changes: https://git.openjdk.org/jdk17u-dev/pull/3704/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3704&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353568 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3704.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3704/head:pull/3704 PR: https://git.openjdk.org/jdk17u-dev/pull/3704 From adinn at openjdk.org Fri Jul 4 13:02:43 2025 From: adinn at openjdk.org (Andrew Dinn) Date: Fri, 4 Jul 2025 13:02:43 GMT Subject: [jdk17u-dev] RFR: 8351997: AArch64: Interpreter volatile reference stores with G1 are not sequentially consistent In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 12:19:05 GMT, Aleksey Shipilev wrote: > Fixes AArch64 memory ordering problem. Readily manifests in new jcstress tests; there are sightings of related problems in JSR 133 tests. > > The patch is not clean, because [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) is in the way, and it is IMO too risky to backport. I picked up the JDK 21u backport version (https://git.openjdk.org/jdk21u-dev/commit/729f10053eab4b8fe8a857e14ce0f96a82c721b8), where I resolved some hunks to match the intended behavior, after checking `do_oop_store` clobbers the same `r3` as in mainline. > > Additional testing: > - [x] Linux AArch64 server release, jcstress `RefDekker` test now passes > - [x] Linux AArch64 server release, jcstress `seqcst.volatiles.ref` tests now pass > - [x] Linux AArch64 server release, jcstress `all` tests now pass > - [x] Linux AArch64 server fastdebug, `all` Yep, nod it through . . . ------------- Marked as reviewed by adinn (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3697#pullrequestreview-2987150114 From goetz at openjdk.org Fri Jul 4 13:04:39 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Jul 2025 13:04:39 GMT Subject: [jdk21u-dev] Integrated: 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1 In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 15:09:35 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle This pull request has now been integrated. Changeset: 0faea690 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/0faea690a065b9c31893296d526e1f6f899b2c0d Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1 Backport-of: e21d06f488bce227eedc4c92d976301a7b54fda8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1936 From goetz at openjdk.org Fri Jul 4 13:05:44 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Jul 2025 13:05:44 GMT Subject: [jdk21u-dev] Integrated: 8344137: Update XML Security for Java to 3.0.5 In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 16:12:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.8-oracle. > > Clean backport except for GenerationTests.java. > That differs because the backport of this update always > omits the new signature method Strings so that the standard > must not be touched, see also the backport CSR. > The test was adapted to this in the past in 21. > > We need to adapt this change, too. > > We can just skip the chunk that does not apply > in GenerationTests. > It increments the number of methods, but as this > is not changed in 21 we don't need this. > > In an extra commit I remove the new method strings and > adapt the test to it. This pull request has now been integrated. Changeset: 2d30662c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/2d30662c5dff99c2fa06fc9e06426a9baabd2b57 Stats: 640 lines in 24 files changed: 600 ins; 12 del; 28 mod 8344137: Update XML Security for Java to 3.0.5 Reviewed-by: mbaesken Backport-of: 18e0b343ab002b193d4db3be226394ee7dbe9f19 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1937 From goetz at openjdk.org Fri Jul 4 13:21:28 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Jul 2025 13:21:28 GMT Subject: [jdk17u-dev] RFR: 8344137: Update XML Security for Java to 3.0.5 Message-ID: I backport this for parity with 17.0.17-oracle from 21. Clean backport, but line endings clash for xmlsecurity_en.properties. The file had windows line endings in 17, unix ones in 21. I changed the file (on my linux system) to unix line endings. ------------- Commit messages: - backport 2d30662c5dff99c2fa06fc9e06426a9baabd2b57 Changes: https://git.openjdk.org/jdk17u-dev/pull/3705/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3705&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344137 Stats: 837 lines in 24 files changed: 600 ins; 12 del; 225 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3705.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3705/head:pull/3705 PR: https://git.openjdk.org/jdk17u-dev/pull/3705 From shade at openjdk.org Fri Jul 4 13:27:47 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 4 Jul 2025 13:27:47 GMT Subject: [jdk17u-dev] RFR: 8351997: AArch64: Interpreter volatile reference stores with G1 are not sequentially consistent In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 12:19:05 GMT, Aleksey Shipilev wrote: > Fixes AArch64 memory ordering problem. Readily manifests in new jcstress tests; there are sightings of related problems in JSR 133 tests. > > The patch is not clean, because [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) is in the way, and it is IMO too risky to backport. I picked up the JDK 21u backport version (https://git.openjdk.org/jdk21u-dev/commit/729f10053eab4b8fe8a857e14ce0f96a82c721b8), where I resolved some hunks to match the intended behavior, after checking `do_oop_store` clobbers the same `r3` as in mainline. > > Additional testing: > - [x] Linux AArch64 server release, jcstress `RefDekker` test now passes > - [x] Linux AArch64 server release, jcstress `seqcst.volatiles.ref` tests now pass > - [x] Linux AArch64 server release, jcstress `all` tests now pass > - [x] Linux AArch64 server fastdebug, `all` Thanks, here we go. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3697#issuecomment-3036275952 From shade at openjdk.org Fri Jul 4 13:27:48 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 4 Jul 2025 13:27:48 GMT Subject: [jdk17u-dev] Integrated: 8351997: AArch64: Interpreter volatile reference stores with G1 are not sequentially consistent In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 12:19:05 GMT, Aleksey Shipilev wrote: > Fixes AArch64 memory ordering problem. Readily manifests in new jcstress tests; there are sightings of related problems in JSR 133 tests. > > The patch is not clean, because [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) is in the way, and it is IMO too risky to backport. I picked up the JDK 21u backport version (https://git.openjdk.org/jdk21u-dev/commit/729f10053eab4b8fe8a857e14ce0f96a82c721b8), where I resolved some hunks to match the intended behavior, after checking `do_oop_store` clobbers the same `r3` as in mainline. > > Additional testing: > - [x] Linux AArch64 server release, jcstress `RefDekker` test now passes > - [x] Linux AArch64 server release, jcstress `seqcst.volatiles.ref` tests now pass > - [x] Linux AArch64 server release, jcstress `all` tests now pass > - [x] Linux AArch64 server fastdebug, `all` This pull request has now been integrated. Changeset: 0e9b1df4 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/0e9b1df4d75b9d233c0297b0763b052e9fde55ed Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod 8351997: AArch64: Interpreter volatile reference stores with G1 are not sequentially consistent Reviewed-by: eosterlund, adinn Backport-of: 83b15da2eb3cb6c8937f517c9b75eaa9eeece314 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3697 From bulasevich at openjdk.org Fri Jul 4 15:11:03 2025 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Fri, 4 Jul 2025 15:11:03 GMT Subject: [jdk25u] RFR: 8358183: [JVMCI] crash accessing nmethod::jvmci_name in CodeCache::aggregate Message-ID: <4Eog8u0AKpGEff-0ma7t27FwGpmmrtislpfbWiZ0Iro=.409cb9a4-d2fd-43b0-adb8-41d2ccae41d3@github.com> This is the backport of the JVMCI metadata crash fix. Issue: When flushing nmethods via CodeBlob::purge(), the JVMCI metadata was freed (mutable_data) but its size fields remained non-zero. As a result, invoking heap analytics via jcmd Compiler.CodeHeap_Analytics still walks the purged metadata and calls jvmci_name() on arbitrary memory, leading to intermittent crashes Fix: Extend CodeBlob::purge() to zero out the _mutable_data_size, _relocation_size, and _metadata_size fields so that after a purge jvmci_data_size() returns 0 and CompileBroker::print_heapinfo() skips any JVMCI metadata ------------- Commit messages: - Backport 74822ce12acaf9816aa49b75ab5817ced3710776 Changes: https://git.openjdk.org/jdk25u/pull/13/files Webrev: https://webrevs.openjdk.org/?repo=jdk25u&pr=13&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8358183 Stats: 3 lines in 2 files changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk25u/pull/13.diff Fetch: git fetch https://git.openjdk.org/jdk25u.git pull/13/head:pull/13 PR: https://git.openjdk.org/jdk25u/pull/13 From sgehwolf at openjdk.org Fri Jul 4 16:05:38 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 4 Jul 2025 16:05:38 GMT Subject: [jdk21u-dev] RFR: 8333446: Add tests for hierarchical container support Message-ID: Please review this test-only backport. Now that https://bugs.openjdk.org/browse/JDK-8322420 is in jdk21u-dev it makes sense to automatically test this functionality. The patch is clean except for the changes in `VMProps.java` which I've added manually. The only non-test tree change is to `whitebox.cpp`. Testing: - [x] GHA - [x] container tests on Linux x86 with cgroups v2 and cgroups v1 Thoughts? Note: I'll follow up with [JDK-8340092](https://bugs.openjdk.org/browse/JDK-8340092) once this is in. ------------- Commit messages: - Backport d9fdf69c34c20e0f2d526c2f04450acb904c3e80 Changes: https://git.openjdk.org/jdk21u-dev/pull/1938/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1938&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333446 Stats: 655 lines in 9 files changed: 648 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1938.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1938/head:pull/1938 PR: https://git.openjdk.org/jdk21u-dev/pull/1938 From duke at openjdk.org Sat Jul 5 03:08:45 2025 From: duke at openjdk.org (duke) Date: Sat, 5 Jul 2025 03:08:45 GMT Subject: [jdk25u] RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 09:33:43 GMT, Manukumar V S wrote: > This is the backport of a test stabilisation fix done by @manukumarvs and approved by @aivanov-jdk. > > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar. This may open some other UI item and may interfere further testing on that machine. > > Fix: > Move the test UI to the centre of the screen by calling frame.setLocationRelativeTo(null). @manukumarvs Your change (at version 3c28e2655dae3bc06d0742061be4af3429c01fbf) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/12#issuecomment-3037785068 From stuefe at openjdk.org Sat Jul 5 11:19:48 2025 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 5 Jul 2025 11:19:48 GMT Subject: [jdk17u-dev] RFR: 8351500: G1: NUMA migrations cause crashes in region allocation In-Reply-To: References: Message-ID: On Thu, 22 May 2025 13:16:06 GMT, Thomas Stuefe wrote: > This is not a clean backport. The effected G1Allocator and G1Collector methods have changed since JDK17. > > So this backports reimplements the patch in a minimally invasive way while retaining as much similarity as possible with the original patch. > > The gist of the patch is clear: instead of finding out the NUMA node index at every instance of G1Allocator::allocate_xxx, and then be subject to NUMA node migrations, we fix the NUMA node index once and use that one. > > I tested this patch with my "FakeNUMA" addition (I plan to upstream that one at some point). This FakeNUMA mode mimics a lot of NUMA node migrations. I can verify that without this patch the JVM crashes quickly, with the patch it does not crash. Could I please have reviews? @jerboaa maybe or @gnu-andrew ? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3607#issuecomment-3038786726 From goetz at openjdk.org Sat Jul 5 16:18:48 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 5 Jul 2025 16:18:48 GMT Subject: [jdk17u-dev] Integrated: 8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 14:08:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: f893fa30 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f893fa30de90ff07932b7e4dae4346e45cf63f7c Stats: 24 lines in 2 files changed: 9 ins; 6 del; 9 mod 8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails Backport-of: b7104ba9a9006ab65e08ea9d7db22e72611ed07c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3700 From goetz at openjdk.org Sat Jul 5 16:19:45 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 5 Jul 2025 16:19:45 GMT Subject: [jdk17u-dev] Integrated: 8297499: Parallel: Missing iteration over klass when marking objArrays/objArrayOops during Full GC In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 14:20:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: ac047084 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ac04708432259c1b2076a50db13835dbe681d774 Stats: 55 lines in 2 files changed: 43 ins; 3 del; 9 mod 8297499: Parallel: Missing iteration over klass when marking objArrays/objArrayOops during Full GC Backport-of: 6a856bc3f67d539f858904667ee86cbed54f94f7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3701 From goetz at openjdk.org Sat Jul 5 16:24:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 5 Jul 2025 16:24:20 GMT Subject: [jdk17u-dev] RFR: 8297740: runtime/ClassUnload/UnloadTest.java failed with "Test failed: should still be live" [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.17-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8297740 - Backport a97e7d9887e448c88f59cf70bfb8ab72435ece9c - Backport 6a856bc3f67d539f858904667ee86cbed54f94f7 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3702/files - new: https://git.openjdk.org/jdk17u-dev/pull/3702/files/3be17c4d..ec8b90af Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3702&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3702&range=00-01 Stats: 38 lines in 4 files changed: 19 ins; 6 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3702.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3702/head:pull/3702 PR: https://git.openjdk.org/jdk17u-dev/pull/3702 From goetz at openjdk.org Sat Jul 5 16:24:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 5 Jul 2025 16:24:20 GMT Subject: [jdk17u-dev] Integrated: 8297740: runtime/ClassUnload/UnloadTest.java failed with "Test failed: should still be live" In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 14:32:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: a14a93e6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/a14a93e64b83ca3bc234f195d80277c3b00d97d3 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod 8297740: runtime/ClassUnload/UnloadTest.java failed with "Test failed: should still be live" Backport-of: a97e7d9887e448c88f59cf70bfb8ab72435ece9c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3702 From goetz at openjdk.org Sat Jul 5 16:24:40 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 5 Jul 2025 16:24:40 GMT Subject: [jdk17u-dev] Integrated: 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 08:54:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: 0b8af09d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0b8af09d5ed6b901d3a940c91a6c4d5673b48bcc Stats: 82 lines in 1 file changed: 55 ins; 11 del; 16 mod 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong Backport-of: 4c5b66dceab15ce27f742c4173e14156249eb61a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3696 From goetz at openjdk.org Sat Jul 5 16:23:27 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 5 Jul 2025 16:23:27 GMT Subject: [jdk17u-dev] RFR: 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1 [v2] In-Reply-To: References: Message-ID: <_QTzfNghQueXgELwTo-9vStHNYSGIutyzn7IYTUG7-M=.65bd1547-5e1c-4222-9b9c-572ab7574642@github.com> > I backport this for parity with 17.0.17-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-GoeLin-e21d06f4-master - Backport e21d06f488bce227eedc4c92d976301a7b54fda8 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3703/files - new: https://git.openjdk.org/jdk17u-dev/pull/3703/files/a4a78fff..2f25f89e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3703&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3703&range=00-01 Stats: 93 lines in 6 files changed: 62 ins; 9 del; 22 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3703.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3703/head:pull/3703 PR: https://git.openjdk.org/jdk17u-dev/pull/3703 From mvs at openjdk.org Sun Jul 6 08:21:41 2025 From: mvs at openjdk.org (Manukumar V S) Date: Sun, 6 Jul 2025 08:21:41 GMT Subject: [jdk25u] RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 09:33:43 GMT, Manukumar V S wrote: > This is the backport of a test stabilisation fix done by @manukumarvs and approved by @aivanov-jdk. > > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar. This may open some other UI item and may interfere further testing on that machine. > > Fix: > Move the test UI to the centre of the screen by calling frame.setLocationRelativeTo(null). Any sponsors? ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/12#issuecomment-3041185580 From serb at openjdk.org Sun Jul 6 09:07:48 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 6 Jul 2025 09:07:48 GMT Subject: [jdk21u-dev] Integrated: 8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 23:10:40 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [ce0ca476](https://github.com/openjdk/jdk/commit/ce0ca476416cb6f96d4b6b4852144382d6abf717) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Daniel D. Daugherty on 29 Oct 2023 and was reviewed by Jaikiran Pai. > > Thanks! This pull request has now been integrated. Changeset: bb0d4c13 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/bb0d4c13b89f764b0a6dd3b24a1cbdaf60f94eaa Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode Backport-of: ce0ca476416cb6f96d4b6b4852144382d6abf717 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1935 From jkratochvil at openjdk.org Sun Jul 6 21:48:43 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sun, 6 Jul 2025 21:48:43 GMT Subject: [jdk21u-dev] RFR: 8333446: Add tests for hierarchical container support In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 16:00:30 GMT, Severin Gehwolf wrote: > Please review this test-only backport. Now that https://bugs.openjdk.org/browse/JDK-8322420 is in jdk21u-dev it makes sense to automatically test this functionality. The patch is clean except for the changes in `VMProps.java` which I've added manually. > > The only non-test tree change is to `whitebox.cpp`. > > Testing: > - [x] GHA > - [x] container tests on Linux x86 with cgroups v2 and cgroups v1 > > Thoughts? > > Note: I'll follow up with [JDK-8340092](https://bugs.openjdk.org/browse/JDK-8340092) once this is in. LGTM ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1938#issuecomment-3042796305 From syan at openjdk.org Mon Jul 7 02:53:38 2025 From: syan at openjdk.org (SendaoYan) Date: Mon, 7 Jul 2025 02:53:38 GMT Subject: [jdk24u] RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails In-Reply-To: References: Message-ID: On Fri, 6 Jun 2025 02:01:23 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [9ca1004e](https://github.com/openjdk/jdk/commit/9ca1004e76a614328cd2eb7546143839c4d2f810) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by pawan chawdhary on 22 May 2025 and was reviewed by Mikhailo Seledtsov and Leonid Mesnik. > > Thanks! I think jdk24u do not need backported now. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/228#issuecomment-3043327248 From syan at openjdk.org Mon Jul 7 02:53:38 2025 From: syan at openjdk.org (SendaoYan) Date: Mon, 7 Jul 2025 02:53:38 GMT Subject: [jdk24u] Withdrawn: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails In-Reply-To: References: Message-ID: On Fri, 6 Jun 2025 02:01:23 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [9ca1004e](https://github.com/openjdk/jdk/commit/9ca1004e76a614328cd2eb7546143839c4d2f810) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by pawan chawdhary on 22 May 2025 and was reviewed by Mikhailo Seledtsov and Leonid Mesnik. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk24u/pull/228 From iklam at openjdk.org Mon Jul 7 04:07:46 2025 From: iklam at openjdk.org (Ioi Lam) Date: Mon, 7 Jul 2025 04:07:46 GMT Subject: [jdk21u-dev] RFR: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() [v3] In-Reply-To: References: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> Message-ID: On Fri, 4 Jul 2025 08:46:41 GMT, Timofei Pushkin wrote: >> Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge remote-tracking branch 'jdk-jdk21u-dev/master' into app-cds-bug-2 >> - 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() >> >> Reviewed-by: ccheung, coleenp >> - 8339460: CDS error when module is located in a directory with space in the name >> >> Reviewed-by: ccheung, iklam > > @iklam Thank you for reviewing the main backport #1835, could you please also review this dependency of it? @TimPushkin could you get JDK 21u maintainer approval first? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1834#issuecomment-3043411878 From tpushkin at openjdk.org Mon Jul 7 05:09:45 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Mon, 7 Jul 2025 05:09:45 GMT Subject: [jdk21u-dev] RFR: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() [v3] In-Reply-To: References: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> Message-ID: On Mon, 7 Jul 2025 04:05:03 GMT, Ioi Lam wrote: >> @iklam Thank you for reviewing the main backport #1835, could you please also review this dependency of it? > > @TimPushkin could you get JDK 21u maintainer approval first? @iklam I am new to backporting, but the order is to first get a review and only then request a maintainer approval. Or do you mean for #1835? I figured, it is better to request approvals for both changes at the same time, since I won't be able to merge that without this one anyway. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1834#issuecomment-3043489815 From mbaesken at openjdk.org Mon Jul 7 07:13:49 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 7 Jul 2025 07:13:49 GMT Subject: [jdk17u-dev] RFR: 8344137: Update XML Security for Java to 3.0.5 In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 13:15:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle from 21. > > Clean backport, but line endings clash for xmlsecurity_en.properties. > The file had windows line endings in 17, unix ones in 21. > I changed the file (on my linux system) to unix line endings. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3705#pullrequestreview-2992459430 From mbaesken at openjdk.org Mon Jul 7 07:19:51 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 7 Jul 2025 07:19:51 GMT Subject: [jdk25u] Integrated: 8360533: ContainerRuntimeVersionTestUtils fromVersionString fails with some docker versions In-Reply-To: References: Message-ID: On Mon, 30 Jun 2025 08:14:34 GMT, Matthias Baesken wrote: > 8360533: ContainerRuntimeVersionTestUtils fromVersionString fails with some docker versions This pull request has now been integrated. Changeset: 622c7434 Author: Matthias Baesken URL: https://git.openjdk.org/jdk25u/commit/622c7434707a9ee00928c9ae4d93c3cf9f68b7b1 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod 8360533: ContainerRuntimeVersionTestUtils fromVersionString fails with some docker versions Backport-of: 97ec9d3e0a6e3455579b567e1f58026f5b168c09 ------------- PR: https://git.openjdk.org/jdk25u/pull/10 From goetz at openjdk.org Mon Jul 7 07:30:45 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 07:30:45 GMT Subject: [jdk17u-dev] Integrated: 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1 In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 15:09:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: cb36233f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/cb36233ff6fb3b1dda31501f6912436e83c2dbe9 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1 Backport-of: e21d06f488bce227eedc4c92d976301a7b54fda8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3703 From roland at openjdk.org Mon Jul 7 08:06:45 2025 From: roland at openjdk.org (Roland Westrelin) Date: Mon, 7 Jul 2025 08:06:45 GMT Subject: [jdk21u-dev] RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe In-Reply-To: References: Message-ID: On Tue, 1 Jul 2025 17:20:57 GMT, Aleksey Shipilev wrote: >> Patch doesn't apply cleanly: >> >> - jdk21u still has IU barriers: context for some of the changes is >> different. >> >> - Because of IU barriers, there's an extra call to `fix_ctrl()` for >> which the renaming to `nodes_above_barriers` must be applied. >> >> - The initial patch makes a subtle change that doesn't affect jdk >> 25/26 in the code that was >> refactored. `ShenandoahBarrierC2Support::push_data_inputs_at_control()` >> is introduced with logic: >> >> if (in != nullptr && phase->has_ctrl(in) && phase->get_ctrl(in) == ctrl) { >> >> >> which replaces the same logic in >> `ShenandoahBarrierC2Support::fix_ctrl()` but also a slightly >> different logic in >> `ShenandoahBarrierC2Support::is_dominator_same_ctrl()`: >> >> >> if (m->in(i) != nullptr && phase->ctrl_or_self(m->in(i)) == c) { >> >> >> that is, it uses `ctrl_or_self()` which works for both data nodes >> and control nodes but the new method uses `has_ctrl(in) && >> get_ctrl(in)` which can only be true for data nodes. That change >> causes failures in jdk 21 again because of IU barriers that produce >> a new memory state when expanded and need the logic from >> `MemoryGraphFixer`. What I propose in this backport to be on the >> safe side is to leave >> `ShenandoahBarrierC2Support::is_dominator_same_ctrl()` alone (not >> apply that part of the refactoring). >> >> Tested with hotspot_gc_shenandoah + tier1 with -XX:+UseShenandoahGC > > Ah yes, apologies, it slipped off my radar. I'll take a look. Thanks for the review @shipilev I pushed a new commit with what you suggested. I think that works. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1901#issuecomment-3043892322 From roland at openjdk.org Mon Jul 7 08:06:45 2025 From: roland at openjdk.org (Roland Westrelin) Date: Mon, 7 Jul 2025 08:06:45 GMT Subject: [jdk21u-dev] RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe [v2] In-Reply-To: References: Message-ID: <728kJ3Vz5ynDyKOS73CEE9VbaCAphO5unv9UtA9qh0U=.486c38f0-6d7d-4795-a1ba-d0e2df5603e9@github.com> > Patch doesn't apply cleanly: > > - jdk21u still has IU barriers: context for some of the changes is > different. > > - Because of IU barriers, there's an extra call to `fix_ctrl()` for > which the renaming to `nodes_above_barriers` must be applied. > > - The initial patch makes a subtle change that doesn't affect jdk > 25/26 in the code that was > refactored. `ShenandoahBarrierC2Support::push_data_inputs_at_control()` > is introduced with logic: > > if (in != nullptr && phase->has_ctrl(in) && phase->get_ctrl(in) == ctrl) { > > > which replaces the same logic in > `ShenandoahBarrierC2Support::fix_ctrl()` but also a slightly > different logic in > `ShenandoahBarrierC2Support::is_dominator_same_ctrl()`: > > > if (m->in(i) != nullptr && phase->ctrl_or_self(m->in(i)) == c) { > > > that is, it uses `ctrl_or_self()` which works for both data nodes > and control nodes but the new method uses `has_ctrl(in) && > get_ctrl(in)` which can only be true for data nodes. That change > causes failures in jdk 21 again because of IU barriers that produce > a new memory state when expanded and need the logic from > `MemoryGraphFixer`. What I propose in this backport to be on the > safe side is to leave > `ShenandoahBarrierC2Support::is_dominator_same_ctrl()` alone (not > apply that part of the refactoring). > > Tested with hotspot_gc_shenandoah + tier1 with -XX:+UseShenandoahGC Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision: review ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1901/files - new: https://git.openjdk.org/jdk21u-dev/pull/1901/files/25cba14f..63c627cf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1901&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1901&range=00-01 Stats: 17 lines in 1 file changed: 0 ins; 13 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1901.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1901/head:pull/1901 PR: https://git.openjdk.org/jdk21u-dev/pull/1901 From shade at openjdk.org Mon Jul 7 08:09:47 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 7 Jul 2025 08:09:47 GMT Subject: [jdk21u-dev] RFR: 8358334: C2/Shenandoah: incorrect execution with Unsafe [v2] In-Reply-To: <728kJ3Vz5ynDyKOS73CEE9VbaCAphO5unv9UtA9qh0U=.486c38f0-6d7d-4795-a1ba-d0e2df5603e9@github.com> References: <728kJ3Vz5ynDyKOS73CEE9VbaCAphO5unv9UtA9qh0U=.486c38f0-6d7d-4795-a1ba-d0e2df5603e9@github.com> Message-ID: On Mon, 7 Jul 2025 08:06:45 GMT, Roland Westrelin wrote: >> Patch doesn't apply cleanly: >> >> - jdk21u still has IU barriers: context for some of the changes is >> different. >> >> - Because of IU barriers, there's an extra call to `fix_ctrl()` for >> which the renaming to `nodes_above_barriers` must be applied. >> >> - The initial patch makes a subtle change that doesn't affect jdk >> 25/26 in the code that was >> refactored. `ShenandoahBarrierC2Support::push_data_inputs_at_control()` >> is introduced with logic: >> >> if (in != nullptr && phase->has_ctrl(in) && phase->get_ctrl(in) == ctrl) { >> >> >> which replaces the same logic in >> `ShenandoahBarrierC2Support::fix_ctrl()` but also a slightly >> different logic in >> `ShenandoahBarrierC2Support::is_dominator_same_ctrl()`: >> >> >> if (m->in(i) != nullptr && phase->ctrl_or_self(m->in(i)) == c) { >> >> >> that is, it uses `ctrl_or_self()` which works for both data nodes >> and control nodes but the new method uses `has_ctrl(in) && >> get_ctrl(in)` which can only be true for data nodes. That change >> causes failures in jdk 21 again because of IU barriers that produce >> a new memory state when expanded and need the logic from >> `MemoryGraphFixer`. What I propose in this backport to be on the >> safe side is to leave >> `ShenandoahBarrierC2Support::is_dominator_same_ctrl()` alone (not >> apply that part of the refactoring). >> >> Tested with hotspot_gc_shenandoah + tier1 with -XX:+UseShenandoahGC > > Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision: > > review Looks good to me, thank you! ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1901#pullrequestreview-2992671111 From sgehwolf at openjdk.org Mon Jul 7 10:32:47 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 7 Jul 2025 10:32:47 GMT Subject: [jdk17u-dev] RFR: 8351500: G1: NUMA migrations cause crashes in region allocation In-Reply-To: References: Message-ID: On Thu, 22 May 2025 13:16:06 GMT, Thomas Stuefe wrote: > This is not a clean backport. The effected G1Allocator and G1Collector methods have changed since JDK17. > > So this backports reimplements the patch in a minimally invasive way while retaining as much similarity as possible with the original patch. > > The gist of the patch is clear: instead of finding out the NUMA node index at every instance of G1Allocator::allocate_xxx, and then be subject to NUMA node migrations, we fix the NUMA node index once and use that one. > > I tested this patch with my "FakeNUMA" addition (I plan to upstream that one at some point). This FakeNUMA mode mimics a lot of NUMA node migrations. I can verify that without this patch the JVM crashes quickly, with the patch it does not crash. I'm not really an expert in GC code. Somebody else needs to review this. @adinn might be able to help, perhaps? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3607#issuecomment-3044373096 From goetz at openjdk.org Mon Jul 7 10:33:27 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 10:33:27 GMT Subject: [jdk17u-dev] RFR: 8225777: java/awt/Mixing/MixingOnDialog.java fails on Ubuntu Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 36f2e5240b8c4d94643188d3a9d87d906c1e8bdf Changes: https://git.openjdk.org/jdk17u-dev/pull/3707/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3707&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8225777 Stats: 177 lines in 2 files changed: 7 ins; 141 del; 29 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3707.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3707/head:pull/3707 PR: https://git.openjdk.org/jdk17u-dev/pull/3707 From goetz at openjdk.org Mon Jul 7 10:35:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 10:35:20 GMT Subject: [jdk17u-dev] RFR: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 013aff87ce7ece5cd4676aa452557ea3f222cede Changes: https://git.openjdk.org/jdk17u-dev/pull/3708/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3708&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326606 Stats: 135 lines in 1 file changed: 135 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3708.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3708/head:pull/3708 PR: https://git.openjdk.org/jdk17u-dev/pull/3708 From goetz at openjdk.org Mon Jul 7 10:35:31 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 10:35:31 GMT Subject: [jdk21u-dev] RFR: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class Message-ID: I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport 013aff87ce7ece5cd4676aa452557ea3f222cede Changes: https://git.openjdk.org/jdk21u-dev/pull/1939/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1939&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326606 Stats: 135 lines in 1 file changed: 135 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1939.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1939/head:pull/1939 PR: https://git.openjdk.org/jdk21u-dev/pull/1939 From goetz at openjdk.org Mon Jul 7 10:41:23 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 10:41:23 GMT Subject: [jdk21u-dev] RFR: 8330535: Update nsk/jdb tests to use driver instead of othervm Message-ID: I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport 4417c276e484c1fe137ed7f4a7c28709d0c99af2 Changes: https://git.openjdk.org/jdk21u-dev/pull/1940/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1940&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330535 Stats: 483 lines in 69 files changed: 6 ins; 273 del; 204 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1940.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1940/head:pull/1940 PR: https://git.openjdk.org/jdk21u-dev/pull/1940 From sgehwolf at openjdk.org Mon Jul 7 10:43:41 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 7 Jul 2025 10:43:41 GMT Subject: [jdk21u-dev] RFR: 8333446: Add tests for hierarchical container support In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 16:00:30 GMT, Severin Gehwolf wrote: > Please review this test-only backport. Now that https://bugs.openjdk.org/browse/JDK-8322420 is in jdk21u-dev it makes sense to automatically test this functionality. The patch is clean except for the changes in `VMProps.java` which I've added manually. > > The only non-test tree change is to `whitebox.cpp`. > > Testing: > - [x] GHA > - [x] container tests on Linux x86 with cgroups v2 and cgroups v1 (including new systemd ones) > > Thoughts? > > Note: I'll follow up with [JDK-8340092](https://bugs.openjdk.org/browse/JDK-8340092) once this is in. @MBaesken You helped review this in mainline, could you help out with a review here? It's a test-only change. Thank you! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1938#issuecomment-3044416795 From sgehwolf at openjdk.org Mon Jul 7 10:44:54 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 7 Jul 2025 10:44:54 GMT Subject: [jdk21u-dev] RFR: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems Message-ID: Clean backport based on #1938 which fixes a test issue observed in mainline when JDK-8333446 got integrated. Test-only change. ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/1938 Commit messages: - Backport 64275e6bbf1377c9a9d77fe3c3ed8d4143138f11 Changes: https://git.openjdk.org/jdk21u-dev/pull/1941/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1941&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340092 Stats: 49 lines in 2 files changed: 30 ins; 4 del; 15 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1941.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1941/head:pull/1941 PR: https://git.openjdk.org/jdk21u-dev/pull/1941 From goetz at openjdk.org Mon Jul 7 11:02:55 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 11:02:55 GMT Subject: [jdk17u-dev] RFR: 8330535: Update nsk/jdb tests to use driver instead of othervm Message-ID: I backport this for parity with 17.0.17-oracle. Three adapted tests are not in 17. Others don't apply clean because mostly the copyright was changed in 21. Only JdbTest needed a trivial resolve of code. test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java Resolved Copyright. 21 has several virtual thread changes. test/hotspot/jtreg/vmTestbase/nsk/jdb/list/list003/list003.java Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped. test/hotspot/jtreg/vmTestbase/nsk/jdb/monitor/monitor001/monitor001.java Resolved Copyright. 21 has a virtual thread change. test/hotspot/jtreg/vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped. test/hotspot/jtreg/vmTestbase/nsk/jdb/resume/resume002/resume002.java Resolved Copyright because "8284191: Replace usages of 'a the' in hotspot and java.base" is not in 17. test/hotspot/jtreg/vmTestbase/nsk/jdb/threadgroup/threadgroup002/threadgroup002.java Resolved Copyright because new feature "8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default" was added in 19. test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads002/threads002.java Resolved Copyright because 21 has virtual thread changes. test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads003/threads003.java Was added by virtual threads change. Skipped. test/hotspot/jtreg/vmTestbase/nsk/jdb/trace/trace001/trace001.java Resolved Copyright because 21 has virtual thread changes. test/hotspot/jtreg/vmTestbase/nsk/jdb/unmonitor/unmonitor001/unmonitor001.java Resolved Copyright because 21 has virtual thread changes. test/hotspot/jtreg/vmTestbase/nsk/share/jdb/JdbTest.java Resolved one chunk due to context because 21 has changes as "8332641: Update nsk.share.jpda.Jdb to don't use finalization" ------------- Commit messages: - Backport 4417c276e484c1fe137ed7f4a7c28709d0c99af2 Changes: https://git.openjdk.org/jdk17u-dev/pull/3709/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3709&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330535 Stats: 460 lines in 66 files changed: 5 ins; 260 del; 195 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3709.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3709/head:pull/3709 PR: https://git.openjdk.org/jdk17u-dev/pull/3709 From goetz at openjdk.org Mon Jul 7 11:39:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 11:39:59 GMT Subject: [jdk17u-dev] RFR: 8330535: Update nsk/jdb tests to use driver instead of othervm [v2] In-Reply-To: References: Message-ID: <2983QDdyUfbF0RsebAK0rmRmUsLPhE69YY7uKeEV-KU=.1bf8b210-4e21-4ea9-b732-1db0b1a793a9@github.com> > I backport this for parity with 17.0.17-oracle. > > Three adapted tests are not in 17. > Others don't apply clean because mostly the copyright was changed > in 21. Only JdbTest needed a trivial resolve of code. > > > test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java > Resolved Copyright. 21 has several virtual thread changes. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/list/list003/list003.java > Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/monitor/monitor001/monitor001.java > Resolved Copyright. 21 has a virtual thread change. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java > Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/resume/resume002/resume002.java > Resolved Copyright because "8284191: Replace usages of 'a the' in hotspot and java.base" is not in 17. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/threadgroup/threadgroup002/threadgroup002.java > Resolved Copyright because new feature "8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default" was added in 19. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads002/threads002.java > Resolved Copyright because 21 has virtual thread changes. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads003/threads003.java > Was added by virtual threads change. Skipped. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/trace/trace001/trace001.java > Resolved Copyright because 21 has virtual thread changes. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/unmonitor/unmonitor001/unmonitor001.java > Resolved Copyright because 21 has virtual thread changes. > > test/hotspot/jtreg/vmTestbase/nsk/share/jdb/JdbTest.java > Resolved one chunk due to context because 21 has changes as "8332641: Update nsk.share.jpda.Jdb to don't use finalization" Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 4417c276e484c1fe137ed7f4a7c28709d0c99af2 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3709/files - new: https://git.openjdk.org/jdk17u-dev/pull/3709/files/c5d07fe0..89bba5ae Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3709&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3709&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3709.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3709/head:pull/3709 PR: https://git.openjdk.org/jdk17u-dev/pull/3709 From mbaesken at openjdk.org Mon Jul 7 11:43:43 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 7 Jul 2025 11:43:43 GMT Subject: [jdk21u-dev] RFR: 8333446: Add tests for hierarchical container support In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 16:00:30 GMT, Severin Gehwolf wrote: > Please review this test-only backport. Now that https://bugs.openjdk.org/browse/JDK-8322420 is in jdk21u-dev it makes sense to automatically test this functionality. The patch is clean except for the changes in `VMProps.java` which I've added manually. > > The only non-test tree change is to `whitebox.cpp`. > > Testing: > - [x] GHA > - [x] container tests on Linux x86 with cgroups v2 and cgroups v1 (including new systemd ones) > > Thoughts? > > Note: I'll follow up with [JDK-8340092](https://bugs.openjdk.org/browse/JDK-8340092) once this is in. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1938#pullrequestreview-2993431100 From goetz at openjdk.org Mon Jul 7 12:22:22 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 12:22:22 GMT Subject: [jdk17u-dev] RFR: 8339834: Replace usages of -mx and -ms in some tests Message-ID: <2r8d1hZvzR2BCj-59-k7pBFZ7iIqp7qCSYxQnt0UfWw=.75fe4216-ee5d-4242-a48e-15897f95cea2@github.com> I backport this to clean up the 17 testing and make later backports clean. ------------- Commit messages: - Backport 1d392492311daceeae12769cb9494eae63289853 Changes: https://git.openjdk.org/jdk17u-dev/pull/3710/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3710&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339834 Stats: 22 lines in 9 files changed: 0 ins; 5 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3710.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3710/head:pull/3710 PR: https://git.openjdk.org/jdk17u-dev/pull/3710 From sgehwolf at openjdk.org Mon Jul 7 12:28:43 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 7 Jul 2025 12:28:43 GMT Subject: [jdk21u-dev] RFR: 8333446: Add tests for hierarchical container support In-Reply-To: References: Message-ID: <_H2AjLEvUnElcM8bi7eczrrGwPK2jrgKcIQsmyUdaOA=.9db91563-dff5-45c2-9aa0-747000b039cc@github.com> On Fri, 4 Jul 2025 16:00:30 GMT, Severin Gehwolf wrote: > Please review this test-only backport. Now that https://bugs.openjdk.org/browse/JDK-8322420 is in jdk21u-dev it makes sense to automatically test this functionality. The patch is clean except for the changes in `VMProps.java` which I've added manually. > > The only non-test tree change is to `whitebox.cpp`. > > Testing: > - [x] GHA > - [x] container tests on Linux x86 with cgroups v2 and cgroups v1 (including new systemd ones) > > Thoughts? > > Note: I'll follow up with [JDK-8340092](https://bugs.openjdk.org/browse/JDK-8340092) once this is in. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1938#issuecomment-3044837573 From sgehwolf at openjdk.org Mon Jul 7 12:41:39 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 7 Jul 2025 12:41:39 GMT Subject: [jdk21u-dev] RFR: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 10:39:37 GMT, Severin Gehwolf wrote: > Clean backport based on #1938 which fixes a test issue observed in mainline when JDK-8333446 got integrated. Test-only change. GHA test failure of [java/util/concurrent/ExecutorService/CloseTest](https://github.com/jerboaa/jdk21u-dev/actions/runs/16114648069#user-content-java_util_concurrent_executorservice_closetest) seems unrelated to this patch. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1941#issuecomment-3044893143 From goetz at openjdk.org Mon Jul 7 12:43:55 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 12:43:55 GMT Subject: [jdk21u-dev] RFR: 8347381: Upgrade jQuery UI to version 1.14.1 Message-ID: I backport this for parity with 21.0.9-oracle. Changed location because of "8310118: Resource files should be moved to appropriate directories". Clean besides that. ------------- Commit messages: - Backport 56c780078f84a2571b779d90f528d5bcab2a9dfd Changes: https://git.openjdk.org/jdk21u-dev/pull/1942/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1942&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347381 Stats: 135 lines in 5 files changed: 3 ins; 70 del; 62 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1942.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1942/head:pull/1942 PR: https://git.openjdk.org/jdk21u-dev/pull/1942 From goetz at openjdk.org Mon Jul 7 12:44:55 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 12:44:55 GMT Subject: [jdk17u-dev] RFR: 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 88fa3b2fe9bccf9cd4a4041732e2f6d425c19244 Changes: https://git.openjdk.org/jdk17u-dev/pull/3712/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3712&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346998 Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3712.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3712/head:pull/3712 PR: https://git.openjdk.org/jdk17u-dev/pull/3712 From goetz at openjdk.org Mon Jul 7 12:45:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 12:45:54 GMT Subject: [jdk17u-dev] RFR: 8347381: Upgrade jQuery UI to version 1.14.1 Message-ID: I backport this for parity with 17.0.17-oracle. Clean backport from 21. ------------- Commit messages: - backport 56c780078f84a2571b779d90f528d5bcab2a9dfd Changes: https://git.openjdk.org/jdk17u-dev/pull/3711/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3711&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347381 Stats: 135 lines in 5 files changed: 3 ins; 70 del; 62 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3711.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3711/head:pull/3711 PR: https://git.openjdk.org/jdk17u-dev/pull/3711 From goetz at openjdk.org Mon Jul 7 12:46:22 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 12:46:22 GMT Subject: [jdk21u-dev] RFR: 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport 88fa3b2fe9bccf9cd4a4041732e2f6d425c19244 Changes: https://git.openjdk.org/jdk21u-dev/pull/1943/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1943&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346998 Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1943.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1943/head:pull/1943 PR: https://git.openjdk.org/jdk21u-dev/pull/1943 From syan at openjdk.org Mon Jul 7 12:47:47 2025 From: syan at openjdk.org (SendaoYan) Date: Mon, 7 Jul 2025 12:47:47 GMT Subject: [jdk24u] RFR: 8354255: [jittester] Remove TempDir debug output In-Reply-To: References: Message-ID: On Fri, 9 May 2025 10:33:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [1fc1cc5d](https://github.com/openjdk/jdk/commit/1fc1cc5da9a38cf936636a72f9b8a4c246ceaab4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Evgeny Nikitin on 11 Apr 2025 and was reviewed by Christian Hagedorn and Tobias Hartmann. > > Thanks! I think jdk24u do not need backported anymore. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/218#issuecomment-3044912328 From syan at openjdk.org Mon Jul 7 12:47:47 2025 From: syan at openjdk.org (SendaoYan) Date: Mon, 7 Jul 2025 12:47:47 GMT Subject: [jdk24u] Withdrawn: 8354255: [jittester] Remove TempDir debug output In-Reply-To: References: Message-ID: On Fri, 9 May 2025 10:33:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [1fc1cc5d](https://github.com/openjdk/jdk/commit/1fc1cc5da9a38cf936636a72f9b8a4c246ceaab4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Evgeny Nikitin on 11 Apr 2025 and was reviewed by Christian Hagedorn and Tobias Hartmann. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk24u/pull/218 From aivanov at openjdk.org Mon Jul 7 12:50:38 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Mon, 7 Jul 2025 12:50:38 GMT Subject: [jdk25u] RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar In-Reply-To: References: Message-ID: <1p4YjBc6zFochMG05leP7jBEZ46qwzj-_zjqksGWp2M=.ee059402-658f-4e64-872b-ccf524c4a901@github.com> On Fri, 4 Jul 2025 09:33:43 GMT, Manukumar V S wrote: > This is the backport of a test stabilisation fix done by @manukumarvs and approved by @aivanov-jdk. > > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar. This may open some other UI item and may interfere further testing on that machine. > > Fix: > Move the test UI to the centre of the screen by calling frame.setLocationRelativeTo(null). This PR isn't necessary because you're integrating this same fix into 25 GA by https://github.com/openjdk/jdk/pull/24845 All the fixes that are available in `jdk25` branch will be automatically synced to `jdk25u` repo. **Do not integrate this PR!** ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/12#issuecomment-3044930263 From mvs at openjdk.org Mon Jul 7 12:58:46 2025 From: mvs at openjdk.org (Manukumar V S) Date: Mon, 7 Jul 2025 12:58:46 GMT Subject: [jdk25u] Withdrawn: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 09:33:43 GMT, Manukumar V S wrote: > This is the backport of a test stabilisation fix done by @manukumarvs and approved by @aivanov-jdk. > > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar. This may open some other UI item and may interfere further testing on that machine. > > Fix: > Move the test UI to the centre of the screen by calling frame.setLocationRelativeTo(null). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk25u/pull/12 From mvs at openjdk.org Mon Jul 7 12:58:45 2025 From: mvs at openjdk.org (Manukumar V S) Date: Mon, 7 Jul 2025 12:58:45 GMT Subject: [jdk25u] RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar In-Reply-To: <1p4YjBc6zFochMG05leP7jBEZ46qwzj-_zjqksGWp2M=.ee059402-658f-4e64-872b-ccf524c4a901@github.com> References: <1p4YjBc6zFochMG05leP7jBEZ46qwzj-_zjqksGWp2M=.ee059402-658f-4e64-872b-ccf524c4a901@github.com> Message-ID: <9tFh20DVTTzDGv-Je8ZDKJjNCuOETEY2FwJijJZIuaY=.f3e537a9-4a5e-40f7-a5f3-0c62d3980553@github.com> On Mon, 7 Jul 2025 12:48:11 GMT, Alexey Ivanov wrote: >> This is the backport of a test stabilisation fix done by @manukumarvs and approved by @aivanov-jdk. >> >> Issue: >> In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar. This may open some other UI item and may interfere further testing on that machine. >> >> Fix: >> Move the test UI to the centre of the screen by calling frame.setLocationRelativeTo(null). > > This PR isn't necessary because you're integrating this same fix into 25 GA by https://github.com/openjdk/jdk/pull/24845 > > All the fixes that are available in `jdk25` branch will be automatically synced to `jdk25u` repo. > > **Do not integrate this PR!** Sure, thanks @aivanov-jdk , closing this PR. ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/12#issuecomment-3044958742 From goetz at openjdk.org Mon Jul 7 13:41:26 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 13:41:26 GMT Subject: [jdk21u-dev] RFR: 8348365: Bad format string in CLDRDisplayNamesTest Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport d9d2e19f923217a6831a8697c62ebeef0cc5d3b8 Changes: https://git.openjdk.org/jdk21u-dev/pull/1944/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1944&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348365 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1944.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1944/head:pull/1944 PR: https://git.openjdk.org/jdk21u-dev/pull/1944 From goetz at openjdk.org Mon Jul 7 14:06:24 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:06:24 GMT Subject: [jdk17u-dev] RFR: 8348365: Bad format string in CLDRDisplayNamesTest Message-ID: I backport this for parity with 17.0.17-oracle ------------- Commit messages: - Backport d9d2e19f923217a6831a8697c62ebeef0cc5d3b8 Changes: https://git.openjdk.org/jdk17u-dev/pull/3713/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3713&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348365 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3713.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3713/head:pull/3713 PR: https://git.openjdk.org/jdk17u-dev/pull/3713 From goetz at openjdk.org Mon Jul 7 14:15:15 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:15:15 GMT Subject: [jdk21u-dev] RFR: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary Message-ID: I backport this for parity with 21.0.9-oracle. Resolved copyright as 8345795: Update copyright year to 2024 for hotspot in files where it was missed is not in 21/17. Probably clean anyways. ------------- Commit messages: - Backport 9b49597244f898400222cfc252f50a2401ca3e2f Changes: https://git.openjdk.org/jdk21u-dev/pull/1945/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1945&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334320 Stats: 44 lines in 3 files changed: 0 ins; 38 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1945.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1945/head:pull/1945 PR: https://git.openjdk.org/jdk21u-dev/pull/1945 From goetz at openjdk.org Mon Jul 7 14:15:24 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:15:24 GMT Subject: [jdk17u-dev] RFR: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary Message-ID: I backport this for parity with 17.0.17-oracl Resolved copyright as 8345795: Update copyright year to 2024 for hotspot in files where it was missed is not in 21/17. Clean backport from 21, but probably clean anyways. ------------- Commit messages: - Backport 9b49597244f898400222cfc252f50a2401ca3e2f Changes: https://git.openjdk.org/jdk17u-dev/pull/3714/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3714&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334320 Stats: 44 lines in 3 files changed: 0 ins; 38 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3714.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3714/head:pull/3714 PR: https://git.openjdk.org/jdk17u-dev/pull/3714 From goetz at openjdk.org Mon Jul 7 14:20:04 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:20:04 GMT Subject: [jdk17u-dev] RFR: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.17-oracl > > Resolved copyright as 8345795: Update copyright year to 2024 for hotspot in files where it was missed is not in 21/17. > Clean backport from 21, but probably clean anyways. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 9b49597244f898400222cfc252f50a2401ca3e2f ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3714/files - new: https://git.openjdk.org/jdk17u-dev/pull/3714/files/7e72255e..a764f7b8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3714&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3714&range=00-01 Stats: 36 lines in 1 file changed: 36 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3714.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3714/head:pull/3714 PR: https://git.openjdk.org/jdk17u-dev/pull/3714 From goetz at openjdk.org Mon Jul 7 14:22:28 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:22:28 GMT Subject: [jdk21u-dev] RFR: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary [v2] In-Reply-To: References: Message-ID: <9F8Uz2SevPB5BRZIAbK74GbvF4ZE9GkMZldsGYo-7aw=.bd551700-01bb-4b01-baa8-711a3753427c@github.com> > I backport this for parity with 21.0.9-oracle. > > Resolved copyright as 8345795: Update copyright year to 2024 for hotspot in files where it was missed is not in 21/17. > > Probably clean anyways. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 9b49597244f898400222cfc252f50a2401ca3e2f ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1945/files - new: https://git.openjdk.org/jdk21u-dev/pull/1945/files/b550fe24..cd7ff649 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1945&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1945&range=00-01 Stats: 36 lines in 1 file changed: 36 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1945.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1945/head:pull/1945 PR: https://git.openjdk.org/jdk21u-dev/pull/1945 From sroy at openjdk.org Mon Jul 7 14:27:46 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 7 Jul 2025 14:27:46 GMT Subject: [jdk24u] Withdrawn: 8355498: [AIX] Adapt code for C++ VLA rule In-Reply-To: <4LY1jPCsxFhKFuraZFo2B1brxxGwMx1HDXmdpcwELPg=.9381c617-7d02-46c5-84f3-7251b9dc798c@github.com> References: <4LY1jPCsxFhKFuraZFo2B1brxxGwMx1HDXmdpcwELPg=.9381c617-7d02-46c5-84f3-7251b9dc798c@github.com> Message-ID: On Tue, 6 May 2025 15:57:04 GMT, Suchismith Roy wrote: > Hi all, > > This pull request contains a backport of commit [2447b981](https://github.com/openjdk/jdk/commit/2447b9812a9f7316a2313f70db4974534fceb9d9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 28 Apr 2025 and was reviewed by Joachim Kern and Martin Doerr. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk24u/pull/214 From goetz at openjdk.org Mon Jul 7 14:30:00 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:30:00 GMT Subject: [jdk17u-dev] RFR: 8325910: Rename jnihelper.h Message-ID: <9nV9YkVV41HxMvJFi1Qsh-czYrNUHeZhgGrA5RY17FA=.bc8a2d73-878a-40cc-8e90-8af79f1df0d6@github.com> I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 810daf820633e16e3ab058325c539695087486d5 Changes: https://git.openjdk.org/jdk17u-dev/pull/3715/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3715&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325910 Stats: 15 lines in 9 files changed: 0 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3715.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3715/head:pull/3715 PR: https://git.openjdk.org/jdk17u-dev/pull/3715 From goetz at openjdk.org Mon Jul 7 14:39:22 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:39:22 GMT Subject: [jdk21u-dev] RFR: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport fa0b18bfde38ee2ffbab33a9eaac547fe8aa3c7c Changes: https://git.openjdk.org/jdk21u-dev/pull/1946/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1946&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352509 Stats: 26 lines in 1 file changed: 23 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1946.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1946/head:pull/1946 PR: https://git.openjdk.org/jdk21u-dev/pull/1946 From goetz at openjdk.org Mon Jul 7 14:39:49 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:39:49 GMT Subject: [jdk17u-dev] RFR: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter Message-ID: <_9vlVLXfH9zWZevT9_paQdflWuwwF9R_X1meyn13JhY=.7108af70-4c14-493c-95f7-798548214e75@github.com> backport this for parity with 17.0.17-oracle, ------------- Commit messages: - Backport fa0b18bfde38ee2ffbab33a9eaac547fe8aa3c7c Changes: https://git.openjdk.org/jdk17u-dev/pull/3716/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3716&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352509 Stats: 26 lines in 1 file changed: 23 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3716.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3716/head:pull/3716 PR: https://git.openjdk.org/jdk17u-dev/pull/3716 From goetz at openjdk.org Mon Jul 7 14:48:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:48:20 GMT Subject: [jdk17u-dev] RFR: 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26 Changes: https://git.openjdk.org/jdk17u-dev/pull/3717/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3717&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352624 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3717.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3717/head:pull/3717 PR: https://git.openjdk.org/jdk17u-dev/pull/3717 From goetz at openjdk.org Mon Jul 7 14:49:18 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:49:18 GMT Subject: [jdk21u-dev] RFR: 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport 41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26 Changes: https://git.openjdk.org/jdk21u-dev/pull/1947/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1947&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352624 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1947.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1947/head:pull/1947 PR: https://git.openjdk.org/jdk21u-dev/pull/1947 From goetz at openjdk.org Mon Jul 7 14:49:55 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:49:55 GMT Subject: [jdk17u-dev] RFR: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport b7ca76ef4bfc640668492e655acc6d755411a92f Changes: https://git.openjdk.org/jdk17u-dev/pull/3718/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3718&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353235 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3718.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3718/head:pull/3718 PR: https://git.openjdk.org/jdk17u-dev/pull/3718 From goetz at openjdk.org Mon Jul 7 14:50:51 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:50:51 GMT Subject: [jdk21u-dev] RFR: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport b7ca76ef4bfc640668492e655acc6d755411a92f Changes: https://git.openjdk.org/jdk21u-dev/pull/1948/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1948&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353235 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1948.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1948/head:pull/1948 PR: https://git.openjdk.org/jdk21u-dev/pull/1948 From goetz at openjdk.org Mon Jul 7 14:55:45 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Jul 2025 14:55:45 GMT Subject: [jdk21u-dev] RFR: 8216437: PPC64: Add intrinsic for GHASH algorithm In-Reply-To: References: Message-ID: On Thu, 15 May 2025 15:30:00 GMT, Suchismith Roy wrote: >> Hi all, >> >> This pull request contains a backport of commit [cdad6d78](https://github.com/openjdk/jdk/commit/cdad6d788de4785c8dbf2710a86fdacb8d070565) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Suchismith Roy on 2 May 2025 and was reviewed by Martin Doerr and Amit Kumar. >> >> Thanks! > > Need to adapt code for jdk21 repo. Looking into it Hi @suchismith1993 please give a fix request comment that gives the necessary details. The change is definitely not needed for 21, probably a nice-to-have performance optimization. This has not been tested in any released JVM yet, do you really want to bring it to 21 now? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1789#issuecomment-3045509423 From sroy at openjdk.org Mon Jul 7 14:58:48 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 7 Jul 2025 14:58:48 GMT Subject: [jdk21u-dev] RFR: 8216437: PPC64: Add intrinsic for GHASH algorithm In-Reply-To: References: Message-ID: On Thu, 15 May 2025 15:30:00 GMT, Suchismith Roy wrote: >> Hi all, >> >> This pull request contains a backport of commit [cdad6d78](https://github.com/openjdk/jdk/commit/cdad6d788de4785c8dbf2710a86fdacb8d070565) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Suchismith Roy on 2 May 2025 and was reviewed by Martin Doerr and Amit Kumar. >> >> Thanks! > > Need to adapt code for jdk21 repo. Looking into it > Hi @suchismith1993 please give a fix request comment that gives the necessary details. The change is definitely not needed for 21, probably a nice-to-have performance optimization. > > This has not been tested in any released JVM yet, do you really want to bring it to 21 now? It has been tested on the headstream, but not sure which release it would be a part of. 21 is LTS and used by many customers, so the optimisation should be a good addition. @TheRealMDoerr Your thoughts ? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1789#issuecomment-3045521715 From mdoerr at openjdk.org Mon Jul 7 15:53:40 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 7 Jul 2025 15:53:40 GMT Subject: [jdk21u-dev] RFR: 8216437: PPC64: Add intrinsic for GHASH algorithm [v3] In-Reply-To: References: Message-ID: On Fri, 23 May 2025 14:07:36 GMT, Suchismith Roy wrote: >> Hi all, >> >> This pull request contains a backport of commit [cdad6d78](https://github.com/openjdk/jdk/commit/cdad6d788de4785c8dbf2710a86fdacb8d070565) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Suchismith Roy on 2 May 2025 and was reviewed by Martin Doerr and Amit Kumar. >> >> Thanks! > > Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: > > Update stubGenerator_ppc.cpp It will be released with JDK25 in September. The October Update of JDK21 should be ok for the backport. The tests should have covered it well enough. If we want some extra safety, postponing to January Update would be ok with me, too. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1789#issuecomment-3045689608 From duke at openjdk.org Mon Jul 7 16:21:45 2025 From: duke at openjdk.org (duke) Date: Mon, 7 Jul 2025 16:21:45 GMT Subject: [jdk25u] RFR: 8358577: Test serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java failed: unexpexcted monitor object In-Reply-To: References: Message-ID: On Thu, 26 Jun 2025 17:16:18 GMT, Ian Myers wrote: > Backports the test improvement added by JDK-8358577 in JDK tip (26). Applies cleanly. Affected test > passes. Risk is low: the change is test code only. @ianrichr Your change (at version 3be048ee0a9495f8201f974e84f6f7a7a62be15f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/7#issuecomment-3045783271 From imyers at openjdk.org Mon Jul 7 16:26:46 2025 From: imyers at openjdk.org (Ian Myers) Date: Mon, 7 Jul 2025 16:26:46 GMT Subject: [jdk25u] Integrated: 8358577: Test serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java failed: unexpexcted monitor object In-Reply-To: References: Message-ID: On Thu, 26 Jun 2025 17:16:18 GMT, Ian Myers wrote: > Backports the test improvement added by JDK-8358577 in JDK tip (26). Applies cleanly. Affected test > passes. Risk is low: the change is test code only. This pull request has now been integrated. Changeset: 829742bc Author: Ian Myers Committer: Paul Hohensee URL: https://git.openjdk.org/jdk25u/commit/829742bcb42e3971bedf1ed93dcb32aff58c5733 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod 8358577: Test serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java failed: unexpexcted monitor object Backport-of: 8f487d26c0f219d4df32be48ff1790e6f98d74a0 ------------- PR: https://git.openjdk.org/jdk25u/pull/7 From duke at openjdk.org Mon Jul 7 21:56:52 2025 From: duke at openjdk.org (Todd V. Jonker) Date: Mon, 7 Jul 2025 21:56:52 GMT Subject: [jdk17u-dev] RFR: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream In-Reply-To: References: Message-ID: <_Ehr3rGSr7iHljdt31lY2ekS0WmUnnbxyEs0ckqQP_U=.ae102df1-7756-436a-b6c4-fc89fa75d3ff@github.com> On Fri, 4 Jul 2025 10:36:08 GMT, Goetz Lindenmaier wrote: >> This is a clean backport of [d3f3011](https://github.com/openjdk/jdk/commit/d3f3011d56267360d65841da3550eca79cf1575b), originally authored by @archiecobbs and reviewed by @jaikiran >> >> The corresponding backport for JDK21 is https://github.com/openjdk/jdk21u-dev/pull/1897 >> >> Testing: >> - [x] New regression test fails without the fix, passes with it >> - [x] linux-x86_64-server-release: headless tiers 1-3 > > Hi @toddjonker > Have you tested anything besides the jtreg tests mentioned above? > This change modifies behaviour, this might have negative side effects, especially on the many working installations that receive this update. Oracle tried to backport, but they didn't deliver it. Usually, they have a good reason for this. > Do we need to rush this backport? I would rather defer it to the next (January) release to get experience with the change in 21. People can go to 21 or soon 25 if they have an issue. Hi @GoeLin, I've not tested further. My expectation was that the "bake time" sufficient to backport to 21 was sufficient for earlier releases. > People can go to 21 or soon 25 if they have an issue. In the environment I support, we cannot assume that JDK updates, _especially_ from older releases (like 11), are straightforward; in fact they can be quite costly. I'd personally rather prevent the inevitable-at-scale data loss than tell customers they have to update to avoid it. Anyway, it sounds like you'd prefer we hold off on this for a while, so I'll update our own issue tracking and then pull this back into draft status. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3667#issuecomment-3046618144 From duke at openjdk.org Tue Jul 8 00:06:45 2025 From: duke at openjdk.org (duke) Date: Tue, 8 Jul 2025 00:06:45 GMT Subject: [jdk17u-dev] Withdrawn: 8313804: JDWP support for -Djava.net.preferIPv6Addresses=system In-Reply-To: <_v2mRPv2Bc9atHF5B2Rd_PKlch7lRF7gnHyH1OZS6x0=.848f4c88-af57-42e1-9a7e-4f92398e4c2f@github.com> References: <_v2mRPv2Bc9atHF5B2Rd_PKlch7lRF7gnHyH1OZS6x0=.848f4c88-af57-42e1-9a7e-4f92398e4c2f@github.com> Message-ID: On Mon, 12 May 2025 22:15:32 GMT, Ilarion Nakonechnyy wrote: > Clean backport. Testing with tier1 in progress on alpine linux and mac os. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3567 From goetz at openjdk.org Tue Jul 8 06:54:38 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Jul 2025 06:54:38 GMT Subject: [jdk17u-dev] RFR: 8316580: HttpClient with StructuredTaskScope does not close when a task fails Message-ID: I backport this for parity with 17.0.17-oracle. The change applies clean, but the test does not work out-of-the-box. It calls some utility methods ReferenceTracker.java that were added by JDK-8305847. That change is not in the current list of backports, so I added the utility methods to this change. Further, the test depends on the fact that in 21 a row of classes implement AutoClosable, which they don't do in 21. I adapted a row of places to work around this. A try-with-resources statement was easy to replace, as the missing close() implementation uses public methods, so that I could copy the code to the test. In TestTaskScope I replaced close() by shutdownNow(). Finally I removed the "useReferenceTracker=false" test variant, as the HttpClient implementation is quite far off of the implementation in 21. ------------- Commit messages: - Adapt test to missing AutoClosable etc. - Parts of 8305847 - Backport d8291f593762ab270bf05643b87c57578d716242 Changes: https://git.openjdk.org/jdk17u-dev/pull/3706/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3706&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316580 Stats: 497 lines in 4 files changed: 473 ins; 10 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3706.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3706/head:pull/3706 PR: https://git.openjdk.org/jdk17u-dev/pull/3706 From goetz at openjdk.org Tue Jul 8 06:58:47 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Jul 2025 06:58:47 GMT Subject: [jdk21u-dev] RFR: 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 14:42:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. GHA failure: not build at all as ant download failed. [sh][ERROR] wget exited with exit code 4 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1947#issuecomment-3047606824 From goetz at openjdk.org Tue Jul 8 07:00:47 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Jul 2025 07:00:47 GMT Subject: [jdk17u-dev] RFR: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary [v2] In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 14:20:04 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.17-oracl >> >> Resolved copyright as 8345795: Update copyright year to 2024 for hotspot in files where it was missed is not in 21/17. >> Clean backport from 21, but probably clean anyways. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 9b49597244f898400222cfc252f50a2401ca3e2f GHA failure:: build did not complete, unrelated. The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3714#issuecomment-3047613374 From goetz at openjdk.org Tue Jul 8 07:41:55 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Jul 2025 07:41:55 GMT Subject: [jdk17u-dev] RFR: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream In-Reply-To: <_Ehr3rGSr7iHljdt31lY2ekS0WmUnnbxyEs0ckqQP_U=.ae102df1-7756-436a-b6c4-fc89fa75d3ff@github.com> References: <_Ehr3rGSr7iHljdt31lY2ekS0WmUnnbxyEs0ckqQP_U=.ae102df1-7756-436a-b6c4-fc89fa75d3ff@github.com> Message-ID: On Mon, 7 Jul 2025 21:53:51 GMT, Todd V. Jonker wrote: >> Hi @toddjonker >> Have you tested anything besides the jtreg tests mentioned above? >> This change modifies behaviour, this might have negative side effects, especially on the many working installations that receive this update. Oracle tried to backport, but they didn't deliver it. Usually, they have a good reason for this. >> Do we need to rush this backport? I would rather defer it to the next (January) release to get experience with the change in 21. People can go to 21 or soon 25 if they have an issue. > > Hi @GoeLin, I've not tested further. My expectation was that the "bake time" sufficient to backport to 21 was sufficient for earlier releases. > >> People can go to 21 or soon 25 if they have an issue. > > In the environment I support, we cannot assume that JDK updates, _especially_ from older releases (like 11), are straightforward; in fact they can be quite costly. I'd personally rather prevent the inevitable-at-scale data loss than tell customers they have to update to avoid it. > > Anyway, it sounds like you'd prefer we hold off on this for a while, so I'll update our own issue tracking and then pull this back into draft status. Hi @toddjonker I'm sorry, I'm really getting careful lately because we see too many regressions in every update and the rate of backports seems to go up instead of down. I'll label it defer-next and probably approve for the January update. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3667#issuecomment-3047734868 From mbaesken at openjdk.org Tue Jul 8 07:58:41 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 8 Jul 2025 07:58:41 GMT Subject: [jdk17u-dev] Integrated: 8353568: SEGV_BNDERR signal code adjust definition In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 11:37:06 GMT, Matthias Baesken wrote: > 8353568: SEGV_BNDERR signal code adjust definition This pull request has now been integrated. Changeset: 0877d64d Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/0877d64dd68f323ef5eb2f5b4bb0e5664e5f4a0a Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8353568: SEGV_BNDERR signal code adjust definition Backport-of: 6abf4e6d4d9f948b8ae51aec731b94ba7acd022e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3704 From goetz at openjdk.org Tue Jul 8 07:58:47 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Jul 2025 07:58:47 GMT Subject: [jdk17u-dev] Integrated: 8344137: Update XML Security for Java to 3.0.5 In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 13:15:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle from 21. > > Clean backport, but line endings clash for xmlsecurity_en.properties. > The file had windows line endings in 17, unix ones in 21. > I changed the file (on my linux system) to unix line endings. This pull request has now been integrated. Changeset: e7454faf Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e7454faf3ebbc663dd36fad057a5670b1fa27f47 Stats: 837 lines in 24 files changed: 600 ins; 12 del; 225 mod 8344137: Update XML Security for Java to 3.0.5 Reviewed-by: mbaesken Backport-of: 2d30662c5dff99c2fa06fc9e06426a9baabd2b57 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3705 From duke at openjdk.org Tue Jul 8 08:33:58 2025 From: duke at openjdk.org (Francesco Andreuzzi) Date: Tue, 8 Jul 2025 08:33:58 GMT Subject: [jdk11u-dev] RFR: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures Message-ID: Amends an inconsistency between declaration and definition of a member function in `classLoaderData.hpp`. This originally emerged as a compilation error in XLC for AIX. ------------- Commit messages: - Backport d35eda31e345142a26f7a5cf12e7606883f15224 Changes: https://git.openjdk.org/jdk11u-dev/pull/3058/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3058&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8211328 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3058.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3058/head:pull/3058 PR: https://git.openjdk.org/jdk11u-dev/pull/3058 From sgehwolf at openjdk.org Tue Jul 8 08:48:41 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 8 Jul 2025 08:48:41 GMT Subject: [jdk11u-dev] RFR: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 08:25:44 GMT, Francesco Andreuzzi wrote: > Amends an inconsistency between declaration and definition of a member function in `classLoaderData.hpp`. This originally emerged as a compilation error in XLC for AIX. @fandreuz Please enable GHA testing for your fork. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3058#issuecomment-3047945617 From duke at openjdk.org Tue Jul 8 08:52:30 2025 From: duke at openjdk.org (Francesco Andreuzzi) Date: Tue, 8 Jul 2025 08:52:30 GMT Subject: [jdk11u-dev] RFR: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures [v2] In-Reply-To: References: Message-ID: > Amends an inconsistency between declaration and definition of a member function in `classLoaderData.hpp`. This originally emerged as a compilation error in XLC for AIX. Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision: trigger ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/3058/files - new: https://git.openjdk.org/jdk11u-dev/pull/3058/files/e9e22662..b376d934 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3058&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3058&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3058.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3058/head:pull/3058 PR: https://git.openjdk.org/jdk11u-dev/pull/3058 From duke at openjdk.org Tue Jul 8 08:52:30 2025 From: duke at openjdk.org (Francesco Andreuzzi) Date: Tue, 8 Jul 2025 08:52:30 GMT Subject: [jdk11u-dev] RFR: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 08:46:08 GMT, Severin Gehwolf wrote: >> Amends an inconsistency between declaration and definition of a member function in `classLoaderData.hpp`. This originally emerged as a compilation error in XLC for AIX. > > @fandreuz Please enable GHA testing for your fork. Thanks! @jerboaa done, thanks ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3058#issuecomment-3047953500 From mdoerr at openjdk.org Tue Jul 8 09:21:45 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Jul 2025 09:21:45 GMT Subject: [jdk21u-dev] RFR: 8347381: Upgrade jQuery UI to version 1.14.1 In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 12:39:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. > > Changed location because of "8310118: Resource files should be moved to appropriate directories". > > Clean besides that. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1942#pullrequestreview-2996730267 From mdoerr at openjdk.org Tue Jul 8 09:34:43 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Jul 2025 09:34:43 GMT Subject: [jdk17u-dev] RFR: 8330535: Update nsk/jdb tests to use driver instead of othervm [v2] In-Reply-To: <2983QDdyUfbF0RsebAK0rmRmUsLPhE69YY7uKeEV-KU=.1bf8b210-4e21-4ea9-b732-1db0b1a793a9@github.com> References: <2983QDdyUfbF0RsebAK0rmRmUsLPhE69YY7uKeEV-KU=.1bf8b210-4e21-4ea9-b732-1db0b1a793a9@github.com> Message-ID: On Mon, 7 Jul 2025 11:39:59 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.17-oracle. >> >> Three adapted tests are not in 17. >> Others don't apply clean because mostly the copyright was changed >> in 21. Only JdbTest needed a trivial resolve of code. >> >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java >> Resolved Copyright. 21 has several virtual thread changes. >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/list/list003/list003.java >> Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped. >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/monitor/monitor001/monitor001.java >> Resolved Copyright. 21 has a virtual thread change. >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java >> Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped. >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/resume/resume002/resume002.java >> Resolved Copyright because "8284191: Replace usages of 'a the' in hotspot and java.base" is not in 17. >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/threadgroup/threadgroup002/threadgroup002.java >> Resolved Copyright because new feature "8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default" was added in 19. >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads002/threads002.java >> Resolved Copyright because 21 has virtual thread changes. >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads003/threads003.java >> Was added by virtual threads change. Skipped. >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/trace/trace001/trace001.java >> Resolved Copyright because 21 has virtual thread changes. >> >> test/hotspot/jtreg/vmTestbase/nsk/jdb/unmonitor/unmonitor001/unmonitor001.java >> Resolved Copyright because 21 has virtual thread changes. >> >> test/hotspot/jtreg/vmTestbase/nsk/share/jdb/JdbTest.java >> Resolved one chunk due to context because 21 has changes as "8332641: Update nsk.share.jpda.Jdb to don't use finalization" > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 4417c276e484c1fe137ed7f4a7c28709d0c99af2 Thanks for the detailed description! LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3709#pullrequestreview-2996781207 From sgehwolf at openjdk.org Tue Jul 8 09:43:57 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 8 Jul 2025 09:43:57 GMT Subject: [jdk21u-dev] Integrated: 8333446: Add tests for hierarchical container support In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 16:00:30 GMT, Severin Gehwolf wrote: > Please review this test-only backport. Now that https://bugs.openjdk.org/browse/JDK-8322420 is in jdk21u-dev it makes sense to automatically test this functionality. The patch is clean except for the changes in `VMProps.java` which I've added manually. > > The only non-test tree change is to `whitebox.cpp`. > > Testing: > - [x] GHA > - [x] container tests on Linux x86 with cgroups v2 and cgroups v1 (including new systemd ones) > > Thoughts? > > Note: I'll follow up with [JDK-8340092](https://bugs.openjdk.org/browse/JDK-8340092) once this is in. This pull request has now been integrated. Changeset: cf8cfec3 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/cf8cfec3f149cb6bb27d0d31bb1c6817feb266f6 Stats: 655 lines in 9 files changed: 648 ins; 0 del; 7 mod 8333446: Add tests for hierarchical container support Reviewed-by: mbaesken Backport-of: d9fdf69c34c20e0f2d526c2f04450acb904c3e80 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1938 From sgehwolf at openjdk.org Tue Jul 8 09:48:11 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 8 Jul 2025 09:48:11 GMT Subject: [jdk21u-dev] RFR: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems [v2] In-Reply-To: References: Message-ID: > Clean backport based on #1938 which fixes a test issue observed in mainline when JDK-8333446 got integrated. Test-only change. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1941/files - new: https://git.openjdk.org/jdk21u-dev/pull/1941/files/0a280207..0a280207 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1941&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1941&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1941.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1941/head:pull/1941 PR: https://git.openjdk.org/jdk21u-dev/pull/1941 From sgehwolf at openjdk.org Tue Jul 8 09:57:21 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 8 Jul 2025 09:57:21 GMT Subject: [jdk21u-dev] RFR: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems [v3] In-Reply-To: References: Message-ID: > Clean backport based on #1938 which fixes a test issue observed in mainline when JDK-8333446 got integrated. Test-only change. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into jdk-8340092-jdk21u-backport-follow-up - Backport 64275e6bbf1377c9a9d77fe3c3ed8d4143138f11 - Backport d9fdf69c34c20e0f2d526c2f04450acb904c3e80 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1941/files - new: https://git.openjdk.org/jdk21u-dev/pull/1941/files/0a280207..d46e66c8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1941&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1941&range=01-02 Stats: 649 lines in 27 files changed: 600 ins; 12 del; 37 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1941.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1941/head:pull/1941 PR: https://git.openjdk.org/jdk21u-dev/pull/1941 From sgehwolf at openjdk.org Tue Jul 8 10:07:52 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 8 Jul 2025 10:07:52 GMT Subject: [jdk11u-dev] RFR: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 08:48:43 GMT, Francesco Andreuzzi wrote: >> @fandreuz Please enable GHA testing for your fork. Thanks! > > @jerboaa done, thanks @fandreuz Your branch is based on an old checkout. Please merge lastest master since windows builds still complain about windows-server-2019 which is no longer used in JDK 11u GHA since https://bugs.openjdk.org/browse/JDK-8358538. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3058#issuecomment-3048218745 From duke at openjdk.org Tue Jul 8 10:14:24 2025 From: duke at openjdk.org (Francesco Andreuzzi) Date: Tue, 8 Jul 2025 10:14:24 GMT Subject: [jdk11u-dev] RFR: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures [v3] In-Reply-To: References: Message-ID: > Amends an inconsistency between declaration and definition of a member function in `classLoaderData.hpp`. This originally emerged as a compilation error in XLC for AIX. Francesco Andreuzzi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8211328 - trigger - Backport d35eda31e345142a26f7a5cf12e7606883f15224 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/3058/files - new: https://git.openjdk.org/jdk11u-dev/pull/3058/files/b376d934..2f1bcfc2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3058&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3058&range=01-02 Stats: 7053 lines in 107 files changed: 3514 ins; 2455 del; 1084 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3058.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3058/head:pull/3058 PR: https://git.openjdk.org/jdk11u-dev/pull/3058 From duke at openjdk.org Tue Jul 8 10:14:24 2025 From: duke at openjdk.org (Francesco Andreuzzi) Date: Tue, 8 Jul 2025 10:14:24 GMT Subject: [jdk11u-dev] RFR: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 10:04:46 GMT, Severin Gehwolf wrote: >> @jerboaa done, thanks > > @fandreuz Your branch is based on an old checkout. Please merge lastest master since windows builds still complain about windows-server-2019 which is no longer used in JDK 11u GHA since https://bugs.openjdk.org/browse/JDK-8358538. Thanks @jerboaa, I missed that. I merged the latest `master` into my branch, tests are re-running now ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3058#issuecomment-3048256102 From goetz at openjdk.org Tue Jul 8 10:57:27 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Jul 2025 10:57:27 GMT Subject: [jdk17u-dev] RFR: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/3706 Commit messages: - Backport 6273ab97dc1a0d3c1f51ba94694d9594dd7593d4 Changes: https://git.openjdk.org/jdk17u-dev/pull/3719/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3719&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317808 Stats: 29 lines in 4 files changed: 22 ins; 4 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3719.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3719/head:pull/3719 PR: https://git.openjdk.org/jdk17u-dev/pull/3719 From sgehwolf at openjdk.org Tue Jul 8 11:10:58 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 8 Jul 2025 11:10:58 GMT Subject: [jdk21u-dev] Integrated: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 10:39:37 GMT, Severin Gehwolf wrote: > Clean backport based on #1938 which fixes a test issue observed in mainline when JDK-8333446 got integrated. Test-only change. This pull request has now been integrated. Changeset: 829d6d99 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/829d6d99a3029c9bd65fd1cdb1552004c00277ba Stats: 49 lines in 2 files changed: 30 ins; 4 del; 15 mod 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems Backport-of: 64275e6bbf1377c9a9d77fe3c3ed8d4143138f11 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1941 From duke at openjdk.org Tue Jul 8 11:19:53 2025 From: duke at openjdk.org (duke) Date: Tue, 8 Jul 2025 11:19:53 GMT Subject: [jdk11u-dev] RFR: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures [v3] In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 10:14:24 GMT, Francesco Andreuzzi wrote: >> Amends an inconsistency between declaration and definition of a member function in `classLoaderData.hpp`. This originally emerged as a compilation error in XLC for AIX. > > Francesco Andreuzzi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8211328 > - trigger > - Backport d35eda31e345142a26f7a5cf12e7606883f15224 @fandreuz Your change (at version 2f1bcfc2f1cbc442ae8906e00bbd928aca6f33ab) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3058#issuecomment-3048483543 From duke at openjdk.org Tue Jul 8 12:03:53 2025 From: duke at openjdk.org (Francesco Andreuzzi) Date: Tue, 8 Jul 2025 12:03:53 GMT Subject: [jdk11u-dev] Integrated: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures In-Reply-To: References: Message-ID: <71qCU04I8e4UJlAGnw8tiajA2mXMfdTAKKNv3_h4tUE=.fd39914e-b5c3-4935-86d4-6e06790d4b38@github.com> On Tue, 8 Jul 2025 08:25:44 GMT, Francesco Andreuzzi wrote: > Amends an inconsistency between declaration and definition of a member function in `classLoaderData.hpp`. This originally emerged as a compilation error in XLC for AIX. This pull request has now been integrated. Changeset: 1468cfa9 Author: Francesco Andreuzzi Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/1468cfa950cb9252103b265fee91ad04fb316008 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures Backport-of: d35eda31e345142a26f7a5cf12e7606883f15224 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/3058 From tkurashige at openjdk.org Tue Jul 8 12:50:43 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Tue, 8 Jul 2025 12:50:43 GMT Subject: [jdk21u-dev] RFR: 8355249: Remove the use of WMIC from the entire source code In-Reply-To: References: Message-ID: On Mon, 23 Jun 2025 01:13:51 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code > > JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported. > > Original patch does not apply cleanly because JDK-8340311 is not backported to jdk21. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java. > > I confirmed that Win8301247Test.java passes on Windows Server 2022. Could anyone review this PR? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1912#issuecomment-3048814549 From jkratochvil at openjdk.org Tue Jul 8 12:55:35 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 8 Jul 2025 12:55:35 GMT Subject: [jdk24u] RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset Message-ID: <37jU4qNE5ntcGj8c1cq2xRsl5S3mn6EoCm6tFHUL-eg=.e746e3cd-7a88-4907-9dfd-ab837f7ca6b0@github.com> Multithreaded handling of ZIP files can throw an exception. This is a clean backport. ------------- Commit messages: - 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset Changes: https://git.openjdk.org/jdk24u/pull/236/files Webrev: https://webrevs.openjdk.org/?repo=jdk24u&pr=236&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347712 Stats: 380 lines in 4 files changed: 323 ins; 14 del; 43 mod Patch: https://git.openjdk.org/jdk24u/pull/236.diff Fetch: git fetch https://git.openjdk.org/jdk24u.git pull/236/head:pull/236 PR: https://git.openjdk.org/jdk24u/pull/236 From evergizova at openjdk.org Tue Jul 8 13:18:42 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Tue, 8 Jul 2025 13:18:42 GMT Subject: [jdk21u-dev] RFR: 8337506: Disable "best-fit" mapping on Windows command line In-Reply-To: References: Message-ID: On Thu, 27 Mar 2025 19:49:49 GMT, Martin Balao wrote: > Thanks for contributing this backport, @kvergizova . Looks good (clean) to me. Looks like the CSR has not been approved (yet) for 21u. We should get an approval before moving forward with this change. SCR https://bugs.openjdk.org/browse/JDK-8349538 is now approved, the fix is ??integrated into 21.0.9-oracle. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1438#issuecomment-3048929732 From jkratochvil at openjdk.org Tue Jul 8 13:22:47 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 8 Jul 2025 13:22:47 GMT Subject: [jdk21u-dev] RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset Message-ID: Multithreaded handling of ZIP files can throw an exception. This backport is far from clean. The last commit resolves the conflicts. The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is [a backward compatibility concern](https://bugs.openjdk.org/browse/JDK-8321156?focusedId=14630523&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14630523) I have not backported it. ------------- Commit messages: - resolve conflicts - 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset Changes: https://git.openjdk.org/jdk21u-dev/pull/1949/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1949&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347712 Stats: 388 lines in 4 files changed: 333 ins; 14 del; 41 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1949.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1949/head:pull/1949 PR: https://git.openjdk.org/jdk21u-dev/pull/1949 From syan at openjdk.org Tue Jul 8 13:24:50 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 8 Jul 2025 13:24:50 GMT Subject: [jdk24u] RFR: 8353545: Improve debug info for StartOptionTest In-Reply-To: References: Message-ID: On Tue, 15 Apr 2025 02:38:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [23eb648c](https://github.com/openjdk/jdk/commit/23eb648cae1ccadbca0fd654d4fbc28a1b8375e2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Lahoda on 2 Apr 2025 and was reviewed by Adam Sotona. > > Thanks! I think jdk24u do not need backported anymore. ------------- PR Comment: https://git.openjdk.org/jdk24u/pull/191#issuecomment-3048952942 From jkratochvil at openjdk.org Tue Jul 8 13:35:34 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 8 Jul 2025 13:35:34 GMT Subject: [jdk17u-dev] RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset Message-ID: Multithreaded handling of ZIP files can throw an exception. This backport is far from clean. The last commit resolves the conflicts. The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is [a backward compatibility concern](https://bugs.openjdk.org/browse/JDK-8321156?focusedId=14630523&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14630523) I have not backported it. ------------- Commit messages: - resolve conflicts - 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset Changes: https://git.openjdk.org/jdk17u-dev/pull/3720/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3720&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347712 Stats: 385 lines in 4 files changed: 333 ins; 13 del; 39 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3720.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3720/head:pull/3720 PR: https://git.openjdk.org/jdk17u-dev/pull/3720 From liach at openjdk.org Tue Jul 8 14:11:41 2025 From: liach at openjdk.org (Chen Liang) Date: Tue, 8 Jul 2025 14:11:41 GMT Subject: [jdk21u-dev] RFR: 8343377: Performance regression in reflective invocation of native methods In-Reply-To: <8Mu4K-1HNfbKyMUC3sN-n3QZW96sLbDrackSXFcIEwg=.d678c231-e0f4-49d8-9e6a-ab42d100b9f4@github.com> References: <8Mu4K-1HNfbKyMUC3sN-n3QZW96sLbDrackSXFcIEwg=.d678c231-e0f4-49d8-9e6a-ab42d100b9f4@github.com> Message-ID: On Fri, 6 Dec 2024 16:45:39 GMT, Chen Liang wrote: > The reimplementation of core reflection with Method Handles blanket-forced all native methods to use the native accessor due to bootstrapping issues. However, these are already covered by a `VM.isJavaLangInvokeInited()` check, and this blanket enforcement causes performance regression in reflective invocation of native methods like `Object::hashCode` or `Thread::currentThread`. > > The patch is not clean due to the comment update to `useNativeAccessor` - it edits a previously added comment not in JDK 21. The code changes are all clean. @Voyinno I think we were looking at stabilizing that patch for longer back then. Anyone can open a new PR to backport this patch again if this is found necessary. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1207#issuecomment-3049128192 From duke at openjdk.org Tue Jul 8 14:21:50 2025 From: duke at openjdk.org (Ayman) Date: Tue, 8 Jul 2025 14:21:50 GMT Subject: [jdk21u-dev] RFR: 8343377: Performance regression in reflective invocation of native methods In-Reply-To: References: <8Mu4K-1HNfbKyMUC3sN-n3QZW96sLbDrackSXFcIEwg=.d678c231-e0f4-49d8-9e6a-ab42d100b9f4@github.com> Message-ID: <9vf8CmDDxGQZNSLEJTiFXEcDBslE24bQWnGswP_Fe2I=.70adb47a-f4c5-4194-87b9-41de7b33fc8e@github.com> On Fri, 6 Dec 2024 17:01:13 GMT, Chen Liang wrote: >> The reimplementation of core reflection with Method Handles blanket-forced all native methods to use the native accessor due to bootstrapping issues. However, these are already covered by a `VM.isJavaLangInvokeInited()` check, and this blanket enforcement causes performance regression in reflective invocation of native methods like `Object::hashCode` or `Thread::currentThread`. >> >> The patch is not clean due to the comment update to `useNativeAccessor` - it edits a previously added comment not in JDK 21. The code changes are all clean. > > Can anyone help run higher-tier tests besides those available from GHA? I will write an approval request after. Hello @liach, Is there a reason why this PR got closed? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1207#issuecomment-3049072502 From mbaesken at openjdk.org Tue Jul 8 15:15:46 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 8 Jul 2025 15:15:46 GMT Subject: [jdk25u] Integrated: 8357826: Avoid running some jtreg tests when asan is configured In-Reply-To: <0L_ugIfXZK9MouycaR1FI0bGdnsEqObNd9magxeGCqQ=.4d6fd3e7-6de9-45ef-a62d-480e6104a961@github.com> References: <0L_ugIfXZK9MouycaR1FI0bGdnsEqObNd9magxeGCqQ=.4d6fd3e7-6de9-45ef-a62d-480e6104a961@github.com> Message-ID: On Mon, 30 Jun 2025 08:00:40 GMT, Matthias Baesken wrote: > 8357826: Avoid running some jtreg tests when asan is configured This pull request has now been integrated. Changeset: 5500a2d1 Author: Matthias Baesken URL: https://git.openjdk.org/jdk25u/commit/5500a2d134136e80098bb6180ffb6091934e52c7 Stats: 64 lines in 12 files changed: 62 ins; 0 del; 2 mod 8357826: Avoid running some jtreg tests when asan is configured Backport-of: d7aa34982053bad37b3b726539f1245d054258f4 ------------- PR: https://git.openjdk.org/jdk25u/pull/9 From duke at openjdk.org Tue Jul 8 15:25:46 2025 From: duke at openjdk.org (duke) Date: Tue, 8 Jul 2025 15:25:46 GMT Subject: [jdk17u-dev] RFR: 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes In-Reply-To: References: Message-ID: <5xDfs5MZwgzsgAJY4m3zNF66mlbDB4af7Y6WhH_wQ5c=.b629ce7e-d53c-4c24-8b5b-1f080fc8766d@github.com> On Wed, 2 Jul 2025 18:01:51 GMT, Daniel Huang wrote: > Backport for RandomSupport issue. There is a loss of information when using `convertSeedBytesToLongs()` with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result. > > Note there is an exact same issue/bugfix with `convertSeedBytesToInts()`, but I will backport that bugfix separately > > Clean backport, ran GHA sanity checks and locally tested tier1, tier2. In tier2, there were 2 failures: > `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` > `test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java` > However, these both failed before the backport as well. > > The backport also includes the test for this issue `T8282144.java`, which passes. @dtmhuang Your change (at version 664cef110a3aa48fa9441487e68f3a94d22316bd) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3698#issuecomment-3049392057 From duke at openjdk.org Tue Jul 8 15:32:59 2025 From: duke at openjdk.org (Francesco Andreuzzi) Date: Tue, 8 Jul 2025 15:32:59 GMT Subject: [jdk11u-dev] RFR: 8214972: Uses of klass_holder() except GC need to apply GC barriers Message-ID: I've been working on a backport to fix [JDK-8339725](https://bugs.openjdk.org/browse/JDK-8339725) on jdk11. The fix mentioned in the ticket is not enough to fix the problem on jdk11. The missing backport is JDK-8214972, which I apply in this PR. JDK-8210321 is also needed to provide `ClassLoaderData::holder_no_keepalive`. Tier1 tests completed successfully. ------------- Commit messages: - 8214972: Uses of klass_holder() except GC need to apply GC barriers - Backport c8be22851361edfd5bc172f25d07058bbf615478 Changes: https://git.openjdk.org/jdk11u-dev/pull/3059/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3059&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8214972 Stats: 40 lines in 11 files changed: 15 ins; 16 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3059.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3059/head:pull/3059 PR: https://git.openjdk.org/jdk11u-dev/pull/3059 From goetz at openjdk.org Tue Jul 8 15:40:00 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Jul 2025 15:40:00 GMT Subject: [jdk17u-dev] RFR: 8316580: HttpClient with StructuredTaskScope does not close when a task fails [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.17-oracle. > > The change applies clean, but the test does not work out-of-the-box. > > It calls some utility methods ReferenceTracker.java that were added by JDK-8305847. > That change is not in the current list of backports, so I added the utility methods > to this change. > > Further, the test depends on the fact that in 21 a row of classes implement > AutoClosable, which they don't do in 21. > I adapted a row of places to work around this. > A try-with-resources statement was easy to replace, as the missing > close() implementation uses public methods, so that I could copy the > code to the test. > In TestTaskScope I replaced close() by shutdownNow(). > Finally I removed the "useReferenceTracker=false" test variant, as the > HttpClient implementation is quite far off of the implementation in 21. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: more graceful close() implementation ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3706/files - new: https://git.openjdk.org/jdk17u-dev/pull/3706/files/1a29498b..622ef2fd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3706&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3706&range=00-01 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3706.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3706/head:pull/3706 PR: https://git.openjdk.org/jdk17u-dev/pull/3706 From duke at openjdk.org Tue Jul 8 15:58:52 2025 From: duke at openjdk.org (Daniel Huang) Date: Tue, 8 Jul 2025 15:58:52 GMT Subject: [jdk17u-dev] Integrated: 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 18:01:51 GMT, Daniel Huang wrote: > Backport for RandomSupport issue. There is a loss of information when using `convertSeedBytesToLongs()` with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result. > > Note there is an exact same issue/bugfix with `convertSeedBytesToInts()`, but I will backport that bugfix separately > > Clean backport, ran GHA sanity checks and locally tested tier1, tier2. In tier2, there were 2 failures: > `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` > `test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java` > However, these both failed before the backport as well. > > The backport also includes the test for this issue `T8282144.java`, which passes. This pull request has now been integrated. Changeset: 8b306de4 Author: Daniel Huang Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/8b306de46d88219722a57f6e72d0b4456eb6faf0 Stats: 72 lines in 2 files changed: 71 ins; 0 del; 1 mod 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes Backport-of: 5fab27e1b8fdf2ea27cb3b349bd339a4a6ec828b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3698 From duke at openjdk.org Tue Jul 8 16:46:06 2025 From: duke at openjdk.org (Rui Li) Date: Tue, 8 Jul 2025 16:46:06 GMT Subject: [jdk21u-dev] RFR: 8309953: Strengthen and optimize oopDesc age methods Message-ID: https://bugs.openjdk.org/browse/JDK-8309953 A clean backport. An minor optimization for oopDesc age. tier 1 passed locally. The logic is simple - store the `mark()` value into a var so we don't read it twice. The original commit is in tip for almost 2 years. Low risk. ------------- Commit messages: - Backport 4a5475ce0492fc02019b0f89b50601c388c63e21 Changes: https://git.openjdk.org/jdk21u-dev/pull/1950/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1950&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309953 Stats: 10 lines in 1 file changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1950.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1950/head:pull/1950 PR: https://git.openjdk.org/jdk21u-dev/pull/1950 From mblaesing at openjdk.org Tue Jul 8 19:20:45 2025 From: mblaesing at openjdk.org (Matthias =?UTF-8?B?QmzDpHNpbmc=?=) Date: Tue, 8 Jul 2025 19:20:45 GMT Subject: [jdk21u-dev] RFR: 8353950: Clipboard interaction on Windows is unstable In-Reply-To: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> References: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> Message-ID: On Sun, 22 Jun 2025 11:32:19 GMT, Matthias Bl?sing wrote: > 8353950: Clipboard interaction on Windows is unstable Can I somehow help to get this into an JDK 21 update release? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1911#issuecomment-3050048394 From duke at openjdk.org Tue Jul 8 20:19:50 2025 From: duke at openjdk.org (Daniel Huang) Date: Tue, 8 Jul 2025 20:19:50 GMT Subject: [jdk17u-dev] RFR: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport Message-ID: Backport for RandomSupport issue. There is a loss of information when using `convertSeedBytesToInts()` with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result. Clean backport, ran GHA sanity checks and locally tested tier1, tier2. In tier2, there was 1 failure: `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` However, this fails on master as well. The backport also updates the test `T8282144.java` to test for ints as well, which passes. ------------- Commit messages: - Backport 5a9cd33632862aa2249794902d4168a7fe143054 Changes: https://git.openjdk.org/jdk17u-dev/pull/3722/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3722&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294509 Stats: 41 lines in 2 files changed: 39 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3722.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3722/head:pull/3722 PR: https://git.openjdk.org/jdk17u-dev/pull/3722 From goetz at openjdk.org Wed Jul 9 05:14:29 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:14:29 GMT Subject: [jdk17u-dev] RFR: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently Message-ID: I backport this as we see the test failing sporadically. Omitted ProblemList change, test is not on the list. ------------- Commit messages: - Backport c93b24d85289167639e9ec4b79bd85403687161b Changes: https://git.openjdk.org/jdk17u-dev/pull/3723/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3723&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8132785 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3723.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3723/head:pull/3723 PR: https://git.openjdk.org/jdk17u-dev/pull/3723 From goetz at openjdk.org Wed Jul 9 05:17:50 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:17:50 GMT Subject: [jdk21u-dev] Integrated: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 10:29:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle This pull request has now been integrated. Changeset: 5486e42b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/5486e42b0aea7df17cc53180769083c83b3f3642 Stats: 135 lines in 1 file changed: 135 ins; 0 del; 0 mod 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class Backport-of: 013aff87ce7ece5cd4676aa452557ea3f222cede ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1939 From goetz at openjdk.org Wed Jul 9 05:18:52 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:18:52 GMT Subject: [jdk21u-dev] Integrated: 8330535: Update nsk/jdb tests to use driver instead of othervm In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 10:35:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle This pull request has now been integrated. Changeset: 88e8f69e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/88e8f69e49bf79af5bd0175fc37dfd40e5fa2237 Stats: 483 lines in 69 files changed: 6 ins; 273 del; 204 mod 8330535: Update nsk/jdb tests to use driver instead of othervm Backport-of: 4417c276e484c1fe137ed7f4a7c28709d0c99af2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1940 From goetz at openjdk.org Wed Jul 9 05:20:53 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:20:53 GMT Subject: [jdk17u-dev] Integrated: 8225777: java/awt/Mixing/MixingOnDialog.java fails on Ubuntu In-Reply-To: References: Message-ID: <4OmpxqeZ2SDG20526U-E3NjYgkvH98HcCfDGqmfhd0c=.b04dd9cc-334e-4154-8ccb-1d1aa7061ef8@github.com> On Mon, 7 Jul 2025 10:28:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: b56182ad Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b56182adc2effd9f927f394fe3030677765779c6 Stats: 177 lines in 2 files changed: 7 ins; 141 del; 29 mod 8225777: java/awt/Mixing/MixingOnDialog.java fails on Ubuntu Backport-of: 36f2e5240b8c4d94643188d3a9d87d906c1e8bdf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3707 From goetz at openjdk.org Wed Jul 9 05:20:53 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:20:53 GMT Subject: [jdk21u-dev] Integrated: 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 12:41:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. This pull request has now been integrated. Changeset: 1e423246 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1e423246cc2e9d629c9f1b33abfedaf95363d288 Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off Backport-of: 88fa3b2fe9bccf9cd4a4041732e2f6d425c19244 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1943 From goetz at openjdk.org Wed Jul 9 05:21:49 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:21:49 GMT Subject: [jdk17u-dev] Integrated: 8325910: Rename jnihelper.h In-Reply-To: <9nV9YkVV41HxMvJFi1Qsh-czYrNUHeZhgGrA5RY17FA=.bc8a2d73-878a-40cc-8e90-8af79f1df0d6@github.com> References: <9nV9YkVV41HxMvJFi1Qsh-czYrNUHeZhgGrA5RY17FA=.bc8a2d73-878a-40cc-8e90-8af79f1df0d6@github.com> Message-ID: On Mon, 7 Jul 2025 14:24:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: 976f317f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/976f317f234cdd5636d4cb8169d7fc98d022a5a6 Stats: 15 lines in 9 files changed: 0 ins; 0 del; 15 mod 8325910: Rename jnihelper.h Backport-of: 810daf820633e16e3ab058325c539695087486d5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3715 From goetz at openjdk.org Wed Jul 9 05:22:42 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:22:42 GMT Subject: [jdk21u-dev] Integrated: 8347381: Upgrade jQuery UI to version 1.14.1 In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 12:39:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. > > Changed location because of "8310118: Resource files should be moved to appropriate directories". > > Clean besides that. This pull request has now been integrated. Changeset: 64b73fbd Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/64b73fbd08c1086ceca26c5724cde8c090246b80 Stats: 135 lines in 5 files changed: 3 ins; 70 del; 62 mod 8347381: Upgrade jQuery UI to version 1.14.1 Reviewed-by: mdoerr Backport-of: 56c780078f84a2571b779d90f528d5bcab2a9dfd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1942 From goetz at openjdk.org Wed Jul 9 05:22:48 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:22:48 GMT Subject: [jdk17u-dev] Integrated: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 10:29:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: 08c1b9d6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/08c1b9d655f8f4b04ee99d0ccb216be0327bd901 Stats: 135 lines in 1 file changed: 135 ins; 0 del; 0 mod 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class Backport-of: 013aff87ce7ece5cd4676aa452557ea3f222cede ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3708 From goetz at openjdk.org Wed Jul 9 05:23:48 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:23:48 GMT Subject: [jdk17u-dev] Integrated: 8330535: Update nsk/jdb tests to use driver instead of othervm In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 10:58:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. > > Three adapted tests are not in 17. > Others don't apply clean because mostly the copyright was changed > in 21. Only JdbTest needed a trivial resolve of code. > > > test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java > Resolved Copyright. 21 has several virtual thread changes. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/list/list003/list003.java > Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/monitor/monitor001/monitor001.java > Resolved Copyright. 21 has a virtual thread change. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java > Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/resume/resume002/resume002.java > Resolved Copyright because "8284191: Replace usages of 'a the' in hotspot and java.base" is not in 17. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/threadgroup/threadgroup002/threadgroup002.java > Resolved Copyright because new feature "8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default" was added in 19. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads002/threads002.java > Resolved Copyright because 21 has virtual thread changes. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads003/threads003.java > Was added by virtual threads change. Skipped. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/trace/trace001/trace001.java > Resolved Copyright because 21 has virtual thread changes. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/unmonitor/unmonitor001/unmonitor001.java > Resolved Copyright because 21 has virtual thread changes. > > test/hotspot/jtreg/vmTestbase/nsk/share/jdb/JdbTest.java > Resolved one chunk due to context because 21 has changes as "8332641: Update nsk.share.jpda.Jdb to don't use finalization" This pull request has now been integrated. Changeset: 6cf00cc7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6cf00cc741cb55c9d8207bc1011cc45e4937e6ec Stats: 461 lines in 66 files changed: 5 ins; 261 del; 195 mod 8330535: Update nsk/jdb tests to use driver instead of othervm Reviewed-by: mdoerr Backport-of: 4417c276e484c1fe137ed7f4a7c28709d0c99af2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3709 From goetz at openjdk.org Wed Jul 9 05:24:40 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:24:40 GMT Subject: [jdk21u-dev] Integrated: 8348365: Bad format string in CLDRDisplayNamesTest In-Reply-To: References: Message-ID: <11LA82ezlmXRD7BzmGkVXyXjA-__mA7_2E0ypPqvlHY=.4611f71a-0658-4b6c-9d3e-d05eb895ee55@github.com> On Mon, 7 Jul 2025 13:35:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. This pull request has now been integrated. Changeset: 144e626e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/144e626ed3893c34eb87591c97ad53c601f01a9f Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8348365: Bad format string in CLDRDisplayNamesTest Backport-of: d9d2e19f923217a6831a8697c62ebeef0cc5d3b8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1944 From goetz at openjdk.org Wed Jul 9 05:25:47 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:25:47 GMT Subject: [jdk17u-dev] Integrated: 8339834: Replace usages of -mx and -ms in some tests In-Reply-To: <2r8d1hZvzR2BCj-59-k7pBFZ7iIqp7qCSYxQnt0UfWw=.75fe4216-ee5d-4242-a48e-15897f95cea2@github.com> References: <2r8d1hZvzR2BCj-59-k7pBFZ7iIqp7qCSYxQnt0UfWw=.75fe4216-ee5d-4242-a48e-15897f95cea2@github.com> Message-ID: On Mon, 7 Jul 2025 12:16:47 GMT, Goetz Lindenmaier wrote: > I backport this to clean up the 17 testing and make later backports clean. This pull request has now been integrated. Changeset: d542d473 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d542d473238b54a3f0185680218e1114d5a9f04e Stats: 22 lines in 9 files changed: 0 ins; 5 del; 17 mod 8339834: Replace usages of -mx and -ms in some tests Backport-of: 1d392492311daceeae12769cb9494eae63289853 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3710 From goetz at openjdk.org Wed Jul 9 05:26:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:26:54 GMT Subject: [jdk21u-dev] Integrated: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary In-Reply-To: References: Message-ID: <-FWYFnzPirI8iXJdkBYr7ykcjoFN3CB64z7a-kDypl4=.f44d4d76-cfdf-4f09-8a3e-e3b4aa9cef32@github.com> On Mon, 7 Jul 2025 14:09:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. > > Resolved copyright as 8345795: Update copyright year to 2024 for hotspot in files where it was missed is not in 21/17. > > Probably clean anyways. This pull request has now been integrated. Changeset: be9fc0b8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/be9fc0b8c8b840fde4a5e3ef37e18722f2d3dd37 Stats: 80 lines in 4 files changed: 36 ins; 38 del; 6 mod 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary Backport-of: 9b49597244f898400222cfc252f50a2401ca3e2f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1945 From goetz at openjdk.org Wed Jul 9 05:28:42 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:28:42 GMT Subject: [jdk17u-dev] Integrated: 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off In-Reply-To: References: Message-ID: <66X99Ur3c5z-dq-SuzhPPpzuT4nN5xprDTVOl61B0wo=.7ab2a351-6583-4573-b54e-c01377562770@github.com> On Mon, 7 Jul 2025 12:40:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: 7e1b9f5e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7e1b9f5e15ce31b3bc82eb38e0f373a04f328753 Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off Backport-of: 88fa3b2fe9bccf9cd4a4041732e2f6d425c19244 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3712 From goetz at openjdk.org Wed Jul 9 05:28:50 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:28:50 GMT Subject: [jdk21u-dev] Integrated: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 14:34:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. This pull request has now been integrated. Changeset: 636ceeed Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/636ceeed79db68137b749ca37e531f6fcb336b3c Stats: 26 lines in 1 file changed: 23 ins; 0 del; 3 mod 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter Backport-of: fa0b18bfde38ee2ffbab33a9eaac547fe8aa3c7c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1946 From goetz at openjdk.org Wed Jul 9 05:29:46 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:29:46 GMT Subject: [jdk21u-dev] Integrated: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 14:44:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. This pull request has now been integrated. Changeset: 352a6418 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/352a6418883b9528afdba4b9cc5588d3e1a2bee5 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException Backport-of: b7ca76ef4bfc640668492e655acc6d755411a92f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1948 From goetz at openjdk.org Wed Jul 9 05:30:43 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:30:43 GMT Subject: [jdk17u-dev] Integrated: 8348365: Bad format string in CLDRDisplayNamesTest In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 13:59:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle This pull request has now been integrated. Changeset: 1ec596a4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/1ec596a4ab461011b2ee25a5f38270296126b777 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8348365: Bad format string in CLDRDisplayNamesTest Backport-of: d9d2e19f923217a6831a8697c62ebeef0cc5d3b8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3713 From goetz at openjdk.org Wed Jul 9 05:33:25 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:33:25 GMT Subject: [jdk21u-dev] RFR: 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.9-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-GoeLin-41f3eea9-master - Backport 41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1947/files - new: https://git.openjdk.org/jdk21u-dev/pull/1947/files/539a56fe..b17528ba Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1947&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1947&range=00-01 Stats: 1549 lines in 93 files changed: 879 ins; 384 del; 286 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1947.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1947/head:pull/1947 PR: https://git.openjdk.org/jdk21u-dev/pull/1947 From goetz at openjdk.org Wed Jul 9 05:33:45 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:33:45 GMT Subject: [jdk17u-dev] Integrated: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 14:09:50 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracl > > Resolved copyright as 8345795: Update copyright year to 2024 for hotspot in files where it was missed is not in 21/17. > Clean backport from 21, but probably clean anyways. This pull request has now been integrated. Changeset: 8636073b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8636073b137980230b00b8a4a2c9a0afde40204a Stats: 80 lines in 4 files changed: 36 ins; 38 del; 6 mod 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary Backport-of: 9b49597244f898400222cfc252f50a2401ca3e2f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3714 From goetz at openjdk.org Wed Jul 9 05:38:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:38:41 GMT Subject: [jdk17u-dev] Integrated: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter In-Reply-To: <_9vlVLXfH9zWZevT9_paQdflWuwwF9R_X1meyn13JhY=.7108af70-4c14-493c-95f7-798548214e75@github.com> References: <_9vlVLXfH9zWZevT9_paQdflWuwwF9R_X1meyn13JhY=.7108af70-4c14-493c-95f7-798548214e75@github.com> Message-ID: On Mon, 7 Jul 2025 14:34:13 GMT, Goetz Lindenmaier wrote: > backport this for parity with 17.0.17-oracle, This pull request has now been integrated. Changeset: c8aee972 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c8aee9726533bbfa8d710762c4d622e3f5aaf40f Stats: 26 lines in 1 file changed: 23 ins; 0 del; 3 mod 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter Backport-of: fa0b18bfde38ee2ffbab33a9eaac547fe8aa3c7c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3716 From goetz at openjdk.org Wed Jul 9 05:40:40 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:40:40 GMT Subject: [jdk17u-dev] Integrated: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 14:44:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: b956b89b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b956b89b7a18ce990e397868463155e1c0283110 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException Backport-of: b7ca76ef4bfc640668492e655acc6d755411a92f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3718 From goetz at openjdk.org Wed Jul 9 05:43:43 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 05:43:43 GMT Subject: [jdk17u-dev] RFR: 8316580: HttpClient with StructuredTaskScope does not close when a task fails [v2] In-Reply-To: References: Message-ID: <_vuM6g5gkJHs3hjsxtg2mu3xokFiaKMc8qreJKviqLw=.2fb2f424-4d1f-4882-86c6-6dbeeb387177@github.com> On Tue, 8 Jul 2025 15:40:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.17-oracle. >> >> The change applies clean, but the test does not work out-of-the-box. >> >> It calls some utility methods ReferenceTracker.java that were added by JDK-8305847. >> That change is not in the current list of backports, so I added the utility methods >> to this change. >> >> Further, the test depends on the fact that in 21 a row of classes implement >> AutoClosable, which they don't do in 21. >> I adapted a row of places to work around this. >> A try-with-resources statement was easy to replace, as the missing >> close() implementation uses public methods, so that I could copy the >> code to the test. >> In TestTaskScope I replaced close() by shutdownNow(). >> Finally I removed the "useReferenceTracker=false" test variant, as the >> HttpClient implementation is quite far off of the implementation in 21. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > more graceful close() implementation GHA failure: unrelated. Error: Failed to FinalizeArtifact: Unable to make request: ECONNRESET ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3706#issuecomment-3051195473 From sparasa at openjdk.org Wed Jul 9 05:52:24 2025 From: sparasa at openjdk.org (Srinivas Vamsi Parasa) Date: Wed, 9 Jul 2025 05:52:24 GMT Subject: [jdk25u] RFR: 8360775: Fix Shenandoah GC test failures when APX is enabled Message-ID: Hello Everyone, This pull request contains a backport of commit [1c560727](https://github.com/openjdk/jdk/commit/1c560727b850593561982ccc3ed37b0e98b3bbee) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is a P3 bug which fixes issue with shenandoah tests when APX is used. The commit being backported was authored by Srinivas Vamsi Parasa on 4 Jul 2025 and was reviewed by Sandhya Viswanathan, Jatin Bhateja and Emanuel Peter. Thanks! ------------- Commit messages: - Backport 1c560727b850593561982ccc3ed37b0e98b3bbee Changes: https://git.openjdk.org/jdk25u/pull/14/files Webrev: https://webrevs.openjdk.org/?repo=jdk25u&pr=14&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8360775 Stats: 41 lines in 2 files changed: 40 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk25u/pull/14.diff Fetch: git fetch https://git.openjdk.org/jdk25u.git pull/14/head:pull/14 PR: https://git.openjdk.org/jdk25u/pull/14 From dzhang at openjdk.org Wed Jul 9 06:08:19 2025 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 9 Jul 2025 06:08:19 GMT Subject: [jdk25u] RFR: 8361532: RISC-V: Several vector tests fail after JDK-8354383 Message-ID: Hi all, This pull request contains a backport of commit [e0245682](https://github.com/openjdk/jdk/commit/e0245682c8d5a0daae055045c81248c12fb23c09) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Dingli Zhang on 9 Jul 2025 and was reviewed by Fei Yang, Feilong Jiang and Gui Cao. Thanks ------------- Commit messages: - Backport e0245682c8d5a0daae055045c81248c12fb23c09 Changes: https://git.openjdk.org/jdk25u/pull/15/files Webrev: https://webrevs.openjdk.org/?repo=jdk25u&pr=15&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8361532 Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk25u/pull/15.diff Fetch: git fetch https://git.openjdk.org/jdk25u.git pull/15/head:pull/15 PR: https://git.openjdk.org/jdk25u/pull/15 From iklam at openjdk.org Wed Jul 9 06:22:39 2025 From: iklam at openjdk.org (Ioi Lam) Date: Wed, 9 Jul 2025 06:22:39 GMT Subject: [jdk21u-dev] RFR: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() [v3] In-Reply-To: <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> References: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> Message-ID: On Wed, 2 Jul 2025 06:44:07 GMT, Timofei Pushkin wrote: >> The original change cleaned up code of static CDS. I am backporting it as a dependency of [JDK-8315130](https://bugs.openjdk.org/browse/JDK-8315130) which I am backporting next (#1835): without this change the backport JDK-8315130 would need to include some parts of this change and would also leave some code unused. >> >> Resolved conflicts: >> - `src/hotspot/share/cds/unregisteredClasses.cpp`: bug fix [JDK-8343416](https://bugs.openjdk.org/browse/JDK-8343416) is missing in this version but the backported change itself incorporates the bug fix (to verify I checked that the backport makes [the test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) pass, but I did not include that test in this PR) >> - `src/hotspot/share/cds/classListParser.*pp`: constant pool resolution was added there in JDK 23/24 as part of Project Layden ([JDK-8293980](https://bugs.openjdk.org/browse/JDK-8293980), [JDK-8332176](https://bugs.openjdk.org/browse/JDK-8332176)) ? this required only insignificant changes to the backport >> - The rest of the conflicts were trivial (caused by renaming, neighboring code removal, copyright year updates) >> >> Testing besides the CI (performed on macos/arm64): `runtime/cds`, [test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) (not included in the backport since that is a separate change). > > Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge remote-tracking branch 'jdk-jdk21u-dev/master' into app-cds-bug-2 > - 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() > > Reviewed-by: ccheung, coleenp > - 8339460: CDS error when module is located in a directory with space in the name > > Reviewed-by: ccheung, iklam I compared the diff of this PR vs the original diff. The changes seem to be functional identical. ------------- Marked as reviewed by iklam (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/1834#pullrequestreview-3000163620 From iklam at openjdk.org Wed Jul 9 06:22:40 2025 From: iklam at openjdk.org (Ioi Lam) Date: Wed, 9 Jul 2025 06:22:40 GMT Subject: [jdk21u-dev] RFR: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() [v3] In-Reply-To: References: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> Message-ID: On Mon, 7 Jul 2025 04:05:03 GMT, Ioi Lam wrote: >> @iklam Thank you for reviewing the main backport #1835, could you please also review this dependency of it? > > @TimPushkin could you get JDK 21u maintainer approval first? > @iklam I am new to backporting, but the order is to first get a review and only then request a maintainer approval. Or do you mean for #1835? I figured, it is better to request approvals for both changes at the same time, since I won't be able to merge that without this one anyway. Thanks for the explanation about maintainer approval. I have reviewed this PR and it seems to be functionally correct. It's up to the maintainer to decide whether this backport should be accepted into JDK 21u. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1834#issuecomment-3051279279 From tkurashige at openjdk.org Wed Jul 9 06:32:53 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Wed, 9 Jul 2025 06:32:53 GMT Subject: [jdk25u] RFR: 8358819: The first year is not displayed correctly in Japanese Calendar Message-ID: <65osDnijsHMRWj3b_F3bYFJE5keLO-AArCwAbWxg8fY=.8c780da7-b8ce-4649-9efe-ab9812eed99b@github.com> Hi all, This is a backport of JDK-8358819 : The first year is not displayed correctly in Japanese Calendar Original patch applies cleanly to 25u. Testing: test/jdk/java/util/Calendar and :jdk_time on Windows Server 2022/RHEL9.4 Thanks. ------------- Commit messages: - Backport 99829950f680936489048a1ad4ce12f166805e4d Changes: https://git.openjdk.org/jdk25u/pull/16/files Webrev: https://webrevs.openjdk.org/?repo=jdk25u&pr=16&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8358819 Stats: 197 lines in 3 files changed: 120 ins; 66 del; 11 mod Patch: https://git.openjdk.org/jdk25u/pull/16.diff Fetch: git fetch https://git.openjdk.org/jdk25u.git pull/16/head:pull/16 PR: https://git.openjdk.org/jdk25u/pull/16 From tpushkin at openjdk.org Wed Jul 9 06:35:43 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Wed, 9 Jul 2025 06:35:43 GMT Subject: [jdk21u-dev] RFR: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() [v3] In-Reply-To: <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> References: <3ICeLn1BiTjsE2iAjwoOA1plD1sjbJbYrd7sp5u7JzI=.53ddabc5-c655-4ee4-80c4-65a73d07104d@github.com> <0tWMyo1SnEqg5Ljz3DZayKjjzYgmjIZdSrm9sNaczwI=.ee8ac3f1-9524-43f1-b6bf-08487157beba@github.com> Message-ID: On Wed, 2 Jul 2025 06:44:07 GMT, Timofei Pushkin wrote: >> The original change cleaned up code of static CDS. I am backporting it as a dependency of [JDK-8315130](https://bugs.openjdk.org/browse/JDK-8315130) which I am backporting next (#1835): without this change the backport JDK-8315130 would need to include some parts of this change and would also leave some code unused. >> >> Resolved conflicts: >> - `src/hotspot/share/cds/unregisteredClasses.cpp`: bug fix [JDK-8343416](https://bugs.openjdk.org/browse/JDK-8343416) is missing in this version but the backported change itself incorporates the bug fix (to verify I checked that the backport makes [the test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) pass, but I did not include that test in this PR) >> - `src/hotspot/share/cds/classListParser.*pp`: constant pool resolution was added there in JDK 23/24 as part of Project Layden ([JDK-8293980](https://bugs.openjdk.org/browse/JDK-8293980), [JDK-8332176](https://bugs.openjdk.org/browse/JDK-8332176)) ? this required only insignificant changes to the backport >> - The rest of the conflicts were trivial (caused by renaming, neighboring code removal, copyright year updates) >> >> Testing besides the CI (performed on macos/arm64): `runtime/cds`, [test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) (not included in the backport since that is a separate change). > > Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge remote-tracking branch 'jdk-jdk21u-dev/master' into app-cds-bug-2 > - 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() > > Reviewed-by: ccheung, coleenp > - 8339460: CDS error when module is located in a directory with space in the name > > Reviewed-by: ccheung, iklam Thank you for the review! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1834#issuecomment-3051318547 From goetz at openjdk.org Wed Jul 9 06:51:17 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 06:51:17 GMT Subject: [jdk17u-dev] RFR: 8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages Message-ID: I backport this for parity with 17.0.17-oracle. Omitted the test file that came with generational zgc. ------------- Commit messages: - backport 4098acc200e608369ac1631dcc8513ea797bd59e Changes: https://git.openjdk.org/jdk17u-dev/pull/3724/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3724&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340146 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3724.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3724/head:pull/3724 PR: https://git.openjdk.org/jdk17u-dev/pull/3724 From sroy at openjdk.org Wed Jul 9 07:18:48 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Wed, 9 Jul 2025 07:18:48 GMT Subject: [jdk21u-dev] RFR: 8216437: PPC64: Add intrinsic for GHASH algorithm [v3] In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 15:49:01 GMT, Martin Doerr wrote: >> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: >> >> Update stubGenerator_ppc.cpp > > It will be released with JDK25 in September. The October Update of JDK21 should be ok for the backport. The tests should have covered it well enough. If we want some extra safety, postponing to January Update would be ok with me, too. @TheRealMDoerr @GoeLin so we wait at least till October ? So should this PR be closed now ? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1789#issuecomment-3051455189 From mdoerr at openjdk.org Wed Jul 9 08:26:41 2025 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 9 Jul 2025 08:26:41 GMT Subject: [jdk21u-dev] RFR: 8216437: PPC64: Add intrinsic for GHASH algorithm [v3] In-Reply-To: References: Message-ID: On Fri, 23 May 2025 14:07:36 GMT, Suchismith Roy wrote: >> Hi all, >> >> This pull request contains a backport of commit [cdad6d78](https://github.com/openjdk/jdk/commit/cdad6d788de4785c8dbf2710a86fdacb8d070565) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Suchismith Roy on 2 May 2025 and was reviewed by Martin Doerr and Amit Kumar. >> >> Thanks! > > Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: > > Update stubGenerator_ppc.cpp No, you can integrate it after you got maintainer approval. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1789#issuecomment-3051658655 From stuefe at openjdk.org Wed Jul 9 08:39:54 2025 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 9 Jul 2025 08:39:54 GMT Subject: [jdk17u-dev] RFR: 8351500: G1: NUMA migrations cause crashes in region allocation In-Reply-To: References: Message-ID: On Thu, 22 May 2025 13:16:06 GMT, Thomas Stuefe wrote: > This is not a clean backport. The effected G1Allocator and G1Collector methods have changed since JDK17. > > So this backports reimplements the patch in a minimally invasive way while retaining as much similarity as possible with the original patch. > > The gist of the patch is clear: instead of finding out the NUMA node index at every instance of G1Allocator::allocate_xxx, and then be subject to NUMA node migrations, we fix the NUMA node index once and use that one. > > I tested this patch with my "FakeNUMA" addition (I plan to upstream that one at some point). This FakeNUMA mode mimics a lot of NUMA node migrations. I can verify that without this patch the JVM crashes quickly, with the patch it does not crash. Fix withdrawn after discussion with Severin ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3607#issuecomment-3051698123 From stuefe at openjdk.org Wed Jul 9 08:39:54 2025 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 9 Jul 2025 08:39:54 GMT Subject: [jdk17u-dev] Withdrawn: 8351500: G1: NUMA migrations cause crashes in region allocation In-Reply-To: References: Message-ID: <6m9A2vdsRFkoCmacNL_Tr7MFCGHOb0jC60VEilOpuBI=.4c30721c-bca7-4736-9f93-362a22ef7f4f@github.com> On Thu, 22 May 2025 13:16:06 GMT, Thomas Stuefe wrote: > This is not a clean backport. The effected G1Allocator and G1Collector methods have changed since JDK17. > > So this backports reimplements the patch in a minimally invasive way while retaining as much similarity as possible with the original patch. > > The gist of the patch is clear: instead of finding out the NUMA node index at every instance of G1Allocator::allocate_xxx, and then be subject to NUMA node migrations, we fix the NUMA node index once and use that one. > > I tested this patch with my "FakeNUMA" addition (I plan to upstream that one at some point). This FakeNUMA mode mimics a lot of NUMA node migrations. I can verify that without this patch the JVM crashes quickly, with the patch it does not crash. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3607 From sgehwolf at openjdk.org Wed Jul 9 08:48:45 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 9 Jul 2025 08:48:45 GMT Subject: [jdk21u-dev] RFR: 8353950: Clipboard interaction on Windows is unstable In-Reply-To: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> References: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> Message-ID: <3g72X5slRIaZNf8ZrE4y_5yHry7mZaAhxct4Ub5-aAg=.55850776-1a6f-44a8-992f-722d2542c526@github.com> On Sun, 22 Jun 2025 11:32:19 GMT, Matthias Bl?sing wrote: > 8353950: Clipboard interaction on Windows is unstable This seems ok. @matthiasblaesing You need to follow instructions for approval to move this forward. See https://github.com/openjdk/jdk21u-dev/pull/1911#issuecomment-2994138749 and `Contributing` section in https://wiki.openjdk.org/display/JDKUpdates/JDK+21u ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1911#issuecomment-3051732346 From goetz at openjdk.org Wed Jul 9 10:35:47 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 10:35:47 GMT Subject: [jdk21u-dev] RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive In-Reply-To: References: Message-ID: On Wed, 2 Jul 2025 06:49:45 GMT, Timofei Pushkin wrote: >> Fixes a error which significantly complicates the use of static CDS in some applications with user-provided class loaders (workarounds require either manually editing the generated CDS classlist which is error-prone, or switching to dynamic CDS which has its own implications, or rewriting the application which is not always possible). >> >> The conflicts were trivial: a few neighboring methods missing from this version and not directly related to the change. >> >> The PR depends on #1833 and #1834 though it can be rewritten not to if needed. >> >> Testing besides the CI (performed on macos/arm64): `runtime/cds`, a minimal reproducer app described in the original bug report. > > @iklam As a reviewer of the original change, could you please review this JDK 21 backport and its dependency #1834? Hi @TimPushkin I would prefer to defer this to the January update. It's a larger change, and then it has time to proof itself in 25 a bit. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1835#issuecomment-3052118173 From goetz at openjdk.org Wed Jul 9 11:53:26 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 11:53:26 GMT Subject: [jdk17u-dev] RFR: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport e7e8f60c9bedd5622525cc4339300b438eedc9fd Changes: https://git.openjdk.org/jdk17u-dev/pull/3725/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3725&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347302 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3725.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3725/head:pull/3725 PR: https://git.openjdk.org/jdk17u-dev/pull/3725 From goetz at openjdk.org Wed Jul 9 11:54:17 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 11:54:17 GMT Subject: [jdk21u-dev] RFR: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport e7e8f60c9bedd5622525cc4339300b438eedc9fd Changes: https://git.openjdk.org/jdk21u-dev/pull/1951/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1951&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347302 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1951.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1951/head:pull/1951 PR: https://git.openjdk.org/jdk21u-dev/pull/1951 From goetz at openjdk.org Wed Jul 9 11:59:22 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 11:59:22 GMT Subject: [jdk21u-dev] RFR: 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests Message-ID: I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport c988d7d6476807bf71a977dc771017915b708ca3 Changes: https://git.openjdk.org/jdk21u-dev/pull/1952/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1952&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350767 Stats: 20 lines in 5 files changed: 0 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1952.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1952/head:pull/1952 PR: https://git.openjdk.org/jdk21u-dev/pull/1952 From goetz at openjdk.org Wed Jul 9 11:59:27 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 11:59:27 GMT Subject: [jdk17u-dev] RFR: 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests Message-ID: <8JYCnsHreuLZsZzgxpNEgEoet4vbHZ_fLA25ZT2ZvKA=.bfe9da26-0f9d-4e4d-a025-58f51984483d@github.com> I backport this for parity with 17.0.17-oracle. Resolved copyright, probably clean anyways. ------------- Commit messages: - Backport c988d7d6476807bf71a977dc771017915b708ca3 Changes: https://git.openjdk.org/jdk17u-dev/pull/3726/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3726&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350767 Stats: 20 lines in 5 files changed: 0 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3726.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3726/head:pull/3726 PR: https://git.openjdk.org/jdk17u-dev/pull/3726 From goetz at openjdk.org Wed Jul 9 12:02:58 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:02:58 GMT Subject: [jdk17u-dev] RFR: 8280818: Expand bug8033699.java to iterate over all LaFs Message-ID: I backport this for parity with 17.0.17-oracle ------------- Commit messages: - Backport b50fe9b8cc39730d3339e45a83b365ab3dd8a5da Changes: https://git.openjdk.org/jdk17u-dev/pull/3727/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3727&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280818 Stats: 110 lines in 1 file changed: 56 ins; 40 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3727.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3727/head:pull/3727 PR: https://git.openjdk.org/jdk17u-dev/pull/3727 From goetz at openjdk.org Wed Jul 9 12:03:23 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:03:23 GMT Subject: [jdk21u-dev] RFR: 8280818: Expand bug8033699.java to iterate over all LaFs Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport b50fe9b8cc39730d3339e45a83b365ab3dd8a5da Changes: https://git.openjdk.org/jdk21u-dev/pull/1953/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1953&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280818 Stats: 110 lines in 1 file changed: 56 ins; 40 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1953.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1953/head:pull/1953 PR: https://git.openjdk.org/jdk21u-dev/pull/1953 From goetz at openjdk.org Wed Jul 9 12:08:25 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:08:25 GMT Subject: [jdk17u-dev] RFR: 8352879: TestPeriod.java and TestGetContentType.java run wrong test class Message-ID: <-Wdv8Z1oVmp8TjUF7Nu-mPLehSSXsKABoNPJptJEUvw=.f6c4fb5f-0026-419a-af83-31ffbcb2dc89@github.com> I backport this for parity with 17.0.17-oracle ------------- Commit messages: - Backport b9d7a75adee8a96cf47bbe73e3009102ceda9589 Changes: https://git.openjdk.org/jdk17u-dev/pull/3728/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3728&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352879 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3728.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3728/head:pull/3728 PR: https://git.openjdk.org/jdk17u-dev/pull/3728 From goetz at openjdk.org Wed Jul 9 12:09:05 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:09:05 GMT Subject: [jdk21u-dev] RFR: 8352879: TestPeriod.java and TestGetContentType.java run wrong test class Message-ID: <6aCpc9CXsZ5tSg_Y2F0SXjcXStTwcg57Emg0wYbexYI=.e7523d72-5449-40d0-be11-c54a65bcb0f8@github.com> I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport b9d7a75adee8a96cf47bbe73e3009102ceda9589 Changes: https://git.openjdk.org/jdk21u-dev/pull/1954/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1954&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352879 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1954.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1954/head:pull/1954 PR: https://git.openjdk.org/jdk21u-dev/pull/1954 From goetz at openjdk.org Wed Jul 9 12:13:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:13:54 GMT Subject: [jdk17u-dev] RFR: 8352719: Add an equals sign to the modules statement Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 85a0baf0cb3366d6c16f9aadee123862117f5338 Changes: https://git.openjdk.org/jdk17u-dev/pull/3729/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3729&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352719 Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3729.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3729/head:pull/3729 PR: https://git.openjdk.org/jdk17u-dev/pull/3729 From goetz at openjdk.org Wed Jul 9 12:14:16 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:14:16 GMT Subject: [jdk21u-dev] RFR: 8352719: Add an equals sign to the modules statement Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport 85a0baf0cb3366d6c16f9aadee123862117f5338 Changes: https://git.openjdk.org/jdk21u-dev/pull/1955/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1955&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352719 Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1955.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1955/head:pull/1955 PR: https://git.openjdk.org/jdk21u-dev/pull/1955 From goetz at openjdk.org Wed Jul 9 12:15:55 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:15:55 GMT Subject: [jdk17u-dev] RFR: 8352895: UserCookie.java runs wrong test class Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport edaeb4b2da7c7a49ea3f3baebc7a072b56088e34 Changes: https://git.openjdk.org/jdk17u-dev/pull/3730/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3730&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352895 Stats: 5 lines in 1 file changed: 2 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3730.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3730/head:pull/3730 PR: https://git.openjdk.org/jdk17u-dev/pull/3730 From goetz at openjdk.org Wed Jul 9 12:36:22 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:36:22 GMT Subject: [jdk17u-dev] RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug Message-ID: I backport this for parity with 17.0.17-oracle resolved copyright, probably clean. ------------- Commit messages: - Backport 1ec64811a365442c902e334b56f4cf926c316a4a Changes: https://git.openjdk.org/jdk17u-dev/pull/3731/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3731&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350582 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3731.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3731/head:pull/3731 PR: https://git.openjdk.org/jdk17u-dev/pull/3731 From goetz at openjdk.org Wed Jul 9 12:37:16 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:37:16 GMT Subject: [jdk21u-dev] RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug Message-ID: I backport this for parity with 21.0.9-oracle. resolved copyright, probably clean. ------------- Commit messages: - Backport 1ec64811a365442c902e334b56f4cf926c316a4a Changes: https://git.openjdk.org/jdk21u-dev/pull/1956/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1956&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350582 Stats: 25 lines in 6 files changed: 2 ins; 0 del; 23 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1956.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1956/head:pull/1956 PR: https://git.openjdk.org/jdk21u-dev/pull/1956 From goetz at openjdk.org Wed Jul 9 12:42:55 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:42:55 GMT Subject: [jdk17u-dev] RFR: 8355475: UNCTest should use an existing UNC path Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport e6cea4025b6743538da76f056fa831b02705f423 Changes: https://git.openjdk.org/jdk17u-dev/pull/3732/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3732&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355475 Stats: 34 lines in 1 file changed: 30 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3732.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3732/head:pull/3732 PR: https://git.openjdk.org/jdk17u-dev/pull/3732 From goetz at openjdk.org Wed Jul 9 12:44:13 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:44:13 GMT Subject: [jdk21u-dev] RFR: 8355475: UNCTest should use an existing UNC path Message-ID: I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport e6cea4025b6743538da76f056fa831b02705f423 Changes: https://git.openjdk.org/jdk21u-dev/pull/1957/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1957&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355475 Stats: 34 lines in 1 file changed: 30 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1957.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1957/head:pull/1957 PR: https://git.openjdk.org/jdk21u-dev/pull/1957 From goetz at openjdk.org Wed Jul 9 12:47:25 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:47:25 GMT Subject: [jdk21u-dev] RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.9-oracle. > resolved copyright, probably clean. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 1ec64811a365442c902e334b56f4cf926c316a4a ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/1956/files - new: https://git.openjdk.org/jdk21u-dev/pull/1956/files/f44a39aa..6ff3fb75 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1956&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1956&range=00-01 Stats: 205 lines in 6 files changed: 185 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1956.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1956/head:pull/1956 PR: https://git.openjdk.org/jdk21u-dev/pull/1956 From goetz at openjdk.org Wed Jul 9 12:48:03 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Jul 2025 12:48:03 GMT Subject: [jdk17u-dev] RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.17-oracle > > resolved copyright, probably clean. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 1ec64811a365442c902e334b56f4cf926c316a4a ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3731/files - new: https://git.openjdk.org/jdk17u-dev/pull/3731/files/74806ced..571f7a10 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3731&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3731&range=00-01 Stats: 185 lines in 1 file changed: 185 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3731.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3731/head:pull/3731 PR: https://git.openjdk.org/jdk17u-dev/pull/3731 From evergizova at openjdk.org Wed Jul 9 13:51:51 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Wed, 9 Jul 2025 13:51:51 GMT Subject: [jdk21u-dev] Integrated: 8337506: Disable "best-fit" mapping on Windows command line In-Reply-To: References: Message-ID: On Thu, 27 Feb 2025 15:34:18 GMT, Ekaterina Vergizova wrote: > I'd like to backport this for parity with 21.0.8-oracle. This pull request has now been integrated. Changeset: 56f04e1a Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk21u-dev/commit/56f04e1a54ed99ca1834c812ce0e6b7df331fb1c Stats: 103 lines in 2 files changed: 101 ins; 0 del; 2 mod 8337506: Disable "best-fit" mapping on Windows command line Reviewed-by: mbalao Backport-of: ff634a967027cfa56b666d31c45db9a4acc09ea4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1438 From evergizova at openjdk.org Wed Jul 9 14:32:00 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Wed, 9 Jul 2025 14:32:00 GMT Subject: [jdk17u-dev] RFR: 8337506: Disable "best-fit" mapping on Windows command line Message-ID: I'd like to backport this for parity with 17.0.17-oracle. CSR JDK-8349538 has been approved for 17u. The patch applies almost cleanly, except for the copyright years. The new test passes successfully after applying the patch. ------------- Commit messages: - Backport ff634a967027cfa56b666d31c45db9a4acc09ea4 Changes: https://git.openjdk.org/jdk17u-dev/pull/3733/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3733&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337506 Stats: 103 lines in 2 files changed: 101 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3733.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3733/head:pull/3733 PR: https://git.openjdk.org/jdk17u-dev/pull/3733 From duke at openjdk.org Wed Jul 9 15:35:49 2025 From: duke at openjdk.org (duke) Date: Wed, 9 Jul 2025 15:35:49 GMT Subject: [jdk11u-dev] Withdrawn: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool In-Reply-To: References: Message-ID: On Thu, 13 Mar 2025 14:57:19 GMT, Dmitry Chuyko wrote: > This a backport of JDK-8351933 [0] (PR [1]) for 11u. At one of code paths the TC subfield of ctl field is decremented and the result is not masked correctly. The target code is in runWorker() instead of tryTrim()/awaitWork() and the surrounding code is different from the current master, as well as the original mask name. The core change is the same, candidate for CTL.compareAndSet is constructed using '(RC_MASK & c) | (TC_MASK & (c - TC_UNIT))' instead of '(UC_MASK & (c - TC_UNIT))' to correctly preserve the RC subfield. > > [0] https://bugs.openjdk.org/browse/JDK-8351933 > [1] https://github.com/openjdk/jdk/pull/24034 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/3012 From mblaesing at openjdk.org Wed Jul 9 16:15:47 2025 From: mblaesing at openjdk.org (Matthias =?UTF-8?B?QmzDpHNpbmc=?=) Date: Wed, 9 Jul 2025 16:15:47 GMT Subject: [jdk21u-dev] RFR: 8353950: Clipboard interaction on Windows is unstable In-Reply-To: <3g72X5slRIaZNf8ZrE4y_5yHry7mZaAhxct4Ub5-aAg=.55850776-1a6f-44a8-992f-722d2542c526@github.com> References: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> <3g72X5slRIaZNf8ZrE4y_5yHry7mZaAhxct4Ub5-aAg=.55850776-1a6f-44a8-992f-722d2542c526@github.com> Message-ID: On Wed, 9 Jul 2025 08:45:38 GMT, Severin Gehwolf wrote: >> 8353950: Clipboard interaction on Windows is unstable > > This seems ok. > > @matthiasblaesing You need to follow instructions for approval to move this forward. See https://github.com/openjdk/jdk21u-dev/pull/1911#issuecomment-2994138749 and `Contributing` section in https://wiki.openjdk.org/display/JDKUpdates/JDK+21u @jerboaa thanks for the reply. I indeed missed that, sorry for the noice. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1911#issuecomment-3053243644 From phh at openjdk.org Wed Jul 9 17:29:40 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 9 Jul 2025 17:29:40 GMT Subject: [jdk11u-dev] RFR: 8355249: Remove the use of WMIC from the entire source code In-Reply-To: References: Message-ID: <0XRTW_uJgrwBXwZoxXzv4qswrB_9piOQQ7jxtgwBwxc=.603569f1-9975-4fde-9785-390db2adc722@github.com> On Fri, 4 Jul 2025 02:29:49 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code > > JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported. > > Original patch does not apply cleanly because WindowsHelper.java doesn't exist in jdk11. WindowsHelper.java was added in jdk14 ([JDK-8212780](https://bugs.openjdk.org/browse/JDK-8212780)). Except for this point, original patch applies cleanly. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/3057#pullrequestreview-3002426290 From phh at openjdk.org Wed Jul 9 17:36:47 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 9 Jul 2025 17:36:47 GMT Subject: [jdk17u-dev] RFR: 8316580: HttpClient with StructuredTaskScope does not close when a task fails [v2] In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 15:40:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.17-oracle. >> >> The change applies clean, but the test does not work out-of-the-box. >> >> It calls some utility methods ReferenceTracker.java that were added by JDK-8305847. >> That change is not in the current list of backports, so I added the utility methods >> to this change. >> >> Further, the test depends on the fact that in 21 a row of classes implement >> AutoClosable, which they don't do in 21. >> I adapted a row of places to work around this. >> A try-with-resources statement was easy to replace, as the missing >> close() implementation uses public methods, so that I could copy the >> code to the test. >> In TestTaskScope I replaced close() by shutdownNow(). >> Finally I removed the "useReferenceTracker=false" test variant, as the >> HttpClient implementation is quite far off of the implementation in 21. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > more graceful close() implementation Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3706#pullrequestreview-3002453461 From phh at openjdk.org Wed Jul 9 17:41:39 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 9 Jul 2025 17:41:39 GMT Subject: [jdk21u-dev] RFR: 8355249: Remove the use of WMIC from the entire source code In-Reply-To: References: Message-ID: On Mon, 23 Jun 2025 01:13:51 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code > > JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported. > > Original patch does not apply cleanly because JDK-8340311 is not backported to jdk21. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java. > > I confirmed that Win8301247Test.java passes on Windows Server 2022. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1912#pullrequestreview-3002488525 From phh at openjdk.org Wed Jul 9 17:48:42 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 9 Jul 2025 17:48:42 GMT Subject: [jdk21u-dev] RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 13:16:40 GMT, Jan Kratochvil wrote: > Multithreaded handling of ZIP files can throw an exception. > > This backport is far from clean. The last commit resolves the conflicts. > > The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is [a backward compatibility concern](https://bugs.openjdk.org/browse/JDK-8321156?focusedId=14630523&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14630523) I have not backported it. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/1949#pullrequestreview-3002535510 From phh at openjdk.org Wed Jul 9 17:58:44 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 9 Jul 2025 17:58:44 GMT Subject: [jdk17u-dev] RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset In-Reply-To: References: Message-ID: <4AE21-XKmlBqd3qAEtIFuMqIxi9nmkZ4iSF6XAR_hRg=.77994842-3581-4fc1-afbd-f19aadb28357@github.com> On Tue, 8 Jul 2025 13:30:17 GMT, Jan Kratochvil wrote: > Multithreaded handling of ZIP files can throw an exception. > > This backport is far from clean. The last commit resolves the conflicts. > > The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is [a backward compatibility concern](https://bugs.openjdk.org/browse/JDK-8321156?focusedId=14630523&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14630523) I have not backported it. Almost clean backport from the 21u backport https://github.com/openjdk/jdk21u-dev/pull/1949. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3720#pullrequestreview-3002585067 From jkratochvil at openjdk.org Wed Jul 9 18:08:35 2025 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 9 Jul 2025 18:08:35 GMT Subject: [jdk17u-dev] RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset [v2] In-Reply-To: References: Message-ID: > Multithreaded handling of ZIP files can throw an exception. > > This backport is far from clean. The last commit resolves the conflicts. > > The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is [a backward compatibility concern](https://bugs.openjdk.org/browse/JDK-8321156?focusedId=14630523&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14630523) I have not backported it. > > [jdk24](https://github.com/openjdk/jdk24u/pull/236), [jdk21](https://github.com/openjdk/jdk21u-dev/pull/1949), this jdk17. Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: Fix testcase compatibility with jdk17 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3720/files - new: https://git.openjdk.org/jdk17u-dev/pull/3720/files/6fa35f83..e405c770 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3720&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3720&range=00-01 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3720.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3720/head:pull/3720 PR: https://git.openjdk.org/jdk17u-dev/pull/3720 From phh at openjdk.org Wed Jul 9 18:11:46 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 9 Jul 2025 18:11:46 GMT Subject: [jdk11u-dev] RFR: 8214972: Uses of klass_holder() except GC need to apply GC barriers In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 14:55:21 GMT, Francesco Andreuzzi wrote: > I've been working on a backport to fix [JDK-8339725](https://bugs.openjdk.org/browse/JDK-8339725). The fix attached to the ticket is not enough to fix the problem on jdk11. > > The missing backport is JDK-8214972, which I apply in this PR. JDK-8210321 is also needed to provide `ClassLoaderData::holder_no_keepalive`. > > Tier1 tests completed successfully. This looks ok, but why is it needed as a prereq for [JDK-8339725](https://bugs.openjdk.org/browse/JDK-8339725)? Given that 11u is old, why do you want to backport it? Do you have production use issues? I recommend running both tier1 and tier2, with both fastdebug and release JDKs. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/3059#pullrequestreview-3002614212 From duke at openjdk.org Wed Jul 9 19:03:43 2025 From: duke at openjdk.org (duke) Date: Wed, 9 Jul 2025 19:03:43 GMT Subject: [jdk21u-dev] RFR: 8353950: Clipboard interaction on Windows is unstable In-Reply-To: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> References: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> Message-ID: On Sun, 22 Jun 2025 11:32:19 GMT, Matthias Bl?sing wrote: > 8353950: Clipboard interaction on Windows is unstable @matthiasblaesing Your change (at version c2fade9e316dd5a21cb47ca71d448592006727ca) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1911#issuecomment-3053691235 From mblaesing at openjdk.org Wed Jul 9 19:03:43 2025 From: mblaesing at openjdk.org (Matthias =?UTF-8?B?QmzDpHNpbmc=?=) Date: Wed, 9 Jul 2025 19:03:43 GMT Subject: [jdk21u-dev] RFR: 8353950: Clipboard interaction on Windows is unstable In-Reply-To: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> References: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> Message-ID: On Sun, 22 Jun 2025 11:32:19 GMT, Matthias Bl?sing wrote: > 8353950: Clipboard interaction on Windows is unstable @vieiro @jerboaa would one of you be willing to sponsor this change? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1911#issuecomment-3053694384 From duke at openjdk.org Wed Jul 9 19:30:46 2025 From: duke at openjdk.org (Francesco Andreuzzi) Date: Wed, 9 Jul 2025 19:30:46 GMT Subject: [jdk11u-dev] RFR: 8214972: Uses of klass_holder() except GC need to apply GC barriers In-Reply-To: References: Message-ID: <3_GSClkEaj0TJc5IcLicj0btTCbulifaYk8gw5IrC9A=.82f1a77a-b07a-4ee1-9e2f-8e761a31ca2d@github.com> On Wed, 9 Jul 2025 18:09:29 GMT, Paul Hohensee wrote: >> I've been working on a backport to fix [JDK-8339725](https://bugs.openjdk.org/browse/JDK-8339725). The fix attached to the ticket is not enough to fix the problem on jdk11. >> >> The missing backport is JDK-8214972, which I apply in this PR. JDK-8210321 is also needed to provide `ClassLoaderData::holder_no_keepalive`. >> >> Tier1 tests completed successfully. > > This looks ok, but why is it needed as a prereq for [JDK-8339725](https://bugs.openjdk.org/browse/JDK-8339725)? > > Given that 11u is old, why do you want to backport it? Do you have production use issues? I recommend running both tier1 and tier2, with both fastdebug and release JDKs. @phohensee > This looks ok, but why is it needed as a prereq for [JDK-8339725](https://bugs.openjdk.org/browse/JDK-8339725)? It's difficult to pinpoint the specific issue as the problem manifests as a segfault in an unrelated location. I determined JDK-8214972 is needed by bisecting the history and backporting JDK-8339725 to each commit. The commit related to JDK-8214972 is the first where the reproducer attached to JDK-8339725 runs successfully. Applying both of them to jdk11 solves the problem indeed. > Given that 11u is old, why do you want to backport it? Do you have production use issues? We had an occurrence of this issue in async-profiler/async-profiler#974. As reported by the user, the problem affects jdk11 too. > I recommend running both tier1 and tier2, with both fastdebug and release JDKs. I ran tier1 with release already, I'll start a tier2 run with fastdebug. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3059#issuecomment-3053762178 From duke at openjdk.org Wed Jul 9 19:40:43 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 9 Jul 2025 19:40:43 GMT Subject: [jdk21u-dev] RFR: 8353950: Clipboard interaction on Windows is unstable In-Reply-To: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> References: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> Message-ID: <-k_CMePnoELKFKJcWUCQkK91h79Kq1pPmv-NBFmir8E=.19b1334a-b5b5-49ef-8cc3-5847b03ecf52@github.com> On Sun, 22 Jun 2025 11:32:19 GMT, Matthias Bl?sing wrote: > 8353950: Clipboard interaction on Windows is unstable I'm not sure this will work (note sure if it's updated yet), but let's ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1911#issuecomment-3053782320 From ssubramaniam at openjdk.org Wed Jul 9 21:59:39 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Wed, 9 Jul 2025 21:59:39 GMT Subject: [jdk21u-dev] Integrated: 8345173: BlockLocationPrinter::print_location misses a ResourceMark In-Reply-To: References: Message-ID: <4TkjEvAeYK_smX6z_ldajtRrUZKSwFMXev5gm6QhUl4=.398f43c1-487f-4eb6-be60-5389d459ec95@github.com> On Tue, 17 Jun 2025 17:35:10 GMT, Satyen Subramaniam wrote: > Backporting JDK-8345173: BlockLocationPrinter::print_location misses a ResourceMark. Since BlockLocationPrinter can be called at any point (e.g. the stop() method of MacroAssembler), it may currently fail with a "Missing ResourceMark error - possible memory leak" error instead of providing the stop() output (and then failing). Ran GHA Sanity Checks and local Tier 1 and 2. Patch is clean. This pull request has now been integrated. Changeset: 7b6ae460 Author: Satyen Subramaniam URL: https://git.openjdk.org/jdk21u-dev/commit/7b6ae4606188dd0fc32abf34b7076ad359764a1b Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8345173: BlockLocationPrinter::print_location misses a ResourceMark Backport-of: f5ebda43709984214a25e23926860fea2ba5819a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1896 From ssubramaniam at openjdk.org Wed Jul 9 22:01:47 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Wed, 9 Jul 2025 22:01:47 GMT Subject: [jdk17u-dev] Integrated: 8345173: BlockLocationPrinter::print_location misses a ResourceMark In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 17:36:10 GMT, Satyen Subramaniam wrote: > Backporting JDK-8345173: BlockLocationPrinter::print_location misses a ResourceMark. Since BlockLocationPrinter can be called at any point (e.g. the stop() method of MacroAssembler), it may currently fail with a "Missing ResourceMark error - possible memory leak" error instead of providing the stop() output (and then failing). Ran GHA Sanity Checks and local Tier 1 and 2. Patch is clean. This pull request has now been integrated. Changeset: 29d46c30 Author: Satyen Subramaniam URL: https://git.openjdk.org/jdk17u-dev/commit/29d46c30a47fdfa811d002af04908ae30d4f93e3 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8345173: BlockLocationPrinter::print_location misses a ResourceMark Backport-of: f5ebda43709984214a25e23926860fea2ba5819a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3665 From duke at openjdk.org Wed Jul 9 22:49:46 2025 From: duke at openjdk.org (Francesco Andreuzzi) Date: Wed, 9 Jul 2025 22:49:46 GMT Subject: [jdk11u-dev] RFR: 8214972: Uses of klass_holder() except GC need to apply GC barriers In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 18:09:29 GMT, Paul Hohensee wrote: >> I've been working on a backport to fix [JDK-8339725](https://bugs.openjdk.org/browse/JDK-8339725). The fix attached to the ticket is not enough to fix the problem on jdk11. >> >> The missing backport is JDK-8214972, which I apply in this PR. JDK-8210321 is also needed to provide `ClassLoaderData::holder_no_keepalive`. >> >> Tier1 tests completed successfully. > > This looks ok, but why is it needed as a prereq for [JDK-8339725](https://bugs.openjdk.org/browse/JDK-8339725)? > > Given that 11u is old, why do you want to backport it? Do you have production use issues? I recommend running both tier1 and tier2, with both fastdebug and release JDKs. @phohensee I ran the following test suites: - release + tier1: all test pass + tier2: all test pass except for: - `ConnectionReuseTest::testConnReuse` - `DirectIOTest` - fastdebug + tier1: all test pass + tier2: all test pass except for: - `ConnectionReuseTest::testConnReuse` - `DirectIOTest` The failures don't seem to be related to my changes, possibly flaky tests? I found tickets related to them (e.g. [JDK-8305900](https://bugs.openjdk.org/browse/JDK-8305900)) which haven't been backported to jdk11. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3059#issuecomment-3054335533 From ssubramaniam at openjdk.org Thu Jul 10 00:56:44 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Thu, 10 Jul 2025 00:56:44 GMT Subject: [jdk21u-dev] RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 17:28:11 GMT, Satyen Subramaniam wrote: > Backporting JDK-8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream. Since Java 10, the trySplit() method for spliterators for the ConcurrentSkipListMap always returned null, causing parallel streams to be broken for ConcurrentSkipListMap and ConcurrentSkipListSet since. This change fixes the logic for considering the head.node.next field in addition to head.node. Ran GHA Sanity Checks, local Tier 1 and 2, and new test directly. Patch is clean. Closing due to `jdk21u-fix-no` label ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1895#issuecomment-3054701581 From ssubramaniam at openjdk.org Thu Jul 10 00:56:45 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Thu, 10 Jul 2025 00:56:45 GMT Subject: [jdk21u-dev] Withdrawn: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 17:28:11 GMT, Satyen Subramaniam wrote: > Backporting JDK-8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream. Since Java 10, the trySplit() method for spliterators for the ConcurrentSkipListMap always returned null, causing parallel streams to be broken for ConcurrentSkipListMap and ConcurrentSkipListSet since. This change fixes the logic for considering the head.node.next field in addition to head.node. Ran GHA Sanity Checks, local Tier 1 and 2, and new test directly. Patch is clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1895 From ssubramaniam at openjdk.org Thu Jul 10 00:57:41 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Thu, 10 Jul 2025 00:57:41 GMT Subject: [jdk21u-dev] RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream In-Reply-To: References: Message-ID: On Fri, 20 Jun 2025 03:27:20 GMT, Satyen Subramaniam wrote: > Backporting JDK-8344253: Test java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed. Fixes an intermittent failure with the `java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed` test in situations where a decrement wouldn't complete, since unsigned shift right twice would lead to decrementing estimated size by 0. Backporting alongside the related issue: JDK-8344253: https://github.com/openjdk/jdk21u-dev/pull/1895. Ran GHA Sanity Checks, and local Tier 1 and 2. Patch is clean. Closing due to `jdk21u-fix-no` label ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1906#issuecomment-3054703648 From ssubramaniam at openjdk.org Thu Jul 10 00:57:41 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Thu, 10 Jul 2025 00:57:41 GMT Subject: [jdk21u-dev] Withdrawn: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream In-Reply-To: References: Message-ID: <17QD6vqFvzdGDwjSo404cb9K451BR57Phb5uAxkL9Io=.592ebb02-25b3-44e3-86a3-0e5130f695a8@github.com> On Fri, 20 Jun 2025 03:27:20 GMT, Satyen Subramaniam wrote: > Backporting JDK-8344253: Test java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed. Fixes an intermittent failure with the `java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed` test in situations where a decrement wouldn't complete, since unsigned shift right twice would lead to decrementing estimated size by 0. Backporting alongside the related issue: JDK-8344253: https://github.com/openjdk/jdk21u-dev/pull/1895. Ran GHA Sanity Checks, and local Tier 1 and 2. Patch is clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1906 From ssubramaniam at openjdk.org Thu Jul 10 00:57:48 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Thu, 10 Jul 2025 00:57:48 GMT Subject: [jdk17u-dev] RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream In-Reply-To: References: Message-ID: On Fri, 20 Jun 2025 03:27:29 GMT, Satyen Subramaniam wrote: > Backporting JDK-8344253: Test java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed. Fixes an intermittent failure with the `java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed` test in situations where a decrement wouldn't complete, since unsigned shift right twice would lead to decrementing estimated size by 0. Backporting alongside the related issue: JDK-8344253: https://github.com/openjdk/jdk21u-dev/pull/1895. Ran GHA Sanity Checks, and local Tier 1 and 2. Patch is clean. Closing due to `jdk21u-fix-no` label ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3668#issuecomment-3054704422 From ssubramaniam at openjdk.org Thu Jul 10 00:57:48 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Thu, 10 Jul 2025 00:57:48 GMT Subject: [jdk17u-dev] RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 17:28:22 GMT, Satyen Subramaniam wrote: > Backporting JDK-8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream. Since Java 10, the trySplit() method for spliterators for the ConcurrentSkipListMap always returned null, causing parallel streams to be broken for ConcurrentSkipListMap and ConcurrentSkipListSet since. This change fixes the logic for considering the head.node.next field in addition to head.node. Ran GHA Sanity Checks, local Tier 1 and 2, and new test directly. Patch is clean. Closing due to `jdk21u-fix-no` label ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3664#issuecomment-3054704367 From ssubramaniam at openjdk.org Thu Jul 10 00:57:48 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Thu, 10 Jul 2025 00:57:48 GMT Subject: [jdk17u-dev] Withdrawn: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream In-Reply-To: References: Message-ID: On Fri, 20 Jun 2025 03:27:29 GMT, Satyen Subramaniam wrote: > Backporting JDK-8344253: Test java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed. Fixes an intermittent failure with the `java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed` test in situations where a decrement wouldn't complete, since unsigned shift right twice would lead to decrementing estimated size by 0. Backporting alongside the related issue: JDK-8344253: https://github.com/openjdk/jdk21u-dev/pull/1895. Ran GHA Sanity Checks, and local Tier 1 and 2. Patch is clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3668 From ssubramaniam at openjdk.org Thu Jul 10 00:57:48 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Thu, 10 Jul 2025 00:57:48 GMT Subject: [jdk17u-dev] Withdrawn: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream In-Reply-To: References: Message-ID: On Tue, 17 Jun 2025 17:28:22 GMT, Satyen Subramaniam wrote: > Backporting JDK-8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream. Since Java 10, the trySplit() method for spliterators for the ConcurrentSkipListMap always returned null, causing parallel streams to be broken for ConcurrentSkipListMap and ConcurrentSkipListSet since. This change fixes the logic for considering the head.node.next field in addition to head.node. Ran GHA Sanity Checks, local Tier 1 and 2, and new test directly. Patch is clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3664 From tpushkin at openjdk.org Thu Jul 10 06:49:46 2025 From: tpushkin at openjdk.org (Timofei Pushkin) Date: Thu, 10 Jul 2025 06:49:46 GMT Subject: [jdk21u-dev] RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 10:33:31 GMT, Goetz Lindenmaier wrote: >> @iklam As a reviewer of the original change, could you please review this JDK 21 backport and its dependency #1834? > > Hi @TimPushkin > I would prefer to defer this to the January update. > It's a larger change, and then it has time to proof itself in 25 a bit. @GoeLin, thank you, sounds reasonable ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1835#issuecomment-3055869567 From goetz at openjdk.org Thu Jul 10 07:59:27 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 07:59:27 GMT Subject: [jdk17u-dev] RFR: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently [v2] In-Reply-To: References: Message-ID: > I backport this as we see the test failing sporadically. > > Omitted ProblemList change, test is not on the list. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport c93b24d85289167639e9ec4b79bd85403687161b ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3723/files - new: https://git.openjdk.org/jdk17u-dev/pull/3723/files/50a602cb..1e185a42 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3723&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3723&range=00-01 Stats: 23 lines in 2 files changed: 20 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3723.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3723/head:pull/3723 PR: https://git.openjdk.org/jdk17u-dev/pull/3723 From goetz at openjdk.org Thu Jul 10 08:08:51 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 08:08:51 GMT Subject: [jdk17u-dev] RFR: 8280818: Expand bug8033699.java to iterate over all LaFs In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 11:58:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle GHA failure: infra issue, tests hang. unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3727#issuecomment-3056210759 From mblaesing at openjdk.org Thu Jul 10 08:25:52 2025 From: mblaesing at openjdk.org (Matthias =?UTF-8?B?QmzDpHNpbmc=?=) Date: Thu, 10 Jul 2025 08:25:52 GMT Subject: [jdk21u-dev] Integrated: 8353950: Clipboard interaction on Windows is unstable In-Reply-To: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> References: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> Message-ID: On Sun, 22 Jun 2025 11:32:19 GMT, Matthias Bl?sing wrote: > 8353950: Clipboard interaction on Windows is unstable This pull request has now been integrated. Changeset: dc28239c Author: Matthias Bl?sing Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/dc28239c29b64f4db068aca5c05b0301623986c3 Stats: 174 lines in 4 files changed: 128 ins; 24 del; 22 mod 8353950: Clipboard interaction on Windows is unstable 8332271: Reading data from the clipboard from multiple threads crashes the JVM Backport-of: 92be7821f5d5cbf5fe0244b41b2b7b1ada898df0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1911 From duke at openjdk.org Thu Jul 10 08:52:27 2025 From: duke at openjdk.org (Shruthi) Date: Thu, 10 Jul 2025 08:52:27 GMT Subject: [jdk17u-dev] RFR: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl [v2] In-Reply-To: References: Message-ID: > Signed-off-by: Shruthi [Shruthi.Shruthi1 at ibm.com](mailto:Shruthi.Shruthi1 at ibm.com) > > OpenJDK PR : https://github.com/openjdk/jdk/pull/10434 > OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8294399 > > The original patch does not apply cleanly to JDK17u-dev, as UnixFileDispatcherImpl.java and UnixFileDispatcherImpl.c do not exist in this version. > Instead, JDK 17 uses FileDispatcherImpl.java and FileDispatcherImpl.c under the unix directory for the relevant implementation. > Therefore, the changes were applied manually to align with the JDK 17 structure. Shruthi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-d667895 - Backport d6678952a6de4e5435dab65e7029021832454857 Signed-off-by: Shruthi ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3631/files - new: https://git.openjdk.org/jdk17u-dev/pull/3631/files/267df776..bab00e47 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3631&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3631&range=00-01 Stats: 14599 lines in 587 files changed: 7527 ins; 4982 del; 2090 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3631.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3631/head:pull/3631 PR: https://git.openjdk.org/jdk17u-dev/pull/3631 From goetz.lindenmaier at sap.com Thu Jul 10 09:36:28 2025 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 10 Jul 2025 09:36:28 +0000 Subject: 2025-07 Security Update Bundles In-Reply-To: References: Message-ID: Hi Paul, On 20.5.2025 you have removed jdk17u-fix-yes and jdk17u-fix-request labels from https://bugs.openjdk.org/browse/JDK-8320687 Why have you done this? You should not touch jdk17u-fix-yes labels!!! These are reserved to the maintainers. Now we have a broken situation with two pushes for the same change. The correct way would have been to open a [REDO] change, this is what I understood as "resubmit". Nobody could tell from your 2nd PR that this was a redo of a previous change. Please mention such things to be transparent. Actually I thought that Skara warns that the change has already been pushed to the repository. Hasn't there been such a warning? Best regards, Goetz. > -----Original Message----- > From: Andrew Hughes > Sent: Wednesday, July 9, 2025 8:53 PM > To: Lindenmaier, Goetz > Subject: Re: 2025-07 Security Update Bundles > > On 11:23 Wed 09 Jul , Lindenmaier, Goetz wrote: > > Hi Andrew, > > > > It seems to be working in the meantime. I saw some mails to Christoph. > > > > Best, Goetz. > > > > Thanks. I've picked up the bundles today. > > I've just been going through the changes in 17.0.16 and I found this > pair confusing: > > JDK-8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() > throws unexpected exceptions when invoked concurrently > JDK-8355914: [17u] Backout backport of JDK-8320687 > > The reason is that there are only two bugs, but three commits. From > the bugs alone, it is not clear that 8320687 was later reapplied as it > happens under the same ID and in a commit with the same summary. > > I can see why you might wanted to have avoided a "[REDO]" bug here to > retain the link to the original bug. Maybe, as it was only a failing > test, it could have just been excluded until fixed? > > The 8355914 bug says "Tonight rampdown starts" but this was in > 17.0.16+1, long before rampdown. > > Thoughts? I'm just wondering if we could have done things a little > better here, though I can understand the change was made under tight > time constraints. > > Best, > -- > Andrew :) > Pronouns: he / him or they / them > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > Please contact via e-mail, not proprietary chat networks From goetz at openjdk.org Thu Jul 10 09:37:43 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 09:37:43 GMT Subject: [jdk17u-dev] RFR: 8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() throws unexpected exceptions when invoked concurrently [v3] In-Reply-To: References: Message-ID: On Tue, 20 May 2025 17:57:44 GMT, Paul Hohensee wrote: >> Backport for parity with Oracle 17.0.16. Clean except for copyright date in MonitoredHost.java, and replacement of try-with-resources in new test with try-catch because ExecutorService does not implement AutoClosable in 17u. New test passes, as well as the existing tests under test/jdk/sun/jvmstat/monitor. > > Paul Hohensee has updated the pull request incrementally with one additional commit since the last revision: > > 8320687: Revert trigger This is a redo change after https://bugs.openjdk.org/browse/JDK-8355914 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3593#issuecomment-3056571541 From tkurashige at openjdk.org Thu Jul 10 10:20:50 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Thu, 10 Jul 2025 10:20:50 GMT Subject: [jdk11u-dev] RFR: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build In-Reply-To: References: Message-ID: On Tue, 24 Jun 2025 12:01:16 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build > > I couldn't reproduce the bug reported in JDK-8352942 in 11u but it will potentially happen as described in https://github.com/openjdk/jdk/pull/24646#issue-2995156538 . So I think this fix should be backported to 11u. > > Original patch applies cleanly to 11u. > > Testing: TestMemoryOptions.java executed by 32/64bit module passes and Winsows Server 2019 > > Thanks. @jerboaa Sorry for sudden mention, could you add maintainer approval for this PR? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3054#issuecomment-3056764145 From sgehwolf at openjdk.org Thu Jul 10 10:35:48 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 10 Jul 2025 10:35:48 GMT Subject: [jdk11u-dev] RFR: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build In-Reply-To: References: Message-ID: On Tue, 24 Jun 2025 12:01:16 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build > > I couldn't reproduce the bug reported in JDK-8352942 in 11u but it will potentially happen as described in https://github.com/openjdk/jdk/pull/24646#issue-2995156538 . So I think this fix should be backported to 11u. > > Original patch applies cleanly to 11u. > > Testing: TestMemoryOptions.java executed by 32/64bit module passes and Winsows Server 2019 > > Thanks. Seems fine, yes. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3054#issuecomment-3056837335 From tkurashige at openjdk.org Thu Jul 10 10:43:47 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Thu, 10 Jul 2025 10:43:47 GMT Subject: [jdk11u-dev] RFR: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build In-Reply-To: References: Message-ID: <7FYJMlDARjwWNZcDY3b_nruabzntusuEYMsrMzqYZLQ=.b4027f18-db26-4e14-a786-f4493d0ba0f6@github.com> On Tue, 24 Jun 2025 12:01:16 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build > > I couldn't reproduce the bug reported in JDK-8352942 in 11u but it will potentially happen as described in https://github.com/openjdk/jdk/pull/24646#issue-2995156538 . So I think this fix should be backported to 11u. > > Original patch applies cleanly to 11u. > > Testing: TestMemoryOptions.java executed by 32/64bit module passes and Winsows Server 2019 > > Thanks. Thank you everyone for reviews. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3054#issuecomment-3056865805 From duke at openjdk.org Thu Jul 10 10:43:47 2025 From: duke at openjdk.org (duke) Date: Thu, 10 Jul 2025 10:43:47 GMT Subject: [jdk11u-dev] RFR: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build In-Reply-To: References: Message-ID: On Tue, 24 Jun 2025 12:01:16 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build > > I couldn't reproduce the bug reported in JDK-8352942 in 11u but it will potentially happen as described in https://github.com/openjdk/jdk/pull/24646#issue-2995156538 . So I think this fix should be backported to 11u. > > Original patch applies cleanly to 11u. > > Testing: TestMemoryOptions.java executed by 32/64bit module passes and Winsows Server 2019 > > Thanks. @kurashige23 Your change (at version fe2dc3157c715a9c603d9ff12135d74ab0d38d24) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3054#issuecomment-3056868641 From tkurashige at openjdk.org Thu Jul 10 10:57:46 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Thu, 10 Jul 2025 10:57:46 GMT Subject: [jdk11u-dev] Integrated: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build In-Reply-To: References: Message-ID: On Tue, 24 Jun 2025 12:01:16 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build > > I couldn't reproduce the bug reported in JDK-8352942 in 11u but it will potentially happen as described in https://github.com/openjdk/jdk/pull/24646#issue-2995156538 . So I think this fix should be backported to 11u. > > Original patch applies cleanly to 11u. > > Testing: TestMemoryOptions.java executed by 32/64bit module passes and Winsows Server 2019 > > Thanks. This pull request has now been integrated. Changeset: 7ff53b5d Author: Taizo Kurashige Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/7ff53b5d990bf8d30df130a88e7c4bf15d591275 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build Reviewed-by: shade, phh Backport-of: c3de94cee12471a11c457c11dd55c547633de5cb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/3054 From goetz at openjdk.org Thu Jul 10 12:29:46 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:29:46 GMT Subject: [jdk21u-dev] Integrated: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 11:47:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. This pull request has now been integrated. Changeset: 44e83945 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/44e8394575c301733a07e63ab92ce20b8a64b4c1 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8347302: Mark test tools/jimage/JImageToolTest.java as flagless Backport-of: e7e8f60c9bedd5622525cc4339300b438eedc9fd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1951 From goetz at openjdk.org Thu Jul 10 12:30:44 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:30:44 GMT Subject: [jdk21u-dev] Integrated: 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 11:53:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle This pull request has now been integrated. Changeset: b7ef5cb7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/b7ef5cb7d181bf173ed79cdff0889df3bb599581 Stats: 20 lines in 5 files changed: 0 ins; 0 del; 20 mod 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests Backport-of: c988d7d6476807bf71a977dc771017915b708ca3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1952 From goetz at openjdk.org Thu Jul 10 12:31:42 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:31:42 GMT Subject: [jdk21u-dev] Integrated: 8280818: Expand bug8033699.java to iterate over all LaFs In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 11:58:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. This pull request has now been integrated. Changeset: adc0c001 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/adc0c00116e3db7f875a76924d4bf3c841375eb4 Stats: 110 lines in 1 file changed: 56 ins; 40 del; 14 mod 8280818: Expand bug8033699.java to iterate over all LaFs Backport-of: b50fe9b8cc39730d3339e45a83b365ab3dd8a5da ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1953 From goetz at openjdk.org Thu Jul 10 12:33:45 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:33:45 GMT Subject: [jdk21u-dev] Integrated: 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 14:42:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. This pull request has now been integrated. Changeset: 285dc910 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/285dc910f828d7a53da5569eebd9b5606c2d3521 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI Backport-of: 41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1947 From goetz at openjdk.org Thu Jul 10 12:34:46 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:34:46 GMT Subject: [jdk21u-dev] Integrated: 8352879: TestPeriod.java and TestGetContentType.java run wrong test class In-Reply-To: <6aCpc9CXsZ5tSg_Y2F0SXjcXStTwcg57Emg0wYbexYI=.e7523d72-5449-40d0-be11-c54a65bcb0f8@github.com> References: <6aCpc9CXsZ5tSg_Y2F0SXjcXStTwcg57Emg0wYbexYI=.e7523d72-5449-40d0-be11-c54a65bcb0f8@github.com> Message-ID: <_9n-L8g5n1uWCU-tc2y7uF_EzDmjmXN4jtQtOVA0Q-g=.b95b521a-1af2-4613-860a-122e85c60106@github.com> On Wed, 9 Jul 2025 12:03:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. This pull request has now been integrated. Changeset: a8f1de56 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/a8f1de56810f2c0f1d652bf0c9fc70cae604a9eb Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8352879: TestPeriod.java and TestGetContentType.java run wrong test class Backport-of: b9d7a75adee8a96cf47bbe73e3009102ceda9589 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1954 From goetz at openjdk.org Thu Jul 10 12:36:45 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:36:45 GMT Subject: [jdk17u-dev] Integrated: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 11:48:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: 4b270f58 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4b270f58066bc70bcb8650858fc829c5061427b2 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8347302: Mark test tools/jimage/JImageToolTest.java as flagless Backport-of: e7e8f60c9bedd5622525cc4339300b438eedc9fd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3725 From goetz at openjdk.org Thu Jul 10 12:37:47 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:37:47 GMT Subject: [jdk21u-dev] Integrated: 8352719: Add an equals sign to the modules statement In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 12:08:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. This pull request has now been integrated. Changeset: 7e0f5200 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/7e0f5200b933179c3e01a00eb05efbd83c3acc46 Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod 8352719: Add an equals sign to the modules statement Backport-of: 85a0baf0cb3366d6c16f9aadee123862117f5338 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1955 From goetz at openjdk.org Thu Jul 10 12:38:43 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:38:43 GMT Subject: [jdk17u-dev] Integrated: 8347381: Upgrade jQuery UI to version 1.14.1 In-Reply-To: References: Message-ID: <9s_EH8axiTaKGUytZCMvHM4LQQmXCh83dbjRiaKjOPo=.65428b61-d3f4-4827-b066-641bc633a433@github.com> On Mon, 7 Jul 2025 12:39:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. > > Clean backport from 21. This pull request has now been integrated. Changeset: eecdbf17 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/eecdbf17828f2164e9af579c6dd3815da2ffc7d6 Stats: 135 lines in 5 files changed: 3 ins; 70 del; 62 mod 8347381: Upgrade jQuery UI to version 1.14.1 Backport-of: 64b73fbd08c1086ceca26c5724cde8c090246b80 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3711 From goetz at openjdk.org Thu Jul 10 12:40:51 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:40:51 GMT Subject: [jdk17u-dev] RFR: 8351500: G1: NUMA migrations cause crashes in region allocation In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 08:36:50 GMT, Thomas Stuefe wrote: >> This is not a clean backport. The effected G1Allocator and G1Collector methods have changed since JDK17. >> >> So this backports reimplements the patch in a minimally invasive way while retaining as much similarity as possible with the original patch. >> >> The gist of the patch is clear: instead of finding out the NUMA node index at every instance of G1Allocator::allocate_xxx, and then be subject to NUMA node migrations, we fix the NUMA node index once and use that one. >> >> I tested this patch with my "FakeNUMA" addition (I plan to upstream that one at some point). This FakeNUMA mode mimics a lot of NUMA node migrations. I can verify that without this patch the JVM crashes quickly, with the patch it does not crash. > > Fix withdrawn after discussion with Severin Hi, at tstuefe, I'll remove the fix labels. Could you please also mention in your fix-request comment that you withdrew it and why? For the next one who might try backporting this? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3607#issuecomment-3057283230 From goetz at openjdk.org Thu Jul 10 12:41:43 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:41:43 GMT Subject: [jdk17u-dev] Integrated: 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests In-Reply-To: <8JYCnsHreuLZsZzgxpNEgEoet4vbHZ_fLA25ZT2ZvKA=.bfe9da26-0f9d-4e4d-a025-58f51984483d@github.com> References: <8JYCnsHreuLZsZzgxpNEgEoet4vbHZ_fLA25ZT2ZvKA=.bfe9da26-0f9d-4e4d-a025-58f51984483d@github.com> Message-ID: On Wed, 9 Jul 2025 11:53:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. > > Resolved copyright, probably clean anyways. This pull request has now been integrated. Changeset: 5654c01a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5654c01a3e484aaf16e80b2d4a020102749cf568 Stats: 20 lines in 5 files changed: 0 ins; 0 del; 20 mod 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests Backport-of: c988d7d6476807bf71a977dc771017915b708ca3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3726 From goetz at openjdk.org Thu Jul 10 12:41:46 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:41:46 GMT Subject: [jdk21u-dev] Integrated: 8350582: Correct the parsing of the ssl value in javax.net.debug In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 12:31:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle. > resolved copyright, probably clean. This pull request has now been integrated. Changeset: a7f1e32b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/a7f1e32bf5d016541688add0092d985981ccf66f Stats: 190 lines in 2 files changed: 187 ins; 0 del; 3 mod 8350582: Correct the parsing of the ssl value in javax.net.debug Backport-of: 1ec64811a365442c902e334b56f4cf926c316a4a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1956 From goetz at openjdk.org Thu Jul 10 12:42:47 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:42:47 GMT Subject: [jdk17u-dev] Integrated: 8280818: Expand bug8033699.java to iterate over all LaFs In-Reply-To: References: Message-ID: <7-LnF0P5cOV5EFYOz_PCVz87H78sE0vev07VoO9KZ2Q=.2c9987e5-f28f-4c2c-9b02-219bd7f88afe@github.com> On Wed, 9 Jul 2025 11:58:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle This pull request has now been integrated. Changeset: 8fb27fbc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8fb27fbc5ae9ca0737b152bebe0d528b20f3859d Stats: 110 lines in 1 file changed: 56 ins; 40 del; 14 mod 8280818: Expand bug8033699.java to iterate over all LaFs Backport-of: b50fe9b8cc39730d3339e45a83b365ab3dd8a5da ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3727 From goetz at openjdk.org Thu Jul 10 12:43:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:43:41 GMT Subject: [jdk21u-dev] Integrated: 8355475: UNCTest should use an existing UNC path In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 12:38:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.9-oracle This pull request has now been integrated. Changeset: 28276ac5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/28276ac5465f54816dd00f1de0ced8f443829f75 Stats: 34 lines in 1 file changed: 30 ins; 1 del; 3 mod 8355475: UNCTest should use an existing UNC path Backport-of: e6cea4025b6743538da76f056fa831b02705f423 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1957 From goetz at openjdk.org Thu Jul 10 12:44:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:44:41 GMT Subject: [jdk17u-dev] Integrated: 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI In-Reply-To: References: Message-ID: <7nK4ZGzyp0C1lr3c_K1tinIethmEICYW9mNHpP9U1Ws=.b0067e89-629d-4c11-897a-a5f1d31efa5d@github.com> On Mon, 7 Jul 2025 14:43:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: 0139d2ef Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0139d2efdde55cb2da8eea8248e625cbca6a4cda Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI Backport-of: 41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3717 From goetz at openjdk.org Thu Jul 10 12:46:44 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:46:44 GMT Subject: [jdk17u-dev] Integrated: 8352879: TestPeriod.java and TestGetContentType.java run wrong test class In-Reply-To: <-Wdv8Z1oVmp8TjUF7Nu-mPLehSSXsKABoNPJptJEUvw=.f6c4fb5f-0026-419a-af83-31ffbcb2dc89@github.com> References: <-Wdv8Z1oVmp8TjUF7Nu-mPLehSSXsKABoNPJptJEUvw=.f6c4fb5f-0026-419a-af83-31ffbcb2dc89@github.com> Message-ID: On Wed, 9 Jul 2025 12:03:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle This pull request has now been integrated. Changeset: 46233194 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4623319433dd27569c547d82aad2329743c68462 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8352879: TestPeriod.java and TestGetContentType.java run wrong test class Backport-of: b9d7a75adee8a96cf47bbe73e3009102ceda9589 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3728 From goetz at openjdk.org Thu Jul 10 12:47:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:47:41 GMT Subject: [jdk17u-dev] Integrated: 8352719: Add an equals sign to the modules statement In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 12:08:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: c333708c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c333708ce3ef7d9e80329c3879ea37aaf2ed416c Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod 8352719: Add an equals sign to the modules statement Backport-of: 85a0baf0cb3366d6c16f9aadee123862117f5338 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3729 From goetz at openjdk.org Thu Jul 10 12:48:44 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:48:44 GMT Subject: [jdk17u-dev] Integrated: 8352895: UserCookie.java runs wrong test class In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 12:11:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: 4f9649a5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4f9649a54f7615ce942f0219697a6912a6085a95 Stats: 5 lines in 1 file changed: 2 ins; 2 del; 1 mod 8352895: UserCookie.java runs wrong test class Backport-of: edaeb4b2da7c7a49ea3f3baebc7a072b56088e34 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3730 From goetz at openjdk.org Thu Jul 10 12:50:43 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:50:43 GMT Subject: [jdk17u-dev] Integrated: 8350582: Correct the parsing of the ssl value in javax.net.debug In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 12:31:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle > > resolved copyright, probably clean. This pull request has now been integrated. Changeset: 350badf5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/350badf5e7fcfebd9fc8848ffad4d6df6b874ad0 Stats: 190 lines in 2 files changed: 187 ins; 0 del; 3 mod 8350582: Correct the parsing of the ssl value in javax.net.debug Backport-of: 1ec64811a365442c902e334b56f4cf926c316a4a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3731 From goetz at openjdk.org Thu Jul 10 12:51:40 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 12:51:40 GMT Subject: [jdk17u-dev] Integrated: 8355475: UNCTest should use an existing UNC path In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 12:38:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. This pull request has now been integrated. Changeset: 78c4c3a9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/78c4c3a9a3243aa320d39c72bc0ca3bb0340bc63 Stats: 34 lines in 1 file changed: 30 ins; 1 del; 3 mod 8355475: UNCTest should use an existing UNC path Backport-of: e6cea4025b6743538da76f056fa831b02705f423 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3732 From sroy at openjdk.org Thu Jul 10 13:48:45 2025 From: sroy at openjdk.org (Suchismith Roy) Date: Thu, 10 Jul 2025 13:48:45 GMT Subject: [jdk21u-dev] RFR: 8216437: PPC64: Add intrinsic for GHASH algorithm In-Reply-To: References: Message-ID: On Mon, 7 Jul 2025 14:52:59 GMT, Goetz Lindenmaier wrote: >> Need to adapt code for jdk21 repo. Looking into it > > Hi @suchismith1993 > please give a fix request comment that gives the necessary details. > The change is definitely not needed for 21, probably a nice-to-have performance optimization. > > This has not been tested in any released JVM yet, do you really want to bring it to 21 now? @GoeLin can it be approved now ? or shall we hold till October ? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1789#issuecomment-3057526323 From goetz at openjdk.org Thu Jul 10 14:05:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 14:05:41 GMT Subject: [jdk17u-dev] RFR: 8316580: HttpClient with StructuredTaskScope does not close when a task fails [v2] In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 15:40:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.17-oracle. >> >> The change applies clean, but the test does not work out-of-the-box. >> >> It calls some utility methods ReferenceTracker.java that were added by JDK-8305847. >> That change is not in the current list of backports, so I added the utility methods >> to this change. >> >> Further, the test depends on the fact that in 21 a row of classes implement >> AutoClosable, which they don't do in 21. >> I adapted a row of places to work around this. >> A try-with-resources statement was easy to replace, as the missing >> close() implementation uses public methods, so that I could copy the >> code to the test. >> In TestTaskScope I replaced close() by shutdownNow(). >> Finally I removed the "useReferenceTracker=false" test variant, as the >> HttpClient implementation is quite far off of the implementation in 21. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > more graceful close() implementation I pushed an extra change to the test. It replaces the shutdownNow() by more graceful coding. This seems to better imitate the behavior of the original test. Unfortunately with this change the test hangs until it is killed by jtreg. It only passes if run with the debug build, and once passed in our nightlies with the fastdebug. I copied the modified test into my jdk21 repo where it passes as expected. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3706#issuecomment-3057597377 From goetz at openjdk.org Thu Jul 10 14:13:53 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 14:13:53 GMT Subject: [jdk21u-dev] RFR: 8216437: PPC64: Add intrinsic for GHASH algorithm [v3] In-Reply-To: References: Message-ID: On Fri, 23 May 2025 14:07:36 GMT, Suchismith Roy wrote: >> Hi all, >> >> This pull request contains a backport of commit [cdad6d78](https://github.com/openjdk/jdk/commit/cdad6d788de4785c8dbf2710a86fdacb8d070565) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Suchismith Roy on 2 May 2025 and was reviewed by Martin Doerr and Amit Kumar. >> >> Thanks! > > Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: > > Update stubGenerator_ppc.cpp Hi Suchismith, I labeled it jdk21u-defer-next. Also, you did not update the fix-request comment yet. There should be good information about this in the JBS issue. The purpose of the PR is only to review it. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1789#issuecomment-3057630083 From thartmann at openjdk.org Thu Jul 10 14:56:44 2025 From: thartmann at openjdk.org (Tobias Hartmann) Date: Thu, 10 Jul 2025 14:56:44 GMT Subject: [jdk25u] RFR: 8358183: [JVMCI] crash accessing nmethod::jvmci_name in CodeCache::aggregate In-Reply-To: <4Eog8u0AKpGEff-0ma7t27FwGpmmrtislpfbWiZ0Iro=.409cb9a4-d2fd-43b0-adb8-41d2ccae41d3@github.com> References: <4Eog8u0AKpGEff-0ma7t27FwGpmmrtislpfbWiZ0Iro=.409cb9a4-d2fd-43b0-adb8-41d2ccae41d3@github.com> Message-ID: On Fri, 4 Jul 2025 15:06:23 GMT, Boris Ulasevich wrote: > This is the backport of the JVMCI metadata crash fix. > > Issue: > When flushing nmethods via CodeBlob::purge(), the JVMCI metadata was freed (mutable_data) but its size fields remained non-zero. As a result, invoking heap analytics via jcmd Compiler.CodeHeap_Analytics still walks the purged metadata and calls jvmci_name() on arbitrary memory, leading to intermittent crashes > > Fix: > Extend CodeBlob::purge() to zero out the _mutable_data_size, _relocation_size, and _metadata_size fields so that after a purge jvmci_data_size() returns 0 and CompileBroker::print_heapinfo() skips any JVMCI metadata Shouldn't this go to JDK 25, not JDK 25u? ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/13#issuecomment-3057808780 From duke at openjdk.org Thu Jul 10 15:07:40 2025 From: duke at openjdk.org (duke) Date: Thu, 10 Jul 2025 15:07:40 GMT Subject: [jdk17u-dev] RFR: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 16:15:48 GMT, Daniel Huang wrote: > Backport for RandomSupport issue. There is a loss of information when using `convertSeedBytesToInts()` with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result. > > Clean backport, ran GHA sanity checks and locally tested tier1, tier2. In tier2, there was 1 failure: > `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` > However, this fails on master as well. > > The backport also updates the test `T8282144.java` to test for ints as well, which passes. @dtmhuang Your change (at version 3b4953c80538028f3a2e808ba3afe44855830aef) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3722#issuecomment-3057849304 From goetz at openjdk.org Thu Jul 10 15:19:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 15:19:20 GMT Subject: [jdk17u-dev] RFR: 8314611: Provide more explicative error message parsing Currencies Message-ID: I backport this for parity with 17.0.17-oracle. The changes to the lib code applied clean. In the test I resolved one chunk and replace Locale.of() which is not available in 17. ------------- Commit messages: - Backport 3c8a6678feac8e3225bc1c44593a78d9e7c4d77c Changes: https://git.openjdk.org/jdk17u-dev/pull/3734/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3734&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314611 Stats: 42 lines in 2 files changed: 29 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3734.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3734/head:pull/3734 PR: https://git.openjdk.org/jdk17u-dev/pull/3734 From goetz at openjdk.org Thu Jul 10 15:41:59 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 15:41:59 GMT Subject: [jdk21u-dev] RFR: 8314611: Provide more explicative error message parsing Currencies Message-ID: I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport 3c8a6678feac8e3225bc1c44593a78d9e7c4d77c Changes: https://git.openjdk.org/jdk21u-dev/pull/1958/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1958&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314611 Stats: 41 lines in 2 files changed: 28 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1958.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1958/head:pull/1958 PR: https://git.openjdk.org/jdk21u-dev/pull/1958 From goetz at openjdk.org Thu Jul 10 15:53:53 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 15:53:53 GMT Subject: [jdk21u-dev] RFR: 8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport e7a1c8660af50a321bc466be2b30412a5b5c4e3c Changes: https://git.openjdk.org/jdk21u-dev/pull/1959/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1959&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8217914 Stats: 22 lines in 3 files changed: 11 ins; 6 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1959.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1959/head:pull/1959 PR: https://git.openjdk.org/jdk21u-dev/pull/1959 From goetz at openjdk.org Thu Jul 10 15:55:26 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 15:55:26 GMT Subject: [jdk17u-dev] RFR: 8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport e7a1c8660af50a321bc466be2b30412a5b5c4e3c Changes: https://git.openjdk.org/jdk17u-dev/pull/3735/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3735&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8217914 Stats: 22 lines in 3 files changed: 11 ins; 6 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3735.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3735/head:pull/3735 PR: https://git.openjdk.org/jdk17u-dev/pull/3735 From goetz at openjdk.org Thu Jul 10 16:03:34 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 16:03:34 GMT Subject: [jdk17u-dev] RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated Message-ID: <-JO449bVdFOuPqLLx3W_5o161UerA3BnY42Io5Z2AYA=.e1c50485-9e32-4047-b20b-6a8c4c370c12@github.com> I backport this for parity with 17.0.17-oracle. This is based on the push to 21. Resolved imports in test/lib/jdk/test/lib/Asserts.java, might be clean. ------------- Commit messages: - Backport 5d6f03c4ed39884e3489298e8776e85fcee285d5 Changes: https://git.openjdk.org/jdk17u-dev/pull/3736/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3736&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343074 Stats: 681 lines in 15 files changed: 235 ins; 281 del; 165 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3736.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3736/head:pull/3736 PR: https://git.openjdk.org/jdk17u-dev/pull/3736 From goetz at openjdk.org Thu Jul 10 16:16:13 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 16:16:13 GMT Subject: [jdk21u-dev] RFR: 8355370: Include server name in HTTP test server thread names to improve diagnostics Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport 7d9a43839ad190a53efdbcc7afd1728760c14e21 Changes: https://git.openjdk.org/jdk21u-dev/pull/1960/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1960&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355370 Stats: 28 lines in 2 files changed: 13 ins; 6 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1960.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1960/head:pull/1960 PR: https://git.openjdk.org/jdk21u-dev/pull/1960 From goetz at openjdk.org Thu Jul 10 16:40:03 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 16:40:03 GMT Subject: [jdk17u-dev] RFR: 8358617: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails with 403 due to system proxies Message-ID: I backport this for parity with 17.0.17-oracle ------------- Commit messages: - Backport a377773fa76b46ac98533c61bc1410485390115e Changes: https://git.openjdk.org/jdk17u-dev/pull/3737/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3737&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8358617 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3737.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3737/head:pull/3737 PR: https://git.openjdk.org/jdk17u-dev/pull/3737 From goetz at openjdk.org Thu Jul 10 16:41:22 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Jul 2025 16:41:22 GMT Subject: [jdk21u-dev] RFR: 8358617: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails with 403 due to system proxies Message-ID: I backport this for parity with 21.0.9-oracle. ------------- Commit messages: - Backport a377773fa76b46ac98533c61bc1410485390115e Changes: https://git.openjdk.org/jdk21u-dev/pull/1961/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1961&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8358617 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1961.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1961/head:pull/1961 PR: https://git.openjdk.org/jdk21u-dev/pull/1961 From duke at openjdk.org Thu Jul 10 17:07:43 2025 From: duke at openjdk.org (duke) Date: Thu, 10 Jul 2025 17:07:43 GMT Subject: [jdk17u-dev] Withdrawn: 8320276: Improve class initialization barrier in TemplateTable::_new In-Reply-To: References: Message-ID: On Wed, 16 Apr 2025 19:44:34 GMT, Matt wrote: > This PR backports 8320276 to support backporting 8338379, see the comment thread linked below. This was a clean backport, though reviewers may want to confirm that the decision to include [this function](https://github.com/openjdk/jdk17u-dev/blob/f19121cc65199f2052c69747dfa7ae8d209596f4/src/hotspot/cpu/ppc/vm_version_ppc.hpp#L135) was correct. > > --------- > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] [JDK-8320276](https://bugs.openjdk.org/browse/JDK-8320276) needs maintainer approval > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3508/head:pull/3508` \ > `$ git checkout pull/3508` > > Update a local copy of the PR: \ > `$ git checkout pull/3508` \ > `$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3508/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 3508` > > View PR using the GUI difftool: \ > `$ git pr show -t 3508` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jdk17u-dev/pull/3508.diff > >
This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3508 From bulasevich at openjdk.org Thu Jul 10 17:50:52 2025 From: bulasevich at openjdk.org (Boris Ulasevich) Date: Thu, 10 Jul 2025 17:50:52 GMT Subject: [jdk25u] Withdrawn: 8358183: [JVMCI] crash accessing nmethod::jvmci_name in CodeCache::aggregate In-Reply-To: <4Eog8u0AKpGEff-0ma7t27FwGpmmrtislpfbWiZ0Iro=.409cb9a4-d2fd-43b0-adb8-41d2ccae41d3@github.com> References: <4Eog8u0AKpGEff-0ma7t27FwGpmmrtislpfbWiZ0Iro=.409cb9a4-d2fd-43b0-adb8-41d2ccae41d3@github.com> Message-ID: On Fri, 4 Jul 2025 15:06:23 GMT, Boris Ulasevich wrote: > This is the backport of the JVMCI metadata crash fix. > > Issue: > When flushing nmethods via CodeBlob::purge(), the JVMCI metadata was freed (mutable_data) but its size fields remained non-zero. As a result, invoking heap analytics via jcmd Compiler.CodeHeap_Analytics still walks the purged metadata and calls jvmci_name() on arbitrary memory, leading to intermittent crashes > > Fix: > Extend CodeBlob::purge() to zero out the _mutable_data_size, _relocation_size, and _metadata_size fields so that after a purge jvmci_data_size() returns 0 and CompileBroker::print_heapinfo() skips any JVMCI metadata This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk25u/pull/13 From mblaesing at openjdk.org Thu Jul 10 18:48:59 2025 From: mblaesing at openjdk.org (Matthias =?UTF-8?B?QmzDpHNpbmc=?=) Date: Thu, 10 Jul 2025 18:48:59 GMT Subject: [jdk21u-dev] RFR: 8353950: Clipboard interaction on Windows is unstable In-Reply-To: <3g72X5slRIaZNf8ZrE4y_5yHry7mZaAhxct4Ub5-aAg=.55850776-1a6f-44a8-992f-722d2542c526@github.com> References: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> <3g72X5slRIaZNf8ZrE4y_5yHry7mZaAhxct4Ub5-aAg=.55850776-1a6f-44a8-992f-722d2542c526@github.com> Message-ID: On Wed, 9 Jul 2025 08:45:38 GMT, Severin Gehwolf wrote: >> 8353950: Clipboard interaction on Windows is unstable > > This seems ok. > > @matthiasblaesing You need to follow instructions for approval to move this forward. See https://github.com/openjdk/jdk21u-dev/pull/1911#issuecomment-2994138749 and `Contributing` section in https://wiki.openjdk.org/display/JDKUpdates/JDK+21u @jerboaa thank you @vieiro thank you too, I saw the vote thread on jdk-updates-dev and thus assumed, that the magic for your commit enablement had already happened ? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1911#issuecomment-3058562184 From dzhang at openjdk.org Fri Jul 11 02:52:14 2025 From: dzhang at openjdk.org (Dingli Zhang) Date: Fri, 11 Jul 2025 02:52:14 GMT Subject: [jdk25u] RFR: 8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb Message-ID: Hi all, This pull request contains a backport of commit [2e7e272d](https://github.com/openjdk/jdk/commit/2e7e272d7b5273bae8684095bcda2a9c8bd21dc8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Dingli Zhang on 11 Jul 2025 and was reviewed by Fei Yang and Feilong Jiang. Thanks! ------------- Commit messages: - Backport 2e7e272d7b5273bae8684095bcda2a9c8bd21dc8 Changes: https://git.openjdk.org/jdk25u/pull/17/files Webrev: https://webrevs.openjdk.org/?repo=jdk25u&pr=17&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8361829 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk25u/pull/17.diff Fetch: git fetch https://git.openjdk.org/jdk25u.git pull/17/head:pull/17 PR: https://git.openjdk.org/jdk25u/pull/17 From duke at openjdk.org Fri Jul 11 05:59:47 2025 From: duke at openjdk.org (duke) Date: Fri, 11 Jul 2025 05:59:47 GMT Subject: [jdk21u-dev] Withdrawn: 8351484: Race condition in max stats in MonitorList::add In-Reply-To: References: Message-ID: On Wed, 14 May 2025 13:33:28 GMT, Francesco Andreuzzi wrote: > Unclean backport of JDK-8351484. Fixes a race condition in `MonitorList::add`. The new test does not pass on `master`. Conflicts were related to the import statements in the test file. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1778 From duke at openjdk.org Fri Jul 11 08:13:50 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 11 Jul 2025 08:13:50 GMT Subject: [jdk21u-dev] RFR: 8353950: Clipboard interaction on Windows is unstable In-Reply-To: <-k_CMePnoELKFKJcWUCQkK91h79Kq1pPmv-NBFmir8E=.19b1334a-b5b5-49ef-8cc3-5847b03ecf52@github.com> References: <_P1Cj_sOOBOBfNVU_1YZQVs-LgrN1l65nYYONdaW_Cs=.ec72427c-a8a9-4522-b46b-ab7e4ee9f4d5@github.com> <-k_CMePnoELKFKJcWUCQkK91h79Kq1pPmv-NBFmir8E=.19b1334a-b5b5-49ef-8cc3-5847b03ecf52@github.com> Message-ID: On Wed, 9 Jul 2025 19:36:35 GMT, Antonio Vieiro wrote: >> 8353950: Clipboard interaction on Windows is unstable > > I'm not sure this will work (note sure if it's updated yet), but let's > @vieiro thank you too, I saw the vote thread on jdk-updates-dev and thus assumed, that the magic for your commit enablement had already happened ? Thank you @matthiasblaesing for backporting this! NetBeans users will be happy to see this on 21 by october. Yeah, these things go slowly I imagine. I'll have to continue abusing committers for sponsoring meanwhile ? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1911#issuecomment-3061162365 From goetz at openjdk.org Fri Jul 11 09:40:28 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 09:40:28 GMT Subject: [jdk21u-dev] RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset In-Reply-To: References: Message-ID: <6KQbQIDQxjmECSNjnSN_ZvPWJqBWKfq5BhsV7OSIG7s=.b59dd22a-cd04-428d-81e8-4249d7cbc08d@github.com> On Tue, 8 Jul 2025 13:16:40 GMT, Jan Kratochvil wrote: > Multithreaded handling of ZIP files can throw an exception. > > This backport is far from clean. The last commit resolves the conflicts. > > The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is [a backward compatibility concern](https://bugs.openjdk.org/browse/JDK-8321156?focusedId=14630523&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14630523) I have not backported it. > > [jdk24](https://github.com/openjdk/jdk24u/pull/236), this jdk21, [jdk17](https://github.com/openjdk/jdk17u-dev/pull/3720). Hi @jankratochvil this is a larger change and just fresh in 25. Can we give this some time until January update? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1949#issuecomment-3061509565 From mbaesken at openjdk.org Fri Jul 11 09:44:50 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 11 Jul 2025 09:44:50 GMT Subject: [jdk17u-dev] RFR: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently [v2] In-Reply-To: References: Message-ID: On Thu, 10 Jul 2025 07:59:27 GMT, Goetz Lindenmaier wrote: >> I backport this as we see the test failing sporadically. >> >> Omitted ProblemList change, test is not on the list. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport c93b24d85289167639e9ec4b79bd85403687161b Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3723#pullrequestreview-3009534972 From goetz at openjdk.org Fri Jul 11 09:46:22 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 09:46:22 GMT Subject: [jdk21u] RFR: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 In-Reply-To: References: Message-ID: On Mon, 23 Jun 2025 09:54:48 GMT, Radek Cap wrote: >> @RadekCap Why is this being requested as a critical fix (to go into the July release)? If at all, it should perhaps go into the October release. > > @jerboaa It was my understanding from the original PR in 21u-dev - https://github.com/openjdk/jdk21u-dev/pull/1846#issuecomment-2943216964 > > Based on this, I waited for 24u approval. > > Based on the latest comment in 21u-dev - https://github.com/openjdk/jdk21u-dev/pull/1846#issuecomment-2980719426 > > I created this PR in 21 to get it into the July release. > > It's up to you, maintainers, if you would prefer a July or October release. I can do both. > > I have a draft PRs in 21-udev, 17-udev, and 11-udev based on jdk approved change - https://github.com/openjdk/jdk/pull/25503 > > Please let me know which way I should pick. Thank you. Hi @RadekCap I approved the change targeting jdk21u-dev. Please close this one. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/465#issuecomment-3061535601 From mbaesken at openjdk.org Fri Jul 11 09:48:48 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 11 Jul 2025 09:48:48 GMT Subject: [jdk17u-dev] RFR: 8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 06:46:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. > > Omitted the test file that came with generational zgc. test/hotspot/jtreg/gc/z/TestAllocateHeapAt.java is also in 17 (and was changed in 21) why is it not in? ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3724#pullrequestreview-3009547400 From goetz at openjdk.org Fri Jul 11 09:49:20 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 09:49:20 GMT Subject: [jdk17u-dev] RFR: 8337506: Disable "best-fit" mapping on Windows command line In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 14:26:48 GMT, Ekaterina Vergizova wrote: > I'd like to backport this for parity with 17.0.17-oracle. > CSR JDK-8349538 has been approved for 17u. > The patch applies almost cleanly, except for the copyright years. > The new test passes successfully after applying the patch. Thanks for backporting this change! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3733#issuecomment-3061543635 From mbaesken at openjdk.org Fri Jul 11 10:01:43 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 11 Jul 2025 10:01:43 GMT Subject: [jdk17u-dev] RFR: 8314611: Provide more explicative error message parsing Currencies In-Reply-To: References: Message-ID: On Thu, 10 Jul 2025 15:14:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.17-oracle. > > The changes to the lib code applied clean. > In the test I resolved one chunk and replace Locale.of() which is not available in 17. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3734#pullrequestreview-3009589351 From duke at openjdk.org Fri Jul 11 10:12:53 2025 From: duke at openjdk.org (duke) Date: Fri, 11 Jul 2025 10:12:53 GMT Subject: [jdk21u-dev] RFR: 8355249: Remove the use of WMIC from the entire source code In-Reply-To: References: Message-ID: On Mon, 23 Jun 2025 01:13:51 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code > > JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported. > > Original patch does not apply cleanly because JDK-8340311 is not backported to jdk21. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java. > > I confirmed that Win8301247Test.java passes on Windows Server 2022. @kurashige23 Your change (at version 1529d21f401d19b8731df932642b24277505cf87) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1912#issuecomment-3061604445 From duke at openjdk.org Fri Jul 11 10:42:59 2025 From: duke at openjdk.org (Radek Cap) Date: Fri, 11 Jul 2025 10:42:59 GMT Subject: [jdk21u] RFR: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 14:07:39 GMT, Radek Cap wrote: > Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15 > > The IANA Functions Operator has updated the language subtag registry to "2025-05-15". > > Clean backport. > Passed tier1 tests. > > GH Actions are passing > > A local run exposed the same subset of failing jtreg tier1 tests and on the master branch. Those failures are unrelated: > > java/foreign/nested/TestNested.java: > PaddingLayout is a preview API and is disabled by default. > > compiler/escapeAnalysis/TestFindInstMemRecursion.java: > test result: Failed. Execution failed: `main' threw exception: java.awt.AWTError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable. > > // error, timeout > serviceability/sa/ClhsdbPstack.java#core > serviceability/sa/ClhsdbPstack.java#process > serviceability/sa/TestJhsdbJstackMixed.java Closed as accepted in https://github.com/openjdk/jdk21u-dev/pull/1846 ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/465#issuecomment-3061723390 From duke at openjdk.org Fri Jul 11 10:42:59 2025 From: duke at openjdk.org (Radek Cap) Date: Fri, 11 Jul 2025 10:42:59 GMT Subject: [jdk21u] Withdrawn: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 In-Reply-To: References: Message-ID: On Wed, 18 Jun 2025 14:07:39 GMT, Radek Cap wrote: > Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15 > > The IANA Functions Operator has updated the language subtag registry to "2025-05-15". > > Clean backport. > Passed tier1 tests. > > GH Actions are passing > > A local run exposed the same subset of failing jtreg tier1 tests and on the master branch. Those failures are unrelated: > > java/foreign/nested/TestNested.java: > PaddingLayout is a preview API and is disabled by default. > > compiler/escapeAnalysis/TestFindInstMemRecursion.java: > test result: Failed. Execution failed: `main' threw exception: java.awt.AWTError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable. > > // error, timeout > serviceability/sa/ClhsdbPstack.java#core > serviceability/sa/ClhsdbPstack.java#process > serviceability/sa/TestJhsdbJstackMixed.java This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/465 From duke at openjdk.org Fri Jul 11 10:47:16 2025 From: duke at openjdk.org (Radek Cap) Date: Fri, 11 Jul 2025 10:47:16 GMT Subject: [jdk21u-dev] RFR: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 In-Reply-To: References: Message-ID: <9O8VaIS0EYgnkK0uZT--b6AuUN93XWm2XH_u7YBUwMI=.5edf74c6-b7c7-493f-b997-7487b89e5063@github.com> On Thu, 5 Jun 2025 08:21:41 GMT, Goetz Lindenmaier wrote: >> Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15 >> >> The IANA Functions Operator has updated the language subtag registry to "2025-05-15". >> >> Clean backport. >> Passed tier1 tests. >> >> There are the same failures on the master branch in a local run: >> >> >> compiler/escapeAnalysis/TestFindInstMemRecursion.java: >> test result: Failed. Execution failed: `main' threw exception: java.awt.AWTError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable. >> >> serviceability/sa/ClhsdbPstack.java#core >> test result: Error. Program `/home/rcap/git/github/jdk21u-dev/build/linux-x86_64-server-release/images/jdk/bin/java' timed out (timeout set to 1920000ms, elapsed time including timeout handling was 1920178ms). >> >> serviceability/sa/ClhsdbPstack.java#process >> test result: Error. Program `/home/rcap/git/github/jdk21u-dev/build/linux-x86_64-server-release/images/jdk/bin/java' timed out (timeout set to 480000ms, elapsed time including timeout handling was 480217ms). >> >> serviceability/sa/TestJhsdbJstackMixed.java: >> test result: Error. "driver" action timed out with a timeout of 480 seconds on agent 58 >> >> java/foreign/nested/TestNested.java >> test result: Failed. Compilation failed: Compilation failed >> >> >> GH Actions are passing, Windows failures are unrelated. > > HI @RadekCap > if this gets approved for 24u, we want to get this into the July update. > Thus, in this case, we will need a PR agains jdk21u, not jdk21u-dev. > But we need to wait on the decision for 24u. > I remove the approval tag in the meantime. Please label again if it get's denied for 24u (or does not make the July update). > If it makes the July update of 24u, please open a PR agains jdk21u and label jdk21u-critical-request. @GoeLin Hi, please review 21u PR if you have time, so we can include it in the following CPU release: https://github.com/openjdk/jdk21u/pull/465 Thank you. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1846#issuecomment-2984517717 From duke at openjdk.org Fri Jul 11 10:48:53 2025 From: duke at openjdk.org (duke) Date: Fri, 11 Jul 2025 10:48:53 GMT Subject: [jdk21u-dev] RFR: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 In-Reply-To: References: Message-ID: <6CrEJkC2SYmhh0DIzifuxw3vuvkWYw0z4OQJvfM3TqM=.0f072c5e-72e3-41e9-83da-1af476aef22c@github.com> On Wed, 4 Jun 2025 10:06:23 GMT, Radek Cap wrote: > Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15 > > The IANA Functions Operator has updated the language subtag registry to "2025-05-15". > > Clean backport. > Passed tier1 tests. > > There are the same failures on the master branch in a local run: > > > compiler/escapeAnalysis/TestFindInstMemRecursion.java: > test result: Failed. Execution failed: `main' threw exception: java.awt.AWTError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable. > > serviceability/sa/ClhsdbPstack.java#core > test result: Error. Program `/home/rcap/git/github/jdk21u-dev/build/linux-x86_64-server-release/images/jdk/bin/java' timed out (timeout set to 1920000ms, elapsed time including timeout handling was 1920178ms). > > serviceability/sa/ClhsdbPstack.java#process > test result: Error. Program `/home/rcap/git/github/jdk21u-dev/build/linux-x86_64-server-release/images/jdk/bin/java' timed out (timeout set to 480000ms, elapsed time including timeout handling was 480217ms). > > serviceability/sa/TestJhsdbJstackMixed.java: > test result: Error. "driver" action timed out with a timeout of 480 seconds on agent 58 > > java/foreign/nested/TestNested.java > test result: Failed. Compilation failed: Compilation failed > > > GH Actions are passing, Windows failures are unrelated. @RadekCap Your change (at version 0e02b81045a8a5f84984d75887dba3b412ab25be) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1846#issuecomment-3061760224 From goetz at openjdk.org Fri Jul 11 10:49:06 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 10:49:06 GMT Subject: [jdk17u-dev] RFR: 8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.17-oracle. > > Omitted the test file that came with generational zgc. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add lost changes to test ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/3724/files - new: https://git.openjdk.org/jdk17u-dev/pull/3724/files/c94d4c3d..a334faef Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3724&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3724&range=00-01 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3724.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3724/head:pull/3724 PR: https://git.openjdk.org/jdk17u-dev/pull/3724 From mbaesken at openjdk.org Fri Jul 11 10:49:06 2025 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 11 Jul 2025 10:49:06 GMT Subject: [jdk17u-dev] RFR: 8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages [v2] In-Reply-To: References: Message-ID: <5nA8sTKObLFsFoAiJJrDvEFuqIEJfmZGuz4Up5ESfy0=.d3f54a6f-8d4c-4430-86b4-e34911ee6353@github.com> On Fri, 11 Jul 2025 10:45:19 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.17-oracle. >> >> Omitted the test file that came with generational zgc. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Add lost changes to test Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/3724#pullrequestreview-3009728588 From goetz at openjdk.org Fri Jul 11 10:49:07 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 10:49:07 GMT Subject: [jdk17u-dev] RFR: 8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages [v2] In-Reply-To: References: Message-ID: On Fri, 11 Jul 2025 09:46:22 GMT, Matthias Baesken wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Add lost changes to test > > test/hotspot/jtreg/gc/z/TestAllocateHeapAt.java is also in 17 (and was changed in 21) why is it not in? Hi @MBaesken thanks for catching this! I added the missing edits. I also reran the test, it passes. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3724#issuecomment-3061721548 From goetz at openjdk.org Fri Jul 11 12:47:41 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 12:47:41 GMT Subject: [jdk17u-dev] RFR: 8316580: HttpClient with StructuredTaskScope does not close when a task fails [v2] In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 15:40:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.17-oracle. >> >> The change applies clean, but the test does not work out-of-the-box. >> >> It calls some utility methods ReferenceTracker.java that were added by JDK-8305847. >> That change is not in the current list of backports, so I added the utility methods >> to this change. >> >> Further, the test depends on the fact that in 21 a row of classes implement >> AutoClosable, which they don't do in 21. >> I adapted a row of places to work around this. >> A try-with-resources statement was easy to replace, as the missing >> close() implementation uses public methods, so that I could copy the >> code to the test. >> In TestTaskScope I replaced close() by shutdownNow(). >> Finally I removed the "useReferenceTracker=false" test variant, as the >> HttpClient implementation is quite far off of the implementation in 21. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > more graceful close() implementation Hi @dfuch, @wxiao @djelinski Could you please have a look at this backport? It seems I have missed something. The problem I describe on the comment above sounds a lot as if the original problem, not decrementing the refcount, still exists. Obviously this backport is tricky as 17 lacks the virtual threads... I would appreciate your help. (I guessed the github name of you, Weibing Xiao. Maybe it works.) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3706#issuecomment-3062200741 From goetz at openjdk.org Fri Jul 11 13:29:36 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 13:29:36 GMT Subject: [jdk17u-dev] RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation Message-ID: I backport this for parity with 17.0.17-oracle. src/java.base/share/conf/security/java.security Resolved due to context. src/java.naming/share/classes/com/sun/jndi/ldap/LdapReferralContext.java Resolved Copyright ------------- Commit messages: - Backport d37ce4cdd18afc4facf996598f79e72aae68f4ff Changes: https://git.openjdk.org/jdk17u-dev/pull/3738/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3738&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290368 Stats: 1566 lines in 22 files changed: 1211 ins; 303 del; 52 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3738.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3738/head:pull/3738 PR: https://git.openjdk.org/jdk17u-dev/pull/3738 From goetz at openjdk.org Fri Jul 11 13:46:50 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 13:46:50 GMT Subject: [jdk21u-dev] RFR: 8343804: Show the default time zone with -XshowSettings option Message-ID: I backport this for parity with 17.0.17-oracle. In the test, I had to resolve the @bug line. Also I omitted the edit of one test function that was added in 22. ------------- Commit messages: - Backport 0329855831102a48abf14b5befc933f84dfd3460 Changes: https://git.openjdk.org/jdk21u-dev/pull/1962/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1962&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343804 Stats: 7 lines in 2 files changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1962.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1962/head:pull/1962 PR: https://git.openjdk.org/jdk21u-dev/pull/1962 From goetz at openjdk.org Fri Jul 11 13:57:16 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 13:57:16 GMT Subject: [jdk17u-dev] RFR: 8343804: Show the default time zone with -XshowSettings option Message-ID: I backport this for parity with 17.0.17-oracle. Same edits as in 21 backport. I will make it reference the 21 commit once available, the it should be clean. ------------- Commit messages: - Backport 0329855831102a48abf14b5befc933f84dfd3460 Changes: https://git.openjdk.org/jdk17u-dev/pull/3739/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3739&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343804 Stats: 8 lines in 2 files changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3739.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3739/head:pull/3739 PR: https://git.openjdk.org/jdk17u-dev/pull/3739 From goetz at openjdk.org Fri Jul 11 14:06:56 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:06:56 GMT Subject: [jdk21u-dev] RFR: 8353662: Add test for non-local file URL fallback to FTP Message-ID: <8mmLNbDNZG21YyZKzve7T0huHh1Jix67nwJ4q_RidbI=.718af5ce-8f10-4723-aac3-8f5171ef7c6e@github.com> I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport cae7a206a2f4b47d6757408d62b88be060113ad5 Changes: https://git.openjdk.org/jdk21u-dev/pull/1963/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1963&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353662 Stats: 145 lines in 1 file changed: 145 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1963.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1963/head:pull/1963 PR: https://git.openjdk.org/jdk21u-dev/pull/1963 From goetz at openjdk.org Fri Jul 11 14:08:23 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:08:23 GMT Subject: [jdk17u-dev] RFR: 8353662: Add test for non-local file URL fallback to FTP Message-ID: <31E_mpwC0z2EIUTmtoVJF8zopFDxqWs8FQOIoZk5H0g=.77222302-d177-4ecd-bc7c-132e80347d60@github.com> I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport cae7a206a2f4b47d6757408d62b88be060113ad5 Changes: https://git.openjdk.org/jdk17u-dev/pull/3740/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3740&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353662 Stats: 145 lines in 1 file changed: 145 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3740.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3740/head:pull/3740 PR: https://git.openjdk.org/jdk17u-dev/pull/3740 From goetz at openjdk.org Fri Jul 11 14:12:48 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:12:48 GMT Subject: [jdk21u-dev] RFR: 8354327: Rewrite runtime/LoadClass/LoadClassNegative.java Message-ID: I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport a2f9c248447d2840d191366cead1ba474ed9a15a Changes: https://git.openjdk.org/jdk21u-dev/pull/1964/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1964&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8354327 Stats: 10 lines in 2 files changed: 7 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1964.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1964/head:pull/1964 PR: https://git.openjdk.org/jdk21u-dev/pull/1964 From goetz at openjdk.org Fri Jul 11 14:13:54 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:13:54 GMT Subject: [jdk17u-dev] RFR: 8354327: Rewrite runtime/LoadClass/LoadClassNegative.java Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport a2f9c248447d2840d191366cead1ba474ed9a15a Changes: https://git.openjdk.org/jdk17u-dev/pull/3741/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3741&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8354327 Stats: 10 lines in 2 files changed: 7 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3741.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3741/head:pull/3741 PR: https://git.openjdk.org/jdk17u-dev/pull/3741 From goetz at openjdk.org Fri Jul 11 14:19:06 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:19:06 GMT Subject: [jdk21u-dev] RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests Message-ID: I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport 2785570f5620db08c0d31cd29839f92ffabd58b2 Changes: https://git.openjdk.org/jdk21u-dev/pull/1965/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1965&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355366 Stats: 63 lines in 3 files changed: 27 ins; 24 del; 12 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1965.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1965/head:pull/1965 PR: https://git.openjdk.org/jdk21u-dev/pull/1965 From goetz at openjdk.org Fri Jul 11 14:21:15 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:21:15 GMT Subject: [jdk17u-dev] RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 2785570f5620db08c0d31cd29839f92ffabd58b2 Changes: https://git.openjdk.org/jdk17u-dev/pull/3742/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3742&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355366 Stats: 63 lines in 3 files changed: 27 ins; 24 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3742.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3742/head:pull/3742 PR: https://git.openjdk.org/jdk17u-dev/pull/3742 From goetz at openjdk.org Fri Jul 11 14:48:21 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:48:21 GMT Subject: [jdk17u-dev] RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport bd7561c315e8fd80e32cb154998bd28745c98682 Changes: https://git.openjdk.org/jdk17u-dev/pull/3743/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3743&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355441 Stats: 10 lines in 1 file changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3743.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3743/head:pull/3743 PR: https://git.openjdk.org/jdk17u-dev/pull/3743 From goetz at openjdk.org Fri Jul 11 14:49:16 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:49:16 GMT Subject: [jdk21u-dev] RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc Message-ID: I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport bd7561c315e8fd80e32cb154998bd28745c98682 Changes: https://git.openjdk.org/jdk21u-dev/pull/1966/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1966&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355441 Stats: 10 lines in 1 file changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1966.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1966/head:pull/1966 PR: https://git.openjdk.org/jdk21u-dev/pull/1966 From goetz at openjdk.org Fri Jul 11 14:50:51 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:50:51 GMT Subject: [jdk17u-dev] RFR: 8351884: Refactor bug8033699.java test code Message-ID: I backport this for parity with 17.0.17-oracle. ------------- Commit messages: - Backport 482538b100856afe2252395d47e576e6c6d885ce Changes: https://git.openjdk.org/jdk17u-dev/pull/3744/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3744&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8351884 Stats: 89 lines in 1 file changed: 37 ins; 3 del; 49 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/3744.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3744/head:pull/3744 PR: https://git.openjdk.org/jdk17u-dev/pull/3744 From goetz at openjdk.org Fri Jul 11 14:51:50 2025 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Jul 2025 14:51:50 GMT Subject: [jdk21u-dev] RFR: 8351884: Refactor bug8033699.java test code Message-ID: <8OsdkfK7l0OvA43o1UKBIs02KwwpF8YyW_wP8BKTOvQ=.bfd4ef36-c02c-4f35-ac4d-6af602cff0f7@github.com> I backport this for parity with 21.0.9-oracle ------------- Commit messages: - Backport 482538b100856afe2252395d47e576e6c6d885ce Changes: https://git.openjdk.org/jdk21u-dev/pull/1967/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=1967&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8351884 Stats: 89 lines in 1 file changed: 37 ins; 3 del; 49 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/1967.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/1967/head:pull/1967 PR: https://git.openjdk.org/jdk21u-dev/pull/1967 From duke at openjdk.org Fri Jul 11 15:34:43 2025 From: duke at openjdk.org (duke) Date: Fri, 11 Jul 2025 15:34:43 GMT Subject: [jdk25u] RFR: 8361532: RISC-V: Several vector tests fail after JDK-8354383 In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 06:03:52 GMT, Dingli Zhang wrote: > Hi all, > > This pull request contains a backport of commit [e0245682](https://github.com/openjdk/jdk/commit/e0245682c8d5a0daae055045c81248c12fb23c09) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Dingli Zhang on 9 Jul 2025 and was reviewed by Fei Yang, Feilong Jiang and Gui Cao. > > Thanks @DingliZhang Your change (at version 5fc82bd80e9f44a6d4d3f03b8b15c84d7aef1d17) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/15#issuecomment-3062757308 From duke at openjdk.org Fri Jul 11 15:35:39 2025 From: duke at openjdk.org (duke) Date: Fri, 11 Jul 2025 15:35:39 GMT Subject: [jdk25u] RFR: 8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb In-Reply-To: References: Message-ID: On Fri, 11 Jul 2025 02:47:40 GMT, Dingli Zhang wrote: > Hi all, > > This pull request contains a backport of commit [2e7e272d](https://github.com/openjdk/jdk/commit/2e7e272d7b5273bae8684095bcda2a9c8bd21dc8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Dingli Zhang on 11 Jul 2025 and was reviewed by Fei Yang and Feilong Jiang. > > Thanks! @DingliZhang Your change (at version 58158dba2d6656160e7c823b2acdfae1887c8a73) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/17#issuecomment-3062758007 From duke at openjdk.org Fri Jul 11 15:38:46 2025 From: duke at openjdk.org (Shruthi) Date: Fri, 11 Jul 2025 15:38:46 GMT Subject: [jdk17u-dev] RFR: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl [v2] In-Reply-To: <9e8-0G68kJJ5VcI3t4cGab0g6MK7W4NAmAuPw5uYdtw=.6230fc23-3d20-42b4-8ede-b1fb5236dc92@github.com> References: <9e8-0G68kJJ5VcI3t4cGab0g6MK7W4NAmAuPw5uYdtw=.6230fc23-3d20-42b4-8ede-b1fb5236dc92@github.com> Message-ID: On Wed, 2 Jul 2025 09:44:14 GMT, Galder Zamarre?o wrote: >> Shruthi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into backport-d667895 >> - Backport d6678952a6de4e5435dab65e7029021832454857 >> >> Signed-off-by: Shruthi > > The changes look fine to me. The changes that were originally `UnixFileDispatcherImpl.[java/c]` align with the ones in `FileDispatcherImpl.[java/c]`. > > What testing have you done to validate the changes? Once that is explained and validated I'll approve. @galderz I was able to create a successful AIX local build with this patch. Also, I ran the `jdk_net` and `jdk_nio` jtreg tests, and all are passing **`jdk_net`** test result TEST TARGETS SUMMARY 19:31:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 19:31:13 PASSED test targets: 19:31:13 jdk_net_0 - Test results: passed: 805 19:31:13 jdk_net_1 - Test results: passed: 805 19:31:13 19:31:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 19:31:13 19:31:13 TESTCASES RESULTS SUMMARY: passed: 1,610; failed: 0; error: 0; skipped: 0 19:31:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 19:31:13 ALL TESTS PASSED **`jdk_nio`** test result 15:01:19 15:01:19 TEST TARGETS SUMMARY 15:01:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 15:01:19 PASSED test targets: 15:01:19 jdk_nio_0 - Test results: passed: 431 15:01:19 jdk_nio_1 - Test results: passed: 431 15:01:19 15:01:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 15:01:19 15:01:19 TESTCASES RESULTS SUMMARY: passed: 862; failed: 0; error: 0; skipped: 0 15:01:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 15:01:19 ALL TESTS PASSED ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3631#issuecomment-3062770152 From duke at openjdk.org Fri Jul 11 15:59:45 2025 From: duke at openjdk.org (Daniel Huang) Date: Fri, 11 Jul 2025 15:59:45 GMT Subject: [jdk17u-dev] Integrated: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 16:15:48 GMT, Daniel Huang wrote: > Backport for RandomSupport issue. There is a loss of information when using `convertSeedBytesToInts()` with a bad seed, causing a lot of the original bytes to be overwritten by 1s. The fix involves using a bitwise AND with the seed before distributing the seed bytes into the result. > > Clean backport, ran GHA sanity checks and locally tested tier1, tier2. In tier2, there was 1 failure: > `test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java` > However, this fails on master as well. > > The backport also updates the test `T8282144.java` to test for ints as well, which passes. This pull request has now been integrated. Changeset: d9fa9cf8 Author: Daniel Huang Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/d9fa9cf83979d91845f238e19dc3438972be59ee Stats: 41 lines in 2 files changed: 39 ins; 0 del; 2 mod 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport Backport-of: 5a9cd33632862aa2249794902d4168a7fe143054 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/3722 From sparasa at openjdk.org Fri Jul 11 17:15:40 2025 From: sparasa at openjdk.org (Srinivas Vamsi Parasa) Date: Fri, 11 Jul 2025 17:15:40 GMT Subject: [jdk25u] RFR: 8360775: Fix Shenandoah GC test failures when APX is enabled In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 05:45:26 GMT, Srinivas Vamsi Parasa wrote: > Hello Everyone, > > This pull request contains a backport of commit [1c560727](https://github.com/openjdk/jdk/commit/1c560727b850593561982ccc3ed37b0e98b3bbee) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This is a P3 bug which fixes issue with shenandoah tests when APX is used. > > The commit being backported was authored by Srinivas Vamsi Parasa on 4 Jul 2025 and was reviewed by Sandhya Viswanathan, Jatin Bhateja and Emanuel Peter. > > Thanks! Created this PR by mistake. The original intention was to backport to jdk25 (not jdk25u). Sorry for the inconvenience caused! ------------- PR Comment: https://git.openjdk.org/jdk25u/pull/14#issuecomment-3063101141 From sparasa at openjdk.org Fri Jul 11 17:15:40 2025 From: sparasa at openjdk.org (Srinivas Vamsi Parasa) Date: Fri, 11 Jul 2025 17:15:40 GMT Subject: [jdk25u] Withdrawn: 8360775: Fix Shenandoah GC test failures when APX is enabled In-Reply-To: References: Message-ID: <-Q6u1_j4ZtUYoftvRR9P98OeoOQl2uYrSxxDPqqPG44=.225fd663-168d-48f7-82e7-e9f822535d7f@github.com> On Wed, 9 Jul 2025 05:45:26 GMT, Srinivas Vamsi Parasa wrote: > Hello Everyone, > > This pull request contains a backport of commit [1c560727](https://github.com/openjdk/jdk/commit/1c560727b850593561982ccc3ed37b0e98b3bbee) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This is a P3 bug which fixes issue with shenandoah tests when APX is used. > > The commit being backported was authored by Srinivas Vamsi Parasa on 4 Jul 2025 and was reviewed by Sandhya Viswanathan, Jatin Bhateja and Emanuel Peter. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk25u/pull/14 From ssubramaniam at openjdk.org Fri Jul 11 17:37:33 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Fri, 11 Jul 2025 17:37:33 GMT Subject: [jdk11u-dev] RFR: 8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest Message-ID: <6BTFZxDrWeJigcnh17pkA8gYsa1CogVldwG1-ZedvH8=.26a90d13-10b2-4612-b983-3f57bd1fae2d@github.com> Backporting JDK-8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest. Adjusting test to be compatible with ZGC by slightly shortening output string check. Also cleaning up test by removing redundant "gc=debug". Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean. ------------- Commit messages: - Backport db89b5fdf9f1dca06ba569dbf61e15f637a4367b Changes: https://git.openjdk.org/jdk11u-dev/pull/3060/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3060&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8231943 Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3060.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3060/head:pull/3060 PR: https://git.openjdk.org/jdk11u-dev/pull/3060 From robm at openjdk.org Fri Jul 11 19:14:24 2025 From: robm at openjdk.org (Rob McKenna) Date: Fri, 11 Jul 2025 19:14:24 GMT Subject: [jdk25u] RFR: Merge jdk:jdk25 Message-ID: <4-Fmdd0MVpye5TI7UDYhRMbBwrW8ZCLVb8GSL33nXNA=.4ff75567-147d-4421-b495-6966814251d1@github.com> Merge ------------- Commit messages: - Merge remote-tracking branch 'jdk/jdk25' into Merge-2025-07-11 - 8358183: [JVMCI] crash accessing nmethod::jvmci_name in CodeCache::aggregate - 8361447: [REDO] Checked version of JNI ReleaseArrayElements needs to filter out known wrapped arrays - 8357976: GenShen crash in swap_card_tables: Should be clean - 8360942: [ubsan] aotCache tests trigger runtime error: applying non-zero offset 16 to null pointer in CodeBlob::relocation_end() - 8360312: Serviceability Agent tests fail with JFR enabled due to unknown thread type JfrRecorderThread - 8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification - 8360599: [TESTBUG] DumpThreadsWithEliminatedLock.java fails because of unstable inlining - 8361175: JFR: Document differences between method sample events - 8361570: Incorrect 'sealed is not allowed here' compile-time error - ... and 63 more: https://git.openjdk.org/jdk25u/compare/5500a2d1...a423b108 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk25u&pr=18&range=00.0 - jdk:jdk25: https://webrevs.openjdk.org/?repo=jdk25u&pr=18&range=00.1 Changes: https://git.openjdk.org/jdk25u/pull/18/files Stats: 7881 lines in 272 files changed: 6409 ins; 510 del; 962 mod Patch: https://git.openjdk.org/jdk25u/pull/18.diff Fetch: git fetch https://git.openjdk.org/jdk25u.git pull/18/head:pull/18 PR: https://git.openjdk.org/jdk25u/pull/18 From robm at openjdk.org Fri Jul 11 19:20:34 2025 From: robm at openjdk.org (Rob McKenna) Date: Fri, 11 Jul 2025 19:20:34 GMT Subject: [jdk25u] RFR: Merge jdk:jdk25 [v2] In-Reply-To: <4-Fmdd0MVpye5TI7UDYhRMbBwrW8ZCLVb8GSL33nXNA=.4ff75567-147d-4421-b495-6966814251d1@github.com> References: <4-Fmdd0MVpye5TI7UDYhRMbBwrW8ZCLVb8GSL33nXNA=.4ff75567-147d-4421-b495-6966814251d1@github.com> Message-ID: > Merge Rob McKenna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - Merge remote-tracking branch 'jdk/jdk25' into Merge-2025-07-11 - 8357826: Avoid running some jtreg tests when asan is configured Backport-of: d7aa34982053bad37b3b726539f1245d054258f4 - 8358577: Test serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java failed: unexpexcted monitor object Backport-of: 8f487d26c0f219d4df32be48ff1790e6f98d74a0 - 8360533: ContainerRuntimeVersionTestUtils fromVersionString fails with some docker versions Backport-of: 97ec9d3e0a6e3455579b567e1f58026f5b168c09 - 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119) Backport-of: 2103dc15cb662fd8795b1b51d9cb61c389bed7a0 - 8359270: C2: alignment check should consider base offset when emitting arraycopy runtime call Backport-of: 6b4393917ae689818d67fcaf9cc61ca16ea6d426 - 8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given Backport-of: 3525a40f39a966b8592f694a9b3cd4c5dc449266 - 8360179: RISC-V: Only enable BigInteger intrinsics when AvoidUnalignedAccess == false Backport-of: 34412da52b41e9374168e67e3b6129576c8e4402 - 8359218: RISC-V: Only enable CRC32 intrinsic when AvoidUnalignedAccess == false Backport-of: 65e63b6ab4241fc9d683e2ffa5bfe6e1a30059b6 - 8359059: Bump version numbers for 25.0.1 Reviewed-by: iris ------------- Changes: - all: https://git.openjdk.org/jdk25u/pull/18/files - new: https://git.openjdk.org/jdk25u/pull/18/files/a423b108..a423b108 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk25u&pr=18&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk25u&pr=18&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk25u/pull/18.diff Fetch: git fetch https://git.openjdk.org/jdk25u.git pull/18/head:pull/18 PR: https://git.openjdk.org/jdk25u/pull/18 From robm at openjdk.org Fri Jul 11 19:20:35 2025 From: robm at openjdk.org (Rob McKenna) Date: Fri, 11 Jul 2025 19:20:35 GMT Subject: [jdk25u] Integrated: Merge jdk:jdk25 In-Reply-To: <4-Fmdd0MVpye5TI7UDYhRMbBwrW8ZCLVb8GSL33nXNA=.4ff75567-147d-4421-b495-6966814251d1@github.com> References: <4-Fmdd0MVpye5TI7UDYhRMbBwrW8ZCLVb8GSL33nXNA=.4ff75567-147d-4421-b495-6966814251d1@github.com> Message-ID: On Fri, 11 Jul 2025 19:09:24 GMT, Rob McKenna wrote: > Merge This pull request has now been integrated. Changeset: 8229274b Author: Rob McKenna URL: https://git.openjdk.org/jdk25u/commit/8229274b2d73a90c1ec6bd04762b90070a368f59 Stats: 7881 lines in 272 files changed: 6409 ins; 510 del; 962 mod Merge ------------- PR: https://git.openjdk.org/jdk25u/pull/18 From tkurashige at openjdk.org Fri Jul 11 19:23:47 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Fri, 11 Jul 2025 19:23:47 GMT Subject: [jdk21u-dev] Integrated: 8355249: Remove the use of WMIC from the entire source code In-Reply-To: References: Message-ID: On Mon, 23 Jun 2025 01:13:51 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code > > JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported. > > Original patch does not apply cleanly because JDK-8340311 is not backported to jdk21. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java. > > I confirmed that Win8301247Test.java passes on Windows Server 2022. This pull request has now been integrated. Changeset: b407af9c Author: Taizo Kurashige Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/b407af9c8224206164e5ad20192b8d0a539767b7 Stats: 31 lines in 4 files changed: 5 ins; 1 del; 25 mod 8355249: Remove the use of WMIC from the entire source code Reviewed-by: phh Backport-of: 4458719a108f45d3744d47a6ea081fe9ec3e675e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1912 From dzhang at openjdk.org Fri Jul 11 21:01:58 2025 From: dzhang at openjdk.org (Dingli Zhang) Date: Fri, 11 Jul 2025 21:01:58 GMT Subject: [jdk25u] Integrated: 8361532: RISC-V: Several vector tests fail after JDK-8354383 In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 06:03:52 GMT, Dingli Zhang wrote: > Hi all, > > This pull request contains a backport of commit [e0245682](https://github.com/openjdk/jdk/commit/e0245682c8d5a0daae055045c81248c12fb23c09) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Dingli Zhang on 9 Jul 2025 and was reviewed by Fei Yang, Feilong Jiang and Gui Cao. > > Thanks This pull request has now been integrated. Changeset: 05dab283 Author: Dingli Zhang Committer: Paul Hohensee URL: https://git.openjdk.org/jdk25u/commit/05dab283f2d0f99f3257db796deb2fde0073e5f8 Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod 8361532: RISC-V: Several vector tests fail after JDK-8354383 Backport-of: e0245682c8d5a0daae055045c81248c12fb23c09 ------------- PR: https://git.openjdk.org/jdk25u/pull/15 From dzhang at openjdk.org Fri Jul 11 21:02:39 2025 From: dzhang at openjdk.org (Dingli Zhang) Date: Fri, 11 Jul 2025 21:02:39 GMT Subject: [jdk25u] Integrated: 8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb In-Reply-To: References: Message-ID: <1Vsw5WOoo060p3maMn4x1_FKaLNQKTSd2qhpD97jrxY=.04aa7f77-3f76-48e8-b0fe-95463ee3944a@github.com> On Fri, 11 Jul 2025 02:47:40 GMT, Dingli Zhang wrote: > Hi all, > > This pull request contains a backport of commit [2e7e272d](https://github.com/openjdk/jdk/commit/2e7e272d7b5273bae8684095bcda2a9c8bd21dc8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Dingli Zhang on 11 Jul 2025 and was reviewed by Fei Yang and Feilong Jiang. > > Thanks! This pull request has now been integrated. Changeset: 98bc22a9 Author: Dingli Zhang Committer: Paul Hohensee URL: https://git.openjdk.org/jdk25u/commit/98bc22a969a343fcf87c0bc2a033feaa2d99d1f6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb Backport-of: 2e7e272d7b5273bae8684095bcda2a9c8bd21dc8 ------------- PR: https://git.openjdk.org/jdk25u/pull/17 From hohensee at amazon.com Fri Jul 11 21:03:17 2025 From: hohensee at amazon.com (Hohensee, Paul) Date: Fri, 11 Jul 2025 21:03:17 +0000 Subject: 2025-07 Security Update Bundles Message-ID: <10C03C51-3BD9-4716-90F6-7D213654AE82@amazon.com> Apologies, I didn't know the process. No warning that I saw. ?On 7/10/25, 2:36 AM, "Lindenmaier, Goetz" > wrote: Hi Paul, On 20.5.2025 you have removed jdk17u-fix-yes and jdk17u-fix-request labels from https://bugs.openjdk.org/browse/JDK-8320687 Why have you done this? You should not touch jdk17u-fix-yes labels!!! These are reserved to the maintainers. Now we have a broken situation with two pushes for the same change. The correct way would have been to open a [REDO] change, this is what I understood as "resubmit". Nobody could tell from your 2nd PR that this was a redo of a previous change. Please mention such things to be transparent. Actually I thought that Skara warns that the change has already been pushed to the repository. Hasn't there been such a warning? Best regards, Goetz. > -----Original Message----- > From: Andrew Hughes > > Sent: Wednesday, July 9, 2025 8:53 PM > To: Lindenmaier, Goetz > > Subject: Re: 2025-07 Security Update Bundles > > On 11:23 Wed 09 Jul , Lindenmaier, Goetz wrote: > > Hi Andrew, > > > > It seems to be working in the meantime. I saw some mails to Christoph. > > > > Best, Goetz. > > > > Thanks. I've picked up the bundles today. > > I've just been going through the changes in 17.0.16 and I found this > pair confusing: > > JDK-8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() > throws unexpected exceptions when invoked concurrently > JDK-8355914: [17u] Backout backport of JDK-8320687 > > The reason is that there are only two bugs, but three commits. From > the bugs alone, it is not clear that 8320687 was later reapplied as it > happens under the same ID and in a commit with the same summary. > > I can see why you might wanted to have avoided a "[REDO]" bug here to > retain the link to the original bug. Maybe, as it was only a failing > test, it could have just been excluded until fixed? > > The 8355914 bug says "Tonight rampdown starts" but this was in > 17.0.16+1, long before rampdown. > > Thoughts? I'm just wondering if we could have done things a little > better here, though I can understand the change was made under tight > time constraints. > > Best, > -- > Andrew :) > Pronouns: he / him or they / them > Red Hat, Inc. (http://www.redhat.com ) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > Please contact via e-mail, not proprietary chat networks From duke at openjdk.org Fri Jul 11 21:03:46 2025 From: duke at openjdk.org (Radek Cap) Date: Fri, 11 Jul 2025 21:03:46 GMT Subject: [jdk21u-dev] Integrated: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 In-Reply-To: References: Message-ID: <4QnJ83F-ntifjotiVAHQo2ZFCUa1L7Txpib2RwMDEt8=.3a1fa61f-9d99-41ff-b84f-717c581b4b0d@github.com> On Wed, 4 Jun 2025 10:06:23 GMT, Radek Cap wrote: > Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15 > > The IANA Functions Operator has updated the language subtag registry to "2025-05-15". > > Clean backport. > Passed tier1 tests. > > There are the same failures on the master branch in a local run: > > > compiler/escapeAnalysis/TestFindInstMemRecursion.java: > test result: Failed. Execution failed: `main' threw exception: java.awt.AWTError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable. > > serviceability/sa/ClhsdbPstack.java#core > test result: Error. Program `/home/rcap/git/github/jdk21u-dev/build/linux-x86_64-server-release/images/jdk/bin/java' timed out (timeout set to 1920000ms, elapsed time including timeout handling was 1920178ms). > > serviceability/sa/ClhsdbPstack.java#process > test result: Error. Program `/home/rcap/git/github/jdk21u-dev/build/linux-x86_64-server-release/images/jdk/bin/java' timed out (timeout set to 480000ms, elapsed time including timeout handling was 480217ms). > > serviceability/sa/TestJhsdbJstackMixed.java: > test result: Error. "driver" action timed out with a timeout of 480 seconds on agent 58 > > java/foreign/nested/TestNested.java > test result: Failed. Compilation failed: Compilation failed > > > GH Actions are passing, Windows failures are unrelated. This pull request has now been integrated. Changeset: 06ff0d6b Author: Radek Cap Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/06ff0d6bd232f8db9c46b2a8343b3e9dc7fd17d7 Stats: 143 lines in 2 files changed: 135 ins; 1 del; 7 mod 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 Backport-of: f318868268f32934a2f0c4e26a6c75360d8e74b1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/1846 From duke at openjdk.org Fri Jul 11 21:06:49 2025 From: duke at openjdk.org (Radek Cap) Date: Fri, 11 Jul 2025 21:06:49 GMT Subject: [jdk17u-dev] RFR: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 In-Reply-To: References: Message-ID: On Thu, 5 Jun 2025 15:36:24 GMT, Radek Cap wrote: > Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15 > > The IANA Functions Operator has updated the language subtag registry to "2025-05-15". > > Clean backport. > Passed tier1 tests. > Passed gtests. > > GH Actions are passing, Windows failures are unrelated. 21u-dev has been accepted so we can continue. 21u-dev for a reference - https://github.com/openjdk/jdk21u-dev/pull/1846 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3620#issuecomment-3063821686 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3620#issuecomment-3063823588 From phh at openjdk.org Fri Jul 11 21:07:50 2025 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 11 Jul 2025 21:07:50 GMT Subject: [jdk11u-dev] RFR: 8214972: Uses of klass_holder() except GC need to apply GC barriers In-Reply-To: References: Message-ID: <_YOuYkra8AbO-kx8uSPZx1VJaFTpa2RnqFmU-pGtkgo=.8e49a651-0c2d-410c-b8ed-21ce78693db8@github.com> On Tue, 8 Jul 2025 14:55:21 GMT, Francesco Andreuzzi wrote: > I've been working on a backport to fix [JDK-8339725](https://bugs.openjdk.org/browse/JDK-8339725). The fix attached to the ticket is not enough to fix the problem on jdk11. > > The missing backport is JDK-8214972, which I apply in this PR. JDK-8210321 is also needed to provide `ClassLoaderData::holder_no_keepalive`. > > Tier1 tests completed successfully. Thanks for the explanation and additional testing. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/3059#pullrequestreview-3011987752 From ssubramaniam at openjdk.org Fri Jul 11 21:08:00 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Fri, 11 Jul 2025 21:08:00 GMT Subject: [jdk11u-dev] RFR: 8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected" Message-ID: <8F4fVJ2TOtoUKPXG9wtGNjMn97RLtP1MnKYiTuc7oCw=.f7bf19d5-a8e2-4112-9d86-df10e56b4c5e@github.com> Backporting JDK-8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected". Adjusted test to add @ requires for GCs, fixing failure when run with GC directly. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean. ------------- Commit messages: - Backport 74500984585c1b93e91931c19d3b95f86e3085ec Changes: https://git.openjdk.org/jdk11u-dev/pull/3061/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=3061&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8247362 Stats: 24 lines in 1 file changed: 23 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/3061.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/3061/head:pull/3061 PR: https://git.openjdk.org/jdk11u-dev/pull/3061 From phh at openjdk.org Fri Jul 11 21:09:49 2025 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 11 Jul 2025 21:09:49 GMT Subject: [jdk17u-dev] RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset [v2] In-Reply-To: References: Message-ID: On Wed, 9 Jul 2025 18:08:35 GMT, Jan Kratochvil wrote: >> Multithreaded handling of ZIP files can throw an exception. >> >> This backport is far from clean. The last commit resolves the conflicts. >> >> The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is [a backward compatibility concern](https://bugs.openjdk.org/browse/JDK-8321156?focusedId=14630523&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14630523) I have not backported it. >> >> [jdk24](https://github.com/openjdk/jdk24u/pull/236), [jdk21](https://github.com/openjdk/jdk21u-dev/pull/1949), this jdk17. > > Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: > > Fix testcase compatibility with jdk17 Thank you. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/3720#pullrequestreview-3011993214