[jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v6]

[Severin Gehwolf]

On Fri, 27 Jun 2025 17:08:59 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

>> A fix for [JDK-8360816](https://bugs.openjdk.org/browse/JDK-8360816). 
>> 
>> The `ProgramFiles(x86)` environment variable is not properly propagated to JTReg tests in JDK11, which makes the AOT compiler tests fail on the new `windows-2025` GHA runners, as manifested in the backport of [https://bugs.openjdk.org/browse/JDK-8358538](JDK-8358538).  
>> 
>> Propagating this environment variable to JTRegs may require creating devkits for Windows 2022, but previous attempts were discarded [JDK-8283723](https://bugs.openjdk.org/browse/JDK-8283723). 
>> 
>> This fix prints a warning message when this environment variable is not set, and then uses a default value (`C:\Program Files (x86)`) that makes it possible to run the AOT tests with these new `windows-2025` GHA runners.  If the `ProgramFiles(x86)` env variable is set the fix has no effect, ensuring the previous behaviour. If the proposed default value is incorrect the AOT tests will continue to fail as before.
>> 
>> The PR is on top of  https://github.com/openjdk/jdk11u-dev/pull/3052 to verify the fix works as intended with the new `windows-2025` GHA runners.
>
> Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8360816: [11u] Use default value for ProgramFiles(x86) in GHA

.github/workflows/test.yml line 156:

> 154:           SYMBOLS_IMAGE_DIR=${{ steps.bundles.outputs.symbols-path }}
> 155:           TEST_IMAGE_DIR=${{ steps.bundles.outputs.tests-path }}
> 156:           JTREG='OPTIONS=-e:ProgramFiles\(x86\)=C:\\Program\ Files\ \(x86\);JAVA_OPTIONS=-XX:-CreateCoredumpOnCrash;VERBOSE=fail,error,time;KEYWORDS=!headful'

We could set a variable separately in a separate step to the right value for Windows jobs. Then we could check here if the variable is empty and only set the `-e` value when the corresponding environment is not empty. Thoughts?

See for example `Set PATH` step and the `env` clause in this `Run tests` step.

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3056#discussion_r2176968587