[jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v6]

[Antonio Vieiro]

On Tue, 1 Jul 2025 09:19:41 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8360816: [11u] Use default value for ProgramFiles(x86) in GHA
>
> .github/workflows/test.yml line 156:
> 
>> 154:           SYMBOLS_IMAGE_DIR=${{ steps.bundles.outputs.symbols-path }}
>> 155:           TEST_IMAGE_DIR=${{ steps.bundles.outputs.tests-path }}
>> 156:           JTREG='OPTIONS=-e:ProgramFiles\(x86\)=C:\\Program\ Files\ \(x86\);JAVA_OPTIONS=-XX:-CreateCoredumpOnCrash;VERBOSE=fail,error,time;KEYWORDS=!headful'
> 
> We could set a variable separately in a separate step to the right value for Windows jobs. Then we could check here if the variable is empty and only set the `-e` value when the corresponding environment is not empty. Thoughts?
> 
> See for example `Set PATH` step and the `env` clause in this `Run tests` step.

Fixed on the last commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3056#discussion_r2179504376