[jdk21u-dev] RFR: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() [v3]

[Timofei Pushkin]

On Wed, 2 Jul 2025 06:44:07 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> The original change cleaned up code of static CDS. I am backporting it as a dependency of [JDK-8315130](https://bugs.openjdk.org/browse/JDK-8315130) which I am backporting next (#1835): without this change the backport JDK-8315130 would need to include some parts of this change and would also leave some code unused.
>> 
>> Resolved conflicts:
>> - `src/hotspot/share/cds/unregisteredClasses.cpp`: bug fix [JDK-8343416](https://bugs.openjdk.org/browse/JDK-8343416) is missing in this version but the backported change itself incorporates the bug fix (to verify I checked that the backport makes [the test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) pass, but I did not include that test in this PR)
>> - `src/hotspot/share/cds/classListParser.*pp`: constant pool resolution was added there in JDK 23/24 as part of Project Layden ([JDK-8293980](https://bugs.openjdk.org/browse/JDK-8293980), [JDK-8332176](https://bugs.openjdk.org/browse/JDK-8332176)) — this required only insignificant changes to the backport
>> - The rest of the conflicts were trivial (caused by renaming, neighboring code removal, copyright year updates)
>> 
>> Testing besides the CI (performed on macos/arm64): `runtime/cds`, [test added in JDK-8343416](https://github.com/openjdk/jdk/commit/dde6230751672bde5a1bcb52686641f3a8b40cfb#diff-1db6a793c81a763792b2b6b2e80ce8a7d4d67288ea4adf9ee457c42d314698c4) (not included in the backport since that is a separate change).
>
> Timofei Pushkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'jdk-jdk21u-dev/master' into app-cds-bug-2
>  - 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class()
>    
>    Reviewed-by: ccheung, coleenp
>  - 8339460: CDS error when module is located in a directory with space in the name
>    
>    Reviewed-by: ccheung, iklam

@iklam Thank you for reviewing the main backport #1835, could you please also review this dependency of it?

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1834#issuecomment-3035022195