[jdk17u-dev] RFR: 8330535: Update nsk/jdb tests to use driver instead of othervm [v2]

[Martin Doerr]

On Mon, 7 Jul 2025 11:39:59 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 17.0.17-oracle.
>> 
>> Three adapted tests are not in 17.
>> Others don't apply clean because mostly the copyright was changed
>> in 21.  Only JdbTest needed a trivial resolve of code.
>> 
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java
>> Resolved Copyright. 21 has several virtual thread changes.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/list/list003/list003.java
>> Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/monitor/monitor001/monitor001.java
>> Resolved Copyright. 21 has a virtual thread change.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java
>> Added by new feature "8271356: Modify jdb to treat an empty command as a repeat of the previous command". Skipped.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/resume/resume002/resume002.java
>> Resolved Copyright because "8284191: Replace usages of 'a the' in hotspot and java.base" is not in 17.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/threadgroup/threadgroup002/threadgroup002.java
>> Resolved Copyright because new feature "8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default" was added in 19.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads002/threads002.java
>> Resolved Copyright because 21 has virtual thread changes.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads003/threads003.java
>> Was added by virtual threads change. Skipped.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/trace/trace001/trace001.java
>> Resolved Copyright because 21 has virtual thread changes.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/unmonitor/unmonitor001/unmonitor001.java
>> Resolved Copyright because 21 has virtual thread changes.
>> 
>> test/hotspot/jtreg/vmTestbase/nsk/share/jdb/JdbTest.java
>> Resolved one chunk due to context because 21 has changes as "8332641: Update nsk.share.jpda.Jdb to don't use finalization"
>
> Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport 4417c276e484c1fe137ed7f4a7c28709d0c99af2

Thanks for the detailed description! LGTM.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/3709#pullrequestreview-2996781207