[jdk17u-dev] RFR: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl [v2]
Shruthi
duke at openjdk.org
Fri Jul 11 15:38:46 UTC 2025
On Wed, 2 Jul 2025 09:44:14 GMT, Galder Zamarreño <galder at openjdk.org> wrote:
>> Shruthi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into backport-d667895
>> - Backport d6678952a6de4e5435dab65e7029021832454857
>>
>> Signed-off-by: Shruthi <Shruthi.Shruthi1 at ibm.com>
>
> The changes look fine to me. The changes that were originally `UnixFileDispatcherImpl.[java/c]` align with the ones in `FileDispatcherImpl.[java/c]`.
>
> What testing have you done to validate the changes? Once that is explained and validated I'll approve.
@galderz
I was able to create a successful AIX local build with this patch. Also, I ran the `jdk_net` and `jdk_nio` jtreg tests, and all are passing
**`jdk_net`** test result
TEST TARGETS SUMMARY
19:31:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
19:31:13 PASSED test targets:
19:31:13 jdk_net_0 - Test results: passed: 805
19:31:13 jdk_net_1 - Test results: passed: 805
19:31:13
19:31:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
19:31:13
19:31:13 TESTCASES RESULTS SUMMARY: passed: 1,610; failed: 0; error: 0; skipped: 0
19:31:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
19:31:13 ALL TESTS PASSED
**`jdk_nio`** test result
15:01:19
15:01:19 TEST TARGETS SUMMARY
15:01:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
15:01:19 PASSED test targets:
15:01:19 jdk_nio_0 - Test results: passed: 431
15:01:19 jdk_nio_1 - Test results: passed: 431
15:01:19
15:01:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
15:01:19
15:01:19 TESTCASES RESULTS SUMMARY: passed: 862; failed: 0; error: 0; skipped: 0
15:01:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
15:01:19 ALL TESTS PASSED
-------------
PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3631#issuecomment-3062770152
More information about the jdk-updates-dev
mailing list