[jdk11u-dev] RFR: 8348597: Update HarfBuzz to 10.4.0 [v3]

[Andrew John Hughes]

On Tue, 20 May 2025 09:43:38 GMT, Antonio Vieiro <avieiro at openjdk.org> wrote:

>> Backport of [JDK-8348597](https://bugs.openjdk.org/browse/JDK-8348597) from JDK17 that updates HarfBuzz to 10.4.0 (which [improves drawing performande by 10+% and includes different build fixes](https://newreleases.io/project/github/harfbuzz/harfbuzz/release/10.4.0)). Backport is not clean because it required adapting `make/lib/Awt2dLibraries.gmk` to fit JDK11.
>> 
>> Even though the backport built correctly, the resulting `jdk/lib/libfontmanager.so` contained undefined symbols that caused Swing tests to fail with `UnsatisfiedLinkError`. This is because JDK11 is missing [JDK-8319197](https://bugs.openjdk.org/browse/JDK-8319197) that excludes hb-subset from compilation, so this is also included as the second commit in the pull request.
>> 
>> While at it, a third commit adds an additional `-Wno-attributes` flag to `HARFBUZZ_DISABLED_WARNINGS_CXX_gcc`, restoring the capability to build JDK11 on Linux with `gcc-4.8.5`  (this is an old version of gcc, dating from 2015, but it's still the system gcc version in RHEL-7).
>> 
>> Tested 
>> 
>> - on Windows 10 with `jdk:jfc_demo`. 
>> - on Linux with `jdk:jfc_demo`, with 
>>     - `gcc 4.8.5/harfbuzz-1.7.5 (x86_64 & s390x)`, 
>>     - `gcc 8.5.0/harfbuzz-1.7.5 (x86_64)`, 
>>     - `gcc 11.5.0/harfbuzz-2.7.4 (x86_64)` 
>>     - and `gcc 14.2.1/harfbuzz-9.0.0 (x86_64)`
>> 
>> with both `--with-harfbuzz=system` and `--with-harfbuzz=bundled`.
>
> Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rearrange Awt2dLibraries.gmk as per review

This version looks a lot better. I would add comments on the other two flags being added though; I don't see anything in the patch to tell us why `attributes` and `dangling-reference` are being added.

Is `calloc-transposed-args` needed on later JDKs? If not, why not?

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/3026#pullrequestreview-3062978385