[jdk17u-dev] RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v4]

Goetz Lindenmaier goetz at openjdk.org
Wed Jul 30 10:32:05 UTC 2025


On Wed, 30 Jul 2025 10:28:25 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 17.0.17-oracle based on the push to 21.
>> 
>> Resolved Coipyright in src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java
>> 
>> I had to adapt the test as it again depends on AutoClosable of HttpClient.
>> Here it seems ok to just not shut down the Client as it is done in other tests.
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Run test standalone

Our nighttests showed 


STARTED    H2GoAwayTest::testUnprocessedRaisesException 'testUnprocessedRaisesException()'
java.lang.SecurityException: access denied ("java.net.URLPermission" "https://127.0.0.1:55295/test" "HEAD:")
	at java.net.http/jdk.internal.net.http.HttpClientImpl.send(HttpClientImpl.java:892)
	at java.net.http/jdk.internal.net.http.HttpClientFacade.send(HttpClientFacade.java:133)
	at H2GoAwayTest.testUnprocessedRaisesException(H2GoAwayTest.java:173)

Locally, the test passes. I assume this is a inference with other tests, as we can not shutdown the HttpClient in 17.  Other, similar tests all run in othervm mode.  Adding othervm mode fixes the issue in our nightly tests.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3783#issuecomment-3135722417


More information about the jdk-updates-dev mailing list