[jdk21u-dev] RFR: 8358538: Update GHA Windows runner to 2025

[Andrew John Hughes]

On Thu, 5 Jun 2025 08:06:05 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Of course there are build failures. And of course they are confusing:
> 
> ```
> === Output from failing command(s) repeated here ===
> * For target hotspot_variant-server_libjvm_gtest_objs_test_enableIf.obj:
> test_enableIf.cpp
> d:\a\jdk21u-dev\jdk21u-dev\test\hotspot\gtest\metaprogramming\test_enableIf.cpp(74): error C2244: 'TestEnableIfNested<T>::sub1': unable to match function definition to an existing declaration
> d:\a\jdk21u-dev\jdk21u-dev\test\hotspot\gtest\metaprogramming\test_enableIf.cpp(74): note: see declaration of 'TestEnableIfNested<T>::sub1'
> d:\a\jdk21u-dev\jdk21u-dev\test\hotspot\gtest\metaprogramming\test_enableIf.cpp(74): note: definition
> d:\a\jdk21u-dev\jdk21u-dev\test\hotspot\gtest\metaprogramming\test_enableIf.cpp(74): note: 'U TestEnableIfNested<T>::sub1(U)'
> d:\a\jdk21u-dev\jdk21u-dev\test\hotspot\gtest\metaprogramming\test_enableIf.cpp(74): note: existing declarations
> d:\a\jdk21u-dev\jdk21u-dev\test\hotspot\gtest\metaprogramming\test_enableIf.cpp(69): note: 'U TestEnableIfNested<T>::sub1(U)'
> ```
> 
> Exactly the same code compiles fine in mainline...

The one difference I see between the 21u and trunk version is the lack of `precompiled.hpp` in trunk, as it is specified on the command line instead ([JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909)).

It might be worth trying 24u and seeing if it fails in the same way, though not worth fixing this there at this point in its lifecycle.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1853#issuecomment-2945973827