[jdk21u-dev] Integrated: 8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp

[Satyen Subramaniam]

On Wed, 4 Jun 2025 17:12:55 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote:

> Backporting JDK-8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp. HotSpot VM build macro only defines _WINDOWS env variable (not WINDOWS). `call_clobbered_gp_registers()` and `call_clobbered_xmm_registers()` use the wrong variable name. Leads to RSI and RDI missing from list of clobbered register on windows, and may cause issue when calling native code which modifies them. Ran GHA Sanity Checks and local Tier 1 and 2 (though not on a Windows machine). Patch is clean.

This pull request has now been integrated.

Changeset: 5cc193f9
Author:    Satyen Subramaniam <ssubramaniam at openjdk.org>
URL:       https://git.openjdk.org/jdk21u-dev/commit/5cc193f93d44cb966a4479d91ed467c1a22c43cf
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp

Backport-of: 0e1c1b793d43064aabe9571057284899c9580f30

-------------

PR: https://git.openjdk.org/jdk21u-dev/pull/1848