[jdk21u-dev] RFR: 8353655: Clean up and open source KeyEvent related tests (Part 1)

Goetz Lindenmaier goetz at openjdk.org
Thu Jun 12 16:42:28 UTC 2025


On Thu, 12 Jun 2025 16:19:21 GMT, Bara' Hasheesh <duke at openjdk.org> wrote:

>> Hi @Baraa-Hasheesh 
>> Did you run these tests manually?  Running tier1 is pointless, this does not include the new tests.
>
> Hello @GoeLin 
> The tests locally are skipped for me as I don't have the proper input devices that are needed to run them

Hi @Baraa-Hasheesh 
Please, it's essential that you run tests that come with a backport.
This is only a test change, so it's not critical. But you should at least make sure the test compiles.  It might be implemented with latest Java and not compile with Java 21.  We have seen a row of pushes with this problem.  No big issue if it is only a test, but undermines trust in the backportee!
I ran them. I don't have a french keyboard either, but at least the test comes up similar to the test in jdk head.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1862#issuecomment-2967530705


More information about the jdk-updates-dev mailing list