[jdk17u-dev] Integrated: 8312475: org.jline.util.PumpReader signed byte problem

[Bara' Hasheesh]

On Tue, 29 Apr 2025 07:10:57 GMT, Bara' Hasheesh <duke at openjdk.org> wrote:

> Clean Backport JDK-8312475: SonarCloud reports a possible issue in `read` method
> 
> * `buffer.get()` reads a signed byte so it has a range of -128-127
> * When end of file is reached the read method returns -1 signed integer
> 
> When the `buffer.get()` reads -1 => it returns 0xFF as a signed byte value, this causes the SonarCloud to confuse the possibility that the -1 byte value (0xFF), equals the -1 EOF value (0xFFFFFFFF)
> 
> This simply added a casting to & 0xFF to avoid this confusion.

This pull request has now been integrated.

Changeset: f7492dda
Author:    Bara' Hasheesh <bara.hasheesh at gmail.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk17u-dev/commit/f7492dda384b814c5fceaea15a2fdf1a2a7bc617
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8312475: org.jline.util.PumpReader signed byte problem

Backport-of: bea2d48696ee2c213e475ca3aa3aa9c412b91089

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/3536