[jdk21u-dev] RFR: 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers [v3]

[Jan Kratochvil]

On Tue, 24 Jun 2025 12:30:14 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>> 
>>  - Merge remote-tracking branch 'janjdk21u-dev/devmaster-cgroup2reduced1234b' into devmaster-cgroup2reduced1234-conflict
>>  - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers
>>    
>>    Reviewed-by: jsjolen, stuefe
>>  - 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container
>>    
>>    Reviewed-by: stuefe, iklam
>>  - src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized'
>>     - a patch by Yuri Nesterenko
>>  - 8333326: Linux Alpine build fails after 8302744
>>    
>>    Reviewed-by: sgehwolf, clanger, stuefe
>>  - 8302744: Refactor Hotspot container detection code
>>    
>>    Reviewed-by: jsjolen, stuefe
>>  - rss/cache fixups.
>>  - 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers
>>    
>>    Reviewed-by: jsjolen, stuefe
>
> src/hotspot/share/opto/convertnode.cpp line 84:
> 
>> 82:         return nullptr;
>> 83:       }
>> 84: 
> 
> This looks like an unrelated change. Please remove.

I do not understand why but I did not see this change by local GIT. And after a clean fresh re-merge with `master` it is no longer visible even on Github. Thanks for checking it but I no longer see it anywhere.

> test/jdk/jdk/internal/platform/cgroup/TestSystemSettings.java line 27:
> 
>> 25:  * @test
>> 26:  * @key cgroups
>> 27:  * @requires (os.family == "linux" & !vm.musl)
> 
> Same here. Unrelated. Perhaps not using up-to-date master branch?

Likewise. You are right maybe I did some mistake with older `master` but I was careful not to do such a problem.

-------------

PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1662#discussion_r2169703597
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1662#discussion_r2169704906