[jdk11u-dev] RFR: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA [v3]

Antonio Vieiro duke at openjdk.org
Fri Jun 27 13:14:44 UTC 2025


On Fri, 27 Jun 2025 12:59:03 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Why don't we set the expected `ProgramFiles(x86)` environment variable to value `C:\\Program Files (x86)` in the GHA job? This would be a less invasive fix as the code in this PR changes product code.

`ProgramFiles(x86)` does not comply with [naming conventions for configuration](https://docs.github.com/en/actions/how-tos/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#naming-conventions-for-configuration-variables) variables (but who knows, maybe we can pass it as an environment variable, despite it having parentheses in the name).

I think we could also add a new entry to the [`VSVERSIONS`](https://github.com/openjdk/jdk11u-dev/blob/a358297587fb415462cdbe67e25617092f9fd9e1/src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Linker.java#L250) enum, specific to the 2022 configuration, that also uses default `C:\\Program Files (x86)` paths. I'll experiment with this and report back.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3056#issuecomment-3013039267


More information about the jdk-updates-dev mailing list