[jdk11u-dev] RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]
Roman Marchenko
rmarchenko at openjdk.org
Mon Mar 10 08:31:00 UTC 2025
On Fri, 28 Feb 2025 20:21:57 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:
>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixing review comments
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line 1296:
>
>> 1294: }
>> 1295: }
>> 1296: if (hasNonexistentEntries) {
>
> I think we should check hasNonexistentEntries at line 1259 also. This is a difference between JDK17 and JDK11 versions
Added the check. Although the checks at the line 1255 look excessive.
-------------
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3007#discussion_r1986809165
More information about the jdk-updates-dev
mailing list