[jdk21u-dev] RFR: 8319439: Move BufferNode from PtrQueue files to new files

[Martin Doerr]

On Fri, 7 Mar 2025 19:43:20 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I would like to bacvkport this change to make future 
> backports easier.
> 
> It is low risk, so this is feasible although it does not fix
> a bug. It is a pure move of code to a new file. The code is unchanged.
> At most, it might slightly affect the size of libjvm.so.
> 
> I had to do some resolkves. 
> Especially the moved code differes. 
> So I moved the classes by hand. 
> They differ because 
> 8314276: Improve PtrQueue API around size/capacity
> 8309899: Rename PtrQueueSet::buffer_size()
> are not in 21.
> The latter would be a candidate for backport as well, 
> it should have low risk. But resolving against 
> function names is not as annoying as applying
> the changes in other files. 
> What do you think?
> 
> Resolved files in detail:
> 
> src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp
> src/hotspot/share/gc/g1/jvmFlagConstraintsG1.cpp
> Resolved includes.
> 
> src/hotspot/share/gc/shared/ptrQueue.cpp
> src/hotspot/share/gc/shared/ptrQueue.hpp
> From these files, I copied the deleted content to
> the two new files.
> I verified that the original change copies these
> without changing them as well.
> 
> test/hotspot/gtest/gc/shared/test_bufferNodeAllocator.cpp
> Trivial resolve.

I think this backport makes sense. I would probably also backport https://github.com/openjdk/jdk/commit/181845ae46157a9bb3bf8e2a328fa59eddc0273a for the same reason, but I leave you free to decide.

src/hotspot/share/gc/shared/bufferNode.hpp line 77:

> 75:   class TestSupport;            // Unit test support.
> 76: };// We use BufferNode::AllocatorConfig to set the allocation options for the
> 77: // FreeListAllocator.

Should look like this:

};
 
// We use BufferNode::AllocatorConfig to set the allocation options for the

-------------

PR Review: https://git.openjdk.org/jdk21u-dev/pull/1458#pullrequestreview-2671114443
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/1458#discussion_r1987373448