[jdk21u-dev] RFR: 8319439: Move BufferNode from PtrQueue files to new files [v2]

[Martin Doerr]

On Tue, 11 Mar 2025 10:12:24 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I would like to bacvkport this change to make future 
>> backports easier.
>> 
>> It is low risk, so this is feasible although it does not fix
>> a bug. It is a pure move of code to a new file. The code is unchanged.
>> At most, it might slightly affect the size of libjvm.so.
>> 
>> I had to do some resolkves. 
>> Especially the moved code differes. 
>> So I moved the classes by hand. 
>> They differ because 
>> 8314276: Improve PtrQueue API around size/capacity
>> 8309899: Rename PtrQueueSet::buffer_size()
>> are not in 21.
>> The latter would be a candidate for backport as well, 
>> it should have low risk. But resolving against 
>> function names is not as annoying as applying
>> the changes in other files. 
>> What do you think?
>> 
>> Resolved files in detail:
>> 
>> src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp
>> src/hotspot/share/gc/g1/jvmFlagConstraintsG1.cpp
>> Resolved includes.
>> 
>> src/hotspot/share/gc/shared/ptrQueue.cpp
>> src/hotspot/share/gc/shared/ptrQueue.hpp
>> From these files, I copied the deleted content to
>> the two new files.
>> I verified that the original change copies these
>> without changing them as well.
>> 
>> test/hotspot/gtest/gc/shared/test_bufferNodeAllocator.cpp
>> Trivial resolve.
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix whitespace

LGTM.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk21u-dev/pull/1458#pullrequestreview-2673772809