[jdk17u-dev] RFR: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11

[Goetz Lindenmaier]

On Mon, 3 Mar 2025 13:45:26 GMT, Sorna Sarathi N <ssarathi at openjdk.org> wrote:

>> Hi all,
>> This pull request contains a backport of commit [3251eea](https://github.com/openjdk/jdk/commit/3251eea1f4289a0505052be204407c02ca38b0ad) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository.
>> I've also resolved a build failure with the latest version of gtest(In JDK17) by backporting the [fix](https://github.com/openjdk/jdk17u-dev/pull/2959).
>> Thanks!
>> 
>> JBS Issue: [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499)
>
> Hi @GoeLin,
> 
> Fix Request 17u
> 
> Backporting this patch to fix the issue described. The patch applies cleanly.
> 
> Risk is medium. It changes the critical component security-libs. No regressions observed in jdk/sun/security/pkcs11 . A regression test is hard to test for pre PKCS 11 standard v2.40 explained in the [JBS comment](https://bugs.openjdk.org/browse/JDK-8336499?focusedId=14690278&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14690278).
> 
> Ran the tier 1-2 tests. Tier 2 ended with few failures and they aren't related to the current changes.
> 
> Thanks,
> Sorna Sarathi.

Hi @Sorna-Sarathi 
Thanks for testing etc.
Basically this is good to go now. I ran it through our testing without issues.
But I think we should await till this has some live coverage.  So I'll label jdk17u-defer-next and approve it some later.
Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2979#issuecomment-2724381362