[jdk11u-dev] RFR: 8328957: Update PKCS11Test.java to not use hardcoded path

Francisco Ferrari Bihurriet fferrari at openjdk.org
Mon Mar 17 14:27:10 UTC 2025


On Fri, 14 Mar 2025 23:51:21 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Hi, I would like to propose an openjdk/jdk at 16576b87b7267aaa99c41f77993287e3479577aa backport.
>> 
>> I do this backport for parity with 11.0.26-oracle. The backport is clean.
>> 
>> Also, this allows running _SunPKCS11_ tests more easily, without the need to make symlink workarounds to locate the NSS library inside a `<base>/nss/lib` path.
>> 
>> ### Testing
>> 
>> * `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk11u-dev/actions/runs/13551011718))
>>     * The failure in macos-x64 / test (hs/tier1 serviceability) / `serviceability/sa/ClhsdbFindPC.java#id1` is unrelated with PKCS11 test changes
>> * `test/jdk/sun/security/pkcs11`
>>     * No regressions found against `jdk11u-dev/master` (currently: 659a4669208645420e151e78ab5fd3ac3808b310)
>>       ```
>>       ==============================
>>       Test summary
>>       ==============================
>>          TEST                                              TOTAL  PASS  FAIL ERROR   
>>       >> jtreg:test/jdk/sun/security/pkcs11                   95    84    10     1 <<
>>       ==============================
>>       TEST FAILURE
>>       ```
>>     * <details>
>>       <summary>jtreg <code>summary.txt</code> comparison</summary>
>>       
>>       ```diff
>>       diff --git a/jdk11u-dev/pkcs11_regression/report/text/summary.txt b/jdk11u-dev-backport-8328957/pkcs11_regression/report/text/summary.txt
>>       index ec3301f..552b9d0 100644
>>       --- a/jdk11u-dev/pkcs11_regression/report/text/summary.txt
>>       +++ b/jdk11u-dev-backport-8328957/pkcs11_regression/report/text/summary.txt
>>       @@ -1,98 +1,98 @@
>>        sun/security/pkcs11/Cipher/CancelMultipart.java              Passed. Execution successful
>>        sun/security/pkcs11/Cipher/EncryptionPadding.java            Passed. Execution successful
>>        sun/security/pkcs11/Cipher/JNICheck.java                     Passed. Execution successful
>>        sun/security/pkcs11/Cipher/ReinitCipher.java                 Passed. Execution successful
>>        sun/security/pkcs11/Cipher/Test4512704.java                  Passed. Execution successful
>>        sun/security/pkcs11/Cipher/TestCICOWithGCM.java              Passed. Execution successful
>>        sun/security/pkcs11/Cipher/TestCICOWithGCMAndAAD.java        Passed. Execution successful
>>        sun/security/pkcs11/Cipher/TestChaChaPoly.java               Passed. Execution successful
>>        sun/security/pkcs11/Cipher/TestChaChaPolyKAT.java            Passed. Execution successful
>>        sun/...
>
> 11u-dev is currently [closed for commits](https://mail.openjdk.org/pipermail/jdk-updates-dev/2025-March/041774.html). This should not have been pushed until the freeze was lifted. Re-assigned manually to 11.0.28.

@gnu-andrew: thanks for updating [JDK-8351477](https://bugs.openjdk.org/browse/JDK-8351477 "Update PKCS11Test.java to not use hardcoded path") and sorry for the inconvenience, I will check next time to make sure we integrate after the corresponding version bump.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3004#issuecomment-2729712663


More information about the jdk-updates-dev mailing list