[jdk21u-dev] RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v3]

[Andrew John Hughes]

On Wed, 19 Mar 2025 17:55:31 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Please review the backport of JDK-8335181
>> 
>> src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java
>>  - manual merge for MultiExchange::getExceptionalCF
>> because of the difference in the logging caused by 8310330
>> 
>> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
>> - added import for the AtomicLong class manually because of the difference in the import section
>> 
>> src/java.net.http/share/classes/jdk/internal/net/http/ExchangeImpl.java
>> - copyright year updated manually
>> 
>> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java
>> - import section is updated manually
>> 
>> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
>> - getConnectionKey() declaration is added manually in the HttpServerAdapters::HttpTestExchange class
>> 
>> All jtreg tests for java.net.httpclient are passed
>
> Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8335181
>  - Remove extra import
>  - Backport 720b44648bcff997278af92746f942b2425298a5
>  - Backport fc98998627443d6e73ac70661f47f48b30525712

Thanks. Backport looks good. `Http2Connection.java` & `Http2TestServerConnection.java` copyright headers were already updated by JDK-8328286 and so didn't need the update from this patch.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk21u-dev/pull/1417#pullrequestreview-2700713868