[jdk11u-dev] RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

[Andrew John Hughes]

On Mon, 10 Mar 2025 08:30:59 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
>> 
>> Original patch does not apply cleanly to jdk11, some minor conflicts, and also in `test/jdk/sun/security/tools/jarsigner/RemovedFiles.java` `ed25519` algorithm was replaced with `RSA`, and `_` was replaced with a variable, and added the check in `src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java` at line 1259.
>> 
>> We need this fix in jdk11 and below, down to jdk8, as all versions have this issue with jarsigner.
>> 
>> New tests successfully ran locally on Linux, x86_64.
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing review comments

Backport looks good. The different `hasNonexistentEntries` handling seems consistent with the lack of [JDK-8250586](https://bugs.openjdk.org/browse/JDK-8250586) in 11u.  EdDSA support was only added in OpenJDK 16 by [JDK-8242068](https://bugs.openjdk.org/browse/JDK-8242068). 

I couldn't see the `_` replacement mentioned. Was this backport based on the 17u version?

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/3007#pullrequestreview-2700905813