[jdk17u] RFR: 8352097: (tz) zone.tab update missed in 2025a backport
Goetz Lindenmaier
goetz at openjdk.org
Thu Mar 20 10:54:14 UTC 2025
On Thu, 20 Mar 2025 10:21:48 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:
> > This is identical to the backport to 21. The edited file lives in a different directory, therefore this is not a clean backport. I second that this goes to jdk17u.
>
> `git cherry-pick` handled the file movement automatically so I would regard this as clean, much as I would regard automated path shuffling from 11u to 8u as clean. No manual intervention was required and there are no differences in the body of the `diff`.
Thanks for giving this additional information. The fact that you could created this automatically reduces the chance for error. But this context is needed to make the information useful for a reviewer.
Also, as approver, I usually take a different look if I know no reveiwer was involved. And as backporter to a later release, I would like information about the previous backports. In both cases, and similar with the 24u backport of the timezone change, it is helpful if a change like this is not labeled as "clean".
Btw, would skara handle the file path differnces? I just did the backport of JDK-8303770, which has the same issue.
-------------
PR Comment: https://git.openjdk.org/jdk17u/pull/405#issuecomment-2739934819
More information about the jdk-updates-dev
mailing list