[jdk17u-dev] RFR: 8320276: Improve class initialization barrier in TemplateTable::_new

Jaroslav Bachorik jbachorik at openjdk.org
Tue May 13 13:53:57 UTC 2025


On Wed, 16 Apr 2025 19:44:34 GMT, Matt <duke at openjdk.org> wrote:

> This PR backports 8320276 to support backporting 8338379, see the comment thread linked below. This was a clean backport, though reviewers may want to confirm that the decision to include [this function](https://github.com/openjdk/jdk17u-dev/blob/f19121cc65199f2052c69747dfa7ae8d209596f4/src/hotspot/cpu/ppc/vm_version_ppc.hpp#L135) was correct. 
> 
> ---------
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] [JDK-8320276](https://bugs.openjdk.org/browse/JDK-8320276) needs maintainer approval
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3508/head:pull/3508` \
> `$ git checkout pull/3508`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/3508` \
> `$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3508/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 3508`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 3508`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/jdk17u-dev/pull/3508.diff">https://git.openjdk.org/jdk17u-dev/pull/3508.diff</a>
> 
> </details>

Please, review the change to vm_version_ppc.hpp - it seems out of place.

For the rest of changes - I have verified they correspond to the original patch.

src/hotspot/cpu/ppc/vm_version_ppc.hpp line 135:

> 133:   static uint64_t _dscr_val;
> 134: 
> 135:   static void initialize_cpu_information(void);

This looks wrong.
The original patch has a different change: https://github.com/openjdk/jdk/commit/409a39ec8da83d6a0895e7e213604455ebf50485#diff-0e8cad40dc55410beb083852ab7a431d0c0cd668719b3c252c93c5083b824654R85-R94

-------------

Changes requested by jbachorik (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/3508#pullrequestreview-2836874891
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3508#discussion_r2086879644


More information about the jdk-updates-dev mailing list