[jdk21u-dev] RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files
Martin Doerr
mdoerr at openjdk.org
Wed May 14 19:29:52 UTC 2025
On Mon, 12 May 2025 15:11:20 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
> I would like to backport this change to keep maintaining the tests more easy.
> It will make later backports clean, saving tedious reviews.
>
> Despite the many touched files, only four files do not patch clean:
>
> test/hotspot/jtreg/serviceability/jvmti/GetClassFields/FilteredFields/libFilteredFieldsTest.cpp
> Was added by https://bugs.openjdk.org/browse/JDK-8318626: GetClassFields does not filter out ConstantPool.constantPoolOop field
> Omitted.
>
> patching file test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/functions/rawmonitor/rawmonitor.cpp
> Later change already backported. Resolved Copyright.
>
>
> |+++ b/test/jdk/java/foreign/enablenativeaccess/org/openjdk/foreigntest/unnamed/libLinkerInvokerUnnamed.cpp
> Was moved to other location by "https://bugs.openjdk.org/browse/JDK-8312522: Implementation of Foreign Function & Memory API".
> Applied hunk to test/jdk/java/foreign/enablenativeaccess/org/openjdk/foreigntest/libLinkerInvokerUnnamed.cpp
>
>
> patching file test/jdk/java/foreign/enablenativeaccess/panama_module/org/openjdk/foreigntest/libLinkerInvokerModule.cpp
> Not clean because of "https://bugs.openjdk.org/browse/JDK-8312522: Implementation of Foreign Function & Memory API" missing in 21.
> Resolved Copyright.
This makes sense. LGTM.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk21u-dev/pull/1772#pullrequestreview-2841275555
More information about the jdk-updates-dev
mailing list