[jdk11u-dev] RFR: 8348597: Update HarfBuzz to 10.4.0 [v3]
Antonio Vieiro
duke at openjdk.org
Tue May 20 09:47:03 UTC 2025
On Tue, 20 May 2025 09:43:38 GMT, Antonio Vieiro <duke at openjdk.org> wrote:
>> Backport of [JDK-8348597](https://bugs.openjdk.org/browse/JDK-8348597) from JDK17 that updates HarfBuzz to 10.4.0 (which [improves drawing performande by 10+% and includes different build fixes](https://newreleases.io/project/github/harfbuzz/harfbuzz/release/10.4.0)). Backport is not clean because it required adapting `make/lib/Awt2dLibraries.gmk` to fit JDK11.
>>
>> Even though the backport built correctly, the resulting `jdk/lib/libfontmanager.so` contained undefined symbols that caused Swing tests to fail with `UnsatisfiedLinkError`. This is because JDK11 is missing [JDK-8319197](https://bugs.openjdk.org/browse/JDK-8319197) that excludes hb-subset from compilation, so this is also included as the second commit in the pull request.
>>
>> While at it, a third commit adds an additional `-Wno-attributes` flag to `HARFBUZZ_DISABLED_WARNINGS_CXX_gcc`, restoring the capability to build JDK11 on Linux with `gcc-4.8.5` (this is an old version of gcc, dating from 2015, but it's still the system gcc version in RHEL-7).
>>
>> Tested
>>
>> - on Windows 10 with `jdk:jfc_demo`.
>> - on Linux with `jdk:jfc_demo`, with
>> - `gcc 4.8.5/harfbuzz-1.7.5 (x86_64 & s390x)`,
>> - `gcc 8.5.0/harfbuzz-1.7.5 (x86_64)`,
>> - `gcc 11.5.0/harfbuzz-2.7.4 (x86_64)`
>> - and `gcc 14.2.1/harfbuzz-9.0.0 (x86_64)`
>>
>> with both `--with-harfbuzz=system` and `--with-harfbuzz=bundled`.
>
> Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision:
>
> Rearrange Awt2dLibraries.gmk as per review
Thanks for the review!
> I'm confused by what is going on in `make/lib/Awt2dLibraries.gmk`. There should be just two changes here according to the description:
>
> * The addition of `dangling-pointer` to the disabled warnings as in 8348597
>
> * The expansion of `LIBFONTMANAGER_EXCLUDE_FILES` from 8319197
>
>
The intention was to make `Awt2dLibraries.gmk` more similar to the one in JDK-17 (which has had significant changes during the years), with the intention to make future backports easier (at the cost of a more difficult review), hence the reordering and the indentation.
So I've re-arranged the changes to make them more similar to the original `Awt2dLibraries.gmk` in 11. Hope this makes it easier to review. Note the `attributes` is required for `gcc.4.8.5`.
Retested with:
- gcc 4.8.5/harfbuzz-1.7.5 (x86_64),
- and gcc 14.2.1/harfbuzz-9.0.0 (x86_64)
-------------
PR Comment: https://git.openjdk.org/jdk11u-dev/pull/3026#issuecomment-2893682712
More information about the jdk-updates-dev
mailing list