[jdk21u-dev] RFR: 8356096: ISO 4217 Amendment 179 Update

Goetz Lindenmaier goetz at openjdk.org
Thu May 22 06:58:07 UTC 2025


On Wed, 21 May 2025 06:52:54 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 21.0.8-oracle
> 
> Resolved adding the bugid in ValidateISO4217.java
> There were several test improvements.  They can not be backported
> easily. They heavily use modern Java that does not compile with 21.

Hi,
I had a look at the improvements to test ValidateISO4217.java that are not in 21 and spoiled the clean
backport. See also
https://github.com/openjdk/jdk/commits/master/test/jdk/java/util/Currency/ValidateISO4217.java
In detail these are
    [8354344: Test behavior after cut-over for future ISO 4217 currency](https://github.com/openjdk/jdk/commit/1526dd81d9b5bf4abaac1546c370cf7a056d01dc)
[8354343: Hardening of Currency tests for not yet defined future ISO 4217 currency](https://github.com/openjdk/jdk/commit/ac41bc31c96951b9fe51c22d16f31bdc1806a881)

The ISO 4217 Update is a recurring change, and thus having clean backports and more testing would be nice.
But the changes are not straight forward to backport, so I think we should better accept the recurring need for reviews and not backport them.

The resolve for this change is trivial after all.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1821#issuecomment-2900123103


More information about the jdk-updates-dev mailing list