[jdk17u-dev] RFR: 8348303: Remove repeated 'a' from ListSelectionEvent
Satyen Subramaniam
ssubramaniam at openjdk.org
Fri May 23 17:19:54 UTC 2025
On Fri, 23 May 2025 13:31:13 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
>> Backporting JDK-8348303: Remove repeated 'a' from ListSelectionEvent. Trivial test change to clean up description. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is clean.
>
> Hi @satyenme
> I want to ask you to be more careful with your backports.
> Here the description is wrong. It is not a test change.
> Before you even pushed a change that had a test that did not compile, but you claimed that you had excecuted it.
> Also, please give a reason why you backport a certain change!
Hi @GoeLin,
Thanks for the feedback and point taken - in this case, the description was an oversight on my part. Planning on being more selective with backports moving forward, strongly emphasizing those with a pressing need and reducing the quantity. I'll also go ahead and close this PR. As for testing, I usually cherry-pick the relevant changes and run tier 1 and 2 tests overnight, then push and confirm sanity checks run before PRing. Was looking back, would you mind linking the case you're referring to?
-------------
PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3590#issuecomment-2905194629
More information about the jdk-updates-dev
mailing list