[jdk21u-dev] RFR: 8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests

[Goetz Lindenmaier]

On Tue, 11 Nov 2025 13:01:04 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> I backport this to get the jpackage testing up-to-date. This simplifies further backports.
>> 
>> This change, [JDK-8347300](https://bugs.openjdk.org/browse/JDK-8347300), is included in the second commit.
>> 
>> To make it work, I backport  changes from https://bugs.openjdk.org/browse/JDK-8340311 "8340311: JPackage app-image exe launches multiple exe's in JDK 22+" as prerequisite.
>> Planned later backport 8365790 needs the adaptions of the test helper classes in 8340311, too.
>> 
>> **8340311 backport adaptions**
>> 
>> The 8340311 test helper changes patch almost cleanly to 21.
>> But I also need to take some changes to tests where the interface
>> to the helper classes changed.
>> 
>> Adaptions:
>> 
>> *    I had to modify the location of test/jdk/tools/jpackage/share/jdk/jpackage/tests/BasicTest.java which was moved by a later change already backported.
>> *    I resolved the copyright in LauncherAsServiceVerifier.java
>>  *   I omitted the changes to Win8301247Test.java. These mostly depend on previous, not backported changes and do not apply well.
>> *    Naturally I omitted the new tests in 8340311.
>> 
>> **8347300 backport adaptions**
>> 
>> To apply [JDK-8347300](https://bugs.openjdk.org/browse/JDK-8347300) for the second commit, I had to resolve several chunks because removePath was renamed to removePathEnvVar.
>
> So this includes 8340311 (or parts).
> Where are the  src/jdk.jpackage/share/native/applauncher/AppLauncher.cpp (and .hpp) changes of  8340311 ? Your comments seem not to mention them.
> See https://github.com/openjdk/jdk/commit/29882bfe7b7e76446a96862cd0a5e81c7e054415

Hi @MBaesken 
yes, I only want to take test changes of 8340311.  They are improvements of the test infrastructure. The functional parts of 8340311 are deliberately left out. 
It probably would suffice to only take the changes to the files in /helpers, but this would break the two tests.

Do you think I should backport 8340311?  If so, I would backport that seperately first.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/2454#issuecomment-3516875627