[jdk17u-dev] RFR: 8310049: Refactor Charset tests to use JUnit

Justin Lu jlu at openjdk.org
Tue Oct 7 17:32:25 UTC 2025


On Sun, 5 Oct 2025 18:00:35 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 17.0.18-oracle.
> 
> I had to resolve as [8260265: UTF-8 by Default](https://bugs.openjdk.org/browse/JDK-8260265) is not in 17.
> 
> The most notable difference is that I omitted the method defaultCharsetTest()
> rather at the beginning, which replaces the try/catch added by 8260265 at the end.

test/jdk/java/nio/charset/Charset/IllegalCharsetName.java line 52:

> 50:         assertThrows(IllegalCharsetNameException.class,
> 51:                 () -> Charset.forName(name));
> 52:         assertThrows(IllegalCharsetNameException.class,

Please see the same concerns as suggested here: https://github.com/openjdk/jdk21u-dev/pull/2296/files#r2411376021.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/4015#discussion_r2411378729


More information about the jdk-updates-dev mailing list