[jdk11u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v2]

[Alexey Bakhtin]

On Fri, 19 Sep 2025 18:43:32 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> Hi, this is a backport of openjdk/jdk17u-dev#3954. The backport is almost clean, except for:
>> 
>> * Trivial context differences in `Main.java`~~, `Resources.java`, `Resources_ja.java`, and `Resources_zh_CN.java`~~
>> * The English `jarsigner.1` manpages have a slightly different format (manually adjusted to match the 11u format)
>>     * Also, there are 3 identical files for it (_Linux_, _BSD_, _Solaris_)
>> * ~~There also exist a Japanese version of the `jarsigner.1` manpages, they were updated using an LLM translation (giving as context the translations from the resources files, where there is a similar sentence), if any Japanese speaker is reading this, please check it:~~
>>   > ~~This jar contains internal inconsistencies detected during verification that may result in different contents when reading via JarFile and JarInputStream.~~
>>   > ~~⬇️~~
>>   > ~~このjarには検証中に検出された内部的な不整合があるため、JarFileとJarInputStreamから読み取る場合にコンテンツが異なる可能性があります。~~
>>     * ~~I updated `src/linux/doc/man/ja/jarsigner.1` and `src/solaris/doc/sun/man/man1/ja/jarsigner.1` (identical), and left `src/bsd/doc/man/ja/jarsigner.1` untouched (doesn't have any content besides the headers)~~
>>     * ~~Tip: these files are encoded in `EUC-JP`, to open them in VIM use `vim -c "e ++enc=EUC-JP" .../ja/jarsigner.1`~~
>> 
>> $\mbox{\color{red}UPDATE}$ (191d5cad9c8c0d452c0571c669e06b375b9f578a): all the internationalized messages have been removed, as they aren't typically included in backports (thanks @jerboaa for letting me know).
>> 
>> #### Related issues ("relates to" Jira issue links)
>> 
>> [JDK-8353299](https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails") (openjdk/jdk at acd4da49a01760599ec4c325ff6c56f53ba5cc9c) and [JDK-8367782](https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName") (openjdk/jdk at 1b9a11682d5f73885213822423bfce8dfc17febd) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of `VerifyJarEntryName.java`.
>> 
>> Since `test/hotspot/jtreg/runtime/appcds/SignedJar.java` is not failing after the backport, [JDK-8353330](https://bugs.openjdk.org/browse/JDK-8353330 "Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier") was not included.
>> 
>> #### Testing
>> 
>> * Besides the `tier1` run from the [GitHub actions](https://github.com/franferrax/jdk11u-dev/actions/runs/17843495340) (all passed), I ran a r...
>
> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove internationalized messages

LGTM

-------------

Marked as reviewed by abakhtin (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/3098#pullrequestreview-3311646475