[jdk17u-dev] RFR: 8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package
Matthias Baesken
mbaesken at openjdk.org
Tue Oct 28 12:54:10 UTC 2025
On Sat, 25 Oct 2025 16:03:25 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
> I backport this to simplify later test backports that touch the files in the new locations.
>
> This is not based on the backport to 21. That backport includes Comm.java. When I did that, it had not planned to backport follow-up "8343876:` Enhancements to jpackage test lib" that brings Comm.java. But as I did that in the meantime I think it is better to add that part there. The backport from 21 would not have been clean, anyways,
> nor backporting 8343876 from 21 on top.
>
> Omitted PredefinedAppImageErrorTest.java. Was added by "8286850: [macos] Add support for signing user provided app image" in 19.
>
> test/jdk/tools/jpackage/windows/WinL10nTest.java
> Code modified was added by "8291978: jpackage: allow to override primary l10n files on Windows" in 20. Omitted.
>
> BasicTest.java requires TKit.assertDirectoryContent(). This was added by 8325089: jpackage utility creates an "infinite", undeleteable directory tree.
> Too big to backport as prereq, so I add that to TKit as I already did in the backport to 21.
Marked as reviewed by mbaesken (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk17u-dev/pull/4105#pullrequestreview-3388618765
More information about the jdk-updates-dev
mailing list