[jdk17u-dev] RFR: 8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win) [v2]

[Goetz Lindenmaier]

On Wed, 29 Oct 2025 11:21:55 GMT, Voznia Anton <duke at openjdk.org> wrote:

>> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add code from 8284161 along with fix of this change
>
> src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 1012:
> 
>> 1010:      * threads that are blocked in I/O operations on this channel. If there are no
>> 1011:      * virtual threads blocked in I/O operations on this channel then the channel's
>> 1012:      * socket is closed. If there are virtual threads in I/O then the final close is
> 
> LGTM in general.
> Since Java 17 doesn't have virtual threads, perhaps remove the mention of them from the comment.

Hi @antonvoznia , Good point, I replaced it by the version of your PR.
Also, I merged head, this resolves the macos failure in the tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/4076#discussion_r2472700289