[jdk17u-dev] RFR: 8294594: Fix cast-function-type warnings in signal handling code

Martin Doerr mdoerr at openjdk.org
Fri Oct 31 14:42:37 UTC 2025


On Tue, 28 Oct 2025 12:11:16 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Need this to unblock MacOS compiler update in GHA.
> 
> Partially backports original https://github.com/openjdk/jdk/commit/b06f1b149c8f8a49d4e42c4b782a4b3a22aa79f6. There are lots of conflicts, because:
>  1. The original [JDK-8294314](https://bugs.openjdk.org/browse/JDK-8294314) that added more verbose build warnings is not in 17u-dev yet. 
>  2. The [JDK-8292054](https://bugs.openjdk.org/browse/JDK-8292054) that added the `/test/hotspot/gtest/runtime/test_signals.cpp` is also not present in 17u-dev.
> 
> Additional testing:
>  - [x] Linux AArch64 server fastdebug, `all`
>  - [x] Linux x86_64 server fastdebug, `all`

LGTM. The fix is small and unlikely to cause trouble. And we need it for modern compiler support. So, thumbs up from my side.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/4125#pullrequestreview-3404614254


More information about the jdk-updates-dev mailing list