[jdk21u-dev] RFR: 8364597: Replace THL A29 Limited with Tencent
Andrew John Hughes
andrew at openjdk.org
Wed Sep 3 16:45:51 UTC 2025
On Tue, 2 Sep 2025 11:24:23 GMT, John Jiang <jjiang at openjdk.org> wrote:
> Please review this backport of `JDK-8364597: Replace THL A29 Limited with Tencent`.
> This backport is not clean, because:
> - Some files don't exist in jdk21u repo.
> - src/hotspot/share/gc/shenandoah/shenandoahGenerationalControlThread.cpp
> - test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java
> - test/hotspot/jtreg/gc/arguments/TestG1CompressedOops.java
> - Some files only in jdk21u repo should be also modified.
> - src/hotspot/cpu/x86/macroAssembler_x86_32_exp.cpp
> - src/hotspot/cpu/x86/macroAssembler_x86_32_log.cpp
> - src/hotspot/cpu/x86/macroAssembler_x86_32_pow.cpp
> - Some files have different copyright notes between these repos.
> - src/hotspot/cpu/x86/stubGenerator_x86_64_pow.cpp
> - src/hotspot/cpu/x86/stubGenerator_x86_64_log.cpp
> - src/hotspot/cpu/x86/stubGenerator_x86_64_exp.cpp
> - test/jdk/jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java
> - test/hotspot/jtreg/compiler/vectorapi/TestIntrinsicBailOut.java
> - test/hotspot/jtreg/compiler/oracle/TestInvalidCompileCommand.java
Rather than treat this as a backport, it seems to make more sense to ensure that all occurrences of 'THL A29' are removed from the code base for each release.
As such, along with sanity checking the patch itself, I compared the list of files covered by the patch with those in the repository containing 'THL A29':
~~~
$ grep -r 'THL A29' * 2>&1 | tee /tmp/thl.21u
$ diffstat -p0 /tmp/8364597.21u > /tmp/diffstat.21u
$ for file in $(cut -d : -f 1 /tmp/thl.21u ); do if ! grep -q ${file} /tmp/diffstat.21u ; then echo "${file} missing"; fi; done
~~~
With this, I confirmed that this change covers all cases.
-------------
Marked as reviewed by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk21u-dev/pull/2138#pullrequestreview-3181464340
More information about the jdk-updates-dev
mailing list