[jdk17u-dev] RFR: 8364597: Replace THL A29 Limited with Tencent

[Andrew John Hughes]

On Wed, 3 Sep 2025 08:10:01 GMT, John Jiang <jjiang at openjdk.org> wrote:

> Please review this backport of `JDK-8364597: Replace THL A29 Limited with Tencent`.
> This backport is not clean, because:
> - Some files have different copyright notes between the repos
>   - test/hotspot/jtreg/compiler/oracle/TestInvalidCompileCommand.java
>   - test/hotspot/jtreg/compiler/vectorapi/TestIntrinsicBailOut.java
>   - test/jdk/jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java
>   - test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS12.java
>   - test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS13.java
> - Some files should not be modified due to there is not Tencent copyright notes
>   - src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
>   - src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp
> - Some files doesn't exist in jdk17u
>   - src/hotspot/cpu/x86/stubGenerator_x86_64_exp.cpp
>   - src/hotspot/cpu/x86/stubGenerator_x86_64_exp.cpp
>   - src/hotspot/cpu/x86/stubGenerator_x86_64_log.cpp
>   - src/hotspot/cpu/x86/stubGenerator_x86_64_pow.cpp
>   - src/hotspot/share/gc/shenandoah/shenandoahGenerationalControlThread.cpp
>   - test/hotspot/jtreg/compiler/c2/TestDuplicateSimpleLoopBackedge.java
>   - test/hotspot/jtreg/compiler/c2/irTests/TestAutoVectorization2DArray.java
>   - test/hotspot/jtreg/compiler/compilercontrol/TestConflictInlineCommands.java
>   - test/hotspot/jtreg/compiler/print/TestTraceOptoParse.java
>   - test/hotspot/jtreg/gc/arguments/TestG1CompressedOops.java
>   - test/hotspot/jtreg/runtime/cds/appcds/FillerObjectLoadTest.java
>   - test/jdk/java/lang/Thread/virtual/ParkWithFixedThreadPool.java
>   - test/jdk/javax/net/ssl/DTLS/DTLSNamedGroups.java
>   - test/jdk/javax/net/ssl/DTLS/DTLSSignatureSchemes.java
>   - test/jdk/javax/net/ssl/SSLException/CheckSSLHandshakeException.java
>   - test/jdk/javax/net/ssl/SSLException/CheckSSLKeyException.java
>   - test/jdk/javax/net/ssl/SSLException/CheckSSLPeerUnverifiedException.java
>   - test/jdk/javax/net/ssl/SSLException/CheckSSLProtocolException.java
>   - test/jdk/javax/net/ssl/SSLParameters/NamedGroups.java
>   - test/jdk/javax/net/ssl/SSLParameters/NamedGroupsSpec.java
>   - test/jdk/javax/net/ssl/SSLParameters/SignatureSchemes.java
>   - test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java
>   - test/jdk/sun/security/jgss/GssContextCleanup.java
>   - test/jdk/sun/security/jgss/GssNameCleanup.java
>   - test/micro/org/openjdk/bench/vm/compiler/AutoVectorization2DArray.java
> - Some files only in jdk17u should be also modified
>   - src/hotspot/cpu/x86/macroAssembler_x86_exp.cpp
>   - src/...

Rather than treat this as a backport, it seems to make more sense to ensure that all occurrences of 'THL A29' are removed from the code base for each release.
~~~
As such, along with sanity checking the patch itself, I compared the list of files covered by the patch with those in the repository containing 'THL A29':

$ grep -r 'THL A29' * 2>&1 | tee /tmp/thl.17u
$ diffstat -p0 /tmp/8364597.21u > /tmp/diffstat.17u
$ for file in $(cut -d : -f 1 /tmp/thl.17u ); do if ! grep -q ${file} /tmp/diffstat.17u ; then echo "${file} missing";  fi; done
~~~
With this, I confirmed that this change covers all cases.

Note that `test/hotspot/jtreg/gtest/MetaspaceUtilsGtests.java`was also in the 21u patch, so is not new to 17u.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/3882#pullrequestreview-3182888519