[jdk17u-dev] RFR: 8364597: Replace THL A29 Limited with Tencent

John Jiang jjiang at openjdk.org
Thu Sep 4 02:57:51 UTC 2025


On Wed, 3 Sep 2025 23:28:50 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Please review this backport of `JDK-8364597: Replace THL A29 Limited with Tencent`.
>> This backport is not clean, because:
>> - Some files have different copyright notes between the repos
>>   - test/hotspot/jtreg/compiler/oracle/TestInvalidCompileCommand.java
>>   - test/hotspot/jtreg/compiler/vectorapi/TestIntrinsicBailOut.java
>>   - test/jdk/jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java
>>   - test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS12.java
>>   - test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS13.java
>> - Some files should not be modified due to there is not Tencent copyright notes
>>   - src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
>>   - src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp
>> - Some files doesn't exist in jdk17u
>>   - src/hotspot/cpu/x86/stubGenerator_x86_64_exp.cpp
>>   - src/hotspot/cpu/x86/stubGenerator_x86_64_exp.cpp
>>   - src/hotspot/cpu/x86/stubGenerator_x86_64_log.cpp
>>   - src/hotspot/cpu/x86/stubGenerator_x86_64_pow.cpp
>>   - src/hotspot/share/gc/shenandoah/shenandoahGenerationalControlThread.cpp
>>   - test/hotspot/jtreg/compiler/c2/TestDuplicateSimpleLoopBackedge.java
>>   - test/hotspot/jtreg/compiler/c2/irTests/TestAutoVectorization2DArray.java
>>   - test/hotspot/jtreg/compiler/compilercontrol/TestConflictInlineCommands.java
>>   - test/hotspot/jtreg/compiler/print/TestTraceOptoParse.java
>>   - test/hotspot/jtreg/gc/arguments/TestG1CompressedOops.java
>>   - test/hotspot/jtreg/runtime/cds/appcds/FillerObjectLoadTest.java
>>   - test/jdk/java/lang/Thread/virtual/ParkWithFixedThreadPool.java
>>   - test/jdk/javax/net/ssl/DTLS/DTLSNamedGroups.java
>>   - test/jdk/javax/net/ssl/DTLS/DTLSSignatureSchemes.java
>>   - test/jdk/javax/net/ssl/SSLException/CheckSSLHandshakeException.java
>>   - test/jdk/javax/net/ssl/SSLException/CheckSSLKeyException.java
>>   - test/jdk/javax/net/ssl/SSLException/CheckSSLPeerUnverifiedException.java
>>   - test/jdk/javax/net/ssl/SSLException/CheckSSLProtocolException.java
>>   - test/jdk/javax/net/ssl/SSLParameters/NamedGroups.java
>>   - test/jdk/javax/net/ssl/SSLParameters/NamedGroupsSpec.java
>>   - test/jdk/javax/net/ssl/SSLParameters/SignatureSchemes.java
>>   - test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java
>>   - test/jdk/sun/security/jgss/GssContextCleanup.java
>>   - test/jdk/sun/security/jgss/GssNameCleanup.java
>>   - test/micro/org/openjdk/bench/vm/compiler/AutoVectorization2DArray.java
>> - Some files only in jdk17u should ...
>
> Rather than treat this as a backport, it seems to make more sense to ensure that all occurrences of 'THL A29' are removed from the code base for each release.
> ~~~
> As such, along with sanity checking the patch itself, I compared the list of files covered by the patch with those in the repository containing 'THL A29':
> 
> $ grep -r 'THL A29' * 2>&1 | tee /tmp/thl.17u
> $ diffstat -p0 /tmp/8364597.17u > /tmp/diffstat.17u
> $ for file in $(cut -d : -f 1 /tmp/thl.17u ); do if ! grep -q ${file} /tmp/diffstat.17u ; then echo "${file} missing";  fi; done
> ~~~
> With this, I confirmed that this change covers all cases.
> 
> Note that `test/hotspot/jtreg/gtest/MetaspaceUtilsGtests.java`was also in the 21u patch, so is not new to 17u.

@gnu-andrew 
Thanks for your review and approval!

> Note that `test/hotspot/jtreg/gtest/MetaspaceUtilsGtests.java` was also in the 21u patch, so is not new to 17u.

When I backported a commit from a repo  (baseline), like `openjdk/jdk`, to another repo (target), say `openjdk/jdk17u`, I just focused on the baseline and target.
So, I didn't mention other repos, including 21u.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3882#issuecomment-3251577330


More information about the jdk-updates-dev mailing list