[jdk17u-dev] RFR: 8364597: Replace THL A29 Limited with Tencent

[Andrew John Hughes]

On Thu, 4 Sep 2025 14:28:26 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Please review this backport of `JDK-8364597: Replace THL A29 Limited with Tencent`.
>> This backport is not clean, because:
>> - Some files have different copyright notes between the repos
>>   - test/hotspot/jtreg/compiler/oracle/TestInvalidCompileCommand.java
>>   - test/hotspot/jtreg/compiler/vectorapi/TestIntrinsicBailOut.java
>>   - test/jdk/jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java
>>   - test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS12.java
>>   - test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS13.java
>> - Some files should not be modified due to there is not Tencent copyright notes
>>   - src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
>>   - src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp
>> - Some files doesn't exist in jdk17u
>>   - src/hotspot/cpu/x86/stubGenerator_x86_64_exp.cpp
>>   - src/hotspot/cpu/x86/stubGenerator_x86_64_exp.cpp
>>   - src/hotspot/cpu/x86/stubGenerator_x86_64_log.cpp
>>   - src/hotspot/cpu/x86/stubGenerator_x86_64_pow.cpp
>>   - src/hotspot/share/gc/shenandoah/shenandoahGenerationalControlThread.cpp
>>   - test/hotspot/jtreg/compiler/c2/TestDuplicateSimpleLoopBackedge.java
>>   - test/hotspot/jtreg/compiler/c2/irTests/TestAutoVectorization2DArray.java
>>   - test/hotspot/jtreg/compiler/compilercontrol/TestConflictInlineCommands.java
>>   - test/hotspot/jtreg/compiler/print/TestTraceOptoParse.java
>>   - test/hotspot/jtreg/gc/arguments/TestG1CompressedOops.java
>>   - test/hotspot/jtreg/runtime/cds/appcds/FillerObjectLoadTest.java
>>   - test/jdk/java/lang/Thread/virtual/ParkWithFixedThreadPool.java
>>   - test/jdk/javax/net/ssl/DTLS/DTLSNamedGroups.java
>>   - test/jdk/javax/net/ssl/DTLS/DTLSSignatureSchemes.java
>>   - test/jdk/javax/net/ssl/SSLException/CheckSSLHandshakeException.java
>>   - test/jdk/javax/net/ssl/SSLException/CheckSSLKeyException.java
>>   - test/jdk/javax/net/ssl/SSLException/CheckSSLPeerUnverifiedException.java
>>   - test/jdk/javax/net/ssl/SSLException/CheckSSLProtocolException.java
>>   - test/jdk/javax/net/ssl/SSLParameters/NamedGroups.java
>>   - test/jdk/javax/net/ssl/SSLParameters/NamedGroupsSpec.java
>>   - test/jdk/javax/net/ssl/SSLParameters/SignatureSchemes.java
>>   - test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java
>>   - test/jdk/sun/security/jgss/GssContextCleanup.java
>>   - test/jdk/sun/security/jgss/GssNameCleanup.java
>>   - test/micro/org/openjdk/bench/vm/compiler/AutoVectorization2DArray.java
>> - Some files only in jdk17u should ...
>
> It looks like you are not running the GitHub Actions tests on your fork. While I don't expect any regression from this change, as it only alters comments, you should enable this for future backports at https://github.com/johnshajiang/jdk17u-dev/actions

> @gnu-andrew Thanks for your review and approval!
> 
> > Note that `test/hotspot/jtreg/gtest/MetaspaceUtilsGtests.java` was also in the 21u patch, so is not new to 17u.
> 
> When I backported a commit from a repo (baseline), like `openjdk/jdk`, to another repo (target), say `openjdk/jdk17u`, I just focused on the baseline and target. So, I didn't mention other repos, including 21u.

For a backport to 17u, the baseline should be 21u. The general expected process for backports is that the oldest supported release is addressed first (hence [Goetz's request for 25](https://github.com/openjdk/jdk21u-dev/pull/2138#issuecomment-3245978677)) and then each successive long-term support release as applicable. It doesn't really save any time to try and do them all in parallel, as we would not approve a backport for an older release before it enters a more recent release, except in exceptional circumstances. It can also result in additional work if changes need to be made as part of the review of the backport for the most recent release.

As mentioned in my review, this one is a little different, as it is a backport in spirit and the changes are going to differ between releases based on which copyright headers are present in each release. But please bear this in mind for any future backports.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/3882#issuecomment-3254064538