[jdk21u-dev] RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset

[Severin Gehwolf]

On Tue, 8 Jul 2025 13:16:40 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> Multithreaded handling of ZIP files can throw an exception.
> 
> This backport is far from clean. The last commit resolves the conflicts.
> 
> The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is [a backward compatibility concern](https://bugs.openjdk.org/browse/JDK-8321156?focusedId=14630523&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14630523) I have not backported it.
> 
> (jdk25 already contains it), this jdk21, [jdk17](https://github.com/openjdk/jdk17u-dev/pull/3720).

> There is needed a backport for 21u to fix ZIP files handling. It is not a clean backport, last commit resolves the conflicts.

This is an insufficient comment. Not explaining when the issue occurs, how likely it is, what you assess the risk of this change is and how you ensured this doesn't cause regressions when ported 4 releases back. It's a fresh change in JDK 25 to really evaluate its impact. This needs a really convincing argument to warrant the fix be backported.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/1949#issuecomment-3292170870