[jdk17u-dev] RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC
Francisco Ferrari Bihurriet
fferrari at openjdk.org
Thu Sep 18 21:41:30 UTC 2025
Hi, this is a backport of openjdk/jdk21u-dev#2235. The backport is almost clean, except for:
* A slightly different context around `Main.java` imports
* 17u doesn't have `Resources_de.java` (changes were discarded)
* The `jarsigner.1` manpage has a slightly different format (manually adjusted to match the 17u format)
#### Related issues ("relates to" Jira issue links)
[JDK-8353299](https://bugs.openjdk.org/browse/JDK-8353299 "VerifyJarEntryName.java test fails") (openjdk/jdk at acd4da49a01760599ec4c325ff6c56f53ba5cc9c) and [JDK-8367782](https://bugs.openjdk.org/browse/JDK-8367782 "VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName") (openjdk/jdk at TBD) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of `VerifyJarEntryName.java`.
Since `test/hotspot/jtreg/runtime/cds/appcds/SignedJar.java` is not failing after the backport, [JDK-8353330](https://bugs.openjdk.org/browse/JDK-8353330 "Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier") was not included.
#### Testing
* Besides the `tier1` run from the [GitHub actions](https://github.com/franferrax/jdk17u-dev/actions/runs/17832135845) (all passed), I ran a regression using the following categories and individual tests:
* `test/hotspot/jtreg/runtime/cds/appcds/SignedJar.java`
* `test/jdk/java/security/SignedJar`
* `test/jdk/java/util/jar`
* `test/jdk/jdk/security/jarsigner`
* `test/jdk/sun/security/pkcs/pkcs7`
* `test/jdk/sun/security/tools/jarsigner`
* Includes `VerifyJarEntryName.java`, created for this issue
* `test/jdk/sun/security/tools/keytool`
No regressions were found against the current `master` branch (ec6528e9cf66abe34b9c293359ca11a4b550b7a8).
-------------
Commit messages:
- Backport 8353299 & 8367782
- Backport bbd5b174c50346152a624317b6bd76ec48f7e551
Changes: https://git.openjdk.org/jdk17u-dev/pull/3954/files
Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=3954&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8339280
Stats: 381 lines in 6 files changed: 381 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk17u-dev/pull/3954.diff
Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/3954/head:pull/3954
PR: https://git.openjdk.org/jdk17u-dev/pull/3954
More information about the jdk-updates-dev
mailing list